luna_park 0.11.0 → 0.11.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: a527e6fff5165d27583a34caaab2543148c3119b895f95898eefe80be7dca8c6
-  data.tar.gz: fc6f47bc87abfead803c5b1d78a6cd76d0450e28637649517394abf8b0fa71a6
+  metadata.gz: 9a850f1f3946c34d92c9f026ffb5f082abdfd066430e8e84e14284b880349cd9
+  data.tar.gz: 0ec998104d358ea3d025734ca7a90e4cd9b6e7a1c2d509750d8ae054b2064e74
 SHA512:
-  metadata.gz: dfb1d4351d12c017c055b67a4f2bcedba375b52bb755d1deeef5a268f0d6fc521ff458b9c37f1f57bec5c3f2cbe842e6fcc6b11a3bff5105b2d20600f27053a1
-  data.tar.gz: 73e4f163196f1a79616e76cb689be7a369b2c5be1d2a6e20db3d02df0ac83dffaba97a3be1a9a762dd4d799519d448edd8085d15993d045f9f245b8a4c5d9fb8
+  metadata.gz: 702a11e09af39984d694748e7fb5464fa5595433fd5beeb951574074004c8891fd4e095b5087e9b80a4608d0f69ba0e22eddcf57012f8b100bfce76bb664b84f
+  data.tar.gz: 0016553ffd33fc1b6073817dedf799acc73c4c37c1ae0eda1e5a8a11188bc3b8c9c96a42fd4f33161d11d3ed7040b7fe26accaeae368ad70c4d543a7ac8f6297

data/.gitignore

@@ -1,17 +1 @@
-/.idea/
-/.bundle/
-/.yardoc
-/_yardoc/
-/coverage/
-/doc/
-/pkg/
-/spec/reports/
-/tmp/
-/.tmp/
-.byebug_history
-
-# rspec failure tracking
-.rspec_status
-
-# gem builds
-*.gem
+g

data/CHANGELOG.md

@@ -4,6 +4,15 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [0.11.1] - 2021-05-24
+Added
+- Inheritance of `Extensions::Injector`
+- Guard and meaningfull exceptions for `Extensions::Injector`
+- nil dependencies caching for `Extensions::Injector`
+- `Http::Client` can accept no-response
+Changed
+- `Forms::Simple` now has default behavior of `#perform`, that returns valid params
+
 ## [0.11.0] - 2021-03-18
 Changed
 - Rename Interactors to UseCases

data/Gemfile.lock

@@ -104,7 +104,7 @@ GEM
       http-cookie (>= 1.0.2, < 2.0)
       mime-types (>= 1.16, < 4.0)
       netrc (~> 0.8)
-    rexml (3.2.4)
+    rexml (3.2.5)
     rspec (3.9.0)
       rspec-core (~> 3.9.0)
       rspec-expectations (~> 3.9.0)

data/lib/luna_park/errors/http.rb

@@ -70,17 +70,17 @@ module LunaPark
           request: {
             method: request.method,
             url: request.url,
-            body: request.body,
-            headers: request.headers,
             open_timeout: request.open_timeout,
             read_timeout: request.read_timeout,
-            sent_at: request.sent_at
+            sent_at: request.sent_at,
+            headers: request.headers,
+            body: request.body
           },
           response: {
             code: response.code,
-            body: response.body,
             headers: response.headers,
-            cookies: response.cookies
+            cookies: response.cookies,
+            body: response.body
           },
           error_details: super
         }

data/lib/luna_park/extensions/injector.rb

@@ -108,6 +108,12 @@ module LunaPark
       end
 
       module ClassMethods
+        def inherited(inheritor)
+          dependencies.each_pair do |key, block|
+            inheritor.dependency(key, &block)
+          end
+        end
+
         ##
         # Set dependency
         #
@@ -118,7 +124,9 @@ module LunaPark
         #     dependency(:example) { Bar.new }
         #   end
         def dependency(name, &block)
-          dependencies[name] = block
+          raise ArgumentError, 'no block given' unless block_given?
+
+          self.dependencies[name] = block
 
           define_method(name) do
             dependencies.call_with_cache(name)

data/lib/luna_park/extensions/injector/dependencies.rb

@@ -48,11 +48,11 @@ module LunaPark
         #    use_case.dependencies[:messenger] # => #<Proc:0x0000564a0d90d438@t.rb:34>
         #    use_case.dependencies.call_with_cache(:messenger) # => 'Foobar'
         def call_with_cache(key)
-          cache[key] ||= self[key].call
+          cache.key?(key) ? cache[key] : cache[key] = self.fetch(key).call
         end
 
         def []=(key, _val)
-          cache[key] = nil
+          cache.delete(key)
           super
         end
 
@@ -62,13 +62,6 @@ module LunaPark
           @cache ||= {}
         end
       end
-
-      # @!parse include Injector::ClassMethods
-      # @!parse extend Injector::InstanceMethods
-      def self.included(base)
-        base.extend ClassMethods
-        base.include InstanceMethods
-      end
     end
   end
 end

data/lib/luna_park/forms/simple.rb

@@ -8,22 +8,36 @@ module LunaPark
     ##
     # Form object represents blank document, required to filled right, and can be performed
     #
-    # @example
+    # @example with default behavior
     #  class MyForm < LunaPark::Forms::SingleItem
     #    validation MyValidator # respond to .validate, #valid?, #errors, #valid_params
     #
     #    def perform(valid_params)
-    #      "Performed #{valid_params[:foo_bar]}"
+    #      "Performed #{valid_params[:foo]}"
     #    end
     #  end
     #
-    #  form = MyForm.new({ foo_bar: 'FooBar' })
+    #  form = MyForm.new({ foo: 'Foo', excess: 'Excess' })
     #
     #  if form.submit
-    #    form.result # => 'Performed FooBar'
+    #    form.result # => 'Performed Foo'
     #  else
-    #    form.errors # => { foo_bar: ['is wrong'] }
+    #    form.errors # => { foo: ['is wrong'] }
     #  end
+    #
+    # @example without default behavior
+    #  class MyForm < LunaPark::Forms::SingleItem
+    #    validation MyValidator # respond to .validate, #valid?, #errors, #valid_params
+    #  end
+    #
+    #  form = MyForm.new({ foo: 'Foo', excess: 'Excess' })
+    #
+    #  if form.submit
+    #    form.result # => { foo: 'Foo' }
+    #  else
+    #    form.errors # => { foo: ['is wrong'] }
+    #  end
+    #
     class Simple
       include Extensions::Validatable
 
@@ -54,8 +68,8 @@ module LunaPark
       # :nocov:
 
       # @abstract
-      def perform(_valid_params)
-        raise Errors::AbstractMethod
+      def perform(valid_params)
+        valid_params
       end
       # :nocov:
     end

data/lib/luna_park/http/send.rb

@@ -83,10 +83,10 @@ module LunaPark
 
       def build_original_response(rest_response)
         Response.new(
-          body: rest_response.body,
-          code: rest_response.code,
-          headers: rest_response.headers,
-          cookies: rest_response.cookies,
+          body: rest_response&.body,
+          code: rest_response&.code || 0,
+          headers: rest_response&.headers,
+          cookies: rest_response&.cookies,
           request: original_request
         )
       end

data/lib/luna_park/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module LunaPark
-  VERSION = '0.11.0'
+  VERSION = '0.11.1'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: luna_park
 version: !ruby/object:Gem::Version
-  version: 0.11.0
+  version: 0.11.1
 platform: ruby
 authors:
 - Alexander Kudrin
@@ -9,7 +9,7 @@ authors:
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2021-05-19 00:00:00.000000000 Z
+date: 2021-05-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bugsnag