lumberg 1.0.1 → 2.0.0.pre4

data/spec/whm/server_spec.rb

@@ -16,7 +16,7 @@ module Lumberg
         @whm.host.should == @login[:host]
       end
 
-      it "should set the url" do
+      it "sets the url" do
         @whm.base_url.should == "https://#{@login[:host]}:2087/json-api/"
       end
 
@@ -37,6 +37,23 @@ module Lumberg
         @whm = Whm::Server.new(@login.merge(:basic_auth => true))
         @whm.basic_auth.should be_true
       end
+
+      it "raises message for invalid domain" do
+        Resolv.stub(:getaddress).and_raise(Resolv::ResolvError)
+        expect do
+          Whm::Server.new(:host => "nxdomain.tld", :hash => "")
+        end.to raise_error(
+         Lumberg::WhmArgumentError, "Unable to resolve nxdomain.tld"
+        )
+      end
+    end
+
+    describe "setting timeout" do
+      it "allows setting of timeout" do
+        Whm::Server.new(
+          @login.merge(:timeout => 1000)
+        ).timeout.should == 1000
+      end
     end
 
     describe "#format_url" do
@@ -57,8 +74,8 @@ module Lumberg
 
     describe "#format_hash" do
       it "raises an error if hash is not a string" do
-        expect{  Whm::Server.new(:host => @whm_host, :hash => nil) }.to
-          raise_error(Lumberg::WhmArgumentError, "Missing WHM hash")
+        expect{  Whm::Server.new(:host => @whm_host, :hash => nil) }.
+          to raise_error(Lumberg::WhmArgumentError, "Missing WHM hash")
       end
 
       it "removes \\n's from the hash" do
@@ -86,25 +103,22 @@ module Lumberg
             @whm.perform_request('my_function')
             @whm.function.should == 'my_function'
             @whm.params.should be_empty
-            @whm.raw_response.should be_a(Net::HTTPOK)
           end
 
           it "calls the proper URL and arguments" do
             JSON.should_receive(:parse).with("[]").and_return([])
             @whm.perform_request('my_function', :arg1 => 1, :arg2 => 'test')
             @whm.function.should == 'my_function'
-            @whm.params.should == "arg1=1&arg2=test"
-            @whm.raw_response.should be_a(Net::HTTPOK)
+            @whm.params.should == {:arg1 => 1, :arg2 => 'test'}
           end
 
           it "changes params to booleans when given a block" do
             req = @whm.perform_request('my_function', :block => 1) do |p|
               p.boolean_params =  :true, :false
             end
-
-            @whm.boolean_params.should include(:true, :false)
             req[:params].should include(:true => true, :false => false, :other => 2)
           end
+
         end
       end
 
@@ -124,83 +138,46 @@ module Lumberg
         end
       end
 
-      context "calling applist" do
-        use_vcr_cassette "whm/server/applist"
-
-        it "sets a response message" do
-          @whm = Whm::Server.new(:host => @whm_host, :hash => @whm_hash)
-          @whm.perform_request('applist')
-          @whm.function.should == 'applist'
+      describe "@timeout" do
+        it "is nil by default" do
+          @whm.timeout.should be_nil
         end
-      end
-    end
-
-    describe "#response_type" do
-
-      use_vcr_cassette "whm/server/response_type"
-
-      it "detects an action function" do
-        @whm.perform_request('testing')
-        @whm.send(:response_type).should == :action
-      end
 
-      it "detects an error function" do
-        @whm.perform_request('testing_error')
-        @whm.send(:response_type).should == :error
-      end
+        describe "setting HTTP timeout" do
+          let(:net_http) { double(Net::HTTP).as_null_object }
 
-      it "detects a query function" do
-        @whm.perform_request('testing_query')
-        @whm.send(:response_type).should == :query
-      end
+          use_vcr_cassette "whm/server/applist"
 
-      it "detects an unknown function" do
-        @whm.perform_request('testing_unknown')
-        @whm.send(:response_type).should == :unknown
-      end
-
-      it "forces response type" do
-        @whm.force_response_type = :magic
-        @whm.send(:response_type).should == :magic
-        @whm.perform_request('testing')
-      end
+          before(:each) do
+            Net::HTTP.stub(:new) { net_http }
+          end
 
-      it "resets response_type each request" do
-        @whm.force_response_type.should be_nil
-        @whm.force_response_type = :magic
-        @whm.send(:response_type).should == :magic
+          it "sets HTTP timeout when assigned" do
+            @whm.timeout = 1000
 
-        @whm.force_response_type = :magic
-        @whm.perform_request('testing')
-        @whm.force_response_type.should be_nil
-      end
+            net_http.should_receive(:read_timeout=).with(1000)
+            net_http.should_receive(:open_timeout=).with(1000)
 
+            @whm.perform_request("applist")
+          end
 
-      it "returns true for a successful :action" do
-        @whm.perform_request('testing')
-        response = @whm.send(:format_response)
-        response[:success].should be(true)
-      end
+          it "uses default HTTP timeout when not assigned" do
+            net_http.should_not_receive(:read_timeout=)
+            net_http.should_not_receive(:open_timeout=)
 
-      it "returns true for a successful :query" do
-        @whm.perform_request('testing_query')
-        response = @whm.send(:format_response)
-        response[:success].should be(true)
-        response[:params].should have_key(:acct)
+            @whm.perform_request("applist")
+          end
+        end
       end
 
-      it "returns false on :error" do
-        @whm.perform_request('testing_error')
-        response = @whm.send(:format_response)
-        response[:success].should be(false)
-        response[:message].should match(/Unknown App Req/)
-      end
+      context "calling applist" do
+        use_vcr_cassette "whm/server/applist"
 
-      it "returns false on :unknown" do
-        @whm.perform_request('testing_unknown')
-        response = @whm.send(:format_response)
-        response[:success].should be(false)
-        response[:message].should match(/Unknown error occurred .*wtf.*/)
+        it "sets a response message" do
+          @whm = Whm::Server.new(:host => @whm_host, :hash => @whm_hash)
+          @whm.perform_request('applist')
+          @whm.function.should == 'applist'
+        end
       end
     end
 
@@ -255,74 +232,42 @@ module Lumberg
       end
     end
 
+    describe "#themes" do
+      use_vcr_cassette "whm/server/themes"
+
+      it "returns list of themes" do
+        result = @whm.themes
+        result[:params].should include :x3
+      end
+    end
+
     describe "#account" do
       it "has an account accessor" do
         @whm.account.should be_an(Whm::Account)
       end
 
-      it "returns the same thing twice" do
-        @whm.account.should be_a(Whm::Account)
-        @whm.account.should respond_to(:list)
-
-        @whm.account.should be_a(Whm::Account)
-        @whm.account.should respond_to(:list)
+      it "sets the server" do
+        @whm.account.server.should == @whm
       end
-
     end
 
     describe "#dns" do
       it "has an dns accessor" do
         @whm.dns.should be_an(Whm::Dns)
       end
+
+      it "sets the server" do
+        @whm.dns.server.should == @whm
+      end
     end
 
     describe "#reseller" do
       it "has an reseller accessor" do
         @whm.reseller.should be_an(Whm::Reseller)
       end
-    end
-
-    describe "#method_missing" do
-      it "caches @vars" do
-        Whm.should_receive(:const_get).once.and_return(Whm::Account)
-        @whm.account
-        @whm.account
-      end
 
-      it "raises to super" do
-        expect { @whm.asdf }.to raise_error(NoMethodError)
-      end
-    end
-
-    describe "#prepare_request" do
-      context "when @basic_auth is true" do
-        before do
-          @whm.basic_auth = true
-          @req = @whm.instance_eval {
-            prepare_request(URI.parse("http://example.com/"))
-          }
-        end
-
-        it "sets Authorization header to 'Basic {base64text}'" do
-          test_auth = Base64.encode64("#{@whm.user}:#{@whm.hash}")
-          auth = @req['Authorization']
-          auth.should_not be_nil
-          auth.should == "Basic #{test_auth}"
-        end
-      end
-
-      context "when @basic_auth is false" do
-        before do
-          @req = @whm.instance_eval {
-            prepare_request(URI.parse("http://example.com/"))
-          }
-        end
-        it "sets Authorization header to 'WHM user:hash'" do
-          test_auth = "#{@whm.user}:#{@whm.hash}"
-          auth = @req['Authorization']
-          auth.should_not be_nil
-          auth.should == "WHM #{test_auth}"
-        end
+      it "sets the server" do
+        @whm.reseller.server.should == @whm
       end
     end
 
@@ -340,14 +285,6 @@ module Lumberg
     describe "#add_ip" do
       use_vcr_cassette "whm/server/addip"
 
-      it "requires an ip address" do
-        requires_attr('ip') { @whm.add_ip(:netmask => '255.255.255.250') }
-      end
-
-      it "requires a netmask" do
-        requires_attr('netmask') { @whm.add_ip(:ip => '123.123.123.123') }
-      end
-
       it "adds the ip address" do
         result = @whm.add_ip(:ip => '208.77.188.166', :netmask => '255.255.255.0')
         result[:success].should be_true
@@ -357,10 +294,6 @@ module Lumberg
     describe "#delete_ip" do
       use_vcr_cassette "whm/server/delip"
 
-      it "requires an ip address" do
-        requires_attr('ip') { @whm.delete_ip }
-      end
-
       it "deletes the ip address" do
         result = @whm.delete_ip(:ip => '208.77.188.166')
         result[:success].should be_true
@@ -370,22 +303,32 @@ module Lumberg
     describe "#set_hostname" do
       use_vcr_cassette "whm/server/sethostname"
 
-      it "requires a hostname" do
-        requires_attr('hostname') { @whm.set_hostname }
-      end
-
       it "changes the server's hostname" do
         result = @whm.set_hostname(:hostname => "myhost.com")
         result[:success].should be_true
       end
     end
 
-    describe "#set_resolvers" do
-      use_vcr_cassette "whm/server/setresolvers"
+    describe "#get_tweaksetting" do
+      use_vcr_cassette "whm/server/gettweaksetting"
 
-      it "requires a nameserver1" do
-        requires_attr('nameserver1') { @whm.set_resolvers }
+      it "gets a tweak setting" do
+        result = @whm.get_tweaksetting(:key => 'skipwebalizer')
+        result[:success].should be_true
+      end
+    end
+
+    describe "#set_tweaksetting" do
+      use_vcr_cassette "whm/server/settweaksetting"
+
+      it "sets a tweak setting" do
+        result = @whm.set_tweaksetting(:key => 'skipwebalizer', :value => 0)
+        result[:success].should be_true
       end
+    end
+
+    describe "#set_resolvers" do
+      use_vcr_cassette "whm/server/setresolvers"
 
       it "configures the nameservers" do
         result = @whm.set_resolvers(:nameserver1 => "123.123.123.123", :nameserver2 => "123.123.123.124")