luhn-check 0.0.1 → 0.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: afca8dc8ac4b88b51f3516c0b922b9d33cf3a238
-  data.tar.gz: 39891f3eacbae1049b5c83712e29096d9b090b5f
+  metadata.gz: 33f175922b61819fcd65ab2081def3813d93827e
+  data.tar.gz: 054980845db991000adcdeb11b2800326f9e6592
 SHA512:
-  metadata.gz: 97fa3e6faa815923805713619260a9f29a2b8afc4c07bc58a72d3d3ce41510c0bba4a9587e7d076035602c0f94054a89d897c6c721ce6163cffcc07ef137f9a2
-  data.tar.gz: 97c843b929d1200a7889410e88eef40e82102e0e07b5a64795a9c2acb83340c23f9cee34603aebf188679a28fdf10ace46863f6062ce0ff30f10c63c350f8918
+  metadata.gz: 836db051316d9ee9dd4ceb1bbb56342ae7e3881d3094a5a22306103fc550d048cf637bd971ebd1fe0eaf4fe765d084b494a78ef0565d79b8658e15572ecf388f
+  data.tar.gz: a3baa6b42f9766ba1a1d5f7bc0a67c24fa31521a216954add2620a1761f895e6b7f381860ae7c4862c0f038900bb0fe22bd77241a3353750d1ca3e05717fe1be

data/README.md

@@ -1,8 +1,10 @@
-# Luhn::Check
+# Luhn check
 
-With the luhn-check you can check a number with the Luhn algoritme.
+With the luhn-check you can check a number with the Luhn algorithm.
 
 ## Installation
+### Version
+`0.0.1`
 
 Add this line to your application's Gemfile:
 
@@ -18,7 +20,15 @@ Or install it yourself as:
 
 ## Usage
 
-TODO: Write usage instructions here
+After the gem is installed. There are some helpers available.
+
+To check if the number is valid with the Luhn algorithm:
+
+  ```ruby
+  Luhn.valid?(number)
+  Luhn.calculate_check_digit(number)
+  Luhn.double_digits(number) # Array with digits for checksum
+  ```
 
 ## Contributing
 

data/lib/luhn.rb

@@ -13,20 +13,26 @@ module Luhn
     end
 
     def calculate_check_digit(number)
-      doubles = double_digits(number)
-      sum_of_all(doubles) unless null?(doubles)
+      number_without_check_digit = number.to_s[0...-1] + '0'
+      doubles = double_digits(number_without_check_digit.to_i)
+      sum = sum_of_all(doubles) unless null?(doubles)
+      product = sum * 9
+      get_check_digit(product)
+    end
+
+    def get_check_digit(number)
+      number.to_s[-1].to_i
     end
 
     def double_digits(number)
       doubles = []
       digits = all_digits(number).reverse
       digits.each_with_index do |d, i|
-        if i.odd? == true
+        if i.odd?
           sum = d * 2
-          if sum > 9 || !sum.nil?
-            split_sum   = sum.to_s.split(//)
-            to_int      = split_sum.map { |m| m.to_i }
-            make_sum    = to_int.inject { |sum, n| sum + n }
+          if sum && sum > 9
+            split_sum   = sum.to_s.split(//).map(&:to_i)
+            make_sum    = split_sum.inject { |sum, n| sum + n }
             doubles     << make_sum
           else
             doubles << sum
@@ -41,11 +47,12 @@ module Luhn
     protected
 
     def checksum(number)
-      check_digit = calculate_check_digit(number)
-      unless check_digit.nil?
-        check_digit % 10 == 0 ? true : false
-      else
+      if null?(number)
         return false
+      else
+        doubles = double_digits(number)
+        sum = sum_of_all(doubles)
+        sum % 10 == 0 ? true : false
       end
     end
 
@@ -54,13 +61,16 @@ module Luhn
     end
 
     def all_digits(number)
-      ary = number.to_s.split(//)
-      return ary.map { |string| string.to_i }
+      number.to_s.split(//).map(&:to_i)
     end
 
-    def null?(doubles)
-      checked_doubles = doubles.reject { |d| d.eql?(0) }
-      return true if checked_doubles.empty?
+    def null?(number)
+      checked_number = all_digits(number).reject! { |d| d.eql?(0) }
+      if checked_number.nil?
+        return false
+      else
+        checked_number.empty? ? true : false
+      end
     end
 
   end

data/lib/luhn/version.rb

@@ -1,3 +1,3 @@
 module Luhn
-  VERSION = "0.0.1"
+  VERSION = "0.0.2"
 end

data/test/luhn_test.rb

@@ -8,17 +8,35 @@ describe 'Luhn' do
 
   describe 'check_digit' do
 
-    describe '.calculate_check_digit' do
-
-      it 'computes the check digit of the .sum_of_all' do
-        Luhn.calculate_check_digit(123).must_equal(8)
-        Luhn.calculate_check_digit(492965255140195).must_equal(60)
-        Luhn.calculate_check_digit(402400711116634).must_equal(46)
-        Luhn.calculate_check_digit(199600).must_equal(26)
-        Luhn.calculate_check_digit(700).must_equal(7)
+    describe 'only for valid numbers' do
+
+      describe '.calculate_check_digit' do
+
+        it 'computes the check digit' do
+          Luhn.calculate_check_digit(79927398713).must_equal(3)
+          Luhn.calculate_check_digit(4539085529167499).must_equal(9)
+          Luhn.calculate_check_digit(6011312159763625).must_equal(5)
+          Luhn.calculate_check_digit(4111111111111111).must_equal(1)
+          Luhn.calculate_check_digit(180002230256255).must_equal(5)
+          Luhn.calculate_check_digit(6011312159763625).must_equal(5)
+        end
       end
     end
 
+    describe 'for all numbers' do
+
+      describe '.get_check_digit' do
+
+        it 'get last digit of number' do
+          Luhn.get_check_digit(123).must_equal(3)
+          Luhn.get_check_digit(7992739871).must_equal(1)
+          Luhn.get_check_digit(492965255140195).must_equal(5)
+          Luhn.get_check_digit(402400711116634).must_equal(4)
+          Luhn.get_check_digit(199600).must_equal(0)
+          Luhn.get_check_digit(4556974027974373).must_equal(3)
+        end
+      end
+    end
   end
 
   describe '.double_digits' do
@@ -28,10 +46,11 @@ describe 'Luhn' do
       it 'computes the sum the digits of the sum' do
         Luhn.double_digits(50).must_equal([0,1])
         Luhn.double_digits(60).must_equal([0,3])
+        Luhn.double_digits(9).must_equal([9])
         Luhn.double_digits(90).must_equal([0,9])
         Luhn.double_digits(123).must_equal([3,4,1])
-        Luhn.double_digits(4992739871).must_equal([1,5,8,9,3,5,2,9,9,8])
-        Luhn.double_digits(7992739871).must_equal([1,5,8,9,3,5,2,9,9,5])
+        Luhn.double_digits(4992739871).must_equal([1, 5, 8, 9, 3, 5, 2, 9, 9, 8])
+        Luhn.double_digits(7992739871).must_equal([1, 5, 8, 9, 3, 5, 2, 9, 9, 5])
       end
     end
 
@@ -40,7 +59,7 @@ describe 'Luhn' do
       it 'computes the double of the digit' do
         Luhn.double_digits(10).must_equal([0,2])
         Luhn.double_digits(40).must_equal([0,8])
-        Luhn.double_digits(50).wont_equal([10])
+        Luhn.double_digits(50531).must_equal([1,6,5,0,5])
       end
     end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: luhn-check
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.0.2
 platform: ruby
 authors:
 - Jan van der Pas
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-09-24 00:00:00.000000000 Z
+date: 2013-09-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: pry