luck_remover 0.2.0 → 0.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 0345edd017f11b270d9f18808531d96cc86e0fead799a40b8d5e67cbb9903779
-  data.tar.gz: b8e18a33f15e910d852069ebb2c2110a7eaf2b5c3ad7e786fad7cf0235834e95
+  metadata.gz: 9e73001c8648d7782184b015b863e8bfd8ae79dd1aac51a515b1602d42c9ba4d
+  data.tar.gz: 4f6353e7a93b1fca872521ce1722fe1bf2b12de3fb866f07897a483bef4865bd
 SHA512:
-  metadata.gz: c92fa7e46a58569543c9cf2c4b9de1ec15c8579a1c5adb3f44b08f425fc5274f21f23ab94a85ec59073266dfdccbb4bd9550551ca0de3c6be1bcfe77db6e446c
-  data.tar.gz: c17e61593422a82880e069c59b7d83c546e3b153da40710e9e45f64d74fcc17a200e78022dbb6266dbb1c1e630d9e2d166f7280a4d097772b896c369e0fa4981
+  metadata.gz: 01a1c6517768b4c6d690d16b46a6d240130e58333463d9d08379f8113b5d86ebdfc68ae543396b2686a49ba4fc4eb787f8f46f95aece39f2706b0f0a7ba14bdf
+  data.tar.gz: 053c049721cbbd0a957040c5ffe97f8b3752da0bfdc6e208331c2f1ad4e98ca90c9d3cfa0ae9657bdaf5d559e1d0940943abf515ea21d738a99373ad4ade52d5

data/app/controllers/luck_remover/goals_controller.rb

@@ -2,31 +2,32 @@ module LuckRemover
   class GoalsController < LuckRemover.parent_controller.constantize
     def index
       @goals = goal_scope.order(:name)
+      @person_names = LuckRemover.people(current_goal_owner).to_h { |label, id| [ id, label ] }
     end
 
     def new
       @goal = goal_scope.new
-      @metrics = LuckRemover.metrics.all
+      load_choices
     end
 
     def create
       @goal = goal_scope.new(goal_params)
       return redirect_to goals_path if @goal.save
 
-      @metrics = LuckRemover.metrics.all
+      load_choices
       render :new, status: :unprocessable_content
     end
 
     def edit
       @goal = goal_scope.find(params[:id])
-      @metrics = LuckRemover.metrics.all
+      load_choices
     end
 
     def update
       @goal = goal_scope.find(params[:id])
       return redirect_to goals_path if @goal.update(goal_params)
 
-      @metrics = LuckRemover.metrics.all
+      load_choices
       render :edit, status: :unprocessable_content
     end
 
@@ -37,12 +38,21 @@ module LuckRemover
 
     private
 
+    def load_choices
+      @metrics = LuckRemover.metrics.all
+      @people = LuckRemover.people(current_goal_owner)
+    end
+
+    def current_goal_owner
+      send(LuckRemover.current_owner_method)
+    end
+
     def goal_params
-      params.expect(goal: [ :name, :metric_key, :target, :direction, :period ])
+      params.expect(goal: [ :name, :metric_key, :person_id, :target, :direction, :period ])
     end
 
     def goal_scope
-      Goal.for_owner(send(LuckRemover.current_owner_method))
+      Goal.for_owner(current_goal_owner)
     end
   end
 end

data/app/models/luck_remover/goal.rb

@@ -11,19 +11,37 @@ module LuckRemover
 
     validates :name, :target, presence: true
     validate :metric_is_registered
+    validate :person_is_one_the_host_gives, if: :person_id
+    validate :metric_is_readable_for_one_person, if: :person_id
 
     def standing(now: Time.current)
-      value = LuckRemover.metric(metric_key).read(range: current_period(now)).value
+      value = LuckRemover.metric(metric_key).read(range: current_period(now), **for_person).value
       Standing.new(value: value, target: target, direction: direction)
     end
 
     private
 
+    def for_person
+      person_id ? { person_id: person_id } : {}
+    end
+
     def current_period(now)
       range = month? ? Cs133::Range.this_month(zone: Time.zone, now: now) : Cs133::Range.last_weeks(1, zone: Time.zone, now: now).first
       range.to_range
     end
 
+    def person_is_one_the_host_gives
+      return if LuckRemover.people(owner).any? { |_label, id| id == person_id }
+
+      errors.add(:person_id, "is not one of the people this goal can be for")
+    end
+
+    def metric_is_readable_for_one_person
+      return if LuckRemover.metrics.per_person?(metric_key.to_s)
+
+      errors.add(:metric_key, "#{metric_key} cannot be read for one person")
+    end
+
     def metric_is_registered
       return if LuckRemover.metrics.registered?(metric_key.to_s)
 

data/app/views/luck_remover/goals/_form.html.erb

@@ -7,6 +7,7 @@
   <%= ui_radio_card(name: "goal[metric_key]", value: metric.key, label: metric.title, hint: metric.definition, checked: goal.metric_key.to_s == metric.key.to_s) %>
 <% end %>
 
+<%= ui_form_field(attribute: "goal[person_id]", label: "Person", type: :select, options: [["Whole business", ""]] + people, value: goal.person_id, errors: goal.errors[:person_id]) %>
 <%= ui_form_field(attribute: "goal[target]", label: "Target", type: :number, step: "any", required: true, value: goal.target, errors: goal.errors[:target]) %>
 <%= ui_form_field(attribute: "goal[direction]", label: "Direction", type: :select, required: true, options: [["At least", "at_least"], ["At most", "at_most"]], value: goal.direction, errors: goal.errors[:direction]) %>
 <%= ui_form_field(attribute: "goal[period]", label: "Period", type: :select, required: true, options: [["Week", "week"], ["Month", "month"]], value: goal.period, errors: goal.errors[:period]) %>

data/app/views/luck_remover/goals/edit.html.erb

@@ -1,7 +1,7 @@
 <%= ui_form_page(title: "Edit", subtitle: @goal.name) %>
 <%= ui_page(max_width: :md) do %>
   <%= ui_form(action: luck_remover.goal_path(@goal), method: :patch) do %>
-    <%= render "luck_remover/goals/form", goal: @goal, metrics: @metrics %>
+    <%= render "luck_remover/goals/form", goal: @goal, metrics: @metrics, people: @people %>
     <%= ui_button(label: "Save") %>
   <% end %>
   <%= ui_action_menu do %>

data/app/views/luck_remover/goals/index.html.erb

@@ -1,3 +1,4 @@
+<%= ui_show_page(title: "Goals") %>
 <%= ui_page(max_width: :xl) do %>
   <%= ui_page_header(title: "Goals", action_url: luck_remover.new_goal_path, action_label: "Add") do |header| %>
     <% header.action do %>
@@ -7,6 +8,7 @@
   <% rows = @goals.map do |goal|
        { name: goal.name,
          edit_url: luck_remover.edit_goal_path(goal),
+         person: goal.person_id ? @person_names[goal.person_id] : "Whole business",
          metric: LuckRemover.metric(goal.metric_key).title,
          target: number_with_precision(goal.target, precision: 2, strip_insignificant_zeros: true),
          direction: goal.direction.humanize,
@@ -14,7 +16,7 @@
      end %>
   <%= ui_data_table(
         items: rows,
-        columns: [{ name: "Name" }, { metric: "Metric" }, { target: "Target" }, { direction: "Direction" }, { period: "Period" }],
+        columns: [{ name: "Name" }, { person: "Person" }, { metric: "Metric" }, { target: "Target" }, { direction: "Direction" }, { period: "Period" }],
         empty_message: "No goals yet."
       ) { |table| table.link(:name) { |row| row[:edit_url] } } %>
 <% end %>

data/app/views/luck_remover/goals/new.html.erb

@@ -1,7 +1,7 @@
 <%= ui_form_page(title: "Add goal") %>
 <%= ui_page(max_width: :md) do %>
   <%= ui_form(action: luck_remover.goals_path) do %>
-    <%= render "luck_remover/goals/form", goal: @goal, metrics: @metrics %>
+    <%= render "luck_remover/goals/form", goal: @goal, metrics: @metrics, people: @people %>
     <%= ui_button(label: "Create") %>
   <% end %>
 <% end %>

data/db/migrate/20261023134729_add_person_id_to_luck_remover_goals.rb

@@ -0,0 +1,5 @@
+class AddPersonIdToLuckRemoverGoals < ActiveRecord::Migration[8.1]
+  def change
+    add_column :luck_remover_goals, :person_id, :integer, limit: 8
+  end
+end

data/lib/luck_remover/metric_registry.rb

@@ -6,15 +6,21 @@ module LuckRemover
   class MetricRegistry
     def initialize
       @stats = {}
+      @per_person = Set.new
     end
 
-    def register(stat)
+    def register(stat, per_person: false)
       key = stat.key.to_sym
       raise DuplicateMetricError, "A goal metric is already registered under #{key}" if registered?(key)
 
+      @per_person << key if per_person
       @stats[key] = stat
     end
 
+    def per_person?(key)
+      @per_person.include?(key.to_sym)
+    end
+
     def registered?(key)
       @stats.key?(key.to_sym)
     end

data/lib/luck_remover/version.rb

@@ -1,3 +1,3 @@
 module LuckRemover
-  VERSION = "0.2.0"
+  VERSION = "0.3.0"
 end

data/lib/luck_remover.rb

@@ -8,12 +8,20 @@ module LuckRemover
   mattr_accessor :parent_controller, default: "LuckRemover::ApplicationController"
   mattr_accessor :current_owner_method, default: nil
 
+  NO_PEOPLE = ->(_owner) { [] }
+
+  mattr_accessor :people_for, default: NO_PEOPLE
+
+  def self.people(owner)
+    people_for.call(owner)
+  end
+
   def self.metrics
     @metrics ||= MetricRegistry.new
   end
 
-  def self.register_metric(stat)
-    metrics.register(stat)
+  def self.register_metric(stat, per_person: false)
+    metrics.register(stat, per_person: per_person)
   end
 
   def self.metric(key)

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: luck_remover
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.3.0
 platform: ruby
 authors:
 - Tyler Schneider
@@ -92,6 +92,7 @@ files:
 - app/views/luck_remover/goals/new.html.erb
 - config/routes.rb
 - db/migrate/20261022212722_create_luck_remover_goals.rb
+- db/migrate/20261023134729_add_person_id_to_luck_remover_goals.rb
 - lib/luck_remover.rb
 - lib/luck_remover/engine.rb
 - lib/luck_remover/metric_registry.rb