lucid-shopify 0.55.0 → 0.56.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 44bfabaa371fa86d7e8e5510a48c06e4736185ec34fbc2f3317ed0666ba8e2fe
-  data.tar.gz: 78b86372b571b91c30b7894f8df2e74fec8b9f505d0c5f148e65ebf123a61150
+  metadata.gz: addb963ec9b838bc5039979f8701a1b640158b8627ee5b2589729dbcc16954ec
+  data.tar.gz: ec5af11336d7b0c5fcfbe139884fd4c1afc6cd8ebc17f12ea2c25f6b18323962
 SHA512:
-  metadata.gz: 76bfe8211440ed42b34782aaafc4b191d6c6bc34fccc3daf9f3bbd18481c7d11fbcdb70a6c54f7e58c507c4949ad325f08bd85ff53367385a04b5221fc7fc33c
-  data.tar.gz: fac21c77880396f5a5f53ac695b56ce2e0394688367e8235c243427ed784ddb0e2d0a8d3a8c4d1089d42426ae83582fe0e5fa5d09d495116ae93144ee364301d
+  metadata.gz: 6fc1a8d5d0098a0fcab038dfec589aa8c97968c6258c53049499bd1cb4e32476e279b86928de3ae7994e59193062897447faf3f84d1cc73cd76cb7b7886e73b8
+  data.tar.gz: 0e0fd6dc44b37064ba6758d23d5662cce0c2cade91496e00c6eb20db1c5aa0564c168797d1a63eb5bfffc8253ef725dc80f0700f2ed40dea315b4acd91abe389

data/lib/lucid/shopify/parse_link_header.rb

@@ -12,7 +12,24 @@ module Lucid
       #
       # @return [Hash]
       def call(link_header)
-        return {} if link_header.nil?
+        case link_header
+        # NOTE: There is a strange behaviour where it seems that if the header
+        # value exceeds a certain length, it is split into chunks. It seems that
+        # if you use {HTTP::Headers#get}, you will always get {Array<String},
+        # and it is the special behaviour of {HTTP::Headers#[]} causing this.
+        #
+        # However, why is it split in the first place? Does Shopify send
+        # multiple Link headers (as chunks) for longer values? There does not
+        # seem to be any limit on the length of value in the HTTP specification.
+        #
+        # https://www.rubydoc.info/gems/http/HTTP/Headers#[]-instance_method
+        # https://www.rubydoc.info/gems/http/HTTP/Headers#get-instance_method
+        when Array
+          link_header = link_header.join
+        when String
+        else
+          return {}
+        end
 
         link_header.split(',').map do |link|
           url, rel = link.split(';') # rel should be the first param

data/lib/lucid/shopify/version.rb

@@ -2,6 +2,6 @@
 
 module Lucid
   module Shopify
-    VERSION = '0.55.0'
+    VERSION = '0.56.0'
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: lucid-shopify
 version: !ruby/object:Gem::Version
-  version: 0.55.0
+  version: 0.56.0
 platform: ruby
 authors:
 - Kelsey Judson
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-03-14 00:00:00.000000000 Z
+date: 2020-03-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: dotenv