lucid-shopify 0.35.0 → 0.36.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e96b6b1a205fa3e97e3594aedce15b42fe63ea1815e0887a4a08cfb353f55fec
-  data.tar.gz: eb0add1838afac04c4b94d1959c14f8b06968fa99ca7045162a99f36e8fa409f
+  metadata.gz: 6941ffc0f656f4a3f25df0ba4530aa8c793d3aedd3e87c0a4a333c5528ef6d16
+  data.tar.gz: 20b48f8e246754880b4f5506387774b5213605c2bf97bb7db2251c2ca24273c0
 SHA512:
-  metadata.gz: 486193c71c99feef87a3327c7686a713968f06e98210085ea10d643ced26f093788d29c86f1b6d93e982b3ca88083c08d89e665e9d7ba90c7415d93b56b2971f
-  data.tar.gz: 0b500a2554b66b324f8618e29d108a1f529f69023845d97c402374f5b7ced10357e1fea11ae72c4ce62cb2934cb757f09a4463723f8e2732822ad8336ead84a5
+  metadata.gz: 0460cdf66d11da1376772eba36cd03a94b60592e0385cf15b9026092107720c8d165791bd0459d791735b29c9683af76241128783cf6ad268c1c13b45f3726ad
+  data.tar.gz: d24830b5067246abd9918e87772a0f726a3a5b96594d81d17e5f6684977579ea0c73221c4f7bca8f884b9bc33cff80dabdf7fa9e201bd8a6dccb90fbe3012f41

data/lib/lucid/shopify/create_all_webhooks.rb

@@ -10,8 +10,7 @@ module Lucid
         @create_webhook = create_webhook
       end
 
-      # Create all webhooks for the shop. Shopify ignores any webhooks which
-      # already exist remotely.
+      # Create all webhooks for the shop.
       #
       # @param credentials [Credentials]
       # @param webhooks [WebhookList]

data/lib/lucid/shopify/create_webhook.rb

@@ -18,6 +18,10 @@ module Lucid
         data = {**webhook, address: Shopify.config.webhook_uri}
 
         @client.post_json(credentials, 'webhooks', webhook: data)
+      rescue Response::Error => e
+        raise e unless e.response.error_message?([
+          'address for this topic has already been taken'
+        ])
       end
     end
   end

data/lib/lucid/shopify/response.rb

@@ -18,7 +18,11 @@ module Lucid
 
         # @return [String]
         def message
-          "bad response (#{response.status_code})"
+          if response.errors?
+            "bad response (#{response.status_code}) '#{response.error_messages.first}'"
+          else
+            "bad response (#{response.status_code})"
+          end
         end
       end
 
@@ -86,7 +90,7 @@ module Lucid
 
       # @return [Boolean]
       def errors?
-        data_hash.has_key?('errors')
+        data_hash.has_key?('errors') # should be only on 422
       end
 
       # A string rather than an object is returned by Shopify in the case of,
@@ -105,6 +109,13 @@ module Lucid
         errors.map { |field, message| "#{field} #{message}" }
       end
 
+      # @param messages [Array<String>]
+      #
+      # @return [Boolean]
+      def error_message?(messages)
+        messages.any? { |message| error_messages.include?(message) }
+      end
+
       # @see Hash#each
       def each(&block)
         data_hash.each(&block)

data/lib/lucid/shopify/version.rb

@@ -2,6 +2,6 @@
 
 module Lucid
   module Shopify
-    VERSION = '0.35.0'
+    VERSION = '0.36.0'
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: lucid-shopify
 version: !ruby/object:Gem::Version
-  version: 0.35.0
+  version: 0.36.0
 platform: ruby
 authors:
 - Kelsey Judson
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-11-27 00:00:00.000000000 Z
+date: 2019-12-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: dotenv