lsa_tdx_feedback 1.0.4 → 2.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 9ba11981b7bf60500f49c19285a8e70e401e0b1901fd81daec64b9838deba7fa
-  data.tar.gz: c1a0858eabc19efa362d67283db2b10b2899b2fdf8d2cd1110727f574a92e143
+  metadata.gz: 69d0dae8aaebab74ea26a463495be295ec35369e9ec579cdfe7ee008837fcbb3
+  data.tar.gz: de81da8ce4c00ed435be260b49d7cd0bd447d963dae02c1d8094ece55fa9bd2d
 SHA512:
-  metadata.gz: 31ba0604bf35ee495ecb501da72a4bac4c0c8ad3101427d001fcf2156bc90cdc4ff8e49e0f994cd8c162210048db55873b83f1149dce2d20dd081cfbee6a9906
-  data.tar.gz: f7896b3c35231a37dcdf798d9ed1a6745c3415e8ba7973a8ef5bd4513c615745bb721941a895dd1f7d9936b016304ce265a89824906864c912de9d1e85d4eaf8
+  metadata.gz: 5b2dd1661fc85b467a0c656ac2a6024a2735fbb81c8c2c7df90c33579e43d8b1da3595417ea52b1c86b8ac7bf96adcfc8762db8fe7b6b41cc3894b5b3dff0210
+  data.tar.gz: d6bdfeb8dc93fc60fc41c03895303bef1a906a839508154e41d9bd910911bbe386b2f958c611adb00a91bb4d787a390df9fcaafc4fea5963eb0fce7aa645299a

data/CHANGELOG.md

@@ -7,13 +7,80 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+## [2.0.1] - 2026-07-21
+
+### Fixed
+- **Duplicate floating trigger button**: the modal partial rendered two
+  `#lsa-tdx-feedback-trigger` buttons (an i18n button outside the `trigger:`
+  guard, plus the old hardcoded button inside it). The JS click handler bound
+  only to the first; the second sat on top and swallowed clicks, so the modal
+  never opened and produced no console or server errors. Also meant
+  `trigger: false` still left a button on the page. There is now a single
+  i18n button inside the `trigger:` guard.
+
+## [2.0.0] - 2026-07-20
+
+### Fixed
+- **`NameError` on controllers that don't define `current_user`**: `set_lsa_tdx_feedback_data`
+  referenced `current_user` unconditionally inside a debug log line, so it raised on any
+  controller without that method — ViewComponent's preview controller,
+  `Rails::HealthController`, ActiveStorage's controllers, and so on. Because the extension is
+  mixed into `ActionController::Base` via `on_load :action_controller`, this broke those
+  requests in every host application.
+  - Removed the leftover per-request debug logging, which also drops six `Rails.logger.info`
+    calls emitted on every request of every controller.
+  - The documented `current_user_email_for_feedback` override point is unchanged, and it was
+    already guarded — email prefill still works exactly as before.
+  - Added specs covering both cases (controller with and without `current_user`).
+
 ### Added
+- **I18n for the modal**: every visible string in the modal now comes from I18n,
+  scoped under `lsa_tdx_feedback.*` (English defaults ship in
+  `config/locales/en.yml`, auto-loaded by the engine). Host apps can translate to
+  other locales — or reword any string — by defining the same scoped keys in
+  their own locale files, which load after the gem's and win. Keys are namespaced
+  so they never collide with a host app's own I18n. (The JavaScript's runtime
+  status/validation messages are not yet localized — a follow-up.)
+- **Opt-out for the floating trigger button**: `lsa_tdx_feedback_modal(trigger: false)`
+  (and `lsa_tdx_feedback(trigger: false)`) render the modal WITHOUT the built-in
+  fixed bottom-right button, so a host can open it from its own control via
+  `window.LsaTdxFeedback.showModal()` — e.g. when the fixed button collides with
+  other fixed page chrome (cookie banners, toasts). Defaults to `true`; callers
+  that don't pass `trigger:` are unaffected.
+- **Delivery fallback (`config.fallback`)**: an optional callable invoked with the
+  feedback data when a ticket can't be filed — TDX not configured, or the API call
+  raises — so feedback is never lost. The controller files a TDX ticket when TDX is
+  configured and the call succeeds, otherwise hands the data to your fallback (e.g.
+  emailing an admin, enqueuing a job). Defaults to `nil`, which preserves the
+  original behavior exactly: no fallback, error response on failure.
 - **Documentation**: Added Rails 8 authentication setup instructions to README
   - Step-by-step guide for generating Rails 8.1.1's built-in authentication system
   - Instructions for creating `current_user` helper method to match Devise pattern
   - Examples for protecting actions and excluding authentication for specific controllers
   - Documentation on using `allow_unauthenticated_access` for public pages
 
+### Changed
+- **Modal is now a native `<dialog>`**: it renders in the browser's top layer
+  (above all page content, no z-index needed) with a built-in focus trap and
+  native Escape handling, so it no longer competes with host page chrome or
+  relies on a hand-rolled backdrop/focus/escape. The JS now saves and restores
+  the host's `document.body` overflow on open/close instead of clearing it
+  (which could clobber another component's scroll lock).
+- **WCAG 2.2 AAA defaults + themeable tokens**: the stylesheet now targets AAA
+  (7:1 text contrast, 44px minimum touch targets) in light and dark, and its
+  colors/sizes are exposed as `--lsa-tdx-feedback-*` CSS custom properties for
+  rebranding without copying the stylesheet. A `prefers-color-scheme: dark`
+  variant is included, and the modal's field colors are pinned so a theme-aware
+  host app can't bleed low-contrast text into them. This changes the modal's
+  default appearance (notably a darker, AAA-contrast accent).
+
+### Breaking
+- The modal's outer element changed from `<div>` to `<dialog>`, and the
+  `.lsa-tdx-feedback-modal-backdrop` div was removed (the backdrop is now the
+  `::backdrop` pseudo-element). If you override the modal partial, or style the
+  old backdrop div, update accordingly. Custom colors/sizes previously set by
+  editing the stylesheet should move to the `--lsa-tdx-feedback-*` properties.
+
 ## [1.0.4] - 2026-02-09
 
 ### Changed

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    lsa_tdx_feedback (1.0.3)
+    lsa_tdx_feedback (2.0.1)
       httparty (~> 0.24.0)
       rails (>= 6.0)
       redis (>= 4.0)
@@ -87,7 +87,7 @@ GEM
     benchmark (0.4.1)
     bigdecimal (4.0.1)
     builder (3.3.0)
-    concurrent-ruby (1.3.5)
+    concurrent-ruby (1.3.7)
     connection_pool (2.5.4)
     crack (1.0.0)
       bigdecimal

data/README.md

@@ -148,6 +148,26 @@ This avoids FOUC (flash of unstyled content) and ensures the script loads after
 - **Optimal loading (recommended)**: Use the separate helpers so CSS loads in `<head>` and JS loads just before `</body>`. This avoids FOUC and keeps asset order predictable.
 - **Convenience**: Use `lsa_tdx_feedback` (all‑in‑one) for quick setup. It injects CSS/JS plus the modal where it’s called, which can delay CSS and is less ideal for performance.
 
+#### Bring your own trigger
+
+By default the modal ships a fixed bottom‑right floating button. To render the
+modal **without** it — and open it from your own control (a nav link, a footer
+button) — pass `trigger: false` and call `window.LsaTdxFeedback.showModal()`:
+
+```erb
+<%= lsa_tdx_feedback_modal(trigger: false) %>
+
+<button type="button" id="my-feedback-link">Send feedback</button>
+<script>
+  document.getElementById('my-feedback-link')
+    .addEventListener('click', () => window.LsaTdxFeedback.showModal());
+</script>
+```
+
+This is handy when the fixed button overlaps other fixed page chrome (a cookie
+banner, toasts), or when you want feedback reachable from a specific place in
+your own UI. `lsa_tdx_feedback(trigger: false)` works the same way.
+
 #### Recommended placement (optimal)
 
 ```erb
@@ -238,6 +258,73 @@ class ApplicationController < ActionController::Base
 end
 ```
 
+### Translating or customizing the modal text
+
+The modal's visible strings come from I18n, scoped under `lsa_tdx_feedback.*`
+(English defaults ship with the gem and are auto-loaded). To translate to another
+locale — or to reword any string — define the same keys in your app's locale
+files; they load after the gem's, so they win:
+
+```yaml
+# config/locales/fr.yml
+fr:
+  lsa_tdx_feedback:
+    modal:
+      title: "Envoyer un commentaire"
+      submit: "Envoyer"
+      # ...override only what you need
+```
+
+See `config/locales/en.yml` in the gem for the full list of keys. (The
+JavaScript's runtime messages — submission success and client-side validation
+text — are not yet localized.)
+### Delivery fallback (never lose feedback)
+
+By default, if TDX isn't configured — or a ticket can't be created — the modal
+shows an error. Set `config.fallback` to a callable and the gem hands it the
+feedback instead, so you can email an admin, enqueue a job, or log it, and the
+user still gets a success response:
+
+```ruby
+# config/initializers/lsa_tdx_feedback.rb
+LsaTdxFeedback.configure do |config|
+  # ...your TDX config...
+
+  config.fallback = ->(feedback_data) do
+    FeedbackMailer.submission(feedback_data).deliver_later
+  end
+end
+```
+
+The callable receives the same `feedback_data` hash the ticket would have used
+(`:feedback`, `:email`, `:category`, `:url`, `:user_agent`, `:additional_info`,
+`:title`, `:priority_id`). When `config.fallback` is `nil` (the default), behavior
+is unchanged. A TDX ticket is still filed when TDX is configured and the call
+succeeds — the fallback runs only when it can't.
+
+### Theming (colors, dark mode, accessibility)
+
+The modal is a native `<dialog>` — it renders in the browser's top layer (above
+your page chrome, with a built-in focus trap and Escape handling), so it needs
+no z-index coordination with the rest of your app.
+
+Its styling ships **WCAG 2.2 AAA** defaults (7:1 text contrast, 44px touch
+targets) in both light and dark, and exposes colors and sizes as CSS custom
+properties. To rebrand, override any of them in a stylesheet loaded after the
+gem's:
+
+```css
+:root {
+  --lsa-tdx-feedback-accent: #6d28d9;         /* your brand color */
+  --lsa-tdx-feedback-accent-hover: #5b21b6;
+  --lsa-tdx-feedback-surface: #ffffff;
+  /* full list in app/assets/stylesheets/lsa_tdx_feedback.css */
+}
+```
+
+A `prefers-color-scheme: dark` variant is built in, and the modal's field colors
+are pinned so a theme-aware host app can't bleed low-contrast text into them.
+
 ## Rails 8 Authentication Setup
 
 If you're using Rails 8.1.1's built-in authentication system, here's how to set it up and create a `current_user` helper method similar to Devise.
@@ -304,22 +391,19 @@ This makes `current_user` available in all controllers and views, including Rail
 
 ### Step 3A: Create an initializer (config/initializers/lsa_tdx_feedback.rb) that skips authentication for the feedback controller, since feedback forms should be public
 
-```ruby
-# Configure lsa_tdx_feedback gem to allow unauthenticated access
-# Feedback forms should be accessible without authentication
-Rails.application.config.to_prepare do
-  if defined?(LsaTdxFeedback::FeedbackController)
-    LsaTdxFeedback::FeedbackController.class_eval do
-      # Skip authentication for feedback submissions
-      # Use raise: false to prevent errors if the before_action doesn't exist
-      skip_before_action :require_authentication, raise: false
-    end
-  end
-rescue => e
-  Rails.logger.warn("Could not configure LsaTdxFeedback: #{e.message}") if defined?(Rails.logger)
-end
+`LsaTdxFeedback::FeedbackController` inherits from the host app's `ApplicationController`. If that controller runs a global authentication `before_action`, anonymous submissions are rejected before the action executes, producing a `401 Unauthorized` on submit:
+
+```text
+Processing by LsaTdxFeedback::FeedbackController#create as */*
+Completed 401 Unauthorized in 8ms (ActiveRecord: 0.0ms)
 ```
 
+The 0‑query, sub‑10ms completion is the tell: the request was blocked by an authentication callback, not by the TDX API. Skip that callback for the feedback controller only.
+
+#### Rails 8 built-in authentication
+
+The Rails 8 generator names the callback `:require_authentication`:
+
 and update request_authentication in the Authentication concern ( app/controllers/concerns/authentication.rb ) to use main_app.new_session_path so it works when called from engine controllers.
 
 ```ruby
@@ -329,6 +413,32 @@ and update request_authentication in the Authentication concern ( app/controller
 ...
 ```
 
+#### Devise
+
+Devise apps use `:authenticate_user!`. Skip that callback instead:
+
+```ruby
+# config/initializers/lsa_tdx_feedback.rb
+# Allow anonymous (signed-out) visitors to submit feedback.
+# The feedback modal is rendered on public pages, so skipping the host app's
+# Devise authentication callback prevents 401 Unauthorized responses on submit.
+Rails.application.config.to_prepare do
+  LsaTdxFeedback::FeedbackController.class_eval do
+    skip_before_action :authenticate_user!, raise: false
+  end
+end
+```
+
+For both setups, `to_prepare` re‑applies the change across code reloads in development, and `raise: false` keeps the app booting even if the callback name differs or changes in a future release.
+
+#### The email field is informational, not an identity
+
+The form requires an email **client‑side** before it allows submission, so the controller always receives a contact address. That value is **not authoritative** — any email can be entered, and it is recorded on the TDX ticket as‑is. For signed‑in users the email is auto‑populated for convenience (via `current_user_email_for_feedback`), but the authorization decision does **not** depend on it.
+
+#### What still protects the endpoint
+
+- **CSRF protection remains in effect.** The controller keeps `protect_from_forgery with: :exception`, so submissions must originate from your rendered pages with a valid CSRF token. This is the primary guard against scripted/anonymous abuse now that authentication is skipped.
+- **No server‑side email validation.** The controller permits `:email` and passes it straight through to the TDX ticket; it does **not** validate presence or format (that enforcement lives only in the browser). If you want a backend safety net so a crafted request can't create a ticket with a blank or malformed email, add that validation in the gem or in a controller override.
 
 ### Step 4: Protect Actions (Optional)
 

data/app/assets/javascripts/lsa_tdx_feedback.js

@@ -13,9 +13,9 @@
       triggerClick: null,
       closeClick: null,
       cancelClick: null,
-      backdropClick: null,
+      dialogClick: null,
       formSubmit: null,
-      escapeKey: null
+      dialogClose: null
     },
 
     init: function() {
@@ -53,7 +53,6 @@
       if (this.modal) {
         var closeBtn = this.modal.querySelector('.lsa-tdx-feedback-close-btn');
         var cancelBtn = this.modal.querySelector('.lsa-tdx-feedback-cancel-btn');
-        var backdrop = this.modal.querySelector('.lsa-tdx-feedback-modal-backdrop');
 
         if (closeBtn && this.handlers.closeClick) {
           closeBtn.removeEventListener('click', this.handlers.closeClick);
@@ -61,8 +60,11 @@
         if (cancelBtn && this.handlers.cancelClick) {
           cancelBtn.removeEventListener('click', this.handlers.cancelClick);
         }
-        if (backdrop && this.handlers.backdropClick) {
-          backdrop.removeEventListener('click', this.handlers.backdropClick);
+        if (this.handlers.dialogClick) {
+          this.modal.removeEventListener('click', this.handlers.dialogClick);
+        }
+        if (this.handlers.dialogClose) {
+          this.modal.removeEventListener('close', this.handlers.dialogClose);
         }
       }
 
@@ -70,18 +72,14 @@
         this.form.removeEventListener('submit', this.handlers.formSubmit);
       }
 
-      if (this.handlers.escapeKey) {
-        document.removeEventListener('keydown', this.handlers.escapeKey);
-      }
-
       // Clear handler references
       this.handlers = {
         triggerClick: null,
         closeClick: null,
         cancelClick: null,
-        backdropClick: null,
+        dialogClick: null,
         formSubmit: null,
-        escapeKey: null
+        dialogClose: null
       };
     },
 
@@ -110,7 +108,6 @@
       // Close buttons
       var closeBtn = this.modal.querySelector('.lsa-tdx-feedback-close-btn');
       var cancelBtn = this.modal.querySelector('.lsa-tdx-feedback-cancel-btn');
-      var backdrop = this.modal.querySelector('.lsa-tdx-feedback-modal-backdrop');
 
       if (closeBtn) {
         this.handlers.closeClick = function(e) {
@@ -128,14 +125,23 @@
         cancelBtn.addEventListener('click', this.handlers.cancelClick);
       }
 
-      if (backdrop) {
-        this.handlers.backdropClick = function(e) {
-          if (e.target === backdrop) {
-            self.hideModal();
-          }
-        };
-        backdrop.addEventListener('click', this.handlers.backdropClick);
-      }
+      // Backdrop click: on a native <dialog>, a click whose target is the
+      // dialog element itself (not its content) lands on the ::backdrop.
+      this.handlers.dialogClick = function(e) {
+        if (e.target === self.modal) {
+          self.hideModal();
+        }
+      };
+      this.modal.addEventListener('click', this.handlers.dialogClick);
+
+      // Runs on every close — button, backdrop, or the dialog's native Escape
+      // handling — so cleanup happens once, wherever the close came from.
+      this.handlers.dialogClose = function() {
+        document.body.style.overflow = self._previousBodyOverflow || '';
+        self.resetForm();
+        self.hideMessage();
+      };
+      this.modal.addEventListener('close', this.handlers.dialogClose);
 
       // Form submission
       this.handlers.formSubmit = function(e) {
@@ -143,20 +149,23 @@
         self.submitFeedback();
       };
       this.form.addEventListener('submit', this.handlers.formSubmit);
-
-      // Escape key to close modal
-      this.handlers.escapeKey = function(e) {
-        if (e.key === 'Escape' && self.modal && self.modal.style.display !== 'none') {
-          self.hideModal();
-        }
-      };
-      document.addEventListener('keydown', this.handlers.escapeKey);
     },
 
     showModal: function() {
       if (!this.modal) return;
 
-      this.modal.style.display = 'block';
+      // Native modal dialog: top layer + page inert + built-in focus trap.
+      if (typeof this.modal.showModal === 'function') {
+        this.modal.showModal();
+      } else {
+        // Older browsers without <dialog>: fall back to a visible dialog.
+        this.modal.setAttribute('open', '');
+      }
+
+      // Save the host's body overflow so we can RESTORE it on close rather
+      // than blindly clearing it (which would clobber a scroll lock another
+      // component may have set).
+      this._previousBodyOverflow = document.body.style.overflow;
       document.body.style.overflow = 'hidden';
 
       // Focus on first input
@@ -173,10 +182,13 @@
     hideModal: function() {
       if (!this.modal) return;
 
-      this.modal.style.display = 'none';
-      document.body.style.overflow = '';
-      this.resetForm();
-      this.hideMessage();
+      // The 'close' event handler restores body scroll + resets the form.
+      if (typeof this.modal.close === 'function') {
+        this.modal.close();
+      } else {
+        this.modal.removeAttribute('open');
+        if (this.handlers.dialogClose) this.handlers.dialogClose();
+      }
     },
 
     resetForm: function() {

data/app/assets/stylesheets/lsa_tdx_feedback.css

@@ -1,37 +1,100 @@
 /* LsaTdxFeedback Styles - Self-contained and namespaced */
 
+/*
+ * Themeable tokens. Override any of these in your own stylesheet (loaded after
+ * this one) to rebrand the modal without copying it. Defaults target WCAG 2.2
+ * AAA: 7:1 text contrast and 44px minimum touch targets, in light and dark.
+ */
+:root {
+  --lsa-tdx-feedback-font: -apple-system, BlinkMacSystemFont, "Segoe UI", Roboto, "Helvetica Neue", Arial, sans-serif;
+
+  --lsa-tdx-feedback-surface: #ffffff;
+  --lsa-tdx-feedback-text: #1a1a1a;
+  --lsa-tdx-feedback-text-muted: #33383f;   /* >= 7:1 on the surface */
+  --lsa-tdx-feedback-border: #ced4da;
+
+  --lsa-tdx-feedback-field-bg: #ffffff;
+  --lsa-tdx-feedback-field-text: #1a1a1a;
+  --lsa-tdx-feedback-placeholder: #4b5563;  /* >= 7:1 on the field */
+
+  --lsa-tdx-feedback-accent: #1e3a8a;       /* white text on this is >= 7:1 */
+  --lsa-tdx-feedback-accent-hover: #172e6e;
+  --lsa-tdx-feedback-on-accent: #ffffff;
+  --lsa-tdx-feedback-focus-ring: rgba(30, 58, 138, 0.35);
+
+  --lsa-tdx-feedback-backdrop: rgba(0, 0, 0, 0.5);
+  --lsa-tdx-feedback-target-min: 44px;      /* WCAG 2.5.5 */
+
+  --lsa-tdx-feedback-success-bg: #d4edda;
+  --lsa-tdx-feedback-success-text: #0f5132; /* >= 7:1 on success-bg */
+  --lsa-tdx-feedback-success-border: #badbcc;
+  --lsa-tdx-feedback-error-bg: #f8d7da;
+  --lsa-tdx-feedback-error-text: #842029;   /* >= 7:1 on error-bg */
+  --lsa-tdx-feedback-error-border: #f5c2c7;
+}
+
+@media (prefers-color-scheme: dark) {
+  :root {
+    --lsa-tdx-feedback-surface: #1e232b;
+    --lsa-tdx-feedback-text: #f1f5f9;
+    --lsa-tdx-feedback-text-muted: #c4ccd6;
+    --lsa-tdx-feedback-border: #333b45;
+
+    --lsa-tdx-feedback-field-bg: #12161c;
+    --lsa-tdx-feedback-field-text: #f1f5f9;
+    --lsa-tdx-feedback-placeholder: #b3bcc9;
+
+    /* accent + white text stay AAA on the dark surface */
+
+    --lsa-tdx-feedback-success-bg: #0f2e1d;
+    --lsa-tdx-feedback-success-text: #a7f3d0;
+    --lsa-tdx-feedback-success-border: #1c4a30;
+    --lsa-tdx-feedback-error-bg: #3b1418;
+    --lsa-tdx-feedback-error-text: #fecaca;
+    --lsa-tdx-feedback-error-border: #5b1d23;
+  }
+}
+
 /* Trigger Button */
 .lsa-tdx-feedback-trigger-btn {
   position: fixed;
   bottom: 20px;
   right: 20px;
-  background: #0D6EFD;
-  color: white;
+  min-width: var(--lsa-tdx-feedback-target-min);
+  min-height: var(--lsa-tdx-feedback-target-min);
+  background: var(--lsa-tdx-feedback-accent);
+  color: var(--lsa-tdx-feedback-on-accent);
   border: none;
   border-radius: 25px;
   padding: 12px 20px;
   font-size: 14px;
   font-weight: 600;
-  font-family: -apple-system, BlinkMacSystemFont, "Segoe UI", Roboto, "Helvetica Neue", Arial, sans-serif;
+  font-family: var(--lsa-tdx-feedback-font);
   cursor: pointer;
-  box-shadow: 0 4px 12px rgba(0, 123, 255, 0.3);
+  box-shadow: 0 4px 12px rgba(0, 0, 0, 0.25);
   transition: all 0.2s ease;
   z-index: 9998;
   display: flex;
   align-items: center;
+  justify-content: center;
   gap: 8px;
 }
 
 .lsa-tdx-feedback-trigger-btn:hover {
-  background: #0056b3;
+  background: var(--lsa-tdx-feedback-accent-hover);
   transform: translateY(-2px);
-  box-shadow: 0 6px 20px rgba(0, 123, 255, 0.4);
+  box-shadow: 0 6px 20px rgba(0, 0, 0, 0.35);
 }
 
 .lsa-tdx-feedback-trigger-btn:active {
   transform: translateY(0);
 }
 
+.lsa-tdx-feedback-trigger-btn:focus-visible {
+  outline: 3px solid var(--lsa-tdx-feedback-accent);
+  outline-offset: 2px;
+}
+
 .lsa-tdx-feedback-trigger-text {
   display: inline;
 }
@@ -44,45 +107,41 @@
     font-size: 13px;
   }
 
+  /* min-width/min-height keep the 44px floor even with the label hidden */
   .lsa-tdx-feedback-trigger-text {
     display: none;
   }
 }
 
-/* Modal Styles */
+/*
+ * Modal — a native <dialog>. The browser promotes it to the top layer (renders
+ * above all page content, no z-index needed) and makes the rest of the page
+ * inert. The dialog element itself is the visible panel; the backdrop is the
+ * ::backdrop pseudo-element.
+ */
 .lsa-tdx-feedback-modal {
-  position: fixed;
-  top: 0;
-  left: 0;
-  width: 100%;
-  height: 100%;
-  z-index: 9999;
-  font-family: -apple-system, BlinkMacSystemFont, "Segoe UI", Roboto, "Helvetica Neue", Arial, sans-serif;
-}
-
-.lsa-tdx-feedback-modal-backdrop {
-  position: absolute;
-  top: 0;
-  left: 0;
-  width: 100%;
-  height: 100%;
-  background: rgba(0, 0, 0, 0.5);
-  backdrop-filter: blur(4px);
-}
-
-.lsa-tdx-feedback-modal-content {
-  position: relative;
-  background: white;
+  padding: 0;
+  border: none;
   border-radius: 12px;
-  box-shadow: 0 20px 40px rgba(0, 0, 0, 0.15);
+  background: var(--lsa-tdx-feedback-surface);
+  color: var(--lsa-tdx-feedback-text);
+  box-shadow: 0 20px 40px rgba(0, 0, 0, 0.3);
   max-width: 500px;
   width: 90%;
   max-height: 90vh;
   overflow-y: auto;
-  margin: 5vh auto;
+  font-family: var(--lsa-tdx-feedback-font);
+}
+
+.lsa-tdx-feedback-modal[open] {
   animation: lsa-tdx-feedback-modal-enter 0.3s ease-out;
 }
 
+.lsa-tdx-feedback-modal::backdrop {
+  background: var(--lsa-tdx-feedback-backdrop);
+  backdrop-filter: blur(4px);
+}
+
 @keyframes lsa-tdx-feedback-modal-enter {
   from {
     opacity: 0;
@@ -94,9 +153,20 @@
   }
 }
 
+@media (prefers-reduced-motion: reduce) {
+  .lsa-tdx-feedback-modal[open] {
+    animation: none;
+  }
+}
+
+/* Content is now a plain wrapper — the dialog element carries the panel look. */
+.lsa-tdx-feedback-modal-content {
+  position: relative;
+}
+
 .lsa-tdx-feedback-modal-header {
   padding: 24px 24px 16px;
-  border-bottom: 1px solid #e9ecef;
+  border-bottom: 1px solid var(--lsa-tdx-feedback-border);
   display: flex;
   justify-content: space-between;
   align-items: center;
@@ -106,18 +176,19 @@
   margin: 0;
   font-size: 20px;
   font-weight: 600;
-  color: #212529;
+  color: var(--lsa-tdx-feedback-text);
 }
 
 .lsa-tdx-feedback-close-btn {
   background: none;
   border: none;
   font-size: 24px;
-  color: #6c757d;
+  line-height: 1;
+  color: var(--lsa-tdx-feedback-text-muted);
   cursor: pointer;
   padding: 0;
-  width: 32px;
-  height: 32px;
+  min-width: var(--lsa-tdx-feedback-target-min);
+  min-height: var(--lsa-tdx-feedback-target-min);
   display: flex;
   align-items: center;
   justify-content: center;
@@ -126,8 +197,13 @@
 }
 
 .lsa-tdx-feedback-close-btn:hover {
-  background: #f8f9fa;
-  color: #495057;
+  background: var(--lsa-tdx-feedback-border);
+  color: var(--lsa-tdx-feedback-text);
+}
+
+.lsa-tdx-feedback-close-btn:focus-visible {
+  outline: 3px solid var(--lsa-tdx-feedback-accent);
+  outline-offset: 2px;
 }
 
 .lsa-tdx-feedback-modal-body {
@@ -142,7 +218,7 @@
   display: block;
   margin-bottom: 6px;
   font-weight: 500;
-  color: #495057;
+  color: var(--lsa-tdx-feedback-text);
   font-size: 14px;
 }
 
@@ -151,7 +227,12 @@
 .lsa-tdx-feedback-form-group textarea {
   width: 100%;
   padding: 10px 12px;
-  border: 1px solid #ced4da;
+  min-height: var(--lsa-tdx-feedback-target-min);
+  /* Pin field colors so a theme-aware host app's global form styles can't
+     bleed light-on-light (or dark-on-dark) into the modal. */
+  background-color: var(--lsa-tdx-feedback-field-bg);
+  color: var(--lsa-tdx-feedback-field-text);
+  border: 1px solid var(--lsa-tdx-feedback-border);
   border-radius: 6px;
   font-size: 14px;
   font-family: inherit;
@@ -159,12 +240,17 @@
   box-sizing: border-box;
 }
 
+.lsa-tdx-feedback-form-group input::placeholder,
+.lsa-tdx-feedback-form-group textarea::placeholder {
+  color: var(--lsa-tdx-feedback-placeholder);
+}
+
 .lsa-tdx-feedback-form-group input:focus,
 .lsa-tdx-feedback-form-group select:focus,
 .lsa-tdx-feedback-form-group textarea:focus {
   outline: none;
-  border-color: #007bff;
-  box-shadow: 0 0 0 3px rgba(0, 123, 255, 0.1);
+  border-color: var(--lsa-tdx-feedback-accent);
+  box-shadow: 0 0 0 3px var(--lsa-tdx-feedback-focus-ring);
 }
 
 .lsa-tdx-feedback-form-group textarea {
@@ -176,7 +262,7 @@
   display: block;
   margin-top: 4px;
   font-size: 12px;
-  color: #6c757d;
+  color: var(--lsa-tdx-feedback-text-muted);
 }
 
 .lsa-tdx-feedback-modal-footer {
@@ -188,6 +274,7 @@
 
 .lsa-tdx-feedback-btn {
   padding: 10px 20px;
+  min-height: var(--lsa-tdx-feedback-target-min);
   border-radius: 6px;
   font-size: 14px;
   font-weight: 500;
@@ -196,33 +283,39 @@
   border: 1px solid transparent;
   display: inline-flex;
   align-items: center;
+  justify-content: center;
   gap: 6px;
   font-family: inherit;
 }
 
+.lsa-tdx-feedback-btn:focus-visible {
+  outline: 3px solid var(--lsa-tdx-feedback-accent);
+  outline-offset: 2px;
+}
+
 .lsa-tdx-feedback-btn-primary {
-  background: #007bff;
-  color: white;
+  background: var(--lsa-tdx-feedback-accent);
+  color: var(--lsa-tdx-feedback-on-accent);
 }
 
 .lsa-tdx-feedback-btn-primary:hover:not(:disabled) {
-  background: #0056b3;
+  background: var(--lsa-tdx-feedback-accent-hover);
 }
 
 .lsa-tdx-feedback-btn-primary:disabled {
-  background: #6c757d;
+  opacity: 0.65;
   cursor: not-allowed;
 }
 
 .lsa-tdx-feedback-btn-secondary {
-  background: white;
-  color: #6c757d;
-  border-color: #ced4da;
+  background: var(--lsa-tdx-feedback-surface);
+  color: var(--lsa-tdx-feedback-text-muted);
+  border-color: var(--lsa-tdx-feedback-border);
 }
 
 .lsa-tdx-feedback-btn-secondary:hover {
-  background: #f8f9fa;
-  color: #495057;
+  background: var(--lsa-tdx-feedback-border);
+  color: var(--lsa-tdx-feedback-text);
 }
 
 .lsa-tdx-feedback-loading-spinner {
@@ -234,6 +327,12 @@
   to { transform: rotate(360deg); }
 }
 
+@media (prefers-reduced-motion: reduce) {
+  .lsa-tdx-feedback-loading-spinner {
+    animation-duration: 0s;
+  }
+}
+
 /* Messages */
 .lsa-tdx-feedback-message {
   margin: 16px 24px 0;
@@ -243,23 +342,22 @@
 }
 
 .lsa-tdx-feedback-message.success {
-  background: #d4edda;
-  color: #155724;
-  border: 1px solid #c3e6cb;
+  background: var(--lsa-tdx-feedback-success-bg);
+  color: var(--lsa-tdx-feedback-success-text);
+  border: 1px solid var(--lsa-tdx-feedback-success-border);
 }
 
 .lsa-tdx-feedback-message.error {
-  background: #f8d7da;
-  color: #721c24;
-  border: 1px solid #f5c6cb;
+  background: var(--lsa-tdx-feedback-error-bg);
+  color: var(--lsa-tdx-feedback-error-text);
+  border: 1px solid var(--lsa-tdx-feedback-error-border);
 }
 
 /* Mobile Responsive */
 @media (max-width: 768px) {
-  .lsa-tdx-feedback-modal-content {
-    margin: 2vh auto;
-    max-height: 96vh;
+  .lsa-tdx-feedback-modal {
     width: 95%;
+    max-height: 96vh;
   }
 
   .lsa-tdx-feedback-modal-header,
@@ -274,6 +372,5 @@
 
   .lsa-tdx-feedback-btn {
     width: 100%;
-    justify-content: center;
   }
 }

data/app/controllers/lsa_tdx_feedback/feedback_controller.rb

@@ -4,8 +4,29 @@ module LsaTdxFeedback
     before_action :set_lsa_tdx_feedback_data
 
     def create
-      ticket_client = TicketClient.new
+      feedback_data = build_feedback_data
 
+      # No fallback configured: preserve the original behavior exactly.
+      return create_via_tdx(feedback_data) if LsaTdxFeedback.configuration.fallback.nil?
+
+      # Fallback configured: file a TDX ticket when TDX is configured and the
+      # call succeeds; otherwise hand the feedback to the fallback so it's never
+      # lost (e.g. TDX creds absent, OAuth/API failure).
+      if LsaTdxFeedback.configuration.valid?
+        begin
+          ticket = TicketClient.new.create_feedback_ticket(feedback_data)
+          return render_ticket_created(ticket)
+        rescue StandardError => e
+          Rails.logger.error "LsaTdxFeedback: ticket failed (#{e.class}: #{e.message}); using fallback"
+        end
+      end
+
+      deliver_via_fallback(feedback_data)
+    end
+
+    private
+
+    def build_feedback_data
       # Build the title and include the app name if available
       title = feedback_params[:title].presence || "User Feedback - #{feedback_params[:category]}"
 
@@ -13,7 +34,7 @@ module LsaTdxFeedback
         title = "[#{@lsa_tdx_feedback_app_name}]: #{title}"
       end
 
-      feedback_data = {
+      {
         title: title,
         feedback: feedback_params[:feedback],
         category: feedback_params[:category],
@@ -23,33 +44,51 @@ module LsaTdxFeedback
         additional_info: feedback_params[:additional_info],
         priority_id: priority_from_category(feedback_params[:category])
       }
+    end
 
-      begin
-        ticket_response = ticket_client.create_feedback_ticket(feedback_data)
-
-        render json: {
-          success: true,
-          message: 'Thank you for your feedback! Your ticket has been created.',
-          ticket_id: ticket_response['ID']
-        }, status: :created
-      rescue LsaTdxFeedback::Error => e
-        Rails.logger.error "LsaTdxFeedback Error: #{e.message}"
-
-        render json: {
-          success: false,
-          message: 'Sorry, there was an error submitting your feedback. Please try again later.'
-        }, status: :unprocessable_entity
-      rescue StandardError => e
-        Rails.logger.error "Unexpected error in LsaTdxFeedback: #{e.message}\n#{e.backtrace.join("\n")}"
-
-        render json: {
-          success: false,
-          message: 'Sorry, there was an unexpected error. Please try again later.'
-        }, status: :internal_server_error
-      end
+    # The original create path, unchanged — used when no fallback is configured.
+    def create_via_tdx(feedback_data)
+      render_ticket_created(TicketClient.new.create_feedback_ticket(feedback_data))
+    rescue LsaTdxFeedback::Error => e
+      Rails.logger.error "LsaTdxFeedback Error: #{e.message}"
+
+      render json: {
+        success: false,
+        message: 'Sorry, there was an error submitting your feedback. Please try again later.'
+      }, status: :unprocessable_entity
+    rescue StandardError => e
+      Rails.logger.error "Unexpected error in LsaTdxFeedback: #{e.message}\n#{e.backtrace.join("\n")}"
+
+      render json: {
+        success: false,
+        message: 'Sorry, there was an unexpected error. Please try again later.'
+      }, status: :internal_server_error
     end
 
-    private
+    def render_ticket_created(ticket_response)
+      render json: {
+        success: true,
+        message: 'Thank you for your feedback! Your ticket has been created.',
+        ticket_id: ticket_response['ID']
+      }, status: :created
+    end
+
+    def deliver_via_fallback(feedback_data)
+      LsaTdxFeedback.configuration.fallback.call(feedback_data)
+
+      render json: {
+        success: true,
+        message: 'Thank you for your feedback!'
+      }, status: :created
+    rescue StandardError => e
+      # A failing fallback must not surface as a 500 — report a retryable error.
+      Rails.logger.error "LsaTdxFeedback: fallback delivery failed (#{e.class}: #{e.message})"
+
+      render json: {
+        success: false,
+        message: 'Sorry, there was an error submitting your feedback. Please try again later.'
+      }, status: :unprocessable_entity
+    end
 
     def feedback_params
       params.require(:feedback).permit(:title, :feedback, :category, :email, :url, :user_agent, :additional_info)

data/app/views/lsa_tdx_feedback/shared/_feedback_modal.html.erb

@@ -1,59 +1,62 @@
 <!-- LsaTdxFeedback Modal -->
-<div id="lsa-tdx-feedback-modal" class="lsa-tdx-feedback-modal" style="display: none;">
-  <div class="lsa-tdx-feedback-modal-backdrop"></div>
+<%# Native <dialog>: the browser promotes it to the top layer (renders above all
+    page content with no z-index needed) and makes the rest of the page inert,
+    so it can't be covered by, or fight, host chrome. The backdrop is the
+    ::backdrop pseudo-element (no manual backdrop div). %>
+<dialog id="lsa-tdx-feedback-modal" class="lsa-tdx-feedback-modal" aria-labelledby="lsa-tdx-feedback-title">
   <div class="lsa-tdx-feedback-modal-content">
     <div class="lsa-tdx-feedback-modal-header">
-      <h2>
-        <%= "[#{@lsa_tdx_feedback_app_name}]: " if defined?(@lsa_tdx_feedback_app_name) && @lsa_tdx_feedback_app_name.present? %>Send Feedback
+      <h2 id="lsa-tdx-feedback-title">
+        <%= "[#{@lsa_tdx_feedback_app_name}]: " if defined?(@lsa_tdx_feedback_app_name) && @lsa_tdx_feedback_app_name.present? %><%= t('lsa_tdx_feedback.modal.title') %>
       </h2>
-      <button type="button" class="lsa-tdx-feedback-close-btn" aria-label="Close">&times;</button>
+      <button type="button" class="lsa-tdx-feedback-close-btn" aria-label="<%= t('lsa_tdx_feedback.modal.close') %>">&times;</button>
     </div>
 
     <div class="lsa-tdx-feedback-modal-body">
       <form id="lsa-tdx-feedback-form">
         <div class="lsa-tdx-feedback-form-group">
-          <label for="lsa-tdx-feedback-category">Category</label>
+          <label for="lsa-tdx-feedback-category"><%= t('lsa_tdx_feedback.modal.category_label') %></label>
           <select id="lsa-tdx-feedback-category" name="category" required>
-            <option value="">Select a category</option>
-            <option value="bug">Bug Report</option>
-            <option value="suggestion">Suggestion</option>
-            <option value="feature">Feature Request</option>
-            <option value="general">General Feedback</option>
-            <option value="other">Other</option>
+            <option value=""><%= t('lsa_tdx_feedback.modal.category_prompt') %></option>
+            <option value="bug"><%= t('lsa_tdx_feedback.modal.categories.bug') %></option>
+            <option value="suggestion"><%= t('lsa_tdx_feedback.modal.categories.suggestion') %></option>
+            <option value="feature"><%= t('lsa_tdx_feedback.modal.categories.feature') %></option>
+            <option value="general"><%= t('lsa_tdx_feedback.modal.categories.general') %></option>
+            <option value="other"><%= t('lsa_tdx_feedback.modal.categories.other') %></option>
           </select>
         </div>
 
         <div class="lsa-tdx-feedback-form-group">
-          <label for="lsa-tdx-feedback-feedback">Your Feedback *</label>
+          <label for="lsa-tdx-feedback-feedback"><%= t('lsa_tdx_feedback.modal.feedback_label') %> *</label>
           <textarea
             id="lsa-tdx-feedback-feedback"
             name="feedback"
             required
             rows="5"
-            placeholder="Please describe your feedback in detail..."
+            placeholder="<%= t('lsa_tdx_feedback.modal.feedback_placeholder') %>"
           ></textarea>
         </div>
 
         <div class="lsa-tdx-feedback-form-group">
-          <label for="lsa-tdx-feedback-email">Your Email *</label>
+          <label for="lsa-tdx-feedback-email"><%= t('lsa_tdx_feedback.modal.email_label') %> *</label>
           <input
             type="email"
             id="lsa-tdx-feedback-email"
             name="email"
-            placeholder="your.email@example.com"
+            placeholder="<%= t('lsa_tdx_feedback.modal.email_placeholder') %>"
             required
             value="<%= @lsa_tdx_feedback_user_email if defined?(@lsa_tdx_feedback_user_email) && @lsa_tdx_feedback_user_email.present? %>"
           >
-          <small class="lsa-tdx-feedback-help-text">Required - We'll use this to follow up on your feedback</small>
+          <small class="lsa-tdx-feedback-help-text"><%= t('lsa_tdx_feedback.modal.email_help') %></small>
         </div>
 
         <div class="lsa-tdx-feedback-form-group">
-          <label for="lsa-tdx-feedback-additional-info">Additional Information</label>
+          <label for="lsa-tdx-feedback-additional-info"><%= t('lsa_tdx_feedback.modal.additional_info_label') %></label>
           <textarea
             id="lsa-tdx-feedback-additional-info"
             name="additional_info"
             rows="3"
-            placeholder="Any additional context or information..."
+            placeholder="<%= t('lsa_tdx_feedback.modal.additional_info_placeholder') %>"
           ></textarea>
         </div>
 
@@ -65,16 +68,16 @@
 
     <div class="lsa-tdx-feedback-modal-footer">
       <button type="button" class="lsa-tdx-feedback-btn lsa-tdx-feedback-btn-secondary lsa-tdx-feedback-cancel-btn">
-        Cancel
+        <%= t('lsa_tdx_feedback.modal.cancel') %>
       </button>
       <button type="submit" form="lsa-tdx-feedback-form" class="lsa-tdx-feedback-btn lsa-tdx-feedback-btn-primary lsa-tdx-feedback-submit-btn">
-        <span class="lsa-tdx-feedback-btn-text">Send Feedback</span>
+        <span class="lsa-tdx-feedback-btn-text"><%= t('lsa_tdx_feedback.modal.submit') %></span>
         <span class="lsa-tdx-feedback-loading-spinner" style="display: none;">
           <svg width="16" height="16" viewBox="0 0 24 24" fill="none">
             <circle cx="12" cy="12" r="10" stroke="currentColor" stroke-width="4" opacity="0.25"/>
             <path d="M4 12a8 8 0 018-8V0C5.373 0 0 5.373 0 12h4zm2 5.291A7.962 7.962 0 014 12H0c0 3.042 1.135 5.824 3 7.938l3-2.647z" fill="currentColor"/>
           </svg>
-          Sending...
+          <%= t('lsa_tdx_feedback.modal.sending') %>
         </span>
       </button>
     </div>
@@ -84,12 +87,17 @@
       <div class="lsa-tdx-feedback-message-content"></div>
     </div>
   </div>
-</div>
+</dialog>
 
-<!-- Feedback Button -->
-<button id="lsa-tdx-feedback-trigger" class="lsa-tdx-feedback-trigger-btn" title="Send Feedback">
-  <svg width="20" height="20" viewBox="0 0 24 24" fill="currentColor">
-    <path d="M20 2H4c-1.1 0-2 .9-2 2v12c0 1.1.9 2 2 2h4l4 4 4-4h4c1.1 0 2-.9 2-2V4c0-1.1-.9-2-2-2zm-2 12H6v-2h12v2zm0-3H6V9h12v2zm0-3H6V6h12v2z"/>
-  </svg>
-  <span class="lsa-tdx-feedback-trigger-text">Feedback</span>
-</button>
+<%# Floating trigger button. Rendered by default; pass trigger: false to
+    lsa_tdx_feedback_modal to omit it and open the modal from your own control
+    via window.LsaTdxFeedback.showModal(). Defaults to true for callers that
+    render the partial without the local (backward compatible). %>
+<% if local_assigns.fetch(:trigger, true) %>
+  <button id="lsa-tdx-feedback-trigger" class="lsa-tdx-feedback-trigger-btn" title="<%= t('lsa_tdx_feedback.modal.title') %>">
+    <svg width="20" height="20" viewBox="0 0 24 24" fill="currentColor">
+      <path d="M20 2H4c-1.1 0-2 .9-2 2v12c0 1.1.9 2 2 2h4l4 4 4-4h4c1.1 0 2-.9 2-2V4c0-1.1-.9-2-2-2zm-2 12H6v-2h12v2zm0-3H6V9h12v2zm0-3H6V6h12v2z"/>
+    </svg>
+    <span class="lsa-tdx-feedback-trigger-text"><%= t('lsa_tdx_feedback.modal.trigger_label') %></span>
+  </button>
+<% end %>

data/config/locales/en.yml

@@ -0,0 +1,30 @@
+# All keys are scoped under `lsa_tdx_feedback.*` so they merge into a host
+# app's I18n without colliding with its own keys. Rails auto-loads this file
+# (Rails::Engine adds config/locales/**/*.yml to I18n.load_path). A host can
+# translate to other locales, or override any string, by defining the same
+# scoped keys in its own locale files (which load after the engine's, so they
+# win).
+en:
+  lsa_tdx_feedback:
+    modal:
+      title: "Send Feedback"
+      close: "Close"
+      category_label: "Category"
+      category_prompt: "Select a category"
+      categories:
+        bug: "Bug Report"
+        suggestion: "Suggestion"
+        feature: "Feature Request"
+        general: "General Feedback"
+        other: "Other"
+      feedback_label: "Your Feedback"
+      feedback_placeholder: "Please describe your feedback in detail..."
+      email_label: "Your Email"
+      email_placeholder: "your.email@example.com"
+      email_help: "Required - We'll use this to follow up on your feedback"
+      additional_info_label: "Additional Information"
+      additional_info_placeholder: "Any additional context or information..."
+      cancel: "Cancel"
+      submit: "Send Feedback"
+      sending: "Sending..."
+      trigger_label: "Feedback"

data/lib/lsa_tdx_feedback/application_controller_extensions.rb

@@ -24,18 +24,9 @@ module LsaTdxFeedback
         nil
       end
 
-      # Logging
-      Rails.logger.info "set_lsa_tdx_feedback_data called"
-      Rails.logger.info "  respond_to? current_user_email_for_feedback: #{respond_to?(:current_user_email_for_feedback, true)}"
-      Rails.logger.info "  current_user available: #{respond_to?(:current_user, true)}"
-      Rails.logger.info "  current_user: #{current_user&.email || 'nil'}"
+      return unless respond_to?(:current_user_email_for_feedback, true)
 
-      if respond_to?(:current_user_email_for_feedback, true)
-        @lsa_tdx_feedback_user_email = current_user_email_for_feedback
-        Rails.logger.info "  @lsa_tdx_feedback_user_email set to: #{@lsa_tdx_feedback_user_email}"
-      else
-        Rails.logger.info "  current_user_email_for_feedback method not available"
-      end
+      @lsa_tdx_feedback_user_email = current_user_email_for_feedback
     end
 
     # Override this method in your ApplicationController to provide user email

data/lib/lsa_tdx_feedback/configuration.rb

@@ -4,7 +4,15 @@ module LsaTdxFeedback
                   :default_type_id, :default_form_id, :default_classification,
                   :default_status_id, :default_priority_id, :default_responsible_group_id,
                   :default_service_id, :default_source_id, :service_offering_id, :account_id,
-                  :cache_store, :cache_expiry
+                  :cache_store, :cache_expiry,
+                  # Optional callable invoked with the feedback data hash when a
+                  # ticket can't be filed — TDX not configured, or the API call
+                  # raises — so feedback is never lost. It receives the same
+                  # feedback_data the ticket would have used (see
+                  # FeedbackController#create) and is responsible for delivering
+                  # it (e.g. emailing an admin). nil (default) preserves the
+                  # original behavior: no fallback, controller returns an error.
+                  :fallback
 
     def initialize
       # All values must be configured by the application for security
@@ -27,6 +35,9 @@ module LsaTdxFeedback
       # Cache configuration
       @cache_store = :redis_cache_store
       @cache_expiry = 3600 # 1 hour for OAuth tokens
+
+      # Optional delivery fallback (see attr_accessor above)
+      @fallback = nil
     end
 
     def oauth_scope

data/lib/lsa_tdx_feedback/version.rb

@@ -1,3 +1,3 @@
 module LsaTdxFeedback
-  VERSION = '1.0.4'
+  VERSION = '2.0.1'
 end

data/lib/lsa_tdx_feedback/view_helpers.rb

@@ -5,9 +5,15 @@ module LsaTdxFeedback
       "HELPER IS WORKING!".html_safe
     end
 
-    # Renders the feedback modal and trigger button
-    def lsa_tdx_feedback_modal
-      render(partial: 'lsa_tdx_feedback/shared/feedback_modal')
+    # Renders the feedback modal and, by default, the floating trigger button.
+    #
+    # Pass trigger: false to render the modal WITHOUT the built-in floating
+    # button, and open it yourself from your own control (a nav link, a footer
+    # button, etc.) via `window.LsaTdxFeedback.showModal()`. Useful when the
+    # fixed bottom-right button collides with other fixed page chrome, or when
+    # you want feedback reachable from a specific place in your own UI.
+    def lsa_tdx_feedback_modal(trigger: true)
+      render(partial: 'lsa_tdx_feedback/shared/feedback_modal', locals: { trigger: trigger })
     end
 
     # Includes the feedback gem CSS
@@ -27,10 +33,11 @@ module LsaTdxFeedback
       (css + js).html_safe
     end
 
-    # All-in-one helper that includes both modal and assets
-    def lsa_tdx_feedback
+    # All-in-one helper that includes both modal and assets.
+    # Passes trigger: through to lsa_tdx_feedback_modal (see there).
+    def lsa_tdx_feedback(trigger: true)
       assets = lsa_tdx_feedback_assets
-      modal = lsa_tdx_feedback_modal
+      modal = lsa_tdx_feedback_modal(trigger: trigger)
       (assets + modal).html_safe
     end
   end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: lsa_tdx_feedback
 version: !ruby/object:Gem::Version
-  version: 1.0.4
+  version: 2.0.1
 platform: ruby
 authors:
 - LSA Rails Team
@@ -185,6 +185,7 @@ files:
 - app/assets/stylesheets/lsa_tdx_feedback.css
 - app/controllers/lsa_tdx_feedback/feedback_controller.rb
 - app/views/lsa_tdx_feedback/shared/_feedback_modal.html.erb
+- config/locales/en.yml
 - config/routes.rb
 - example_application_tests.rb
 - lib/lsa_tdx_feedback.rb
@@ -216,7 +217,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.6.9
+rubygems_version: 4.0.12
 specification_version: 4
 summary: A self-contained Rails gem for collecting user feedback via TDX API for LSA
   applications