lportal 1.0.18 → 1.0.19

data/test/unit/phone_test.rb

@@ -1,18 +1,24 @@
-require 'test_helper'
+# encoding: utf-8
+
+require 'test/test_helper'
 
 class PhoneTest < ActiveSupport::TestCase
   fixtures [
-    :company,
-    :user_,
-    :phone,
-    :contact_,
-    :classname_,
-    :listtype
+    :Company,
+    :User_,
+    :Phone,
+    :Contact_,
+    :ClassName_,
+    :ListType
   ]
 
   def setup
     @phones = Phone.all
   end
+  
+  def test_create
+    flunk 'todo'
+  end
 
   def test_phones
     @phones.each do |phone|

data/test/unit/poll/question_test.rb

@@ -1,8 +1,34 @@
-require 'test_helper'
+# encoding: utf-8
+
+require 'test/test_helper'
 
 class Poll::QuestionTest < ActiveSupport::TestCase
-  # Replace this with your real tests.
-  def test_truth
-    assert true
+  fixtures [
+    :Company,
+    :User_,
+    :Group_,
+    :PollsQuestion
+  ]
+
+  def setup
+    @qs = Journal::Feed.all
+  end
+
+  def test_company
+    @qs.each do |x|
+      assert_not_nil x.company
+    end
+  end
+
+  def test_group
+    @qs.each do |x|
+      assert_not_nil x.group
+    end
+  end
+
+  def test_user
+    @qs.each do |x|
+      assert_not_nil x.user
+    end
   end
 end

data/test/unit/ratings_stats_test.rb

@@ -0,0 +1,16 @@
+# encoding: utf-8
+
+require 'test/test_helper'
+
+class RatingsStatsTest < ActiveSupport::TestCase
+#   fixtures [
+#     :Company,
+#     :User_,
+#     :Group_,
+#     :RatingsStats
+#   ]
+# 
+#   def setup
+#     @stats = RatingsStats.all
+#   end
+end

data/test/unit/release_test.rb

@@ -1,7 +1,9 @@
-require 'test_helper'
+# encoding: utf-8
+
+require 'test/test_helper'
 
 class ReleaseTest < ActiveSupport::TestCase
-  fixtures :release_
+  fixtures :Release_
 
   def test_releases
     releases = Release.all
@@ -19,7 +21,7 @@ class ReleaseTest < ActiveSupport::TestCase
 
     Lportal::Schema.buildnumber = 5100
     assert_equal 5100, Lportal::Schema.buildnumber
-    assert_equal '5.1', Lportal::Schema.version
+    assert_equal '5.1.0', Lportal::Schema.version
   end
 
 end

data/test/unit/resource_code_test.rb

@@ -1,8 +1,11 @@
-require 'test_helper'
+# encoding: utf-8
+
+require 'test/test_helper'
 
 class ResourceCodeTest < ActiveSupport::TestCase
   fixtures [
-    :resource_, :resourcecode,
+    :Company,
+    :Resource_, :ResourceCode
   ]
 
   def setup

data/test/unit/resource_test.rb

@@ -1,31 +1,52 @@
-require 'test_helper'
+# encoding: utf-8
+
+require 'test/test_helper'
 
 class ResourceTest < ActiveSupport::TestCase
   fixtures [
-    :resource_, :resourcecode,
-    :igimage,
-    :portletpreferences,
-    :mbmessage,
-    :layout,
-    :journalarticle,
-    :bookmarksfolder,
-    :wikinode, :wikipage, :wikipageresource,
-    :announcementsentry,
-    :calevent,
-    :dlfolder, :dlfileentry
+    :Company,
+    :Resource_, :ResourceCode,
+    :Permission_,
+    :IGImage,
+    :PortletPreferences,
+    :MBMessage,
+    :Layout,
+    :JournalArticle,
+    :BookmarksFolder,
+    :WikiNode, :WikiPage, :WikiPageResource,
+    :AnnouncementsEntry,
+    :CalEvent,
+    :DLFolder, :DLFileEntry
   ]
 
   def setup
     @resources = Resource.all
   end
 
-#   # each resource must have a resourcecode
-#   def test_codes
-#     @resources.each do |x|
-#       assert_not_nil x.code, "#{x.id} has no resourcecode"
-#     end
-#   end
-# 
+  # each resource must have a resourcecode
+  def test_codes
+    @resources.each do |x|
+      assert_not_nil x.resourcecode, "#{x.id} has no resourcecode"
+    end
+  end
+
+  def test_permissions
+    @resources.each do |x|
+      x.permissions.each do |p|
+        assert_equal Permission, p.class
+        assert_equal x, p.resource
+      end
+    end
+  end
+
+  def test_layout
+    @resources.each do |x|
+      if x.layout
+        assert_equal Web::Layout, x.layout.class
+      end
+    end
+  end
+  
 #   def test_permissions
 #     @resources.each do |x|
 #       permissions = x.permissions

data/test/unit/role_test.rb

@@ -1,15 +1,20 @@
-require 'test_helper'
+# encoding: utf-8
+
+require 'test/test_helper'
 
 class RoleTest < ActiveSupport::TestCase
   fixtures [
-    :role_,
-    :users_roles,
-    :groups_roles,
-#     :permission_,
-#     :users_permissions,
-#     :groups_permissions,
-#     :resource_,
-#     :resourcecode
+    :Company,
+    :Role_,
+    :Users_Roles,
+    :Group_,
+    :Groups_Roles,
+
+#     :Permission_,
+#     :Roles_Permissions,
+#     :Users_Permissions,
+#     :Groups_Permissions,
+#     :Resource_, :ResourceCode
   ]
 
   def setup
@@ -19,6 +24,9 @@ class RoleTest < ActiveSupport::TestCase
   end
 
   def test_create
+    flunk mysql_bug if defined?(mysql_bug)
+    # ^ bug goes down to Acts as Resourceful
+
     name = 'Regular role'
     description = 'test'
 

data/test/unit/social_activity_test.rb

@@ -0,0 +1,35 @@
+# encoding: utf-8
+
+require 'test/test_helper'
+
+class SocialActivityTest < ActiveSupport::TestCase
+  fixtures [
+    :Company,
+    :User_,
+    :Group_,
+    :SocialActivity
+  ]
+
+  def setup
+    @activities = SocialActivity.all
+  end
+
+  def test_company
+    @activities.each do |x|
+      assert_not_nil x.company
+    end
+  end
+
+  def test_group
+    @activities.each do |x|
+      assert_not_nil x.group
+    end
+  end
+
+  def test_user
+    @activities.each do |x|
+      assert_not_nil x.user
+    end
+  end
+
+end

data/test/unit/social_relation_test.rb

@@ -0,0 +1,29 @@
+# encoding: utf-8
+
+require 'test/test_helper'
+
+class SocialRelationTest < ActiveSupport::TestCase
+  fixtures [
+    :Company,
+    :User_,
+    :SocialRelation
+  ]
+
+  def setup
+    @relations = SocialRelation.all
+  end
+
+  def test_company
+    @relations.each do |x|
+      assert_not_nil x.company
+    end
+  end
+
+  def test_users
+    @relations.each do |x|
+      assert_not_nil x.user1
+      assert_not_nil x.user2
+    end
+  end
+
+end

data/test/unit/tag/asset_test.rb

@@ -1,21 +1,28 @@
-require 'test_helper'
+# encoding: utf-8
+
+require 'test/test_helper'
 
 class Tag::AssetTest < ActiveSupport::TestCase
   fixtures [
-    :tagsasset, :tagsassets_tagsentries,
-#     :resource_, :resourcecode,
-    :classname_,
-    :igimage,
-    :mbmessage,
-    :blogsentry,
-    :wikipage,
-    :bookmarksentry,
-    :journalarticle,
-    :dlfileentry,
-    :layout
+    :Company,
+    :User_,
+    :Group_,
+    :TagsAsset, :TagsAssets_TagsEntries,
+#     :Resource_, :ResourceCode,
+    :ClassName_,
+    :IGImage,
+    :MBMessage,
+    :BlogsEntry,
+    :WikiPage,
+    :BookmarksEntry,
+    :JournalArticle,
+    :DLFileEntry,
+    :Layout
   ]
 
   def setup
+    flunk mysql_bug if defined?(mysql_bug)
+
     @assets = Tag::Asset.all
     # TODO: DRY up, the same creation code is in portlet test.
     unless Web::Portlet.find_by_name('asset_publisher')
@@ -55,6 +62,7 @@ class Tag::AssetTest < ActiveSupport::TestCase
 
         path = asset.path
         assert_not_nil path
+        assert !path.empty?
         if build==5100
           assert path[/#{asset.id}/], 'Path ”%s” does not contain asset id (%i)' % [path, asset.id]
           assert path[/tagged_content/]
@@ -93,10 +101,16 @@ class Tag::AssetTest < ActiveSupport::TestCase
     end
   end
 
-  def test_owner
+  def test_company
+    @assets.each do |asset|
+      assert_not_nil asset.company
+    end
+  end
+
+  def test_user
     @assets.each do |asset|
-      assert_not_nil asset.owner
-      assert_equal User, asset.owner.class
+      assert_not_nil asset.user, 'Asset %i has no user' % asset.id
+      assert_equal User, asset.user.class
     end
   end
 

data/test/unit/tag/entry_test.rb

@@ -1,7 +1,17 @@
-require 'test_helper'
+# encoding: utf-8
+
+require 'test/test_helper'
 
 class Tag::EntryTest < ActiveSupport::TestCase
-  fixtures :tagsentry, :tagsproperty, :tagsasset, :tagsassets_tagsentries, :classname_
+  fixtures [
+    :Company,
+    :User_,
+    :TagsAsset,
+    :TagsEntry,
+    :TagsAssets_TagsEntries,
+    :TagsProperty,
+    :ClassName_
+  ]
 
   def setup
     @tags = Tag::Entry.find :all
@@ -20,9 +30,9 @@ class Tag::EntryTest < ActiveSupport::TestCase
     end
   end
 
-  def test_owner
+  def test_user
     @tags.each do |x|
-      assert_not_nil x.owner, "#{x.id} (#{x.name}) belongs to no user"
+      assert_not_nil x.user, "#{x.id} (#{x.name}) belongs to no user"
     end
   end
 

data/test/unit/tag/property_test.rb

@@ -1,21 +1,29 @@
-require 'test_helper'
+# encoding: utf-8
+
+require 'test/test_helper'
 
 class Tag::PropertyTest < ActiveSupport::TestCase
-  fixtures :tagsentry, :tagsproperty
+  fixtures [
+    :Company,
+    :User_,
+    :TagsEntry,
+    :TagsProperty
+  ]
 
   def setup
-    @properties = Tag::Property.find :all
+    @properties = Tag::Property.all
+    flunk 'No properties to test' unless @properties.any?
   end
 
   def test_company
     @properties.each do |x|
-      assert_not_nil x.company, "#{x.id} belongs to no companies"
+      assert_not_nil x.company
     end
   end
 
-  def test_owner
+  def test_user
     @properties.each do |x|
-      assert_not_nil x.owner, "#{x.id} belongs to no user"
+      assert_not_nil x.user, "#{x.id} belongs to no user"
     end
   end
 

data/test/unit/user_test.rb

@@ -1,16 +1,23 @@
-require 'test_helper'
+# encoding: utf-8
+
+require 'test/test_helper'
 
 class UserTest < ActiveSupport::TestCase
   fixtures [
-    :organization_,
-    :address,
-    :phone,
-    :contact_,
-    :classname_,
-    :listtype,
-    :layoutset,
-    :counter,
-    :resourcecode
+    :Address,
+    :Company,
+    :Phone,
+    :Contact_,
+    :ClassName_,
+    :ListType,
+    :LayoutSet,
+    :Counter,
+    :Role_,
+    :ResourceCode,
+    :Organization_,
+    :Users_Orgs,
+    :Group_,
+    :Users_Groups
   ]
 
   def setup
@@ -20,6 +27,8 @@ class UserTest < ActiveSupport::TestCase
   end
 
   def test_create
+    flunk mysql_bug if defined?(mysql_bug)
+
     firstname = 'Test'
     lastname  = 'User'
     email     = 'test@localhost'
@@ -200,25 +209,17 @@ class UserTest < ActiveSupport::TestCase
 
   # each user must belong to a company
   def test_company
+    companies = Company.all
     @users.each do |x|
-      assert_not_nil x.company
-    end
-  end
-
-  # each user can belong to many organizations (they don't have to)
-  def test_organization
-    @users.each do |x|
-      x.organizations.each do |o|
-        assert_not_nil o
-      end
-        #assert !x.organizations.empty?, "#{x.screenname} belongs to no organizations"
+      assert_equal Company, x.company.class
+      assert companies.include?(x.company)
     end
   end
 
   # each user must have a contact
   def test_contact
     @users.each do |x|
-      assert_not_nil x.contact
+      assert_not_nil x.contact, x.inspect unless x.is_default?
     end
   end
 
@@ -230,7 +231,7 @@ class UserTest < ActiveSupport::TestCase
 
   def test_sex
     @users.each do |x|
-      assert_not_nil x.sex
+      assert_not_nil x.sex unless x.is_default?
     end
   end
 
@@ -238,11 +239,12 @@ class UserTest < ActiveSupport::TestCase
   def test_hive
     @users.each do |user|
       group = user.hive
-      if user.is_guest?
-        assert_nil group
-      else
-        assert_not_nil group
-      end
+      # since Liferay 5.2.3 guest has group
+      #if user.is_guest?
+      #  assert_nil group
+      #else
+      #  assert_not_nil group, 'User %i has no "home" group' % user.id
+      #end
       next unless group
       # the group must have a proper classnameid
       _class = Classname.find_by_value user.liferay_class
@@ -257,7 +259,7 @@ class UserTest < ActiveSupport::TestCase
         # there has to be layoutsets
         assert !group.layoutsets.empty?, "#{user.id}'s personal group does not have layoutsets"
 
-      # ..eusercept that Liferay-5.1.user doesn't seem to unactive the group
+      # ..except that Liferay-5.1 doesn't seem to unactivate the group
       else
         #assert !group.is_active?, "#{user.id}'s personal group is active, while the user is not"
 
@@ -265,33 +267,60 @@ class UserTest < ActiveSupport::TestCase
     end
   end
 
-#   def test_rigidity
-#     # each group must exist!
-#     groups = @users.map{|x| x.groups}.uniq
-#     groups.each do |group|
-#       assert_not_nil group, "Reference to non-existing group  #{group.inspect}"
-#     end
-# 
-#     # each role must exist!
-#     roles = @users.map{|x| x.roles}.uniq
-#     roles.each do |role|
-#       assert_not_nil role, "Reference to non-existing role #{role.inspect}"
-#     end
-# 
-#     # each permission must exist!
-#     perms = @users.map{|x| x.permissions}.uniq
-#     perms.each do |p|
-#       assert_not_nil p, "Reference to non-existing permission #{p.inspect}"
-#     end
-#   end
-# 
-#   def test_path
-#     @users.each do |u|
-#       unless u.hive.nil?
-#         assert_not_nil u.path(:public), u.id if u.hive.public_layoutset
-#         assert_not_nil u.path(:private), u.id if u.hive.private_layoutset
-#       end
-#     end
-#   end
+  def test_organizations
+    orgs = @users.map{|x| x.orgs}.flatten.uniq
+    # Liferay 5.2.3
+    assert_equal 11, orgs.size
+    orgs.each do |org|
+      assert_equal Organization, org.class
+    end
+  end
+
+  def test_all_groups
+    # each group must exist!
+    groups = @users.map{|x| x.groups}.flatten.uniq
+    # Liferay 5.2.3
+    assert_equal 1, groups.size
+    groups.each do |group|
+      assert_equal Group, group.class
+    end
+  end
+
+  def test_all_roles
+    # each role must exist!
+    roles = @users.map{|x| x.roles}.flatten.uniq
+    # Liferay 5.2.3
+    assert_equal 3, roles.size
+    roles.each do |role|
+      assert_equal Role, role.class
+    end
+  end
+
+  def test_all_permissions
+    permissions = @users.map{|x| x.permissions}.flatten.uniq
+    # Liferay 5.2.3
+    assert_equal 0, permissions.size
+    permissions.each do |permission|
+      assert_equal Permission, permission.class
+    end
+  end
+
+  def test_all_usergroups
+    usergroups = @users.map{|x| x.usergroups}.flatten.uniq
+    # Liferay 5.2.3
+    assert_equal 0, usergroups.size
+    usergroups.each do |usergroup|
+      assert_equal Usergroup, permission.class
+    end
+  end
+
+  def test_path
+    @users.each do |u|
+      unless u.hive.nil?
+        assert_not_nil u.path(:public), u.id if u.hive.public_layoutset
+        assert_not_nil u.path(:private), u.id if u.hive.private_layoutset
+      end
+    end
+  end
 
 end