loyal_devise 2.1.2

data/test/models/lockable_test.rb

@@ -0,0 +1,274 @@
+# -*- encoding : utf-8 -*-
+require 'test_helper'
+
+class LockableTest < ActiveSupport::TestCase
+  def setup
+    setup_mailer
+  end
+
+  test "should respect maximum attempts configuration" do
+    user = create_user
+    user.confirm!
+    swap Devise, :maximum_attempts => 2 do
+      3.times { user.valid_for_authentication?{ false } }
+      assert user.reload.access_locked?
+    end
+  end
+
+  test "should increment failed_attempts on successfull validation if the user is already locked" do
+    user = create_user
+    user.confirm!
+
+    swap Devise, :maximum_attempts => 2 do
+      3.times { user.valid_for_authentication?{ false } }
+      assert user.reload.access_locked?
+    end
+
+    user.valid_for_authentication?{ true }
+    assert_equal 4, user.reload.failed_attempts
+  end
+
+  test "should not touch failed_attempts if lock_strategy is none" do
+    user = create_user
+    user.confirm!
+    swap Devise, :lock_strategy => :none, :maximum_attempts => 2 do
+      3.times { user.valid_for_authentication?{ false } }
+      assert !user.access_locked?
+      assert_equal 0, user.failed_attempts
+    end
+  end
+
+  test 'should be valid for authentication with a unlocked user' do
+    user = create_user
+    user.lock_access!
+    user.unlock_access!
+    assert user.valid_for_authentication?{ true }
+  end
+
+  test "should verify whether a user is locked or not" do
+    user = create_user
+    assert_not user.access_locked?
+    user.lock_access!
+    assert user.access_locked?
+  end
+
+  test "active_for_authentication? should be the opposite of locked?" do
+    user = create_user
+    user.confirm!
+    assert user.active_for_authentication?
+    user.lock_access!
+    assert_not user.active_for_authentication?
+  end
+
+  test "should unlock a user by cleaning locked_at, falied_attempts and unlock_token" do
+    user = create_user
+    user.lock_access!
+    assert_not_nil user.reload.locked_at
+    assert_not_nil user.reload.unlock_token
+
+    user.unlock_access!
+    assert_nil user.reload.locked_at
+    assert_nil user.reload.unlock_token
+    assert_equal 0, user.reload.failed_attempts
+  end
+
+  test "new user should not be locked and should have zero failed_attempts" do
+    assert_not new_user.access_locked?
+    assert_equal 0, create_user.failed_attempts
+  end
+
+  test "should unlock user after unlock_in period" do
+    swap Devise, :unlock_in => 3.hours do
+      user = new_user
+      user.locked_at = 2.hours.ago
+      assert user.access_locked?
+
+      Devise.unlock_in = 1.hour
+      assert_not user.access_locked?
+    end
+  end
+
+  test "should not unlock in 'unlock_in' if :time unlock strategy is not set" do
+    swap Devise, :unlock_strategy => :email do
+      user = new_user
+      user.locked_at = 2.hours.ago
+      assert user.access_locked?
+    end
+  end
+
+  test "should set unlock_token when locking" do
+    user = create_user
+    assert_nil user.unlock_token
+    user.lock_access!
+    assert_not_nil user.unlock_token
+  end
+
+  test "should never generate the same unlock token for different users" do
+    unlock_tokens = []
+    3.times do
+      user = create_user
+      user.lock_access!
+      token = user.unlock_token
+      assert !unlock_tokens.include?(token)
+      unlock_tokens << token
+    end
+  end
+
+  test "should not generate unlock_token when :email is not an unlock strategy" do
+    swap Devise, :unlock_strategy => :time do
+      user = create_user
+      user.lock_access!
+      assert_nil user.unlock_token
+    end
+  end
+
+  test "should send email with unlock instructions when :email is an unlock strategy" do
+    swap Devise, :unlock_strategy => :email do
+      user = create_user
+      assert_email_sent do
+        user.lock_access!
+      end
+    end
+  end
+
+  test "should not send email with unlock instructions when :email is not an unlock strategy" do
+    swap Devise, :unlock_strategy => :time do
+      user = create_user
+      assert_email_not_sent do
+        user.lock_access!
+      end
+    end
+  end
+
+  test 'should find and unlock a user automatically' do
+    user = create_user
+    user.lock_access!
+    locked_user = User.unlock_access_by_token(user.unlock_token)
+    assert_equal locked_user, user
+    assert_not user.reload.access_locked?
+  end
+
+  test 'should return a new record with errors when a invalid token is given' do
+    locked_user = User.unlock_access_by_token('invalid_token')
+    assert_not locked_user.persisted?
+    assert_equal "is invalid", locked_user.errors[:unlock_token].join
+  end
+
+  test 'should return a new record with errors when a blank token is given' do
+    locked_user = User.unlock_access_by_token('')
+    assert_not locked_user.persisted?
+    assert_equal "can't be blank", locked_user.errors[:unlock_token].join
+  end
+
+  test 'should find a user to send unlock instructions' do
+    user = create_user
+    user.lock_access!
+    unlock_user = User.send_unlock_instructions(:email => user.email)
+    assert_equal unlock_user, user
+  end
+
+  test 'should return a new user if no email was found' do
+    unlock_user = User.send_unlock_instructions(:email => "invalid@example.com")
+    assert_not unlock_user.persisted?
+  end
+
+  test 'should add error to new user email if no email was found' do
+    unlock_user = User.send_unlock_instructions(:email => "invalid@example.com")
+    assert_equal 'not found', unlock_user.errors[:email].join
+  end
+
+  test 'should find a user to send unlock instructions by authentication_keys' do
+    swap Devise, :authentication_keys => [:username, :email] do
+      user = create_user
+      unlock_user = User.send_unlock_instructions(:email => user.email, :username => user.username)
+      assert_equal unlock_user, user
+    end
+  end
+
+  test 'should require all unlock_keys' do
+      swap Devise, :unlock_keys => [:username, :email] do
+          user = create_user
+          unlock_user = User.send_unlock_instructions(:email => user.email)
+          assert_not unlock_user.persisted?
+          assert_equal "can't be blank", unlock_user.errors[:username].join
+      end
+  end
+
+  test 'should not be able to send instructions if the user is not locked' do
+    user = create_user
+    assert_not user.resend_unlock_token
+    assert_not user.access_locked?
+    assert_equal 'was not locked', user.errors[:email].join
+  end
+
+  test 'should unlock account if lock has expired and increase attempts on failure' do
+    swap Devise, :unlock_in => 1.minute do
+      user = create_user
+      user.confirm!
+
+      user.failed_attempts = 2
+      user.locked_at = 2.minutes.ago
+
+      user.valid_for_authentication? { false }
+      assert_equal 1, user.failed_attempts
+    end
+  end
+
+  test 'should unlock account if lock has expired on success' do
+    swap Devise, :unlock_in => 1.minute do
+      user = create_user
+      user.confirm!
+
+      user.failed_attempts = 2
+      user.locked_at = 2.minutes.ago
+
+      user.valid_for_authentication? { true }
+      assert_equal 0, user.failed_attempts
+      assert_nil user.locked_at
+    end
+  end
+
+  test 'required_fields should contain the all the fields when all the strategies are enabled' do
+    swap Devise, :unlock_strategy => :both do
+      swap Devise, :lock_strategy => :failed_attempts do
+        assert_same_content Devise::Models::Lockable.required_fields(User), [
+         :failed_attempts,
+         :locked_at,
+         :unlock_token
+        ]
+      end
+    end
+  end
+
+  test 'required_fields should contain only failed_attempts and locked_at when the strategies are time and failed_attempts are enabled' do
+    swap Devise, :unlock_strategy => :time do
+      swap Devise, :lock_strategy => :failed_attempts do
+        assert_same_content Devise::Models::Lockable.required_fields(User), [
+         :failed_attempts,
+         :locked_at
+        ]
+      end
+    end
+  end
+
+  test 'required_fields should contain only failed_attempts and unlock_token when the strategies are token and failed_attempts are enabled' do
+    swap Devise, :unlock_strategy => :email do
+      swap Devise, :lock_strategy => :failed_attempts do
+        assert_same_content Devise::Models::Lockable.required_fields(User), [
+         :failed_attempts,
+         :unlock_token
+        ]
+      end
+    end
+  end
+
+  test 'should not return a locked unauthenticated message if in paranoid mode' do
+    swap Devise, :paranoid => :true do
+      user = create_user
+      user.failed_attempts = Devise.maximum_attempts + 1
+      user.lock_access!
+
+      assert_equal :invalid, user.unauthenticated_message
+    end
+  end
+end

data/test/models/omniauthable_test.rb

@@ -0,0 +1,8 @@
+# -*- encoding : utf-8 -*-
+require 'test_helper'
+
+class OmniauthableTest < ActiveSupport::TestCase
+  test 'required_fields should contain the fields that Devise uses' do
+    assert_same_content Devise::Models::Omniauthable.required_fields(User), []
+  end
+end

data/test/models/recoverable_test.rb

@@ -0,0 +1,206 @@
+# -*- encoding : utf-8 -*-
+require 'test_helper'
+
+class RecoverableTest < ActiveSupport::TestCase
+
+  def setup
+    setup_mailer
+  end
+
+  test 'should not generate reset password token after creating a record' do
+    assert_nil new_user.reset_password_token
+  end
+
+  test 'should never generate the same reset password token for different users' do
+    reset_password_tokens = []
+    3.times do
+      user = create_user
+      user.send_reset_password_instructions
+      token = user.reset_password_token
+      assert !reset_password_tokens.include?(token)
+      reset_password_tokens << token
+    end
+  end
+
+  test 'should reset password and password confirmation from params' do
+    user = create_user
+    user.reset_password!('123456789', '987654321')
+    assert_equal '123456789', user.password
+    assert_equal '987654321', user.password_confirmation
+  end
+
+  test 'should reset password and save the record' do
+    assert create_user.reset_password!('123456789', '123456789')
+  end
+
+  test 'should clear reset password token while reseting the password' do
+    user = create_user
+    assert_nil user.reset_password_token
+
+    user.send_reset_password_instructions
+    assert_present user.reset_password_token
+    assert user.reset_password!('123456789', '123456789')
+    assert_nil user.reset_password_token
+  end
+
+  test 'should not clear reset password token if record is invalid' do
+    user = create_user
+    user.send_reset_password_instructions
+    assert_present user.reset_password_token
+    assert_not user.reset_password!('123456789', '987654321')
+    assert_present user.reset_password_token
+  end
+
+  test 'should not reset password with invalid data' do
+    user = create_user
+    user.stubs(:valid?).returns(false)
+    assert_not user.reset_password!('123456789', '987654321')
+  end
+
+  test 'should reset reset password token and send instructions by email' do
+    user = create_user
+    assert_email_sent do
+      token = user.reset_password_token
+      user.send_reset_password_instructions
+      assert_not_equal token, user.reset_password_token
+    end
+  end
+
+  test 'should find a user to send instructions by email' do
+    user = create_user
+    reset_password_user = User.send_reset_password_instructions(:email => user.email)
+    assert_equal reset_password_user, user
+  end
+
+  test 'should return a new record with errors if user was not found by e-mail' do
+    reset_password_user = User.send_reset_password_instructions(:email => "invalid@example.com")
+    assert_not reset_password_user.persisted?
+    assert_equal "not found", reset_password_user.errors[:email].join
+  end
+
+  test 'should find a user to send instructions by authentication_keys' do
+    swap Devise, :authentication_keys => [:username, :email] do
+      user = create_user
+      reset_password_user = User.send_reset_password_instructions(:email => user.email, :username => user.username)
+      assert_equal reset_password_user, user
+    end
+  end
+
+  test 'should require all reset_password_keys' do
+      swap Devise, :reset_password_keys => [:username, :email] do
+          user = create_user
+          reset_password_user = User.send_reset_password_instructions(:email => user.email)
+          assert_not reset_password_user.persisted?
+          assert_equal "can't be blank", reset_password_user.errors[:username].join
+      end
+  end
+
+  test 'should reset reset_password_token before send the reset instructions email' do
+    user = create_user
+    token = user.reset_password_token
+    User.send_reset_password_instructions(:email => user.email)
+    assert_not_equal token, user.reload.reset_password_token
+  end
+
+  test 'should send email instructions to the user reset his password' do
+    user = create_user
+    assert_email_sent do
+      User.send_reset_password_instructions(:email => user.email)
+    end
+  end
+
+  test 'should find a user to reset his password based on reset_password_token' do
+    user = create_user
+    user.send :generate_reset_password_token!
+
+    reset_password_user = User.reset_password_by_token(:reset_password_token => user.reset_password_token)
+    assert_equal reset_password_user, user
+  end
+
+  test 'should return a new record with errors if no reset_password_token is found' do
+    reset_password_user = User.reset_password_by_token(:reset_password_token => 'invalid_token')
+    assert_not reset_password_user.persisted?
+    assert_equal "is invalid", reset_password_user.errors[:reset_password_token].join
+  end
+
+  test 'should return a new record with errors if reset_password_token is blank' do
+    reset_password_user = User.reset_password_by_token(:reset_password_token => '')
+    assert_not reset_password_user.persisted?
+    assert_match "can't be blank", reset_password_user.errors[:reset_password_token].join
+  end
+
+  test 'should return a new record with errors if password is blank' do
+    user = create_user
+    user.send :generate_reset_password_token!
+
+    reset_password_user = User.reset_password_by_token(:reset_password_token => user.reset_password_token, :password => '')
+    assert_not reset_password_user.errors.empty?
+    assert_match "can't be blank", reset_password_user.errors[:password].join
+  end
+
+  test 'should reset successfully user password given the new password and confirmation' do
+    user = create_user
+    old_password = user.password
+    user.send :generate_reset_password_token!
+
+    User.reset_password_by_token(
+      :reset_password_token => user.reset_password_token,
+      :password => 'new_password',
+      :password_confirmation => 'new_password'
+    )
+    user.reload
+
+    assert_not user.valid_password?(old_password)
+    assert user.valid_password?('new_password')
+  end
+
+  test 'should not reset reset password token during reset_password_within time' do
+    swap Devise, :reset_password_within => 1.hour do
+      user = create_user
+      user.send_reset_password_instructions
+      3.times do
+        token = user.reset_password_token
+        user.send_reset_password_instructions
+        assert_equal token, user.reset_password_token
+      end
+    end
+  end
+
+  test 'should reset reset password token after reset_password_within time' do
+    swap Devise, :reset_password_within => 1.hour do
+      user = create_user
+      user.reset_password_sent_at = 2.days.ago
+      token = user.reset_password_token
+      user.send_reset_password_instructions
+      assert_not_equal token, user.reset_password_token
+    end
+  end
+
+  test 'should not reset password after reset_password_within time' do
+    swap Devise, :reset_password_within => 1.hour do
+      user = create_user
+      old_password = user.password
+      user.send :generate_reset_password_token!
+      user.reset_password_sent_at = 2.days.ago
+      user.save!
+
+      reset_password_user = User.reset_password_by_token(
+        :reset_password_token => user.reset_password_token,
+        :password => 'new_password',
+        :password_confirmation => 'new_password'
+      )
+      user.reload
+
+      assert user.valid_password?(old_password)
+      assert_not user.valid_password?('new_password')
+      assert_equal "has expired, please request a new one", reset_password_user.errors[:reset_password_token].join
+    end
+  end
+
+  test 'required_fields should contain the fields that Devise uses' do
+    assert_same_content Devise::Models::Recoverable.required_fields(User), [
+      :reset_password_sent_at,
+      :reset_password_token
+    ]
+  end
+end

data/test/models/registerable_test.rb

@@ -0,0 +1,8 @@
+# -*- encoding : utf-8 -*-
+require 'test_helper'
+
+class RegisterableTest < ActiveSupport::TestCase
+  test 'required_fields should contain the fields that Devise uses' do
+    assert_same_content Devise::Models::Registerable.required_fields(User), []
+  end
+end

data/test/models/rememberable_test.rb

@@ -0,0 +1,175 @@
+# -*- encoding : utf-8 -*-
+require 'test_helper'
+
+class RememberableTest < ActiveSupport::TestCase
+  def resource_class
+    User
+  end
+
+  def create_resource
+    create_user
+  end
+
+  test 'remember_me should not generate a new token if using salt' do
+    user = create_user
+    user.expects(:valid?).never
+    user.remember_me!
+  end
+
+  test 'forget_me should not clear remember token if using salt' do
+    user = create_user
+    user.remember_me!
+    user.expects(:valid?).never
+    user.forget_me!
+  end
+
+  test 'serialize into cookie' do
+    user = create_user
+    user.remember_me!
+    assert_equal [user.to_key, user.authenticatable_salt], User.serialize_into_cookie(user)
+  end
+
+  test 'serialize from cookie' do
+    user = create_user
+    user.remember_me!
+    assert_equal user, User.serialize_from_cookie(user.to_key, user.authenticatable_salt)
+  end
+
+  test 'raises a RuntimeError if authenticatable_salt is nil' do
+    user = User.new
+    user.encrypted_password = nil
+    assert_raise RuntimeError do
+      user.rememberable_value
+    end
+  end
+
+  test 'should respond to remember_me attribute' do
+    assert resource_class.new.respond_to?(:remember_me)
+    assert resource_class.new.respond_to?(:remember_me=)
+  end
+
+  test 'forget_me should clear remember_created_at' do
+    resource = create_resource
+    resource.remember_me!
+    assert_not resource.remember_created_at.nil?
+    resource.forget_me!
+    assert resource.remember_created_at.nil?
+  end
+
+  test 'forget_me should not try to update resource if it has been destroyed' do
+    resource = create_resource
+    resource.destroy
+    resource.expects(:remember_created_at).never
+    resource.expects(:save).never
+    resource.forget_me!
+  end
+
+  test 'remember is expired if not created at timestamp is set' do
+    assert create_resource.remember_expired?
+  end
+
+  test 'serialize should return nil if no resource is found' do
+    assert_nil resource_class.serialize_from_cookie([0], "123")
+  end
+
+  test 'remember me return nil if is a valid resource with invalid token' do
+    resource = create_resource
+    assert_nil resource_class.serialize_from_cookie([resource.id], "123")
+  end
+
+  test 'remember for should fallback to devise remember for default configuration' do
+    swap Devise, :remember_for => 1.day do
+      resource = create_resource
+      resource.remember_me!
+      assert_not resource.remember_expired?
+    end
+  end
+
+  test 'remember expires at should sum date of creation with remember for configuration' do
+    swap Devise, :remember_for => 3.days do
+      resource = create_resource
+      resource.remember_me!
+      assert_equal 3.days.from_now.to_date, resource.remember_expires_at.to_date
+
+      Devise.remember_for = 5.days
+      assert_equal 5.days.from_now.to_date, resource.remember_expires_at.to_date
+    end
+  end
+
+  test 'remember should be expired if remember_for is zero' do
+    swap Devise, :remember_for => 0.days do
+      Devise.remember_for = 0.days
+      resource = create_resource
+      resource.remember_me!
+      assert resource.remember_expired?
+    end
+  end
+
+  test 'remember should be expired if it was created before limit time' do
+    swap Devise, :remember_for => 1.day do
+      resource = create_resource
+      resource.remember_me!
+      resource.remember_created_at = 2.days.ago
+      resource.save
+      assert resource.remember_expired?
+    end
+  end
+
+  test 'remember should not be expired if it was created whitin the limit time' do
+    swap Devise, :remember_for => 30.days do
+      resource = create_resource
+      resource.remember_me!
+      resource.remember_created_at = (30.days.ago + 2.minutes)
+      resource.save
+      assert_not resource.remember_expired?
+    end
+  end
+
+  test 'if extend_remember_period is false, remember_me! should generate a new timestamp if expired' do
+    swap Devise, :remember_for => 5.minutes do
+      resource = create_resource
+      resource.remember_me!(false)
+      assert resource.remember_created_at
+
+      resource.remember_created_at = old = 10.minutes.ago
+      resource.save
+
+      resource.remember_me!(false)
+      assert_not_equal old.to_i, resource.remember_created_at.to_i
+    end
+  end
+
+  test 'if extend_remember_period is false, remember_me! should not generate a new timestamp' do
+    swap Devise, :remember_for => 1.year do
+      resource = create_resource
+      resource.remember_me!(false)
+      assert resource.remember_created_at
+
+      resource.remember_created_at = old = 10.minutes.ago.utc
+      resource.save
+
+      resource.remember_me!(false)
+      assert_equal old.to_i, resource.remember_created_at.to_i
+    end
+  end
+
+  test 'if extend_remember_period is true, remember_me! should always generate a new timestamp' do
+    swap Devise, :remember_for => 1.year do
+      resource = create_resource
+      resource.remember_me!(true)
+      assert resource.remember_created_at
+
+      resource.remember_created_at = old = 10.minutes.ago
+      resource.save
+
+      resource.remember_me!(true)
+      assert_not_equal old, resource.remember_created_at
+    end
+  end
+
+  test 'should have the required_fiels array' do
+    assert_same_content Devise::Models::Rememberable.required_fields(User), [
+      :remember_created_at
+    ]
+  end
+end