lou 0.2.1 → 0.2.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 6c875d55f836118c55dd4e3bedc345fb9839dbb6
-  data.tar.gz: 12c8985d3aaf1bf744a980f0135e456e8a04b860
+  metadata.gz: 4dea25041b0ad0a9ec2e1bf43bcceff1c300d9b6
+  data.tar.gz: 92d368f757c66030610c3b6492d3773456dc384f
 SHA512:
-  metadata.gz: 7eb8dedecc8d4589abcb8f83d7e37c00d32689e2710f1f58a6bbea709f198276d2e30c5ab889c3237a39f88e0e9b5691a640c4d3f859542748bfe618b5f9075d
-  data.tar.gz: 38e5554d87650c7df1f439d387091a6b749265b1941fe71edbaa74987ea74efcd4a593dc7521f37a1af0e76bf381325291b5722dbe8a48759d3a011c412e411a
+  metadata.gz: 3456df775aada99d3f62fe854e65f92a230c67a6ca0d3af2c526da35244b7892722018118f51ac0319505a5db4fa802e6cdcad0d2fa701af6ce4881d41bd80c4
+  data.tar.gz: 53cfccb9aa2ef91cd5b1f64a56ad7cb5cd19888d40d0190d61418db1207dd993e28e17250cea5fb9625b67d00fbb0f3490b871affa89eaccfa62b03d46230f73

data/README.md

@@ -44,13 +44,13 @@ original = HashTransformer.reverse(result)
 # {:an_old_key=>"this is old"}
 ~~~
 
-The steps are applied in the order that they're defined, when the ~apply~ method is called, with each step receiving the result of the previous one. The process can be reversed using the ~reverse~ method. Note that for each step, the input is the result of the previous step.
+The steps are applied in the order that they're defined, when the `apply` method is called, with each step receiving the result of the previous one. The process can be reversed using the `reverse` method. Note that for each step, the input is the result of the previous step.
 
-If ~reverse_on~ is defined, then any completed steps will be reversed if the exception specified is raised.
+If `reverse_on` is defined, then any completed steps will be reversed if the exception specified is raised.
 
 Transformers inherit the steps of their parent class, so it's possible to reuse steps by using inheritance.
 
 Credits
 -------
 
-Lou is heavily inspired by [Hash Mapper](http://github.com/ismasan) by [Ismael Celis](http://github.com/ismasan).
+Lou was originally inspired by [Hash Mapper](http://github.com/ismasan) by [Ismael Celis](http://github.com/ismasan) to be a way of transforming hashes, however, it evolved into a general purpose pipeline for arbitrary blocks of code.

data/lib/lou/transformer.rb

@@ -33,7 +33,8 @@ module Lou
           applied_steps += 1
         end
       rescue error_class => e
-        total_steps == steps.count ? reverse(input, applied_steps) : raise(e)
+        reverse(input, applied_steps) if total_steps == steps.count
+        raise e
       end
       input
     end
@@ -46,7 +47,8 @@ module Lou
           reversed_steps += 1
         end
       rescue error_class => e
-        total_steps == steps.count ? apply(output, reversed_steps) : raise(e)
+        apply(output, reversed_steps) if total_steps == steps.count
+        raise e
       end
       output
     end

data/lib/lou/version.rb

@@ -1,3 +1,3 @@
 module Lou
-  VERSION = '0.2.1'
+  VERSION = '0.2.2'
 end

data/spec/lou/transformer_spec.rb

@@ -133,12 +133,14 @@ module Lou
     end
 
     context 'when #reverse_on has been set' do
+      let!(:error_class) do
+        class SpecialError < StandardError; end
+      end
+
       let(:parent) do
         Class.new do
           extend Lou::Transformer
 
-          class SpecialError < StandardError; end
-
           reverse_on SpecialError
         end
       end
@@ -157,7 +159,7 @@ module Lou
           it 'reverses no steps when the specified error is raised' do
             expect(target).to_not receive(:create)
             expect(target).to_not receive(:destroy)
-            klass.apply(target)
+            expect { klass.apply(target) }.to raise_error(SpecialError)
           end
         end
 
@@ -165,7 +167,7 @@ module Lou
           it 'applies no steps when the specified error is raised' do
             expect(target).to_not receive(:destroy)
             expect(target).to_not receive(:create)
-            klass.reverse(target)
+            expect { klass.reverse(target) }.to raise_error(SpecialError)
           end
         end
       end
@@ -182,18 +184,41 @@ module Lou
         let(:target) { instance_double('Target') }
 
         describe '#apply' do
-          it 'reverses all successfully applied steps when the specified error is raised' do
+          it 'reverses all successfully applied steps before raising the error when the specified error is raised' do
             expect(target).to receive(:create).once.with(1).ordered
             expect(target).to receive(:destroy).once.with(1).ordered
-            klass.apply(target)
+            expect { klass.apply(target) }.to raise_error(SpecialError)
           end
         end
 
         describe '#reverse' do
-          it 'reapplies all successfully reversed steps when the specified error is raised' do
+          it 'reapplies all successfully reversed steps before raising the error when the specified error is raised' do
             expect(target).to receive(:destroy).once.with(3).ordered
             expect(target).to receive(:create).once.with(3).ordered
-            klass.reverse(target)
+            expect { klass.reverse(target) }.to raise_error(SpecialError)
+          end
+        end
+      end
+
+      context 'and the up and down steps should lead to an infinite loop' do
+        let(:klass) do
+          Class.new(parent) do
+            step.up { |x| x.create(1); x }.down { |_| fail SpecialError, 'fail on down' }
+            step.up { |_| fail SpecialError, 'fail on up' }.down { |x| x.destroy(2); x }
+          end
+        end
+
+        describe '#apply' do
+          it 'raises the error from the down step' do
+            expect(target).to receive(:create).once.with(1)
+            expect { klass.apply(target) }.to raise_error(SpecialError, 'fail on down')
+          end
+        end
+
+        describe '#reverse' do
+          it 'raises the error from the up step' do
+            expect(target).to receive(:destroy).once.with(2)
+            expect { klass.reverse(target) }.to raise_error(SpecialError, 'fail on up')
           end
         end
       end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: lou
 version: !ruby/object:Gem::Version
-  version: 0.2.1
+  version: 0.2.2
 platform: ruby
 authors:
 - Iain Beeston
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-08-08 00:00:00.000000000 Z
+date: 2014-08-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler