lost_in_translations 1.3.1 → 1.3.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 0704c23c3e9281b106f8ab586fbebbf0e26ece04
-  data.tar.gz: 0be875ce8e5f47fb0de2cf1535584d5ec9a14db3
+  metadata.gz: 4d1a0959d1fda7cbd026bfb47d428d44072c4faf
+  data.tar.gz: d37b0255c177943d54b9dd3857f148a8425559e1
 SHA512:
-  metadata.gz: a61787435c7aba311e09dc7c0a9907345893089a1daef8a01619ca1071ddf5e385b217909e197f0c9182166939737739541162bce8935726a72c2d1db8ca1227
-  data.tar.gz: 2adae0cfdd8bf0dcce6e5678e24d3bffcae663cd67eb418d0287a25565f0df61989cda94ac58f9fc41c309eb34e23d669665e1777dd9b4d900e987a125385e2d
+  metadata.gz: 8b4b4e39527f47afc0035ea6a56ef8ce0a2c2ef455ce2f0c1c7ad773f2d62f0946ad0b20d997798f7afe679b976a94b8e9913507ae532ebee74d5815c862efe1
+  data.tar.gz: a4b34612c1a1dacf97943c5f1d2f4dee79e220cb706b3f934875cc8aa21989d61ba045a3274f0cda56e207cb4562796246fe05d52d12fd958f65e05a68bd17ce

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    lost_in_translations (1.3.1)
+    lost_in_translations (1.3.2)
       i18n (~> 0.7)
 
 GEM

data/README.md

@@ -124,7 +124,7 @@ I18n.locale = :fr
 
 @user.first_name # returns 'Jean'
 @user.last_name # returns 'Neve'
-@user.title # returns 'Cavaleiro'
+@user.title # returns nil
 ```
 
 ## 3) Configuration
@@ -180,10 +180,8 @@ User.find(1).first_name # returns 'Jean'
 ### 3.3) Custom translation mechanism
 ```ruby
 class MyTranslator < Translator::Base
-  def self.translate(object, field, locale)
-    translations = #get_data_from_redis_or_yaml_file(object)
-
-    (translations[locale] || {})[field]
+  def self.translation_data(object)
+    # get_data_from_redis_or_yaml_file(object)
   end
 end
 ```

data/lib/lost_in_translations.rb

@@ -28,6 +28,10 @@ module LostInTranslations
     config.translator.assign_translation(*args)
   end
 
+  def self.translation_data(object)
+    config.translator.translation_data(object)
+  end
+
   def self.define_translation_methods(object, *fields)
     fields.each do |field|
       define_dynamic_translation_method(object, field)

data/lib/lost_in_translations/version.rb

@@ -1,5 +1,5 @@
 module LostInTranslations
 
-  VERSION = '1.3.1'.freeze
+  VERSION = '1.3.2'.freeze
 
 end

data/spec/lost_in_translations/lost_in_translations_spec.rb

@@ -74,9 +74,28 @@ describe LostInTranslations do
     end
   end
 
-  describe "#config.translation_data_field" do
+  describe "#translation_data" do
 
-    context "when setting the 'translation_data_field' to a known method" do
+    context "when the object.translation_data is nil" do
+      before do
+        @user_class = Struct.new(:first_name, :last_name) do
+          include LostInTranslations
+
+          translate :first_name
+
+          attr_accessor :translation_data
+        end
+
+        @user = @user_class.new('joao', 'neve')
+      end
+
+      it "should return an empty Hash" do
+        expect(LostInTranslations.translation_data(@user)).to eq({})
+        expect(@user.translation_data).to eq({})
+      end
+    end
+
+    context "when setting the #config.translation_data_field to a known method" do
       before do
         LostInTranslations.configure do |config|
           config.translation_data_field = 'translation_json'
@@ -96,14 +115,12 @@ describe LostInTranslations do
       end
       after { LostInTranslations.config.translation_data_field = 'translation_data' }
 
-      it "calling a translated field must return a translation" do
-        I18n.with_locale(:en) do
-          expect(@user.first_name).to eq 'Jon'
-        end
+      it "should return the known method results" do
+        expect(LostInTranslations.translation_data(@user)).to eq({ en: { first_name: 'Jon', last_name: 'Snow' } })
       end
     end
 
-    context "when setting the 'translation_data_field' to an unknown method" do
+    context "when setting the #config.translation_data_field to an unknown method" do
       before do
         LostInTranslations.configure do |config|
           config.translation_data_field = 'translation_json'
@@ -119,18 +136,12 @@ describe LostInTranslations do
       end
       after { LostInTranslations.config.translation_data_field = 'translation_data' }
 
-      it "calling a translated field, must raise an error" do
-        I18n.with_locale(:en) do
-          expect { @user.first_name }.to raise_error(NotImplementedError)
-        end
+      it "should raise an error" do
+        expect { LostInTranslations.translation_data(@user) }.to raise_error(NotImplementedError)
       end
     end
 
-  end
-
-  describe "#config.translator" do
-
-    context "changing the source of the translation_data" do
+    context "when changing the #config.translator" do
       before do
         LostInTranslations.configure do |config|
           config.translator = Class.new(LostInTranslations::Translator::Base) do
@@ -150,10 +161,8 @@ describe LostInTranslations do
       end
       after { LostInTranslations.config.translator = LostInTranslations::Translator::Base }
 
-      it "calling a translated field must return a translation" do
-        I18n.with_locale(:en) do
-          expect(@user.first_name).to eq 'Jon'
-        end
+      it "should return the known method results" do
+        expect(LostInTranslations.translation_data(@user)).to eq({ en: { first_name: 'Jon', last_name: 'Snow' } })
       end
     end
 

data/spec/support/shared_examples/basic_usage.rb

@@ -1,7 +1,7 @@
 # encoding: UTF-8
 
 shared_examples_for "a basic usage" do
-  it "should behave like the readme says" do
+  it "should behave like the readme says it does" do
     I18n.default_locale = :pt
     I18n.locale = :fr
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: lost_in_translations
 version: !ruby/object:Gem::Version
-  version: 1.3.1
+  version: 1.3.2
 platform: ruby
 authors:
 - StreetBees Dev Team