lookup_by 0.6.0 → 0.7.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 741a85349dfd3272380b485113086dffec0339da
-  data.tar.gz: 4468ad178cf1b092dfe06d5d2812ab068d87edf6
+  metadata.gz: 03729b904ce688e312634ce27fc0378510189a06
+  data.tar.gz: 1da87c9243ce001671e57a92084f82a01c0ccba7
 SHA512:
-  metadata.gz: 457ebe5fbc8ac341869c91d4fe7cf5faa03e69ffed4c98ad0a3b229c1c71b8a6f127f8ebc712618662a199a101fd96db02a389aa90e21ba8c83e3df6d99eeadf
-  data.tar.gz: c3df0d6bf016ca2dd5ff05b5a7e67e4c478dd222ec62f3c9ffad75a94f21c4aaf0375c2bdf32d84a11a9b7eca70f73f235508b034984d68d32d32bbf63395a5f
+  metadata.gz: 940795913611bb0a21b97c15a79b847fbb1bf62c79447765991aa8d5d389bc763f242510c03a3cb9548b8db3fec36d877df60b71c6b3901a03d2323800da0939
+  data.tar.gz: e00e0708e39fe04352ea4e1f19799643e1efc9946467d3d63e86fde83225f8cff5e7ed2cef980da84b8db3450ae49a7596f28a9a7e63923be771b14c408bcd24

data/Gemfile

@@ -7,6 +7,7 @@ gemspec
 
 group :development, :test do
   gem 'rspec'
+  gem 'rspec-its'
   gem 'database_cleaner'
 
   gem "pg", platform: :ruby

data/lib/lookup_by/cache.rb

@@ -25,6 +25,8 @@ module LookupBy
       when true
         @type    = :all
         @read  ||= false
+
+        raise ArgumentError, "`#{@klass}.lookup_by :#{@field}` Should be `cache: true` or `cache: N, find_or_create: true`" if @write
       when ::Integer
         raise ArgumentError, "`#{@klass}.lookup_by :#{@field}` options[:find] must be true when caching N" if @read == false
 

data/lib/lookup_by/version.rb

@@ -1,3 +1,3 @@
 module LookupBy
-  VERSION = "0.6.0"
+  VERSION = "0.7.0"
 end

data/spec/association_spec.rb

@@ -59,7 +59,9 @@ describe ::ActiveRecord::Base do
       it { should_not respond_to(:with_postal_codes) }
     end
 
-    its(:lookups) { should include(:city) }
+    it "better include the association under test in lookups" do
+      expect(subject.lookups).to include(:city)
+    end
   end
 end
 

data/spec/caching/lru_spec.rb

@@ -67,6 +67,8 @@ module LookupBy::Caching
       cache.should eq(1 => "change", 2 => "two", 3 => "three")
     end
 
-    its(:to_h) { should eq(1 => "one", 2 => "two") }
+    it "better include the values under test" do
+      expect(subject.to_h).to eq(1 => "one", 2 => "two")
+    end
   end
 end

data/spec/dummy/app/models/uncacheable.rb

@@ -0,0 +1,3 @@
+class Uncacheable < ActiveRecord::Base
+  lookup_by :uncacheable, cache: true, find_or_create: true
+end

data/spec/dummy/app/models/unfindable.rb

@@ -0,0 +1,3 @@
+class Unfindable < ActiveRecord::Base
+  lookup_by :unfindable, cache: 10, find: false
+end

data/spec/dummy/db/migrate/20121019040009_create_tables.rb

@@ -10,6 +10,9 @@ class CreateTables < ActiveRecord::Migration
 
     create_lookup_table :ip_addresses, lookup_type: :inet
 
+    create_lookup_table :uncacheables
+    create_lookup_table :unfindables
+
     enable_extension 'uuid-ossp'
 
     execute 'CREATE SCHEMA traffic;'

data/spec/dummy/db/structure.sql

@@ -353,6 +353,64 @@ CREATE SEQUENCE streets_street_id_seq
 ALTER SEQUENCE streets_street_id_seq OWNED BY streets.street_id;
 
 
+--
+-- Name: uncacheables; Type: TABLE; Schema: public; Owner: -; Tablespace: 
+--
+
+CREATE TABLE uncacheables (
+    uncacheable_id integer NOT NULL,
+    uncacheable text NOT NULL
+);
+
+
+--
+-- Name: uncacheables_uncacheable_id_seq; Type: SEQUENCE; Schema: public; Owner: -
+--
+
+CREATE SEQUENCE uncacheables_uncacheable_id_seq
+    START WITH 1
+    INCREMENT BY 1
+    NO MINVALUE
+    NO MAXVALUE
+    CACHE 1;
+
+
+--
+-- Name: uncacheables_uncacheable_id_seq; Type: SEQUENCE OWNED BY; Schema: public; Owner: -
+--
+
+ALTER SEQUENCE uncacheables_uncacheable_id_seq OWNED BY uncacheables.uncacheable_id;
+
+
+--
+-- Name: unfindables; Type: TABLE; Schema: public; Owner: -; Tablespace: 
+--
+
+CREATE TABLE unfindables (
+    unfindable_id integer NOT NULL,
+    unfindable text NOT NULL
+);
+
+
+--
+-- Name: unfindables_unfindable_id_seq; Type: SEQUENCE; Schema: public; Owner: -
+--
+
+CREATE SEQUENCE unfindables_unfindable_id_seq
+    START WITH 1
+    INCREMENT BY 1
+    NO MINVALUE
+    NO MAXVALUE
+    CACHE 1;
+
+
+--
+-- Name: unfindables_unfindable_id_seq; Type: SEQUENCE OWNED BY; Schema: public; Owner: -
+--
+
+ALTER SEQUENCE unfindables_unfindable_id_seq OWNED BY unfindables.unfindable_id;
+
+
 --
 -- Name: user_agents; Type: TABLE; Schema: public; Owner: -; Tablespace: 
 --
@@ -466,6 +524,20 @@ ALTER TABLE ONLY statuses ALTER COLUMN status_id SET DEFAULT nextval('statuses_s
 ALTER TABLE ONLY streets ALTER COLUMN street_id SET DEFAULT nextval('streets_street_id_seq'::regclass);
 
 
+--
+-- Name: uncacheable_id; Type: DEFAULT; Schema: public; Owner: -
+--
+
+ALTER TABLE ONLY uncacheables ALTER COLUMN uncacheable_id SET DEFAULT nextval('uncacheables_uncacheable_id_seq'::regclass);
+
+
+--
+-- Name: unfindable_id; Type: DEFAULT; Schema: public; Owner: -
+--
+
+ALTER TABLE ONLY unfindables ALTER COLUMN unfindable_id SET DEFAULT nextval('unfindables_unfindable_id_seq'::regclass);
+
+
 --
 -- Name: user_agent_id; Type: DEFAULT; Schema: public; Owner: -
 --
@@ -553,6 +625,22 @@ ALTER TABLE ONLY streets
     ADD CONSTRAINT streets_pkey PRIMARY KEY (street_id);
 
 
+--
+-- Name: uncacheables_pkey; Type: CONSTRAINT; Schema: public; Owner: -; Tablespace: 
+--
+
+ALTER TABLE ONLY uncacheables
+    ADD CONSTRAINT uncacheables_pkey PRIMARY KEY (uncacheable_id);
+
+
+--
+-- Name: unfindables_pkey; Type: CONSTRAINT; Schema: public; Owner: -; Tablespace: 
+--
+
+ALTER TABLE ONLY unfindables
+    ADD CONSTRAINT unfindables_pkey PRIMARY KEY (unfindable_id);
+
+
 --
 -- Name: user_agents_pkey; Type: CONSTRAINT; Schema: public; Owner: -; Tablespace: 
 --
@@ -636,6 +724,20 @@ CREATE UNIQUE INDEX statuses__u_status ON statuses USING btree (status);
 CREATE UNIQUE INDEX streets__u_street ON streets USING btree (street);
 
 
+--
+-- Name: uncacheables__u_uncacheable; Type: INDEX; Schema: public; Owner: -; Tablespace: 
+--
+
+CREATE UNIQUE INDEX uncacheables__u_uncacheable ON uncacheables USING btree (uncacheable);
+
+
+--
+-- Name: unfindables__u_unfindable; Type: INDEX; Schema: public; Owner: -; Tablespace: 
+--
+
+CREATE UNIQUE INDEX unfindables__u_unfindable ON unfindables USING btree (unfindable);
+
+
 --
 -- Name: unique_schema_migrations; Type: INDEX; Schema: public; Owner: -; Tablespace: 
 --

data/spec/lookup_by_spec.rb

@@ -29,6 +29,12 @@ describe LookupBy::Lookup do
     end
   end
 
+  context "Uncacheable.lookup_by :column, cache: true, find_or_create: true" do
+    it "fails when trying to cache and write-through" do
+      expect { Uncacheable }.to raise_error
+    end
+  end
+
   context "City.lookup_by :column" do
     subject { City }
 
@@ -96,7 +102,7 @@ describe LookupBy::Lookup do
     it_behaves_like "a read-through cache"
 
     it "is not testing when not writing through the LRU" do
-      subject.lookup.testing.should be_false
+      subject.lookup.testing.should be false
     end
   end
 
@@ -109,7 +115,7 @@ describe LookupBy::Lookup do
     it_behaves_like "a write-through cache"
 
     it "sets testing when RAILS_ENV=test" do
-      subject.lookup.testing.should be_true
+      subject.lookup.testing.should be true
     end
 
     it "does not write primary keys" do

data/spec/spec_helper.rb

@@ -20,7 +20,11 @@ rescue LoadError
 end
 
 require 'rspec'
+require 'rspec/its'
 require 'database_cleaner'
+require 'pry'
+
+ActiveRecord::Migration.maintain_test_schema! if defined?(ActiveRecord::Migration)
 
 # Requires supporting ruby files with custom matchers and macros, etc,
 # in spec/support/ and its subdirectories.

data/spec/support/shared_examples_for_a_lookup.rb

@@ -4,7 +4,9 @@ shared_examples "a lookup" do
   it { should respond_to :lookup_by  }
   it { should respond_to :lookup_for }
 
-  its(:is_a_lookup?) { should be_true }
+  it "better be a lookup" do
+    expect(subject.is_a_lookup?).to be true
+  end
 
   it "raises with no args" do
     expect { subject[] }.to raise_error ArgumentError

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: lookup_by
 version: !ruby/object:Gem::Version
-  version: 0.6.0
+  version: 0.7.0
 platform: ruby
 authors:
 - Erik Peterson
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-05-08 00:00:00.000000000 Z
+date: 2014-06-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -95,6 +95,8 @@ files:
 - spec/dummy/app/models/state.rb
 - spec/dummy/app/models/status.rb
 - spec/dummy/app/models/street.rb
+- spec/dummy/app/models/uncacheable.rb
+- spec/dummy/app/models/unfindable.rb
 - spec/dummy/app/models/user_agent.rb
 - spec/dummy/bin/bundle
 - spec/dummy/bin/rails
@@ -160,6 +162,8 @@ test_files:
 - spec/dummy/app/models/state.rb
 - spec/dummy/app/models/status.rb
 - spec/dummy/app/models/street.rb
+- spec/dummy/app/models/uncacheable.rb
+- spec/dummy/app/models/unfindable.rb
 - spec/dummy/app/models/user_agent.rb
 - spec/dummy/bin/bundle
 - spec/dummy/bin/rails