lookup_by 0.2.0 → 0.3.1

data/spec/lookup_by_spec.rb

@@ -85,8 +85,8 @@ describe LookupBy::Lookup do
     end
   end
 
-  context "IpAddress.lookup_by :column, cache: N, find_or_create: true" do
-    subject { IpAddress }
+  context "UserAgent.lookup_by :column, cache: N, find_or_create: true" do
+    subject { UserAgent }
 
     it_behaves_like "a lookup"
     it_behaves_like "a cache"
@@ -97,4 +97,31 @@ describe LookupBy::Lookup do
       subject.lookup.testing.should be_true
     end
   end
+
+  context "IpAddress.lookup_by :column, cache: N, find_or_create: true" do
+    subject { IpAddress }
+
+    it "allows lookup by IPAddr" do
+      ip = subject['127.0.0.1']
+
+      subject[IPAddr.new('127.0.0.1')].should == ip
+      subject[ip.id].should == ip
+      subject['127.0.0.1'].should == ip
+    end
+  end
+
+  context "Path.lookup_by :column, cache: true, find_or_create: true (UUID primary key)" do
+    subject { Path }
+
+    it_behaves_like "a lookup"
+    it_behaves_like "a cache"
+    it_behaves_like "a read-through cache"
+    it_behaves_like "a write-through cache"
+
+    it 'treats UUIDs as the primary key' do
+      path = subject['/']
+      path.id.should match(LookupBy::UUID_REGEX)
+      subject[path.id].should == path
+    end
+  end
 end

data/spec/spec_helper.rb

@@ -14,6 +14,7 @@ rescue LoadError
   require File.expand_path("../dummy/config/environment", __FILE__)
 end
 
+require 'database_cleaner'
 require 'rspec/rails'
 require 'rspec/autorun'
 
@@ -33,11 +34,23 @@ RSpec.configure do |config|
   # If you're not using ActiveRecord, or you'd prefer not to run each of your
   # examples within a transaction, remove the following line or assign false
   # instead of true.
-  config.use_transactional_fixtures = true
+  config.use_transactional_fixtures = false
 
   # Run specs in random order to surface order dependencies. If you find an
   # order dependency and want to debug it, you can fix the order by providing
   # the seed, which is printed after each run.
   #     --seed 1234
   config.order = "random"
+
+  config.before(:suite) do
+    DatabaseCleaner.strategy = :transaction
+  end
+
+  config.before(:each) do
+    DatabaseCleaner.start
+  end
+
+  config.after(:each) do
+    DatabaseCleaner.clean
+  end
 end

data/spec/support/shared_examples_for_a_lookup.rb

@@ -51,7 +51,7 @@ shared_examples "a proxy" do
   end
 
   it "allows .destroy_all" do
-    subject.destroy_all.should == []
+    expect { subject.destroy_all }.to_not raise_error
   end
 
   it "allows .destroy" do
@@ -60,7 +60,7 @@ shared_examples "a proxy" do
   end
 
   it "allows .delete_all" do
-    subject.delete_all.should == 0
+    expect { subject.delete_all }.to_not raise_error
   end
 
   it "allows .delete" do
@@ -106,14 +106,15 @@ shared_examples "a strict cache" do
     expect { subject.create(name: "new") }.to_not change(subject, :count)
   end
 
-  it "caches .all" do
-    expect { subject.create(name: "add") }.to_not change(subject, :all)
+  xit "does cache .all" do
+    new = subject.create(name: 'add')
+    subject.all.to_a.should_not include(new)
   end
 
-  it "reloads .all when called with args" do
+  xit "reloads .all when called with args" do
     new = subject.create(name: "new")
-    subject.all.should_not include(new)
-    subject.all({}).should include(new)
+    subject.all.to_a.should_not include(new)
+    subject.all({}).to_a.should include(new)
   end
 
   it "caches .pluck" do
@@ -138,7 +139,8 @@ shared_examples "a read-through proxy" do
   end
 
   it "reloads .all" do
-    expect { subject.create(name: "add") }.to change(subject, :all)
+    new = subject.create(name: 'add')
+    subject.all.to_a.should include (new)
   end
 
   it "reloads .pluck" do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: lookup_by
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.3.1
 platform: ruby
 authors:
 - Erik Peterson
@@ -63,19 +63,35 @@ files:
 - spec/dummy/app/models/city.rb
 - spec/dummy/app/models/email_address.rb
 - spec/dummy/app/models/ip_address.rb
+- spec/dummy/app/models/path.rb
 - spec/dummy/app/models/postal_code.rb
 - spec/dummy/app/models/state.rb
 - spec/dummy/app/models/status.rb
 - spec/dummy/app/models/street.rb
+- spec/dummy/app/models/user_agent.rb
+- spec/dummy/bin/bundle
+- spec/dummy/bin/rails
+- spec/dummy/bin/rake
 - spec/dummy/config.ru
 - spec/dummy/config/application.rb
 - spec/dummy/config/boot.rb
 - spec/dummy/config/database.yml
 - spec/dummy/config/environment.rb
 - spec/dummy/config/environments/development.rb
+- spec/dummy/config/environments/production.rb
 - spec/dummy/config/environments/test.rb
+- spec/dummy/config/initializers/backtrace_silencers.rb
+- spec/dummy/config/initializers/filter_parameter_logging.rb
+- spec/dummy/config/initializers/inflections.rb
+- spec/dummy/config/initializers/mime_types.rb
+- spec/dummy/config/initializers/secret_token.rb
+- spec/dummy/config/initializers/session_store.rb
+- spec/dummy/config/initializers/wrap_parameters.rb
+- spec/dummy/config/locales/en.yml
+- spec/dummy/config/routes.rb
 - spec/dummy/db/migrate/20121019040009_create_tables.rb
-- spec/dummy/db/schema.rb
+- spec/dummy/db/seeds.rb
+- spec/dummy/db/structure.sql
 - spec/dummy/lib/missing.rb
 - spec/dummy/log/.gitkeep
 - spec/dummy/script/rails
@@ -116,19 +132,35 @@ test_files:
 - spec/dummy/app/models/city.rb
 - spec/dummy/app/models/email_address.rb
 - spec/dummy/app/models/ip_address.rb
+- spec/dummy/app/models/path.rb
 - spec/dummy/app/models/postal_code.rb
 - spec/dummy/app/models/state.rb
 - spec/dummy/app/models/status.rb
 - spec/dummy/app/models/street.rb
+- spec/dummy/app/models/user_agent.rb
+- spec/dummy/bin/bundle
+- spec/dummy/bin/rails
+- spec/dummy/bin/rake
 - spec/dummy/config.ru
 - spec/dummy/config/application.rb
 - spec/dummy/config/boot.rb
 - spec/dummy/config/database.yml
 - spec/dummy/config/environment.rb
 - spec/dummy/config/environments/development.rb
+- spec/dummy/config/environments/production.rb
 - spec/dummy/config/environments/test.rb
+- spec/dummy/config/initializers/backtrace_silencers.rb
+- spec/dummy/config/initializers/filter_parameter_logging.rb
+- spec/dummy/config/initializers/inflections.rb
+- spec/dummy/config/initializers/mime_types.rb
+- spec/dummy/config/initializers/secret_token.rb
+- spec/dummy/config/initializers/session_store.rb
+- spec/dummy/config/initializers/wrap_parameters.rb
+- spec/dummy/config/locales/en.yml
+- spec/dummy/config/routes.rb
 - spec/dummy/db/migrate/20121019040009_create_tables.rb
-- spec/dummy/db/schema.rb
+- spec/dummy/db/seeds.rb
+- spec/dummy/db/structure.sql
 - spec/dummy/lib/missing.rb
 - spec/dummy/log/.gitkeep
 - spec/dummy/script/rails

data/spec/dummy/db/schema.rb

@@ -1,71 +0,0 @@
-# encoding: UTF-8
-# This file is auto-generated from the current state of the database. Instead
-# of editing this file, please use the migrations feature of Active Record to
-# incrementally modify your database, and then regenerate this schema definition.
-#
-# Note that this schema.rb definition is the authoritative source for your
-# database schema. If you need to create the application database on another
-# system, you should be using db:schema:load, not running all the migrations
-# from scratch. The latter is a flawed and unsustainable approach (the more migrations
-# you'll amass, the slower it'll run and the greater likelihood for issues).
-#
-# It's strongly recommended to check this file into your version control system.
-
-ActiveRecord::Schema.define(:version => 20121019040009) do
-
-  create_table "accounts", :primary_key => "account_id", :force => true do |t|
-    t.text "account", :null => false
-  end
-
-  add_index "accounts", ["account"], :name => "index_accounts_on_account", :unique => true
-
-  create_table "addresses", :primary_key => "address_id", :force => true do |t|
-    t.integer "city_id"
-    t.integer "state_id"
-    t.integer "postal_code_id"
-    t.integer "street_id"
-  end
-
-  create_table "cities", :primary_key => "city_id", :force => true do |t|
-    t.text "city", :null => false
-  end
-
-  add_index "cities", ["city"], :name => "index_cities_on_city", :unique => true
-
-  create_table "email_addresses", :primary_key => "email_address_id", :force => true do |t|
-    t.text "email_address", :null => false
-  end
-
-  add_index "email_addresses", ["email_address"], :name => "index_email_addresses_on_email_address", :unique => true
-
-  create_table "ip_addresses", :primary_key => "ip_address_id", :force => true do |t|
-    t.text "ip_address", :null => false
-  end
-
-  add_index "ip_addresses", ["ip_address"], :name => "index_ip_addresses_on_ip_address", :unique => true
-
-  create_table "postal_codes", :primary_key => "postal_code_id", :force => true do |t|
-    t.text "postal_code", :null => false
-  end
-
-  add_index "postal_codes", ["postal_code"], :name => "index_postal_codes_on_postal_code", :unique => true
-
-  create_table "states", :primary_key => "state_id", :force => true do |t|
-    t.text "state", :null => false
-  end
-
-  add_index "states", ["state"], :name => "index_states_on_state", :unique => true
-
-  create_table "statuses", :primary_key => "status_id", :force => true do |t|
-    t.text "status", :null => false
-  end
-
-  add_index "statuses", ["status"], :name => "index_statuses_on_status", :unique => true
-
-  create_table "streets", :primary_key => "street_id", :force => true do |t|
-    t.text "street", :null => false
-  end
-
-  add_index "streets", ["street"], :name => "index_streets_on_street", :unique => true
-
-end