lookup_by 0.10.6 → 0.10.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 733db5812641f61aedee288b13938b411ca1fe8f
-  data.tar.gz: 1ef219c1cf241bb0dbf342160f13f70c472f43b6
+  metadata.gz: 5f66e8cfacf984285ac5c1a39050c953e59727cf
+  data.tar.gz: 88e26f09abcb787959662658bd1cf941337dd1e0
 SHA512:
-  metadata.gz: a1e2d836bdff533ff4563530c46c6d1532f610cdcf41c099faa9c4e209c14db99990dcb12617062745f35101520ff41639e0c6efa9b72ac8546c7aa80d5cdf0d
-  data.tar.gz: 00be839049273eead6d1be21855d3753e865bf1afad15e207427a12f82043825548bfd15e56dbe2cc8ae00477ec9b063fe530d30f2b22ffd7da5e091f6e8b1b5
+  metadata.gz: 9b3f2d7a4ea2d2dde3d9ef4f90b72e78003d1e0c63aa60487cff6132d7042cf467de1fdd3c56f04960c2c61a132b143c2d820c07164a43d10067d838a3f95162
+  data.tar.gz: 63c97a2f17ac275aed7732d8419fbe626d9cb6bf884a1997336a175638c1b76d24fc4319cccb814b78db6cec6812b2cc930a289f10842488ff3c30b5ee0fe743

data/Gemfile

@@ -6,7 +6,7 @@ source "https://rubygems.org"
 gemspec
 
 group :development, :test do
-  gem 'appraisal', '~> 2.0.0', require: false
+  gem 'appraisal', '~> 2.1.0', require: false
 
   gem 'rspec'
   gem 'rspec-its'

data/gemfiles/rails_4.0.gemfile

@@ -5,7 +5,7 @@ source "https://rubygems.org"
 gem "rails", "~> 4.0.0"
 
 group :development, :test do
-  gem "appraisal", "~> 2.0.0", :require => false
+  gem "appraisal", "~> 2.1.0", :require => false
   gem "rspec"
   gem "rspec-its"
   gem "rspec-rails"

data/gemfiles/rails_4.1.gemfile

@@ -5,7 +5,7 @@ source "https://rubygems.org"
 gem "rails", "~> 4.1.0"
 
 group :development, :test do
-  gem "appraisal", "~> 2.0.0", :require => false
+  gem "appraisal", "~> 2.1.0", :require => false
   gem "rspec"
   gem "rspec-its"
   gem "rspec-rails"

data/gemfiles/rails_4.2.gemfile

@@ -5,7 +5,7 @@ source "https://rubygems.org"
 gem "rails", "~> 4.2.0"
 
 group :development, :test do
-  gem "appraisal", "~> 2.0.0", :require => false
+  gem "appraisal", "~> 2.1.0", :require => false
   gem "rspec"
   gem "rspec-its"
   gem "rspec-rails"

data/lib/lookup_by/cache.rb

@@ -202,14 +202,14 @@ module LookupBy
         return unless object
 
         @mutex.synchronize do
-          @reverse[object.send(@field)] = @cache[object.id] = object
+          @reverse[object.send(@field).to_s] = @cache[object.id] = object
         end
       end
     else
       def cache_write(object)
         return unless object
 
-        @reverse[object.send(@field)] = @cache[object.id] = object
+        @reverse[object.send(@field).to_s] = @cache[object.id] = object
       end
     end
 

data/lib/lookup_by/lookup.rb

@@ -98,7 +98,7 @@ module LookupBy
           when Symbol  then @lookup.fetch(arg.to_s)
           when IPAddr  then @lookup.fetch(arg.to_s)
           when self    then arg
-          else raise TypeError, "#{name}[arg]: arg must be at least one String, Symbol, Integer, nil, or #{name}"
+          else raise TypeError, "#{name}[*args]: args must be at least one String, Symbol, Integer, IPAddr, nil, or #{name}"
           end
         else return args.map { |arg| self[arg] } 
         end

data/lib/lookup_by/version.rb

@@ -1,3 +1,3 @@
 module LookupBy
-  VERSION = "0.10.6"
+  VERSION = "0.10.7"
 end

data/spec/caching/lru_spec.rb

@@ -56,7 +56,7 @@ describe LookupBy::Caching::LRU do
   describe "#fetch" do
     specify { expect(cache.fetch(1)).to eq "one" }
     specify { expect(cache.fetch(3) { |key| key }).to eq 3 }
-    specify { expect { cache.fetch(3) }.to raise_error }
+    specify { expect { cache.fetch(3) }.to raise_error(KeyError) }
 
     it "writes missing values" do
       expect(cache.fetch(3) { "missing" }).to eq "missing"
@@ -71,7 +71,7 @@ describe LookupBy::Caching::LRU do
   end
 
   describe "#max_size=" do
-    specify { expect { cache.max_size = -1 }.to raise_error }
+    specify { expect { cache.max_size = -1 }.to raise_error(ArgumentError) }
   end
 
   describe "#size" do

data/spec/lookup_by_spec.rb

@@ -87,7 +87,7 @@ end
 describe LookupBy::Lookup do
   context "Uncacheable.lookup_by :column, cache: true, find_or_create: true" do
     it "fails when trying to cache and write-through" do
-      expect { Uncacheable }.to raise_error
+      expect { Uncacheable }.to raise_error(ArgumentError)
     end
   end
 
@@ -209,12 +209,30 @@ describe LookupBy::Lookup do
   context "IpAddress.lookup_by :column, cache: N, find_or_create: true" do
     subject { IpAddress }
 
-    it "allows lookup by IPAddr" do
-      ip = subject['127.0.0.1']
+    let(:value) { '127.0.0.1' }
+    let(:ip)    { subject[value] }
 
-      expect(subject[IPAddr.new('127.0.0.1')]).to eq(ip)
+    it "allows lookup by IPAddr" do
+      expect(subject[IPAddr.new(value)]).to eq(ip)
+      expect(subject[ip]).to eq(ip)
       expect(subject[ip.id]).to eq(ip)
-      expect(subject['127.0.0.1']).to eq(ip)
+      expect(subject[value]).to eq(ip)
+    end
+
+    it 'caches values' do
+      subject.lookup.testing = false
+
+      subject[value]
+
+      id1 = subject[IPAddr.new(value)].object_id
+      id2 = subject[ip.id].object_id
+      id3 = subject[value].object_id
+      id4 = subject[ip].object_id
+
+      expect([id1, id2, id3, id4].uniq.size).to eq(1)
+
+      subject.lookup.testing = true
+      subject.lookup.clear
     end
   end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: lookup_by
 version: !ruby/object:Gem::Version
-  version: 0.10.6
+  version: 0.10.7
 platform: ruby
 authors:
 - Erik Peterson
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-11-12 00:00:00.000000000 Z
+date: 2015-11-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -153,7 +153,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.8
+rubygems_version: 2.4.5.1
 signing_key: 
 specification_version: 4
 summary: A thread-safe lookup table cache for ActiveRecord