lookup_by 0.1.0 → 0.1.1

checksums.yaml

@@ -0,0 +1,7 @@
+---
+SHA1:
+  metadata.gz: faef63af11f71cb58ed963cb274535be04ee72a1
+  data.tar.gz: 52faac6d69885248e29fb4292433786c73ba4d9f
+SHA512:
+  metadata.gz: 141b39d68b61dc72c1bcb12f87a192ffbc41d312649b88ccd6e996db19003f65e051ec41412fa16462f59bd30ac9555175fd682e7b3475a5ff9ecbe80db92c06
+  data.tar.gz: b0ccddd30f0245895891cd39f4152c1a9a17aceb1e3c945b74a06057d4fc8c6cf084dd3ba73a28eb35cbbda4ffbf38503a7284503115271987eaa6a5612349dc

data/lib/lookup_by/cache.rb

@@ -51,6 +51,10 @@ module LookupBy
       end
     end
 
+    def clear
+      cache.clear if cache?
+    end
+
     def create!(*args, &block)
       created = klass.create!(*args, &block)
       cache[created.id] = created if cache?
@@ -72,6 +76,10 @@ module LookupBy
       found
     end
 
+    def has_cache?
+      !!type
+    end
+
     def read_through?
       @read
     end
@@ -118,10 +126,6 @@ module LookupBy
       value.is_a?(Fixnum) ? primary_key : field
     end
 
-    def cache?
-      !!type && enabled?
-    end
-
     def enabled?
       enabled
     end
@@ -130,6 +134,10 @@ module LookupBy
       type == :all
     end
 
+    def cache?
+      !!type && enabled?
+    end
+
     def write?
       !!write
     end

data/lib/lookup_by/lookup.rb

@@ -9,7 +9,7 @@ module LookupBy
         options.symbolize_keys!
         options.assert_valid_keys :order, :cache, :normalize, :find, :find_or_create, :raise
 
-        raise "#{self} already uses lookup_by" if is_a? LookupBy::Lookup::ClassMethods
+        raise "#{self} already called lookup_by" if is_a? LookupBy::Lookup::ClassMethods
         raise "#{self} responds_to :[], needed for lookup_by"     if respond_to? :[]
         raise "#{self} responds_to :lookup, needed for lookup_by" if respond_to? :lookup
 
@@ -35,8 +35,9 @@ module LookupBy
     end
 
     module ClassMethods
-      def all
+      def all(*args)
         return super if @lookup.read_through?
+        return super if args.any?
 
         @lookup.cache.values
       end
@@ -64,6 +65,30 @@ module LookupBy
         else raise TypeError, "#{name}[arg]: arg must be a String, Symbol, Fixnum, nil, or #{name}"
         end
       end
+
+      def destroy_all(conditions = nil)
+        raise NotImplementedError, "#{name}.destroy_all is not supported on cached lookup tables." if @lookup.has_cache?
+
+        super
+      end
+
+      def destroy(id)
+        raise NotImplementedError, "#{name}.destroy(arg) is not supported on cached lookup tables" if @lookup.has_cache?
+
+        super
+      end
+
+      def delete_all(conditions = nil)
+        raise NotImplementedError, "#{name}.delete_all is not supported on cached lookup tables." if @lookup.has_cache?
+
+        super
+      end
+
+      def delete(id_or_array)
+        raise NotImplementedError, "#{name}.delete(arg) is not supported on cached lookup tables." if @lookup.has_cache?
+
+        super
+      end
     end
 
     module InstanceMethods

data/lib/lookup_by/version.rb

@@ -1,3 +1,3 @@
 module LookupBy
-  VERSION = "0.1.0"
+  VERSION = "0.1.1"
 end

data/spec/association_spec.rb

@@ -41,10 +41,6 @@ describe LookupBy::Association do
     City.create(name: "New York")
   end
 
-  after do
-    City.delete_all
-  end
-
   subject { Address.new }
 
   context "Address.lookup_for :city, strict: false" do

data/spec/support/shared_examples_for_a_lookup.rb

@@ -39,6 +39,23 @@ shared_examples "a proxy" do
     subject.update(original.id, name: "updated")
     subject[original.id].name.should_not eq original.name
   end
+
+  it "allows .destroy_all" do
+    subject.destroy_all.should == []
+  end
+
+  it "allows .destroy" do
+    instance = subject.create(name: "foo")
+    subject.destroy(instance.id).should == instance
+  end
+
+  it "allows .delete_all" do
+    subject.delete_all.should == 0
+  end
+
+  it "allows .delete" do
+    subject.delete(1).should == 0
+  end
 end
 
 shared_examples "a cache" do
@@ -56,6 +73,22 @@ shared_examples "a cache" do
 
     subject.lookup.enabled = was_enabled
   end
+
+  it "raises on .destroy_all" do
+    expect { subject.destroy_all }.to raise_error NotImplementedError, /destroy_all.*not supported/
+  end
+
+  it "raises on .destroy(id)" do
+    expect { subject.destroy(1) }.to raise_error NotImplementedError, /destroy.*not supported/
+  end
+
+  it "raises on .delete_all" do
+    expect { subject.delete_all }.to raise_error NotImplementedError, /delete_all.*not supported/
+  end
+
+  it "raises on .delete(id)" do
+    expect { subject.delete(1) }.to raise_error NotImplementedError, /delete.*not supported/
+  end
 end
 
 shared_examples "a strict cache" do
@@ -67,6 +100,12 @@ shared_examples "a strict cache" do
     expect { subject.create(name: "add") }.to_not change(subject, :all)
   end
 
+  it "reloads .all when called with args" do
+    new = subject.create(name: "new")
+    subject.all.should_not include(new)
+    subject.all({}).should include(new)
+  end
+
   it "caches .pluck" do
     subject.create(name: "pluck this")
     subject.pluck(:name).should_not include("pluck this")

metadata

@@ -1,32 +1,29 @@
 --- !ruby/object:Gem::Specification
 name: lookup_by
 version: !ruby/object:Gem::Version
-  prerelease: 
-  version: 0.1.0
+  version: 0.1.1
 platform: ruby
 authors:
 - Erik Peterson
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-02-07 00:00:00.000000000 Z
+date: 2014-05-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
-  version_requirements: !ruby/object:Gem::Requirement
+  name: rails
+  requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 3.0.0
-    none: false
-  name: rails
   type: :runtime
   prerelease: false
-  requirement: !ruby/object:Gem::Requirement
+  version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 3.0.0
-    none: false
 description: Use database lookup tables in AR models.
 email:
 - erik@enova.com
@@ -34,9 +31,9 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- .gitignore
-- .rvmrc
-- .travis.yml
+- ".gitignore"
+- ".rvmrc"
+- ".travis.yml"
 - Gemfile
 - MIT-LICENSE
 - README.md
@@ -86,27 +83,26 @@ files:
 - spec/support/shared_examples_for_a_lookup.rb
 homepage: http://www.github.com/companygardener/lookup_by
 licenses: []
+metadata: {}
 post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ! '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
-  none: false
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ! '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
-  none: false
 requirements: []
 rubyforge_project: 
-rubygems_version: 1.8.23
+rubygems_version: 2.2.2
 signing_key: 
-specification_version: 3
+specification_version: 4
 summary: A thread-safe lookup table cache for ActiveRecord
 test_files:
 - spec/association_spec.rb