looksist 0.2.8 → 0.2.9

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: af0970edfde1eaaedf7ff9dfeb7618e1c815beb9
-  data.tar.gz: 6a05e43560a57b6cbc150bb59b149f02316fd923
+  metadata.gz: a94198209689c7f7d3ab46c70ea437e34aa94ec9
+  data.tar.gz: 371c038b94dcf344047530fcebb5dbc0ea06851c
 SHA512:
-  metadata.gz: 5ce3783053136540929bc910c84b51c6e0fa00f0aa448e2fc1b88449863096f3cba725e43e58b9ee804600dd59c2ab11b653d8757431ffe84b396c799ab35573
-  data.tar.gz: feb2a4bb3cb516f7b34d95c4d474011fb5636cceae2fa32013948b0e72a3c764200cf1bd69a52fc3752c9be86448835086cd344dfd0a0d85fb5e36e39a52dc34
+  metadata.gz: f8adf4a7ba0580561c474dac05c47bbd4b31bc9f7567f26a8ed88a94b002af699b3b989957bf0ea550f6fe7fd16445dfff331da2793f6e10d78f9d04b48e3366
+  data.tar.gz: 5bb2d70eea93254ece6a6c9ebf890f19bc19195c3836f44a5f5134412f319e0ad42ee4f62b1c4f374a5abc84e79526b7953c980d4fab63f374fcd7753e5db3b5

data/features/hash_lookup.feature

@@ -27,4 +27,18 @@ Feature: Enrich hashes
     Then I should see the following "item name" enriched for each sub hash at "$.table.menu"
       | value  |
       | Idly   |
-      | Pongal |
+      | Pongal |
+
+  @array_of_hashes
+  Scenario: I should be able to enrich an array of hashes
+    Given I have the following keys setup in Redis
+      | key     | value    |
+      | items/1 | Idly     |
+      | items/2 | Pongal   |
+      | items/3 | Off Menu |
+    When I ask ArrayOfHash for menu
+    Then I should see the following "item name" in all the hashes
+      | value    |
+      | Idly     |
+      | Pongal   |
+      | Off Menu |

data/features/hash_services/array_of_hash.rb

@@ -0,0 +1,16 @@
+class ArrayOfHash
+  include Looksist
+
+  def menu
+    [{
+         item_id: 1
+    }, {
+        item_id: 2
+    }, {
+        item_id: 3
+    }
+    ]
+  end
+
+  inject after: :menu, at: '$', using: :item_id, populate: :item_name
+end

data/features/step_definitions/hash_lookup_steps.rb

@@ -1,4 +1,4 @@
-When(/^I ask (DeepHash|Menu) for (metrics|menu)$/) do |lookup_service, method|
+When(/^I ask (DeepHash|Menu|ArrayOfHash) for (metrics|menu)$/) do |lookup_service, method|
   @enriched_hash = Object.const_get(lookup_service.classify).new.send(method)
 end
 
@@ -11,4 +11,15 @@ end
 
 Then(/^I should see the following "([^"]*)" enriched for each sub hash at "([^"]*)"$/) do |name, jsonpath, table|
   expect(JsonPath.new(jsonpath).on(@enriched_hash.with_indifferent_access).first.collect { |i| i[name.parameterize.underscore.to_sym] }).to eq(table.hashes.collect { |i| i[:value] })
+end
+
+
+Then(/^I should see the following "([^"]*)" in all the hashes$/) do |name, table|
+  expected_names = table.hashes.collect { |row| row[:value] }
+  method_name = "#{name.parameterize.underscore.singularize}"
+  actual_names = @enriched_hash.collect do |elt|
+    elt.with_indifferent_access["#{method_name}"]
+  end
+  expect(actual_names).to eq(expected_names)
+
 end

data/lib/looksist/hashed.rb

@@ -19,7 +19,7 @@ module Looksist
             hash = send("#{after}_without_inject".to_sym, *args)
             self.class.instance_variable_get(:@rules)[after].each do |opts|
               if opts[:at].is_a? String
-                hash = update_using_json_path(hash, opts).to_hash.deep_symbolize_keys
+                hash = update_using_json_path(hash, opts)
               else
                 inject_attributes_at(hash[opts[:at]], opts)
               end
@@ -50,12 +50,17 @@ module Looksist
     end
 
     def update_using_json_path(hash, opts)
-      JsonPath.for(hash.with_indifferent_access).gsub!(opts[:at]) do |i|
-        i.is_a?(Array) ? inject_attributes_for(i, opts) : inject_attributes_at(i, opts) unless i.empty?
-        i
+      if hash.is_a?(Hash)
+        JsonPath.for(hash.with_indifferent_access).gsub!(opts[:at]) do |i|
+          i.is_a?(Array) ? inject_attributes_for(i, opts) : inject_attributes_at(i, opts) unless (i.nil? or i.empty?)
+          i
+        end.to_hash.deep_symbolize_keys
+      else
+        inject_attributes_for(hash, opts)
       end
     end
 
+
     def inject_attributes_for(arry_of_hashes, opts)
       entity_name = __entity__(opts[:bucket_name] || opts[:using])
       keys = (arry_of_hashes.collect { |i| i[opts[:using]] }).compact.uniq

data/lib/looksist/version.rb

@@ -1,3 +1,3 @@
 module Lookist
-  VERSION = '0.2.8'
+  VERSION = '0.2.9'
 end

data/spec/looksist/hashed_spec.rb

@@ -49,6 +49,7 @@ describe Looksist::Hashed do
                                        })
       end
 
+
       it 'should be capable to deep lookup and inject from custom bucket' do
         class CustomizedMenu
           include Looksist
@@ -370,5 +371,37 @@ describe Looksist::Hashed do
           }
       }})
     end
+
+    it 'should work for array of hashes' do
+      class ArrayOfHashes
+        include Looksist
+
+        def metrics
+          [
+              {
+                  item_id: 1
+          },
+              {
+                  item_id: 2
+          }
+          ]
+        end
+
+        inject after: :metrics, at: '$', using: :item_id, populate: :item_name
+      end
+
+      expect(@mock).to receive(:mget).once.with(*%w(items/1 items/2)).and_return(%w(Idly Pongal))
+
+      expect(ArrayOfHashes.new.metrics).to eq(
+                                      [{
+                                           item_id: 1,
+          item_name: 'Idly'
+      },
+          {
+              item_id: 2,
+          item_name: 'Pongal'
+      }]
+      )
+    end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: looksist
 version: !ruby/object:Gem::Version
-  version: 0.2.8
+  version: 0.2.9
 platform: ruby
 authors:
 - RC
@@ -198,6 +198,7 @@ files:
 - Rakefile
 - features/bucket_lookup.feature
 - features/hash_lookup.feature
+- features/hash_services/array_of_hash.rb
 - features/hash_services/deep_hash.rb
 - features/hash_services/menu.rb
 - features/model_lookup.feature
@@ -246,6 +247,7 @@ summary: Redis backed lookup for your models
 test_files:
 - features/bucket_lookup.feature
 - features/hash_lookup.feature
+- features/hash_services/array_of_hash.rb
 - features/hash_services/deep_hash.rb
 - features/hash_services/menu.rb
 - features/model_lookup.feature