looksist 0.2.5 → 0.2.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: d37e2dc990cb95ab09f7a065a226c2265808e1d7
-  data.tar.gz: 6e6886eca193e7b311b5c94ead38e098257d1821
+  metadata.gz: ac523f9688ba86477a776e9350c37978d8bbd46f
+  data.tar.gz: 4c0f7bdd47f0e43ac9ab7a87fcc8c28b3bb759b4
 SHA512:
-  metadata.gz: 82919b4456e2340f65119e66f7411051c9b5cccad412e2a150e2f03982542e1214ad4ad7f6c412567e7d447dfb722041c211bbaa6d25e8298ee899e195b285eb
-  data.tar.gz: 06003bbbc83e7499be00083848a16f97fc0d8db1e25c7376c16b0209807a172e712b444181e5c9cb0f8f9d24fcc968057df9fd64051f28448d5cfb728f82c2b8
+  metadata.gz: b7112c481f716d6d9180c4174cc43e73789aafff7a20173a30f7c4609fd0895ca0890c90dc9c4f7a0a198e068384c35bc3f6675871b76aedd48dae65db7b0cf2
+  data.tar.gz: 3f255b69863bf7bfbac3885af83c32631104861778dea24a27f9b4266de055a1e55a4faa39921f81f090368cff8256d7a6406e4448516df1cd997eb692e0ffe7

data/README.md

@@ -31,7 +31,7 @@ Or install it yourself as:
 
 ``` ruby
 Looksist.configure do |looksist|
-      looksist.lookup_store = Redis.new(:url => (ENV['REDIS_URL'], :driver => :hiredis)
+      looksist.lookup_store = Redis.new(:url => ENV['REDIS_URL'], :driver => :hiredis)
       looksist.driver =  Looksist::Serializers::Her
 end
 ```
@@ -45,7 +45,7 @@ it 'should generate declarative attributes on the model with simple lookup value
         class Employee
           include Looksist
           attr_accessor :id
-          lookup :name, using= :id
+          lookup :name, using: :id
 
           def initialize(id)
             @id = id
@@ -58,18 +58,22 @@ it 'should generate declarative attributes on the model with simple lookup value
       expect(e.name).to eq('Employee Name')
 end
 ```
-lookup takes the following form:
+lookup can take the following forms:
 
 ``` ruby
 # will lookup "employees/#{employee_id}" from the store
-lookup :name, using = :employee_id  
+lookup :name, using: :employee_id  
 
 # will lookup "stars/#{employee_id}" from the store
-lookup :name, using = :employee_id, bucket_name="stars" 
+lookup :name, using: :employee_id, bucket_name: "stars" 
 
 # will lookup "stars/#{employee_id}" from the store 
 # for an object with two attributes (name, location)
-lookup [:name, :location], using = :employee_id 
+lookup [:name, :location], using: :employee_id 
+
+# will lookup "stars/#{employee_id}" from the store 
+# for an object with two attributes (name, location) and expose name as nome
+lookup [:name, :age], using: :id, as: {name: 'nome'}
 
 ```
 
@@ -186,3 +190,17 @@ it 'should be capable to deep lookup and inject' do
     end
 ```
 
+### Controlling the L2 cache
+Looksist has support for an in memory L2 cache which it uses to optimize redis lookups. To disable L2 cache initialize looksists as below. 
+
+* Note that in no L2 cache mode, all lookups would go to redis and the gem would not optimize redundant lookups.
+* Hash based lookups would still see optimizations which come from performing unique on keys when injecting values.
+
+```ruby
+Looksist.configure do |looksist|
+      looksist.lookup_store = Redis.new(:url => ENV['REDIS_URL'], :driver => :hiredis)
+      looksist.driver =  Looksist::Serializers::Her
+      looksist.l2_cache = :no_cache
+end
+
+```

data/lib/looksist/core.rb

@@ -42,7 +42,12 @@ module Looksist
 
 
     def as_json(opts)
-      Looksist.driver.json_opts(self, self.class.lookup_attributes, opts)
+      parent_lookups = {}
+      class_lookups = self.class.lookup_attributes || {}
+      if self.class.superclass.respond_to?(:lookup_attributes)
+        parent_lookups = self.class.superclass.lookup_attributes || {}
+      end
+      Looksist.driver.json_opts(self, class_lookups.merge(parent_lookups), opts)
     end
 
   end
@@ -51,7 +56,7 @@ module Looksist
     class Her
       class << self
         def json_opts(obj, lookup_attributes, _)
-          lookup_attributes  ||= {}
+          lookup_attributes ||= {}
           other_attributes = lookup_attributes.keys.each_with_object({}) do |a, acc|
             using = lookup_attributes[a]
             acc[a] = obj.send(a) if obj.respond_to?(using)

data/lib/looksist/redis_service.rb

@@ -34,12 +34,12 @@ module Looksist
     def find_all(entity, ids)
       raise 'Buffer overflow! Increase buffer size' if  ids.length > @buffer_size && @buffer_size != 0
       keys = ids.collect { |id| redis_key(entity, id) }
-      missed_keys = cache_op(proc_from { keys.uniq }) { (keys - @cache.keys).uniq }
+      missed_keys = cache_op(proc { keys.uniq }) { (keys - @cache.keys).uniq }
       unless missed_keys.empty?
         response = Hash[*missed_keys.zip(@client.mget *missed_keys).flatten]
         cache_op { @cache.merge!(response) }
       end
-      (cache_op(proc_from { keys.collect {|k| response[k] } }) { @cache.mslice(keys) })
+      (cache_op(proc { keys.collect {|k| response[k] } }) { @cache.mslice(keys) })
     end
 
     def cache_op(computed = nil)
@@ -58,15 +58,13 @@ module Looksist
     end
 
     def fetch(key, &block)
-      (cache_op(proc_from { block.call }) { @cache[key] ||= block.call })
+      (cache_op(proc { block.call }) { @cache[key] ||= block.call })
     end
 
     def redis_key(entity, id)
       "#{entity.pluralize}/#{id}"
     end
 
-    def proc_from
-      Proc.new
-    end
+
   end
 end

data/lib/looksist/version.rb

@@ -1,3 +1,3 @@
 module Lookist
-  VERSION = '0.2.5'
+  VERSION = '0.2.6'
 end

data/spec/looksist/hashed_spec.rb

@@ -340,7 +340,6 @@ describe Looksist::Hashed do
       @mock = {}
       Looksist.configure do |looksist|
         looksist.lookup_store = @mock
-        looksist.cache_buffer_size = 10
         looksist.l2_cache = :no_cache
       end
     end

data/spec/looksist/looksist_spec.rb

@@ -60,6 +60,51 @@ describe Looksist do
         expect(e.to_json).to eq("{\"nome\":\"Rajini\",\"age\":16,\"id\":1}")
       end
     end
+
+    context 'Look up support in case of Inheritance' do
+      it 'should also get parent class lookups during to json conversion' do
+
+        module InheritedLookUp
+          class Employee
+            include Her::Model
+            use_api TEST_API
+            include Looksist
+            attr_accessor :id
+            attr_accessor :department_id
+            lookup :name, using: :id, bucket_name: 'employees'
+
+            def initialize(id, department_id)
+              @id = id
+              @department_id = department_id
+            end
+
+            def as_json(opts)
+              super(opts).merge(id: @id)
+            end
+          end
+
+          class Manager < Employee
+            lookup :name, using: :department_id, as: {name: 'department_name'}
+
+            def is_manager?
+              true
+            end
+
+            def as_json(opts)
+              super(opts).merge(is_manager: is_manager?)
+            end
+          end
+        end
+
+        expect(@mock).to receive(:get).once.with('employees/1').and_return('SuperStar')
+        expect(@mock).to receive(:get).once.with('departments/2').and_return('Kollywood')
+
+        e = InheritedLookUp::Manager.new(1, 2)
+
+        expect(e.to_json).to eq("{\"department_name\":\"Kollywood\",\"name\":\"SuperStar\",\"id\":1,\"is_manager\":true}")
+      end
+    end
+
   end
   context 'with l2 cache' do
     before(:each) do
@@ -127,7 +172,7 @@ describe Looksist do
             end
           end
         end
-        expect(@mock).to receive(:get).never.with('employees_/1')
+        expect(@mock).to receive(:get).never.with('employees/1')
         e = TolerantLookUp::Employee.new
         expect(e.to_json).to eq('{}')
       end
@@ -291,5 +336,6 @@ describe Looksist do
         employee_second_instance.name
       end
     end
+
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: looksist
 version: !ruby/object:Gem::Version
-  version: 0.2.5
+  version: 0.2.6
 platform: ruby
 authors:
 - RC