looksist 0.1.1 → 0.1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 7699db1f029bfd6f15c34c647b972ad4ff8a7a55
-  data.tar.gz: e2131d4bd14186ccdcf5993204e8d0e6f9abdc06
+  metadata.gz: a968b111e81190b6beb211859660441fd85ce1a4
+  data.tar.gz: f77a551f75633ae29b2da166f57adcbbd0d5c725
 SHA512:
-  metadata.gz: 13060ecc41d9c3c2d306f7b5e5cb18ea988afce19c0b4b9c6dd33399f9fadaa865788b92feffc735cbf247374338a00c1e766c88ff35e65b2b78d37715638187
-  data.tar.gz: 1d897d919454bd425738421ac0042ea4279f4e24ba00a4619d4683a8ffe22dbfa24518413858951e14c7f2ebbf87511f00ce68de40f22fd6c3c7c10bcd958bab
+  metadata.gz: efb01d26875fd426930deb8a3edaf1b29e058747eff9a21b98462c71227e8d95e73cb8c5fd3ccf547441aa57d63450b20f83144c2698941ba8d59b32b33d4f62
+  data.tar.gz: 327be6f5250333bd497d3f6adc1f725f5636c43eca053c87fe1a63bdf789352a3887390f7d867a3d33d220a68e94bd99cee1fddeea7f3d21b3cf9ed172213ddc

data/lib/looksist/redis_service.rb

@@ -16,8 +16,8 @@ module Looksist
     end
 
     def method_missing(name, *args, &block)
-      if name.to_s.ends_with?("_for")
-        entity = name.to_s.gsub('_for','')
+      if name.to_s.ends_with?('_for')
+        entity = name.to_s.gsub('_for', '')
         first_arg = args.first
         first_arg.is_a?(Array) ? find_all(entity, first_arg) : find(entity, first_arg)
       else
@@ -35,8 +35,10 @@ module Looksist
       raise 'Buffer overflow! Increase buffer size' if ids.length > @buffer_size
       keys = ids.collect { |id| redis_key(entity, id) }
       missed_keys = (keys - @cache.keys).uniq
-      values = @client.mget missed_keys
-      @cache.merge!(Hash[*missed_keys.zip(values).flatten])
+      unless missed_keys.empty?
+        values = @client.mget *missed_keys
+        @cache.merge!(Hash[*missed_keys.zip(values).flatten])
+      end
       @cache.mslice(keys)
     end
 
@@ -48,7 +50,7 @@ module Looksist
     end
 
     def fetch(key, &block)
-      @cache[key] ||=  block.call
+      @cache[key] ||= block.call
     end
 
     def redis_key(entity, id)

data/lib/looksist/version.rb

@@ -1,3 +1,3 @@
 module Lookist
-  VERSION = '0.1.1'
+  VERSION = '0.1.2'
 end

data/spec/looksist/hashed_spec.rb

@@ -33,8 +33,8 @@ describe Looksist::Hashed do
         inject after: :metrics, at: '$.table.menu', using: :item_id, populate: :item_name
       end
 
-      expect(@mock).to receive(:mget).with(['items/1']).and_return(['Idly'])
-      expect(@mock).to receive(:mget).with(['items/2']).and_return(['Pongal'])
+      expect(@mock).to receive(:mget).with(*['items/1']).and_return(['Idly'])
+      expect(@mock).to receive(:mget).with(*['items/2']).and_return(['Pongal'])
 
       expect(Menu.new.metrics).to eq({
                                          table: {
@@ -110,7 +110,7 @@ describe Looksist::Hashed do
         inject after: :metrics, at: '$.table.inner_table', using: :employee_id, populate: :employee_name
       end
 
-      expect(@mock).to receive(:mget).with(%w(employees/10 employees/20)).and_return(['emp 1', 'emp 2'])
+      expect(@mock).to receive(:mget).with(*%w(employees/10 employees/20)).and_return(['emp 1', 'emp 2'])
 
       expect(DeepHash.new.metrics).to eq({table: {
           inner_table: {
@@ -135,7 +135,7 @@ describe Looksist::Hashed do
         inject after: :metrics, at: :table, using: :employee_id, populate: :employee_name
       end
 
-      expect(@mock).to receive(:mget).with(%w(employees/1 employees/2)).and_return(['emp 1', 'emp 2'])
+      expect(@mock).to receive(:mget).with(*%w(employees/1 employees/2)).and_return(['emp 1', 'emp 2'])
 
       expect(HashService1.new.metrics).to eq({table: {
           employee_id: [1, 2],
@@ -160,9 +160,9 @@ describe Looksist::Hashed do
         inject after: :metrics, at: :table, using: :employer_id, populate: :employer_name
       end
 
-      expect(@mock).to receive(:mget).with(%w(employees/5 employees/6)).and_return(['emp 5', 'emp 6'])
+      expect(@mock).to receive(:mget).with(*%w(employees/5 employees/6)).and_return(['emp 5', 'emp 6'])
 
-      expect(@mock).to receive(:mget).with(%w(employers/3 employers/4)).and_return(['empr 3', 'empr 4'])
+      expect(@mock).to receive(:mget).with(*%w(employers/3 employers/4)).and_return(['empr 3', 'empr 4'])
 
       expect(HashService.new.metrics).to eq({table: {
           employee_id: [5, 6],
@@ -192,9 +192,9 @@ describe Looksist::Hashed do
       inject after: :metrics, at: '$.table.database', using: :employer_id, populate: :employer_name
     end
 
-    expect(@mock).to receive(:mget).with(%w(employees/15 employees/16)).and_return(['emp 15', 'emp 16'])
+    expect(@mock).to receive(:mget).with(*%w(employees/15 employees/16)).and_return(['emp 15', 'emp 16'])
 
-    expect(@mock).to receive(:mget).with(%w(employers/13 employers/14)).and_return(['empr 13', 'empr 14'])
+    expect(@mock).to receive(:mget).with(*%w(employers/13 employers/14)).and_return(['empr 13', 'empr 14'])
 
     expect(EmployeeHash.new.metrics).to eq({table: {
         database: {
@@ -267,9 +267,9 @@ describe Looksist::Hashed do
         inject after: :stock, at: :table, using: :dc_id, populate: :dc_name
       end
 
-      expect(@mock).to receive(:mget).with(%w(shrinks/1 shrinks/2)).and_return(['shrink 1', 'shrink 2'])
+      expect(@mock).to receive(:mget).with(*%w(shrinks/1 shrinks/2)).and_return(['shrink 1', 'shrink 2'])
 
-      expect(@mock).to receive(:mget).with(%w(dcs/7 dcs/8)).and_return(['dc 7', 'dc 8'])
+      expect(@mock).to receive(:mget).with(*%w(dcs/7 dcs/8)).and_return(['dc 7', 'dc 8'])
 
       hash_service_super = HashServiceSuper.new
       expect(hash_service_super.shrinkage).to eq({table: {

data/spec/looksist/redis_service_spec.rb

@@ -39,14 +39,20 @@ describe Looksist::RedisService do
     end
 
     it 'should mget redis when there are multiple keys' do
-      expect(@mock).to receive(:mget).with(['snacks/1', 'snacks/2', 'snacks/3']).once.and_return(['BAJJI', 'BONDA', 'VADA'])
+      expect(@mock).to receive(:mget).with('snacks/1', 'snacks/2', 'snacks/3').once.and_return(%w(BAJJI BONDA VADA))
       expect(@lookup.snacks_for([1, 2, 3])).to match_array(%w(BAJJI BONDA VADA))
     end
 
     it 'should mget redis only for unique keys' do
-      expect(@mock).to receive(:mget).with(['snacks/1', 'snacks/2', 'snacks/3']).once.and_return(['BAJJI', 'BONDA', 'VADA'])
+      expect(@mock).to receive(:mget).with('snacks/1', 'snacks/2', 'snacks/3').once.and_return(%w(BAJJI BONDA VADA))
       expect(@lookup.snacks_for([1, 2, 3, 1, 2])).to match_array(%w(BAJJI BONDA VADA BAJJI BONDA))
     end
+
+    it 'should get from cache' do
+      expect(@mock).to receive(:mget).with('snacks/1', 'snacks/2', 'snacks/3', 'snacks/4', 'snacks/5').once.and_return(%w(BAJJI BONDA VADA MEDU_VADA MASALA_VADA))
+      expect(@lookup.snacks_for([1, 2, 3, 4, 5])).to match_array(%w(BAJJI BONDA VADA MEDU_VADA MASALA_VADA))
+      expect(@lookup.snacks_for([1, 2, 3, 4, 5])).to match_array(%w(BAJJI BONDA VADA MEDU_VADA MASALA_VADA))
+    end
   end
 
   context 'value not present' do
@@ -59,8 +65,8 @@ describe Looksist::RedisService do
     end
 
     it 'should not bomb when there are no values present' do
-      expect(@mock).to receive(:mget).with(['snacks/1', 'snacks/2', 'snacks/3']).once.and_return(['BAJJI', nil, 'VADA'])
-      expect(@lookup.snacks_for([1, 2, 3])).to match_array(["BAJJI", nil, "VADA"])
+      expect(@mock).to receive(:mget).with('snacks/1', 'snacks/2', 'snacks/3').once.and_return(['BAJJI', nil, 'VADA'])
+      expect(@lookup.snacks_for([1, 2, 3])).to match_array(['BAJJI', nil, 'VADA'])
     end
   end
 
@@ -74,7 +80,7 @@ describe Looksist::RedisService do
     end
 
     it 'should clear the local cache' do
-      expect(@mock).to receive(:mget).with(['snacks/1', 'snacks/2', 'snacks/3']).once.and_return(['BAJJI', nil, 'VADA'])
+      expect(@mock).to receive(:mget).with('snacks/1', 'snacks/2', 'snacks/3').once.and_return(['BAJJI', nil, 'VADA'])
       @lookup.snacks_for([1, 2, 3])
       expect(@lookup.cache.size).to eq(3)
       @lookup.flush_cache!

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: looksist
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.1.2
 platform: ruby
 authors:
 - RC
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-10-19 00:00:00.000000000 Z
+date: 2014-10-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler