looksist 0.1.0 → 0.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 4692f5e6e9889da65c8102e96df4c6568bc055d6
-  data.tar.gz: c29a30d638075b5b1c8ea4640eb0150d6835eb83
+  metadata.gz: 7699db1f029bfd6f15c34c647b972ad4ff8a7a55
+  data.tar.gz: e2131d4bd14186ccdcf5993204e8d0e6f9abdc06
 SHA512:
-  metadata.gz: 0a9842bcb7941d3647be3ae3ab274665ddf8442a831499fc73b49b35e4023277c2b4f72a04af91e8c7db3a754afa8c6d5c84a0221db7db180133d9d429987575
-  data.tar.gz: 7a51b99b6bdd7c1e526408618cd780f3f336cd6e47ae3eeeed37433116ef124513d77b49be4289cbf8cdb21b6009c5d3aef8259cb399dfa836e2ca6b3a6e178d
+  metadata.gz: 13060ecc41d9c3c2d306f7b5e5cb18ea988afce19c0b4b9c6dd33399f9fadaa865788b92feffc735cbf247374338a00c1e766c88ff35e65b2b78d37715638187
+  data.tar.gz: 1d897d919454bd425738421ac0042ea4279f4e24ba00a4619d4683a8ffe22dbfa24518413858951e14c7f2ebbf87511f00ce68de40f22fd6c3c7c10bcd958bab

data/lib/looksist/hashed.rb

@@ -43,6 +43,7 @@ module Looksist
     end
 
     def inject_attributes_at(hash_offset, opts)
+      return nil unless hash_offset
       keys = hash_offset[opts[:using]]
       entity_name = entity(opts[:using])
       values = Looksist.redis_service.send("#{entity_name}_for", keys)

data/lib/looksist/version.rb

@@ -1,3 +1,3 @@
 module Lookist
-  VERSION = '0.1.0'
+  VERSION = '0.1.1'
 end

data/spec/looksist/hashed_spec.rb

@@ -110,7 +110,7 @@ describe Looksist::Hashed do
         inject after: :metrics, at: '$.table.inner_table', using: :employee_id, populate: :employee_name
       end
 
-      expect(@mock).to receive(:mget).with(['employees/10', 'employees/20']).and_return(['emp 1', 'emp 2'])
+      expect(@mock).to receive(:mget).with(%w(employees/10 employees/20)).and_return(['emp 1', 'emp 2'])
 
       expect(DeepHash.new.metrics).to eq({table: {
           inner_table: {
@@ -135,7 +135,7 @@ describe Looksist::Hashed do
         inject after: :metrics, at: :table, using: :employee_id, populate: :employee_name
       end
 
-      expect(@mock).to receive(:mget).with(['employees/1', 'employees/2']).and_return(['emp 1', 'emp 2'])
+      expect(@mock).to receive(:mget).with(%w(employees/1 employees/2)).and_return(['emp 1', 'emp 2'])
 
       expect(HashService1.new.metrics).to eq({table: {
           employee_id: [1, 2],
@@ -160,9 +160,9 @@ describe Looksist::Hashed do
         inject after: :metrics, at: :table, using: :employer_id, populate: :employer_name
       end
 
-      expect(@mock).to receive(:mget).with(['employees/5', 'employees/6']).and_return(['emp 5', 'emp 6'])
+      expect(@mock).to receive(:mget).with(%w(employees/5 employees/6)).and_return(['emp 5', 'emp 6'])
 
-      expect(@mock).to receive(:mget).with(['employers/3', 'employers/4']).and_return(['empr 3', 'empr 4'])
+      expect(@mock).to receive(:mget).with(%w(employers/3 employers/4)).and_return(['empr 3', 'empr 4'])
 
       expect(HashService.new.metrics).to eq({table: {
           employee_id: [5, 6],
@@ -192,9 +192,9 @@ describe Looksist::Hashed do
       inject after: :metrics, at: '$.table.database', using: :employer_id, populate: :employer_name
     end
 
-    expect(@mock).to receive(:mget).with(['employees/15', 'employees/16']).and_return(['emp 15', 'emp 16'])
+    expect(@mock).to receive(:mget).with(%w(employees/15 employees/16)).and_return(['emp 15', 'emp 16'])
 
-    expect(@mock).to receive(:mget).with(['employers/13', 'employers/14']).and_return(['empr 13', 'empr 14'])
+    expect(@mock).to receive(:mget).with(%w(employers/13 employers/14)).and_return(['empr 13', 'empr 14'])
 
     expect(EmployeeHash.new.metrics).to eq({table: {
         database: {
@@ -206,6 +206,41 @@ describe Looksist::Hashed do
     }})
   end
 
+  context 'handle no data' do
+    it 'should not inject when data is not available' do
+        class EmptyResponse
+          include Looksist
+          def empty
+            {}
+          end
+          inject after: :empty, at: :'$.table', using: :subcat_id, populate: :sub_cat_name
+        end
+        expect(EmptyResponse.new.empty).to eq({})
+    end
+
+    it 'should be capable to deep lookup and inject' do
+      class EmptyMenu
+        include Looksist
+
+        def metrics
+          {
+              table: {
+                  menu: []
+              }
+          }
+        end
+
+        inject after: :metrics, at: '$.table.menu', using: :item_id, populate: :item_name
+      end
+
+      expect(EmptyMenu.new.metrics).to eq({
+                                         table: {
+                                             menu: []
+                                         }
+                                     })
+    end
+  end
+
 
   context 'multiple methods and injections' do
     it 'should inject multiple attribute to an existing hash' do
@@ -232,9 +267,9 @@ describe Looksist::Hashed do
         inject after: :stock, at: :table, using: :dc_id, populate: :dc_name
       end
 
-      expect(@mock).to receive(:mget).with(['shrinks/1', 'shrinks/2']).and_return(['shrink 1', 'shrink 2'])
+      expect(@mock).to receive(:mget).with(%w(shrinks/1 shrinks/2)).and_return(['shrink 1', 'shrink 2'])
 
-      expect(@mock).to receive(:mget).with(['dcs/7', 'dcs/8']).and_return(['dc 7', 'dc 8'])
+      expect(@mock).to receive(:mget).with(%w(dcs/7 dcs/8)).and_return(['dc 7', 'dc 8'])
 
       hash_service_super = HashServiceSuper.new
       expect(hash_service_super.shrinkage).to eq({table: {

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: looksist
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.1
 platform: ruby
 authors:
 - RC