looksist 0.0.3 → 0.0.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 6559932c80aa96627db70da45c2f911ff3dcdf5c
-  data.tar.gz: c6dc2f87865ab21682371a16609a239c25c7de2e
+  metadata.gz: b5a7bf0e877c516e9c5e5d3ab5592a3f7e2dbea3
+  data.tar.gz: 16575e3d5b0a651e0ed801db1769f640d9401f75
 SHA512:
-  metadata.gz: 991490a0e2acbe36aa3080a854047a39604e9d4ebec2796a26a365fce95a9c04952728b6f720a69999f3933e74bf2cf8ca3168911484c652b246aedc087e2ac6
-  data.tar.gz: 086812da4bd01e882a7e7a986c0ed7c305e5a37e66ad6ffa985f59b904aa82eb5ea64e00f2113238ac1ef0192831883676073b24d4f8b361f1739716fd0f71bc
+  metadata.gz: 5efb4ef3b7c9ce4d39c35b1e91d8ff61bb95b270fcb4582bb73f0df9d0388c317890086b0215aa9307127286ae16ff6e2080a15e0469b748712804d82eaf11d2
+  data.tar.gz: ac6029d274ab7e31148abded157c583e39c6486c10dc7f53eed148e604c2497b501f756805bac912ecb394256a9daa704b523c8bdce804bb09d6d9d03ddb44a8

data/lib/looksist.rb

@@ -1,6 +1,7 @@
 require 'looksist/version'
 require 'looksist/redis_service'
 require 'looksist/hashed'
+require 'looksist/her_collection'
 
 module Looksist
   extend ActiveSupport::Concern
@@ -15,32 +16,54 @@ module Looksist
       entity.pluralize
     end
 
+    def memoized(key)
+      self.storage ||= OpenStruct.new
+      self.storage[key] = self.storage[key] || Looksist.lookup_store_client.get(key)
+    end
+
+    def mmemoized(key, values)
+      key_and_bucket = id_and_buckets.find{|h| h[:id] == key}
+      return if key_and_bucket.nil?
+      redis_keys = values.collect{|v| redis_key(key_and_bucket[:bucket], v)}
+      left_keys_to_lookup = redis_keys.select{|k| self.storage[k].nil?}
+      Looksist.lookup_store_client.mapped_mget(left_keys_to_lookup).each do |key, value|
+        self.storage[key] = value
+      end
+
+    end
+
+    def redis_key bucket, value
+      [bucket, '/', value].join('')
+    end
+
     def lookup(what, using, bucket = bucket_name(using))
       self.lookup_attributes ||= []
+      self.id_and_buckets ||= []
+      self.id_and_buckets << {id: using, bucket: bucket}
       if what.is_a? Array
         what.each do |method_name|
           define_method(method_name) do
-            key = [bucket, '/', self.send(using).try(:to_s)].join('')
-            JSON.parse(send(:memoized, key) || '{}')[method_name.to_s]
+            JSON.parse(self.class.memoized(self.class.redis_key(bucket, self.send(using).try(:to_s))) || '{}')[method_name.to_s]
           end
           self.lookup_attributes << method_name
         end
       else
         define_method(what) do
-          key = [bucket, '/', self.send(using).try(:to_s)].join('')
-          send(:memoized, key)
+          self.class.memoized(self.class.redis_key(bucket, self.send(using).try(:to_s)))
         end
         self.lookup_attributes << what.to_sym
       end
     end
   end
 
+
+
   def as_json(opts)
     Looksist.driver.json_opts(self, opts)
   end
 
   included do |base|
-    base.class_attribute :lookup_attributes
+    base.class_attribute :lookup_attributes, :storage, :id_and_buckets
   end
 
   module Serializers
@@ -53,11 +76,4 @@ module Looksist
       end
     end
   end
-
-  private
-
-  def memoized(key)
-    @storage = @storage || OpenStruct.new
-    @storage[key] = @storage[key] || Looksist.lookup_store_client.get(key)
-  end
-end
+end

data/lib/looksist/hashed.rb

@@ -2,8 +2,6 @@ module Looksist
   module Hashed
     extend ActiveSupport::Concern
 
-    # inject after: :assortment, at: 'table', using: :supplier_id, populate: :supplier_name, bucket_name: 'suppliers'
-
     class << self;
       attr_accessor :redis_service
     end
@@ -37,7 +35,7 @@ module Looksist
     end
 
     def entity(entity_id)
-      entity = entity_id.to_s.gsub('_id', '')
+      entity_id.to_s.gsub('_id', '')
     end
   end
 end

data/lib/looksist/her_collection.rb

@@ -0,0 +1,13 @@
+module Her
+  class Collection
+    def load_all_meta
+      klass = a.first.class
+      return unless klass.respond_to?(:id_and_buckets)
+      id_attributes = klass.id_and_buckets.collect{|h| h[:id]}
+      id_attributes.each do |attribute|
+        id_attribute_values = self.collect(&attribute.to_sym)
+        klass.mmemoized(attribute, id_attribute_values)
+      end
+    end
+  end
+end

data/lib/looksist/version.rb

@@ -1,3 +1,3 @@
 module Lookist
-  VERSION = '0.0.3'
+  VERSION = '0.0.4'
 end

data/spec/hashed_spec.rb

@@ -9,6 +9,7 @@ describe Looksist::Hashed do
     end
 
     @mock = MockRedis.new
+
     Looksist::Hashed.redis_service = Looksist::RedisService.instance do |lookup|
       lookup.client = @mock
     end
@@ -34,7 +35,7 @@ describe Looksist::Hashed do
       expect(@mock).to receive(:get).with('employees/1').and_return(OpenStruct.new(value:'emp 1'))
       expect(@mock).to receive(:get).with('employees/2').and_return(OpenStruct.new(value:'emp 2'))
 
-      HashService1.new.metrics.should eq({table: {
+      expect(HashService1.new.metrics).to eq({table: {
           employee_id: [1, 2],
           employee_name: ['emp 1', 'emp 2']
       }})
@@ -63,7 +64,7 @@ describe Looksist::Hashed do
       expect(@mock).to receive(:get).with('employers/3').and_return(OpenStruct.new(value:'empr 3'))
       expect(@mock).to receive(:get).with('employers/4').and_return(OpenStruct.new(value:'empr 4'))
 
-      HashService.new.metrics.should eq({table: {
+      expect(HashService.new.metrics).to eq({table: {
           employee_id: [5, 6],
           employer_id: [3, 4],
           employee_name: ['emp 5', 'emp 6'],
@@ -105,12 +106,12 @@ describe Looksist::Hashed do
       expect(@mock).to receive(:get).with('dcs/8').and_return(OpenStruct.new(value:'dc 8'))
 
       hash_service_super = HashServiceSuper.new
-      hash_service_super.shrinkage.should eq({table: {
+      expect(hash_service_super.shrinkage).to eq({table: {
           shrink_id: [1, 2],
           shrink_name: ['shrink 1', 'shrink 2']
       }})
 
-      hash_service_super.stock.should eq({table: {
+      expect(hash_service_super.stock).to eq({table: {
           dc_id: [7, 8],
           dc_name: ['dc 7', 'dc 8']
       }})

data/spec/looksist_spec.rb

@@ -116,4 +116,62 @@ describe Looksist do
       expect(e.sex).to be(nil)
     end
   end
+
+  context 'share storage between instances' do
+    class Employee
+      include Looksist
+      attr_accessor :id
+
+      lookup [:name, :location], using=:id
+
+      def initialize(id)
+        @id = id
+      end
+    end
+    it 'should share storage between instances to improve performance' do
+      employee_first_instance = Employee.new(1)
+      expect(Looksist.lookup_store_client).to receive(:get).with('ids/1')
+                                              .and_return({name: 'Employee Name', location: 'Chennai'}.to_json)
+      employee_first_instance.name
+
+      employee_second_instance = Employee.new(1)
+      expect(Looksist.lookup_store_client).not_to receive(:get).with('ids/1')
+
+      employee_second_instance.name
+    end
+  end
+
+  context '.id_and_buckets' do
+    class Developer
+      include Looksist
+      lookup [:city], using=:city_id
+      lookup [:role], using=:role_id
+    end
+    it 'should hold all the id and buckets' do
+       expect(Developer.id_and_buckets).to eq([{id: :city_id, bucket: 'cities'}, {id: :role_id, bucket: 'roles'}])
+    end
+  end
+
+  context '.mmemoized' do
+    class AnotherDeveloperClass
+      include Looksist
+      lookup [:city], using=:city_id
+      lookup [:role], using=:role_id
+    end
+
+    AnotherDeveloperClass.storage = OpenStruct.new
+    AnotherDeveloperClass.storage['cities/1'] = 'Chennai'
+    AnotherDeveloperClass.storage['cities/2'] = 'Delhi'
+
+    it 'make single request for multiple values' do
+      expect(Looksist.lookup_store_client).to receive(:mapped_mget).with(%w(cities/4 cities/5))
+                        .and_return({'cities/4' => 'Bangalore', 'cities/5' => 'Kolkata'})
+      AnotherDeveloperClass.mmemoized(:city_id, [1, 4, 5])
+
+      expect(AnotherDeveloperClass.storage.to_h.length).to eq(4)
+      expect(AnotherDeveloperClass.storage['cities/5']).to eq('Kolkata')
+      expect(AnotherDeveloperClass.storage['cities/4']).to eq('Bangalore')
+
+    end
+  end
 end

data/spec/redis_service_spec.rb

@@ -0,0 +1,55 @@
+require 'spec_helper'
+
+describe Looksist::RedisService do
+
+  class MockRedis
+    def pipelined
+      yield
+    end
+  end
+
+  context 'single lookup' do
+    before(:each) do
+      @lookup = Looksist::RedisService.instance do |lookup|
+        lookup.client = {}
+        lookup.buffer_size = 1
+      end
+      @lookup.cache.clear
+    end
+
+    it 'should call redis when key not present in cache' do
+      expect(@lookup.client).to receive(:get).with('sub_categories/8001').and_return('CEREALI')
+      expect(@lookup.sub_category_for(8001)).to eq('CEREALI')
+      expect(@lookup.sub_category_for(8001)).to eq('CEREALI')
+    end
+
+    it 'should abandon older entries incase of buffer overflow' do
+      expect(@lookup.client).to receive(:get).with('sub_families/12').and_return('DON CORLEONE')
+      expect(@lookup.client).to receive(:get).with('sub_families/34').and_return('SOPRANOS')
+
+      expect(@lookup.sub_family_for(12)).to eq('DON CORLEONE')
+      expect(@lookup.sub_family_for(34)).to eq('SOPRANOS')
+      expect(@lookup.cache.keys).to match_array(['sub_families/34'])
+    end
+
+  end
+
+  context 'multi lookup' do
+
+    before(:each) do
+      @mock = MockRedis.new
+      @lookup = Looksist::RedisService.instance do |lookup|
+        lookup.client = @mock
+        lookup.buffer_size = 5
+      end
+    end
+
+    it 'should pipeline calls to redis when there are multiple keys' do
+      expect(@mock).to receive(:get).with('snacks/1').and_return(OpenStruct.new(value:'BAJJI'))
+      expect(@mock).to receive(:get).with('snacks/2').and_return(OpenStruct.new(value:'BONDA'))
+      expect(@mock).to receive(:get).with('snacks/3').and_return(OpenStruct.new(value:'VADA'))
+
+      expect(@lookup.snacks_for([1,2,3,1])).to match_array(%w(BAJJI BONDA VADA BAJJI))
+    end
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: looksist
 version: !ruby/object:Gem::Version
-  version: 0.0.3
+  version: 0.0.4
 platform: ruby
 authors:
 - RC
@@ -156,11 +156,13 @@ files:
 - Rakefile
 - lib/looksist.rb
 - lib/looksist/hashed.rb
+- lib/looksist/her_collection.rb
 - lib/looksist/redis_service.rb
 - lib/looksist/version.rb
 - looksist.gemspec
 - spec/hashed_spec.rb
 - spec/looksist_spec.rb
+- spec/redis_service_spec.rb
 - spec/spec_helper.rb
 homepage: https://github.com/jpsimonroy/herdis
 licenses:
@@ -189,4 +191,5 @@ summary: Redis backed lookup for your her models
 test_files:
 - spec/hashed_spec.rb
 - spec/looksist_spec.rb
+- spec/redis_service_spec.rb
 - spec/spec_helper.rb