lookout-rack-test 2.3.1 → 3.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 5966c38c1c55f5245f2973d343f23faf22994761
-  data.tar.gz: 77e1c227f30e6ac8b5b27033cdae1c2dfa9c1618
+  metadata.gz: d772480091efff46c2b182b767967e47884f696e
+  data.tar.gz: 08e06bcd1d781492e44c9754e10f1fda21909eb8
 SHA512:
-  metadata.gz: 36178e2b41cc81aa640ef85ee83975e6b091cd650ca0b2fd53f4110ab3844306cbeb1ec63c378b4cf95ebb2e628c17a68d7ebc8dd07a95c3a4395a82713f0cb7
-  data.tar.gz: fadc37c301f92ee2b0ab8afe18df8660a771e1cfe4547be62c3ec99700d54b3f6f3e4fb076abee655c4d477ca224003d311dabcb1b8dfe6914d591d078416def
+  metadata.gz: a353035ed4598e473a23f3733a38143c2bc0a71252c7e091a5df08f2c1609defc743d78785ba67361b786d1289eff0e8d6758a61923d6589b70488845cf582eb
+  data.tar.gz: b497c3d94f55aee5dbbd3bedb64671a75f4c13fd2c60fb4103b7a1aad52c501b75dcaa6249087cb4fd1bad9d9b7ebf389d71ed437659d3923b01e2696e38cab3

data/.travis.yml

@@ -4,4 +4,8 @@ rvm:
 - 1.9.3
 - jruby
 before_install:
-  - gem install bundler
+- gem install bundler
+deploy:
+  provider: rubygems
+  api_key:
+    secure: NYRm2JAJY5zSehxYUDioKYidvU7QaGw0BtFqxo4wzdvQite7ZLOW4dtBiKv5kdFcpkUQhnrD2ilGkt3XhImqt4T20MA12JgZBZa17/vZHXN2bAkxkubx9Sqo7G4Rcip+x2vLZNlcJnaU76+91zBEyp9ts4jvljriANbUn4eFmuE=

data/Gemfile

@@ -2,3 +2,11 @@ source 'https://rubygems.org'
 
 # Specify your gem's dependencies in lookout-rack-test.gemspec
 gemspec
+
+# For local tests, pin dependencies for pre Ruby 2.X
+if RUBY_VERSION.start_with?("1")
+  gem "activesupport", "< 5"
+  gem "liquid", "< 4"
+elsif RUBY_VERSION =~ (/^2.[01]/)
+  gem "activesupport", "< 5"
+end

data/lib/lookout/rack/test/cucumber/general_steps.rb

@@ -16,12 +16,22 @@ When /^I (GET|PUT|POST|PATCH|DELETE)( to)? "([^"]*)" with:$/ do |verb, unused, u
   send(verb, render_string(url), options, headers)
 end
 
-When /^I (GET|PUT|POST|PATCH|DELETE) to "(.*?)" with the JSON:$/ do |verb, url, body|
+When /^I (GET|PUT|POST|PATCH) to "(.*?)" with the JSON:$/ do |verb, url, body|
   verb = verb.downcase.to_sym
   headers = template_vars['headers'] || {}
   send(verb, render_string(url), render_string(body), headers)
 end
 
+When /^I DELETE to "(.*?)" with the JSON:$/ do |url, body|
+  # Rack::Test lost the ability to provide a body for delete
+  # requests. Until https://github.com/rack-test/rack-test/issues/200
+  # is resolved, work around this
+  env = {:method => :delete,
+         :input => render_string(body),
+        }.merge(template_vars['headers'] || {})
+  request render_string(url), env
+end
+
 Then /^the response (should be|is) (\d+)$/ do |verb, code|
   expect(last_response.status).to eq(code), "expected #{code} got #{last_response.status} \n\n #{last_response.body}
 "
@@ -51,4 +61,4 @@ end
 When /^I (PUT|POST) a file to "(.*?)"$/ do |verb, url|
   verb = verb.downcase.to_sym
   send(verb, render_string(url), "some file", template_vars['headers'] || {})
-end
+end

data/lib/lookout/rack/test/load_factories.rb

@@ -1,5 +1,5 @@
 unless $factories_loaded
-  require 'factory_girl'
-  ::FactoryGirl.find_definitions
+  require 'factory_bot'
+  ::FactoryBot.find_definitions
   $factories_loaded = true
 end

data/lib/lookout/rack/test/rake/cucumber.rake

@@ -1,11 +1,6 @@
 require 'cucumber/rake/task'
 require 'ci/reporter/rake/cucumber'
 
-# parallel_tests is somewhat pointless/nonfunctional on JRuby
-unless RUBY_PLATFORM == 'java'
-  require 'parallel_tests/tasks'
-end
-
 namespace :cucumber do
   Cucumber::Rake::Task.new(:api) do |t|
     t.cucumber_opts = '--profile api'

data/lib/lookout/rack/test/rspec.rb

@@ -1,6 +1,7 @@
 require 'rspec'
 require 'rack/test'
 require 'timecop'
+require 'factory_bot'
 
 require 'lookout/rack/test'
 module Lookout::Rack::Test
@@ -19,29 +20,31 @@ module Lookout
         # .unsetup method
         def setup_models(models)
           ::RSpec.configure do |c|
+            c.include FactoryBot::Syntax::Methods
+
             c.around(:each, :speed => :slow) do |example|
               models.setup
               example.run
               models.unsetup
             end
-      
+
             c.before(:all, :speed => :slow) do
               require 'lookout/rack/test/load_factories'
             end
           end
         end
-  
+
         # Takes one argument, the application (e.g., SinatraApplication)
         def setup_routes(application)
           ::RSpec.configure do |c|
             c.include(::Rack::Test::Methods, :type => :route)
-  
+
             require 'lookout/rack/test/rspec/route_helper'
             ::Lookout::Rack::Test.app = application
             c.include(::RouteHelper, :type => :route)
           end
         end
-  
+
         def configure_rspec
           ::RSpec.configure do |c|
             c.around(:each, :timefreeze => true) do |example|

data/lib/lookout/rack/test/rspec/fake_request.rb

@@ -3,18 +3,18 @@ require 'rspec'
 module Lookout::Rack::Test::RSpec
   class FakeRequest
     attr_accessor :session, :env, :request
-    
+
     def initialize
       @session = {}
       @env = {}
       @request = Object.new
       @request.stub(:path_info).and_return('')
     end
-  
+
     def redirect(path, params={}); end # So we can catch calls to the redirect method
-  
+
     def halt(status, error_string); end
-  
+
     def to(url); url; end
   end
 end

data/lib/lookout/rack/test/version.rb

@@ -1,7 +1,7 @@
 module Lookout
   module Rack
     module Test
-      VERSION = "2.3.1"
+      VERSION = "3.0.0"
     end
   end
 end

data/lookout-rack-test.gemspec

@@ -32,7 +32,6 @@ Gem::Specification.new do |spec|
   # For freezing time inside of tests
   spec.add_dependency 'timecop'
   # Used to assist with scaffolded data and generating random data
-  spec.add_dependency 'factory_girl'
+  spec.add_dependency 'factory_bot'
   spec.add_dependency 'cucumber'
-  spec.add_dependency 'parallel_tests'
-end
+end

data/spec/factories/fake_request.rb

@@ -0,0 +1,4 @@
+FactoryBot.define do
+  factory :fake_request do
+  end
+end

data/spec/setup_spec.rb

@@ -24,12 +24,26 @@ describe ':speed => :slow' do
     it 'should have called .setup on the Models module' do
       expect(TestModels.was_setup?).to be true
     end
+
+    it 'loads factories' do
+      expect(FactoryBot.build(:fake_request)).not_to be_nil
+    end
   end
 
   context 'a test not marked as :speed => :slow' do
+    before do
+      # Unload factories in case they were loaded in 'loads factories' spec above.
+      FactoryBot.reset_configuration
+      FactoryBot.register_default_strategies
+    end
+
     it 'should not have called .setup on the Models module' do
       expect(TestModels.was_setup?).to be false
     end
+
+    it 'does not load factories' do
+      expect { FactoryBot.build(:fake_request) }.to raise_error(/Factory not registered/)
+    end
   end
 end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: lookout-rack-test
 version: !ruby/object:Gem::Version
-  version: 2.3.1
+  version: 3.0.0
 platform: ruby
 authors:
 - Ian Smith
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-02-03 00:00:00.000000000 Z
+date: 2017-10-31 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -151,7 +151,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: factory_girl
+  name: factory_bot
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -178,20 +178,6 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-- !ruby/object:Gem::Dependency
-  name: parallel_tests
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
 description: RSpec and Cucumber helpers
 email:
 - ian.smith@lookout.com
@@ -236,6 +222,7 @@ files:
 - lib/lookout/rack/test/rspec/route_helper.rb
 - lib/lookout/rack/test/version.rb
 - lookout-rack-test.gemspec
+- spec/factories/fake_request.rb
 - spec/model_examples_spec.rb
 - spec/setup_spec.rb
 - spec/spec_helper.rb
@@ -259,7 +246,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.5.1
+rubygems_version: 2.6.14
 signing_key: 
 specification_version: 4
 summary: ''
@@ -276,6 +263,7 @@ test_files:
 - features/step_definitions/timefreeze_steps.rb
 - features/support/env.rb
 - features/timefreeze.feature
+- spec/factories/fake_request.rb
 - spec/model_examples_spec.rb
 - spec/setup_spec.rb
 - spec/spec_helper.rb