lookbook 1.0.0.beta.5 → 1.0.0.beta.8

data/lib/lookbook/config.rb

@@ -6,14 +6,14 @@ module Lookbook
   class Config
     def initialize
       @options = Store.new
-      
+
       @options.set({
         project_name: "Lookbook",
         log_level: 2,
         auto_refresh: true,
 
         components_path: "app/components",
-        
+
         page_controller: "Lookbook::PageController",
         page_route: "pages",
         page_paths: ["test/components/docs"],
@@ -22,9 +22,9 @@ module Lookbook
 
         preview_paths: [],
         preview_display_params: {},
-        preview_options: {},
-        preview_srcdoc: false,
-        sort_examples: true,
+        preview_srcdoc: nil,
+        preview_tags: {},
+        sort_examples: false,
 
         listen: Rails.env.development?,
         listen_paths: [],
@@ -39,11 +39,12 @@ module Lookbook
 
         ui_theme: "indigo",
         ui_theme_overrides: {},
+        ui_favicon: true,
 
         hooks: {
           after_initialize: [],
           before_exit: [],
-          after_change: [],
+          after_change: []
         },
 
         debug_menu: Rails.env.development?,
@@ -57,7 +58,8 @@ module Lookbook
             partial: "lookbook/previews/panels/preview",
             hotkey: "v",
             panel_classes: "overflow-hidden",
-            padded: false
+            padded: false,
+            system: true
           },
           output: {
             pane: :main,
@@ -65,7 +67,8 @@ module Lookbook
             partial: "lookbook/previews/panels/output",
             label: "HTML",
             hotkey: "h",
-            padded: false
+            padded: false,
+            system: true
           },
           source: {
             pane: :drawer,
@@ -74,7 +77,8 @@ module Lookbook
             label: "Source",
             hotkey: "s",
             copy: ->(data) { data.examples.map { |e| e.source }.join("\n") },
-            padded: false
+            padded: false,
+            system: true
           },
           notes: {
             pane: :drawer,
@@ -83,7 +87,8 @@ module Lookbook
             label: "Notes",
             hotkey: "n",
             disabled: ->(data) { data.examples.select { |e| e.notes.present? }.none? },
-            padded: false
+            padded: false,
+            system: true
           },
           params: {
             pane: :drawer,
@@ -92,25 +97,10 @@ module Lookbook
             label: "Params",
             hotkey: "p",
             disabled: ->(data) { data.preview.params.none? },
-            padded: false
+            padded: false,
+            system: true
           }
-        },
-
-        inspector_panel_defaults: {
-          id: ->(data) { "inspector-panel-#{data.name}" },
-          partial: "lookbook/previews/panels/content",
-          content: nil,
-          label: ->(data) { data.name.titleize },
-          pane: :drawer,
-          position: ->(data) { data.index_position },
-          hotkey: nil,
-          disabled: false,
-          show: true,
-          copy: nil,
-          panel_classes: nil,
-          locals: {},
-          padded: true
-        },
+        }
       })
     end
 
@@ -122,22 +112,33 @@ module Lookbook
       absolute_path(@options.components_path)
     end
 
+    def page_paths=(paths = [])
+      @options.page_paths += paths if paths.is_a? Array
+    end
+
     def page_paths
       normalize_paths(@options.page_paths)
     end
 
+    def preview_paths=(paths = [])
+      @options.preview_paths += paths if paths.is_a? Array
+    end
+
     def preview_paths
       normalize_paths(@options.preview_paths)
     end
 
+    def preview_srcdoc=(enable)
+      Lookbook.logger.warn "The `preview_srcdoc` config option is deprecated and will be removed in v2.0"
+    end
+
     def listen_paths
       normalize_paths(@options.listen_paths)
     end
 
-    def listen_extensions
-      @options.listen_extensions += ["rb", "html.*"]
+    def listen_extensions=(extensions = [])
+      @options.listen_extensions += extensions if extensions.is_a? Array
       @options.listen_extensions.uniq!
-      @options.listen_extensions
     end
 
     def parser_registry_path
@@ -146,7 +147,7 @@ module Lookbook
 
     def inspector_panels(&block)
       panels = Store.new(@options.inspector_panels.select { |key, panel| panel != false })
-      if block_given?
+      if block
         yield panels
       else
         panels
@@ -154,16 +155,13 @@ module Lookbook
     end
 
     def define_inspector_panel(name, opts = {})
+      pane = opts[:pane].presence || :drawer
+      siblings = inspector_panels.select { |key, panel| panel.pane == pane }
+      opts[:position] ||= siblings.size + 1
       @options.inspector_panels[name] = opts
-      if opts[:position].present?
-        pane = inspector_panels[name].pane.presence || :drawer
-        siblings = inspector_panels.select do |key, panel|
-          panel.pane == pane && key != name.to_sym
-        end
-        siblings.each do |key, panel|
-          if panel.position >= opts[:position]
-            panel.position += 1
-          end
+      siblings.each do |key, panel|
+        if panel.position >= opts[:position]
+          panel.position += 1
         end
       end
     end
@@ -180,6 +178,24 @@ module Lookbook
       amend_inspector_panel(name, false)
     end
 
+    def inspector_panel_defaults
+      {
+        id: ->(data) { "inspector-panel-#{data.name}" },
+        partial: "lookbook/previews/panels/content",
+        content: nil,
+        label: ->(data) { data.name.titleize },
+        pane: :drawer,
+        position: ->(data) { data.index_position },
+        hotkey: nil,
+        disabled: false,
+        show: true,
+        copy: nil,
+        panel_classes: nil,
+        locals: {},
+        system: false
+      }
+    end
+
     def ui_theme=(name)
       name = name.to_s
       if Theme.valid_theme?(name)
@@ -190,7 +206,7 @@ module Lookbook
     end
 
     def ui_theme_overrides(&block)
-      if block_given?
+      if block
         yield @options.ui_theme_overrides
       else
         @options.ui_theme_overrides
@@ -221,12 +237,14 @@ module Lookbook
     def to_json(*a)
       to_h.to_json(*a)
     end
-    
+
     protected
 
     def normalize_paths(paths)
-      paths.map! { |path| absolute_path(path) }
-      paths.select! { |path| Dir.exist?(path) }
+      paths.map! do |path|
+        full_path = absolute_path(path)
+        full_path if Dir.exist?(full_path)
+      end.compact!
       paths
     end
 
@@ -237,5 +255,9 @@ module Lookbook
     def method_missing(name, *args)
       @options.send(name, *args)
     end
+
+    def respond_to_missing?(name, *)
+      to_h.key? name
+    end
   end
-end
+end

data/lib/lookbook/data.rb

@@ -0,0 +1,11 @@
+module Lookbook
+  module Data
+    def data
+      @data ||= Store.new
+    end
+
+    def data=(props)
+      @data = Store.new(props)
+    end
+  end
+end

data/lib/lookbook/engine.rb

@@ -2,12 +2,21 @@ require "rails"
 require "view_component"
 require "action_cable/engine"
 require "listen"
+require "rake"
 
 module Lookbook
-
   autoload :Config, "lookbook/config"
-  
+  autoload :Data, "lookbook/data"
+  autoload :Hooks, "lookbook/hooks"
+  autoload :Panels, "lookbook/panels"
+  autoload :Tags, "lookbook/tags"
+
   class << self
+    include Lookbook::Data
+    include Lookbook::Hooks
+    include Lookbook::Panels
+    include Lookbook::Tags
+
     def version
       Lookbook::VERSION
     end
@@ -48,38 +57,12 @@ module Lookbook
       Page.any?
     end
 
-    def after_initialize(&block)
-      add_hook(:after_initialize, block)
-    end
-
-    def before_exit(&block)
-      add_hook(:before_exit, block)
-    end
-
-    def after_change(&block)
-      add_hook(:after_change, block)
-    end
-
-    def define_panel(name, opts = {})
-      config.define_inspector_panel(name, opts)
-    end
-
-    def amend_panel(name, opts = {})
-      config.amend_inspector_panel(name, opts)
-    end
-
-    def remove_panel(name)
-      config.remove_inspector_panel(name)
-    end
-
     def broadcast(event_name, data = {})
       Engine.websocket&.broadcast(event_name.to_s, data)
     end
 
-    protected
-
-    def add_hook(event_name, block)
-      config.hooks[event_name] << block
+    def theme
+      @theme ||= Lookbook::Theme.new(config.ui_theme, config.ui_theme_overrides)
     end
   end
 
@@ -89,14 +72,14 @@ module Lookbook
     config.lookbook = Lookbook.config
     config.autoload_paths << File.expand_path(Lookbook::Engine.root.join("app/components"))
 
-    initializer "lookbook.viewcomponent.config" do      
+    initializer "lookbook.viewcomponent.config" do
       config.lookbook.preview_paths += config.view_component.preview_paths
       config.lookbook.preview_controller ||= config.view_component.preview_controller
 
       config.lookbook.components_path = config.view_component.view_component_path if config.view_component.view_component_path.present?
 
       config.lookbook.listen_paths += config.lookbook.preview_paths
-      config.lookbook.listen_paths << config.lookbook.components_path 
+      config.lookbook.listen_paths << config.lookbook.components_path
     end
 
     initializer "lookbook.logging.development" do
@@ -104,7 +87,7 @@ module Lookbook
     end
 
     initializer "lookbook.parser.tags" do
-      Lookbook::Parser.define_tags
+      Lookbook::Parser.define_tags(Lookbook.config.preview_tags)
     end
 
     initializer "lookbook.assets.serve" do
@@ -118,39 +101,20 @@ module Lookbook
       @preview_controller = Lookbook.config.preview_controller.constantize
       @preview_controller.include(Lookbook::PreviewController)
 
-      if config.lookbook.listen
-        Listen.logger = Lookbook.logger
-        
-        preview_listener = Listen.to(
-          *config.lookbook.listen_paths,
-          only: /\.(#{config.lookbook.listen_extensions.join("|")})$/,
-          force_polling: config.lookbook.listen_use_polling
-        ) do |modified, added, removed|
-          changes = { modified: modified, added: added, removed: removed }
-          begin
-            parser.parse
-          rescue
-          end
-          Lookbook::Preview.clear_cache
-          Lookbook::Engine.reload_ui(changes)
-          Lookbook::Engine.run_hooks(:after_change, changes)
+      if Gem::Version.new(Rails.version) >= Gem::Version.new("6.1.3.1")
+        # Rails.application.server is only available for newer Rails versions
+        Rails.application.server do
+          init_listeners
         end
-        Lookbook::Engine.register_listener(preview_listener)
-
-        page_listener = Listen.to(
-          *config.lookbook.page_paths,
-          only: /\.(html.*|md.*)$/,
-          force_polling: config.lookbook.listen_use_polling
-        ) do |modified, added, removed|
-          changes = { modified: modified, added: added, removed: removed }
-          Lookbook::Engine.reload_ui(changes)
-          Lookbook::Engine.run_hooks(:after_change, changes)
+      else
+        # Fallback for older Rails versions - don't start listeners if running in a rake task.
+        unless File.basename($0) == "rake" || Rake.application.top_level_tasks.any?
+          init_listeners
         end
-        Lookbook::Engine.register_listener(page_listener)
       end
 
       if config.lookbook.runtime_parsing
-        parser.parse
+        Lookbook::Engine.parser.parse
       else
         unless File.exist?(config.lookbook.parser_registry_path)
           Lookbook.logger.warn "
@@ -164,16 +128,48 @@ module Lookbook
       Lookbook::Engine.run_hooks(:after_initialize)
     end
 
+    def init_listeners
+      return unless config.lookbook.listen == true
+      Listen.logger = Lookbook.logger
+      Lookbook.logger.info "Initializing listeners"
+
+      preview_listener = Listen.to(
+        *config.lookbook.listen_paths,
+        only: /\.(#{config.lookbook.listen_extensions.join("|")})$/,
+        force_polling: config.lookbook.listen_use_polling
+      ) do |modified, added, removed|
+        changes = {modified: modified, added: added, removed: removed}
+        begin
+          Lookbook::Engine.parser.parse
+        rescue
+        end
+        Lookbook::Preview.clear_cache
+        Lookbook::Engine.reload_ui(changes)
+        Lookbook::Engine.run_hooks(:after_change, changes)
+      end
+      Lookbook::Engine.register_listener(preview_listener)
+
+      page_listener = Listen.to(
+        *config.lookbook.page_paths,
+        only: /\.(html.*|md.*)$/,
+        force_polling: config.lookbook.listen_use_polling
+      ) do |modified, added, removed|
+        changes = {modified: modified, added: added, removed: removed}
+        Lookbook::Engine.reload_ui(changes)
+        Lookbook::Engine.run_hooks(:after_change, changes)
+      end
+      Lookbook::Engine.register_listener(page_listener)
+    end
+
     at_exit do
-      if config.lookbook.listen
+      if Lookbook::Engine.listeners.any?
         Lookbook.logger.debug "Stopping listeners"
-        Lookbook::Engine.listeners.each { |listener| listener.stop } 
+        Lookbook::Engine.listeners.each { |listener| listener.stop }
       end
       Lookbook::Engine.run_hooks(:before_exit)
     end
 
     class << self
-
       def websocket
         return @websocket unless @websocket.nil?
         if config.lookbook.auto_refresh
@@ -186,9 +182,9 @@ module Lookbook
           @websocket ||= if Rails.version.to_f >= 6.0
             ActionCable::Server::Base.new(config: cable)
           else
-            @websocket ||= ActionCable::Server::Base.new
-            @websocket.config = cable
-            @websocket
+            ws = ActionCable::Server::Base.new
+            ws.config = cable
+            ws
           end
         end
       end
@@ -223,7 +219,7 @@ module Lookbook
       end
 
       def run_hooks(event_name, *args)
-        Lookbook.config.hooks[event_name].each do |hook|
+        config.lookbook.hooks[event_name].each do |hook|
           hook.call(Lookbook, *args)
         end
       end

data/lib/lookbook/entity.rb

@@ -44,4 +44,4 @@ module Lookbook
 
     alias_method :url_path, :lookup_path
   end
-end
+end

data/lib/lookbook/hooks.rb

@@ -0,0 +1,21 @@
+module Lookbook
+  module Hooks
+    def after_initialize(&block)
+      add_hook(:after_initialize, block)
+    end
+
+    def before_exit(&block)
+      add_hook(:before_exit, block)
+    end
+
+    def after_change(&block)
+      add_hook(:after_change, block)
+    end
+
+    protected
+
+    def add_hook(event_name, block)
+      Lookbook.config.hooks[event_name] << block
+    end
+  end
+end

data/lib/lookbook/markdown.rb

@@ -13,7 +13,7 @@ module Lookbook
     }
 
     def self.render(text)
-      text&.gsub!(/\<\!\-\- (BEGIN|END) (.*) \-\-\>/, "")
+      text&.gsub!(/<!-- (BEGIN|END) (.*) -->/, "")
       markdown = Redcarpet::Markdown.new(Renderer, Lookbook.config.markdown_options)
       markdown.render(text).html_safe
     end

data/lib/lookbook/page.rb

@@ -1,6 +1,5 @@
 module Lookbook
   class Page < Entity
-
     FRONTMATTER_FIELDS = [
       :id,
       :label,
@@ -76,7 +75,7 @@ module Lookbook
     def type
       :page
     end
-    
+
     def id
       options[:id]
     end
@@ -125,7 +124,7 @@ module Lookbook
         }))
       end
       @options = Lookbook.config.page_options.deep_merge(frontmatter).with_indifferent_access
-      @options[:id] = @options[:id] ? generate_id(@options[:id]) : generate_id(lookup_path)
+      @options[:id] = generate_id(@options[:id] || lookup_path)
       @options[:label] ||= name.titleize
       @options[:title] ||= @options[:label]
       @options[:hidden] ||= false
@@ -159,7 +158,7 @@ module Lookbook
       end
 
       def all
-         pages, sections =
+        pages, sections =
           Array(page_paths).flat_map do |dir|
             Dir["#{dir}/**/*.html.*", "#{dir}/**/*.md.*"].sort.map do |path|
               create(path, dir)
@@ -172,7 +171,7 @@ module Lookbook
 
         page_dict = sorted_pages.index_by(&:path)
         sorted_sections = sections.sort_by { |section| [section.position, section.label] }
-        
+
         sorted_sections.each do |section|
           page_dict[section.path].sections << section
         end

data/lib/lookbook/page_section.rb

@@ -1,6 +1,5 @@
 module Lookbook
   class PageSection < Page
-
     def name
       return @name if @name.present?
       matches = full_path.to_s.match(%r{\[(?<name>\w+)\]})
@@ -24,8 +23,7 @@ module Lookbook
     end
 
     def lookup_path
-       "#{super}/#{name}"
+      "#{super}/#{name}"
     end
-
   end
-end
+end

data/lib/lookbook/panels.rb

@@ -0,0 +1,15 @@
+module Lookbook
+  module Panels
+    def define_panel(name, opts = {})
+      Lookbook.config.define_inspector_panel(name, opts)
+    end
+
+    def amend_panel(name, opts = {})
+      Lookbook.amend_inspector_panel(name, opts)
+    end
+
+    def remove_panel(name)
+      Lookbook.remove_inspector_panel(name)
+    end
+  end
+end

data/lib/lookbook/params.rb

@@ -63,6 +63,14 @@ module Lookbook
             result = []
           end
           result
+        when "datetime"
+          begin
+            result = DateTime.parse(value)
+          rescue Date::Error
+            Lookbook.logger.debug "Failed to parse '#{value}' into a DateTime"
+            result = DateTime.now
+          end
+          result
         else
           begin
             type_class = "ActiveModel::Type::#{type}".constantize
@@ -92,6 +100,8 @@ module Lookbook
           "Boolean"
         elsif default.is_a? Symbol
           "Symbol"
+        elsif ["date", "datetime-local"].include?(input&.downcase) || default.is_a?(DateTime)
+          "DateTime"
         else
           "String"
         end
@@ -99,6 +109,8 @@ module Lookbook
 
       def input_text?(input)
         [
+          "date",
+          "datetime-local",
           "email",
           "number",
           "tel",

data/lib/lookbook/parser.rb

@@ -24,13 +24,16 @@ module Lookbook
     end
 
     class << self
-      def define_tags
+      def define_tags(custom = {})
         YARD::Tags::Library.define_tag("Hidden status", :hidden)
         YARD::Tags::Library.define_tag("Label", :label)
         YARD::Tags::Library.define_tag("Display", :display)
         YARD::Tags::Library.define_tag("Position", :position)
         YARD::Tags::Library.define_tag("ID", :id)
         YARD::Tags::Library.define_tag("Component", :component)
+        custom.each do |name, opts|
+          YARD::Tags::Library.define_tag(name.to_s.titleize, name)
+        end
       end
     end
   end

data/lib/lookbook/preview.rb

@@ -3,7 +3,7 @@ module Lookbook
     include Utils
 
     delegate :name, :render_args, to: :@preview
-    delegate :position, :group, :notes, :hidden?, to: :@preview_inspector
+    delegate :position, :group, :notes, :hidden?, :tags, :tag, to: :@preview_inspector
 
     def initialize(preview)
       @preview = preview
@@ -97,7 +97,7 @@ module Lookbook
     end
 
     def components
-      component_classes = @preview_inspector&.components.any? ? @preview_inspector&.components : [guess_component]
+      component_classes = @preview_inspector&.components&.any? ? @preview_inspector&.components : [guess_component]
       component_classes.map do |class_name|
         Component.new(class_name.to_s)
       end
@@ -106,11 +106,9 @@ module Lookbook
     protected
 
     def guess_component
-      begin
-        name.chomp("Preview").constantize
-      rescue
-        nil
-      end
+      name.chomp("Preview").constantize
+    rescue
+      nil
     end
 
     class << self
@@ -156,7 +154,7 @@ module Lookbook
 
       def clear_cache
         cache_dir = File.dirname(cache_marker_path)
-        FileUtils.mkdir_p(cache_dir) unless File.exists?(cache_dir)
+        FileUtils.mkdir_p(cache_dir) unless File.exist?(cache_dir)
         File.write(cache_marker_path, Time.now.to_i)
       end
 
@@ -167,7 +165,7 @@ module Lookbook
       end
 
       def cache_stale?
-        return false if !File.exists?(cache_marker_path)
+        return false if !File.exist?(cache_marker_path)
         cache_timestamp = File.read(cache_marker_path).to_i
         if @last_cache_timestamp.nil? || cache_timestamp > @last_cache_timestamp
           @last_cache_timestamp = cache_timestamp
@@ -179,7 +177,7 @@ module Lookbook
 
       def mark_as_cached
         cache_dir = File.dirname(cache_marker_path)
-        FileUtils.mkdir_p(cache_dir) unless File.exists?(cache_dir)
+        FileUtils.mkdir_p(cache_dir) unless File.exist?(cache_dir)
         File.write(cache_marker_path, Time.now)
       end
 
@@ -196,7 +194,7 @@ module Lookbook
           )
         end
       end
-    
+
       def preview_files
         files = Array(Lookbook.config.preview_paths).map do |preview_path|
           Dir["#{preview_path}/**/*preview.rb"].map do |path|