lono 5.3.0 → 5.3.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 805088c405e44e3e7b228f5d03a893af2a99c2ce990615bb89b906c0c2bb56ee
-  data.tar.gz: fff83f7bdae3c28fed272a489e3170d09f803d35a05e943b98db33c89e5d7a9e
+  metadata.gz: ab8f59278665a11fa19fb70dfbb8959271156d79cede05f67acd56ef12b7b8c5
+  data.tar.gz: 640cc60f99dc42503b7f583384fc2700ea12ce720cf76f1e6203ef05ba753e88
 SHA512:
-  metadata.gz: bd70ed81d8e4495dff371cd2ec66b519b1002325dac0d17d094a31127ea4e9d186a00001200391f36b9dcece8f85b25f085abeb09c49eedc1f269be457113ad0
-  data.tar.gz: 9bb60f3efa20a1c06a0597656f0729e1723380c2af6b20f673f28f4b08fe2ac941876e3252f405864bd488b989b5d7436ce3dad50b65bb059bf51371751b0290
+  metadata.gz: 27cf1a8a766adf340f9c57c68b4d0870037c53bd281c4fe444923a4df5727dc994773b98f2ded35982a432eaf8a70b6072a84dbd61ea529f86c5b6ad8b06062e
+  data.tar.gz: 944c85c1bb31cc3e1fd0682934aeb4302d85b1c832b0450ca3211901e00173f53d268f5746a3abd4324d86ebee0b81dd698cfbe4e02e94b6def8d0b027787575

data/CHANGELOG.md

@@ -3,6 +3,9 @@
 All notable changes to this project will be documented in this file.
 This project *tries* to adhere to [Semantic Versioning](http://semver.org/), even before v1.0.
 
+## [5.3.1]
+- #10 fixes for param diff preview: Ignore noecho parameters
+
 ## [5.3.0]
 - #8 param preview feature. 3rd type of preview.
 - #9 ssm helper support in configs

data/lib/lono/cfn/preview/param.rb

@@ -15,28 +15,38 @@ module Lono::Cfn::Preview
         return
       end
 
-      params = generate_all
-      write_to_tmp(new_path, params)
       write_to_tmp(existing_path, existing_parameters)
+      write_to_tmp(new_path, new_parameters)
 
       show_diff(existing_path, new_path)
     end
 
+    def new_parameters
+      params = generate_all
+      params.reject { |p| ignore_parameters.include?(p[:parameter_key]) }
+    end
+
     def existing_parameters
-      resp = cfn.describe_stacks(stack_name: @stack_name)
-      stack = resp.stacks.first
-      parameters = stack.parameters
+      existing = stack_parameters
+      existing = existing.reject { |p| ignore_parameters.include?(p.parameter_key) }
+      convert_to_cfn_format(existing)
+    end
 
+    def ignore_parameters
       # Remove optional parameters if they match already. Produces better diff.
-      optional = optional_parameters.map do |logical_id, attributes|
-        {
-          "ParameterKey" => logical_id,
-          "ParameterValue" => attributes["Default"],
-        }
-      end
-      converted = convert_to_cfn_format(parameters)
-      converted - optional
+      optional = optional_parameters.map { |logical_id, attributes| logical_id }
+      noecho = stack_parameters.select { |p| p.parameter_value == '****' }
+      noecho = noecho.map { |p| p.parameter_key }
+      optional + noecho
+    end
+    memoize :ignore_parameters
+
+    def stack_parameters
+      resp = cfn.describe_stacks(stack_name: @stack_name)
+      stack = resp.stacks.first
+      stack.parameters
     end
+    memoize :stack_parameters
 
   private
     def output_template

data/lib/lono/output_template.rb

@@ -20,11 +20,11 @@ module Lono
     end
 
     def required_parameters
-      parameters.reject { |logical_id, p| p["Default"] }
+      parameters.reject { |logical_id, p| p["Default"].nil? }
     end
 
     def optional_parameters
-      parameters.select { |logical_id, p| p["Default"] }
+      parameters.select { |logical_id, p| !p["Default"].nil? }
     end
 
     def parameters

data/lib/lono/version.rb

@@ -1,3 +1,3 @@
 module Lono
-  VERSION = "5.3.0"
+  VERSION = "5.3.1"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: lono
 version: !ruby/object:Gem::Version
-  version: 5.3.0
+  version: 5.3.1
 platform: ruby
 authors:
 - Tung Nguyen
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2019-11-23 00:00:00.000000000 Z
+date: 2019-11-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport