lono 4.2.7 → 5.0.1

data/lib/lono/cfn/create.rb

@@ -1,40 +1,44 @@
 require "yaml"
 
-class Lono::Cfn::Create < Lono::Cfn::Base
-  # save_stack is the interface method
-  def save_stack(params)
-    create_stack(params)
-  end
-
-  # aws cloudformation create-stack --stack-name prod-hi-123456789 --parameters file://output/params/prod-hi-123456789.json --template-body file://output/prod-hi.json
-  def create_stack(params)
-    message = "Creating #{@stack_name.color(:green)} stack."
-    if @options[:noop]
-      puts "NOOP #{message}"
-      return
+class Lono::Cfn
+  class Create < Base
+    # save_stack is the interface method
+    def save_stack(params)
+      create_stack(params)
     end
 
-    if stack_exists?(@stack_name)
-      puts "Cannot create #{@stack_name.color(:green)} stack because it already exists.".color(:red)
-      return
-    end
+    # aws cloudformation create-stack --stack-name prod-hi-123456789 --parameters file://output/params/prod-hi-123456789.json --template-body file://output/prod-hi.json
+    def create_stack(params)
+      message = "Creating #{@stack_name.color(:green)} stack."
+      if @options[:noop]
+        puts "NOOP #{message}"
+        return
+      end
 
-    unless File.exist?(@template_path)
-      puts "Cannot create #{@stack_name.color(:green)} template not found: #{@template_path}."
-      return
-    end
+      delete_rollback_stack
 
-    params = {
-      stack_name: @stack_name,
-      parameters: params,
-      capabilities: capabilities, # ["CAPABILITY_IAM", "CAPABILITY_NAMED_IAM"]
-      disable_rollback: !@options[:rollback],
-      tags: tags,
-    }
-    set_template_body!(params)
+      if stack_exists?(@stack_name)
+        puts "Cannot create #{@stack_name.color(:green)} stack because it already exists.".color(:red)
+        return
+      end
 
-    show_parameters(params, "cfn.create_stack")
-    cfn.create_stack(params)
-    puts message unless @options[:mute]
+      unless File.exist?(@template_path)
+        puts "Cannot create #{@stack_name.color(:green)} template not found: #{@template_path}."
+        return
+      end
+
+      params = {
+        stack_name: @stack_name,
+        parameters: params,
+        capabilities: capabilities, # ["CAPABILITY_IAM", "CAPABILITY_NAMED_IAM"]
+        disable_rollback: !@options[:rollback],
+      }
+      params[:tags] = tags unless tags.empty?
+      set_template_body!(params)
+
+      show_parameters(params, "cfn.create_stack")
+      cfn.create_stack(params) # TODO: COMMENT OUT FOR TESTING
+      puts message unless @options[:mute]
+    end
   end
-end
+end

data/lib/lono/cfn/current.rb

@@ -3,7 +3,7 @@ require "yaml"
 class Lono::Cfn
   class Current
     def initialize(options={})
-      Lono::ProjectChecker.check_lono_project
+      Lono::ProjectChecker.check
       @options = options
       @file = ".lono/current"
       @path = "#{Lono.root}/#{@file}"

data/lib/lono/cfn/delete.rb

@@ -1,5 +1,5 @@
 class Lono::Cfn::Delete
-  include Lono::Cfn::AwsService
+  include Lono::AwsServices
   include Lono::Cfn::Util
 
   def initialize(stack_name, options={})
@@ -30,7 +30,7 @@ class Lono::Cfn::Delete
   end
 
   def status
-    @status ||= Lono::Cfn::Status.new(@stack_name)
+    @status ||= Cfn::Status.new(@stack_name)
   end
 
   def switch_current(stack_name)

data/lib/lono/cfn/deploy.rb

@@ -0,0 +1,11 @@
+class Lono::Cfn
+  class Deploy < Base
+    def save_stack(params)
+      if stack_exists?(@stack_name)
+        Update.new(@stack_name, @options).update_stack(params)
+      else
+        Create.new(@stack_name, @options).create_stack(params)
+      end
+    end
+  end
+end

data/lib/lono/cfn/diff.rb

@@ -1,5 +1,5 @@
 class Lono::Cfn::Diff < Lono::Cfn::Base
-  include Lono::Cfn::AwsService
+  include Lono::AwsServices
 
   def run
     unless stack_exists?(@stack_name)

data/lib/lono/cfn/preview.rb

@@ -27,8 +27,8 @@ class Lono::Cfn::Preview < Lono::Cfn::Base
       stack_name: @stack_name,
       parameters: params,
       capabilities: capabilities, # ["CAPABILITY_IAM", "CAPABILITY_NAMED_IAM"],
-      tags: tags,
     }
+    params[:tags] = tags unless tags.empty?
     set_template_body!(params)
     show_parameters(params, "cfn.create_change_set")
     begin
@@ -74,9 +74,9 @@ class Lono::Cfn::Preview < Lono::Cfn::Base
         display_change(change)
       end
     when "FAILED"
-      puts "Fail to create a CloudFormation preview for '#{@stack_name}' stack update. Reason:".color(:red)
+      puts "WARN: Fail to create a CloudFormation preview for '#{@stack_name}' stack update. Reason:".color(:yellow)
       puts change_set.status_reason
-      quit(1)
+      quit(0)
     else
       raise "hell: never come here"
     end

data/lib/lono/cfn/rollback.rb

@@ -0,0 +1,26 @@
+class Lono::Cfn
+  class Rollback
+    extend Memoist
+    include Lono::AwsServices
+
+    def initialize(stack_name)
+      @stack_name = stack_name
+    end
+
+    def delete_stack
+      stack = find_stack(@stack_name)
+      if stack && rollback_complete?(stack)
+        puts "Existing stack in ROLLBACK_COMPLETE state. Deleting stack before continuing."
+        cfn.delete_stack(stack_name: @stack_name)
+        status.wait
+        status.reset
+        true
+      end
+    end
+
+    def status
+      Cfn::Status.new(@stack_name)
+    end
+    memoize :status
+  end
+end

data/lib/lono/cfn/status.rb

@@ -1,213 +1,12 @@
 class Lono::Cfn
-  class Status
-    include AwsService
-
-    attr_reader :events
+  class Status < ::Cfn::Status
     def initialize(stack_name, options={})
+      super
       @stack_name = switch_current(stack_name)
-      @options = options
-      reset
-    end
-
-    # used for the lono cfn status command
-    def run
-      unless stack_exists?(@stack_name)
-        puts "The stack #{@stack_name.color(:green)} does not exist."
-        return
-      end
-
-      resp = cfn.describe_stacks(stack_name: @stack_name)
-      stack = resp.stacks.first
-
-      puts "The current status for the stack #{@stack_name.color(:green)} is #{stack.stack_status.color(:green)}"
-      if stack.stack_status =~ /_IN_PROGRESS$/
-        puts "Stack events (tailing):"
-        # tail all events until done
-        @hide_time_took = true
-        wait
-      else
-        puts "Stack events:"
-        # show the last events that was user initiated
-        refresh_events
-        show_events(true)
-      end
     end
 
     def switch_current(stack_name)
       Lono::Cfn::Current.name!(stack_name)
     end
-
-    def reset
-      @events = [] # constantly replaced with recent events
-      @last_shown_event_id = nil
-      @stack_deletion_completed = nil
-    end
-
-    # check for /(_COMPLETE|_FAILED)$/ status
-    def wait
-      puts "Waiting for stack to complete"
-      start_time = Time.now
-
-      refresh_events
-      until completed || @stack_deletion_completed
-        show_events
-      end
-      show_events(true) # show the final event
-
-      if @stack_deletion_completed
-        puts "Stack #{@stack_name} deleted."
-        return
-      end
-
-      if last_event_status =~ /_FAILED/
-        puts "Stack failed: #{last_event_status}".color(:red)
-        puts "Stack reason #{@events[0]["resource_status_reason"]}".color(:red)
-      elsif last_event_status =~ /_ROLLBACK_/
-        puts "Stack rolled back: #{last_event_status}".color(:red)
-      else # success
-        puts "Stack success status: #{last_event_status}".color(:green)
-      end
-
-      # Never gets here when deleting a stack because the describe stack returns nothing
-      # once the stack is deleted. Gets here for stack create and update though.
-      return if @hide_time_took # set in run
-      took = Time.now - start_time
-      puts "Time took for stack deployment: #{pretty_time(took).color(:green)}."
-    end
-
-    def completed
-      last_event_status =~ /(_COMPLETE|_FAILED)$/ &&
-      @events[0]["logical_resource_id"] == @stack_name &&
-      @events[0]["resource_type"] == "AWS::CloudFormation::Stack"
-    end
-
-    def last_event_status
-      @events[0]["resource_status"]
-    end
-
-    # Only shows new events
-    def show_events(final=false)
-      if @last_shown_event_id.nil?
-        i = find_index(:start)
-        print_events(i)
-      else
-        i = find_index(:last_shown)
-        # puts "last_shown index #{i}"
-        print_events(i-1) unless i == 0
-      end
-
-      return if final
-      sleep 5 unless ENV['TEST']
-      refresh_events
-    end
-
-    def print_events(i)
-      @events[0..i].reverse.each do |e|
-        print_event(e)
-      end
-      @last_shown_event_id = @events[0]["event_id"]
-      # puts "@last_shown_event_id #{@last_shown_event_id.inspect}"
-    end
-
-    def print_event(e)
-      message = [
-        event_time(e["timestamp"]),
-        e["resource_status"],
-        e["resource_type"],
-        e["logical_resource_id"],
-        e["resource_status_reason"]
-      ].join(" ")
-      message = message.color(:red) if e["resource_status"] =~ /_FAILED/
-      puts message
-    end
-
-    # https://stackoverflow.com/questions/18000432/rails-12-hour-am-pm-range-for-a-day
-    def event_time(timestamp)
-      Time.parse(timestamp.to_s).localtime.strftime("%I:%M:%S%p")
-    end
-
-    # refreshes the loaded events in memory
-    def refresh_events
-      resp = cfn.describe_stack_events(stack_name: @stack_name)
-      @events = resp["stack_events"]
-    rescue Aws::CloudFormation::Errors::ValidationError => e
-      if e.message =~ /Stack .* does not exis/
-        @stack_deletion_completed = true
-      else
-        raise
-      end
-    end
-
-    def find_index(name)
-      send("#{name}_index")
-    end
-
-    def start_index
-      @events.find_index do |event|
-        event["resource_type"] == "AWS::CloudFormation::Stack" &&
-        event["resource_status_reason"] == "User Initiated"
-      end
-    end
-
-    def last_shown_index
-      @events.find_index do |event|
-        event["event_id"] == @last_shown_event_id
-      end
-    end
-
-    def success?
-      resource_status = @events[0]["resource_status"]
-      %w[CREATE_COMPLETE UPDATE_COMPLETE].include?(resource_status)
-    end
-
-    def update_rollback?
-      @events[0]["resource_status"] == "UPDATE_ROLLBACK_COMPLETE"
-    end
-
-    def find_update_failed_event
-      i = @events.find_index do |event|
-        event["resource_type"] == "AWS::CloudFormation::Stack" &&
-        event["resource_status_reason"] == "User Initiated"
-      end
-
-      @events[0..i].reverse.find do |e|
-        e["resource_status"] == "UPDATE_FAILED"
-      end
-    end
-
-    def rollback_error_message
-      return unless update_rollback?
-
-      event = find_update_failed_event
-      return unless event
-
-      reason = event["resource_status_reason"]
-      messages_map.each do |pattern, message|
-        if reason =~ pattern
-          return message
-        end
-      end
-
-      reason # default message is original reason if not found in messages map
-    end
-
-    def messages_map
-      {
-        /CloudFormation cannot update a stack when a custom-named resource requires replacing/ => "A workaround is to run ufo again with STATIC_NAME=0 and to switch to dynamic names for resources. Then run ufo again with STATIC_NAME=1 to get back to statically name resources. Note, there are caveats with the workaround.",
-        /cannot be associated with more than one load balancer/ => "There's was an issue updating the stack. Target groups can only be associated with one load balancer at a time. The workaround for this is to use UFO_FORCE_TARGET_GROUP=1 and run the command again. This will force the recreation of the target group resource.",
-        /SetSubnets is not supported for load balancers of type/ => "Changing subnets for Network Load Balancers is currently not supported. You can try workarouding this with UFO_FORCE_ELB=1 and run the command again. This will force the recreation of the elb resource."
-      }
-    end
-
-    # http://stackoverflow.com/questions/4175733/convert-duration-to-hoursminutesseconds-or-similar-in-rails-3-or-ruby
-    def pretty_time(total_seconds)
-      minutes = (total_seconds / 60) % 60
-      seconds = total_seconds % 60
-      if total_seconds < 60
-        "#{seconds.to_i}s"
-      else
-        "#{minutes.to_i}m #{seconds.to_i}s"
-      end
-    end
   end
 end

data/lib/lono/cfn/suffix.rb

@@ -0,0 +1,67 @@
+class Lono::Cfn
+  module Suffix
+    # Appends a short suffix at the end of a stack name.
+    # Lono internally strips this same suffix for the template name.
+    # Makes it convenient for the development flow.
+    #
+    #   lono cfn current --suffix 1
+    #   lono cfn create demo => demo-1
+    #   lono cfn update demo-1
+    #
+    # Instead of typing:
+    #
+    #   lono cfn create demo-1 --template demo
+    #   lono cfn update demo-1 --template demo
+    #
+    # The suffix can be specified at the CLI but can also be saved as a
+    # preference.
+    #
+    # A random suffix can be specified with random. Example:
+    #
+    #   lono cfn current --suffix random
+    #   lono cfn create demo => demo-[RANDOM], example: demo-abc
+    #   lono cfn update demo-abc
+    #
+    # It is not a default setting because it might confuse new lono users.
+    @@append_suffix = nil
+    def append_suffix(stack_name)
+      return @@append_suffix if @@append_suffix
+      return stack_name unless allow_suffix?
+
+      suffix ||= stack_name_suffix == 'random' ? random_suffix : stack_name_suffix
+      @@append_suffix = [stack_name, suffix].compact.join('-')
+    end
+
+    def remove_suffix(stack_name)
+      return stack_name unless allow_suffix?
+      return stack_name unless stack_name_suffix
+
+      if stack_name_suffix == 'random'
+        stack_name.sub(/-(\w{3})$/,'') # strip the random suffix at the end
+      elsif stack_name_suffix
+        pattern = Regexp.new("-#{stack_name_suffix}$",'')
+        stack_name.sub(pattern, '') # strip suffix
+      else
+        stack_name
+      end
+    end
+
+    def allow_suffix?
+      %w[Lono::Cfn::Create Lono::Cfn::Deploy].include?(self.class.to_s)
+    end
+
+    # only generate random suffix for Create class
+    def random_suffix
+      return nil unless allow_suffix?
+      (0...3).map { (65 + rand(26)).chr }.join.downcase # Ex: jhx
+    end
+
+    def stack_name_suffix
+      if @options[:suffix] && !@options[:suffix].nil?
+        return @options[:suffix] # CLI option takes highest precedence
+      end
+
+      Lono.suffix # core.rb accounts for LONO_SUFFIX env variable, current, and settings
+    end
+  end
+end