lonely_planet_tours 1.0.3 → 1.1.0

data/spec/lonelyplanet_spec.rb

@@ -9,30 +9,49 @@ require 'webmock/minitest'
 require './lib/lonely_planet/lonelyplanet_scrap'
 require './spec/support/vcr_setup'
 
-tours_from_file = YAML.load(File.read('./spec/tours.yml'))
-
-VCR.use_cassette('taiwan_tours') do
+VCR.use_cassette('taiwan_tours_json') do
   obj = LonelyPlanetScrape::LonelyPlanetTours.new('taiwan')
   tours_found = JSON.parse(obj.tours) if !obj.tours.nil?
 
-  describe 'Check for difference between returned results and actual data and possibly HTML structure changes' do
+  describe 'Validate structure of result' do
+
+    0.upto(tours_found.length - 1) do |index|
+    
+
+    it 'check if title exist and is not empty' do
+      
+      refute_nil tours_found[index]['title'], "Expect Tittle not nil value for Object #{index}"
+      refute_empty tours_found[index]['title'], "Expect Tittle not empty value for Object #{index}"
+    end
 
-    it 'check if the number of taiwan tours has changed' do
-      tours_found.size.must_equal tours_from_file.size
+    it 'check if content exist and is not empty' do
+      
+      refute_nil tours_found[index]['content'], "Expect description not nil for Object #{index}"
+      refute_empty tours_found[index]['content'], "Expect description not value for Object #{index}"
     end
 
-    0.upto(tours_from_file.length - 1) do |index|
-    it 'check for price changes' do
-      tours_from_file[index]['price'].must_equal tours_found[index]['price']
+    it 'check if location exist and is not empty' do
+      
+      refute_nil tours_found[index]['location'], "Expect location not nil for Object #{index}"
+      refute_empty tours_found[index]['location'], "Expect location not value for Object #{index}"
     end
 
-    it 'check for title changes' do
-      tours_from_file[index]['title'].must_equal tours_found[index]['title']
+    it 'check if price_currency exist and is not empty' do
+      
+      refute_nil tours_found[index]['price_currency'], "Expect price_currency not nil for Object #{index}"
+      refute_empty tours_found[index]['price_currency'], "Expect price_currency not value for Object #{index}"
     end
 
-    it 'check for description changes' do
-      tours_from_file[index]['content'].must_equal tours_found[index]['content']
+    it 'check if price exist and is not empty' do
+      refute_nil tours_found[index]['price'] , "Expect Price not nil value for Object #{index}"
+      refute_empty tours_found[index]['price'] , "Expect Price not empty value for Object #{index}"
     end
+
+    it 'check if category exist and is not empty' do
+      refute_nil tours_found[index]['category'] , "Expect Category not nil value for Object #{index}"
+      refute_empty tours_found[index]['category'] , "Expect Category not empty value for Object #{index}"
+    end
+
    end  
   end
 end

data/spec/tours.yml

@@ -77,40 +77,3 @@
   location: Taiwan
   price_currency: "$"
   price: '340'
-- img: http://cache-graphicslib.viator.com/graphicslib/thumbs674x446/5972/SITours/experience-beijing-opera-private-makeup-session-and-show-at-taipeieye-in-taipei-170230.jpg
-  title: 'Experience Beijing Opera: Private Makeup Session and Show at TaipeiEYE'
-  content: You'll feel like a Chinese opera star during this 2-hour session with a
-    professional makeup artist...
-  location: Taiwan
-  price_currency: "$"
-  price: '177'
-- img: http://cache-graphicslib.viator.com/graphicslib/thumbs674x446/5972/SITours/2-day-private-yilan-trip-from-taipei-in-taipei-156503.jpg
-  title: 2-Day Private Yilan Trip from Taipei
-  content: Experience the scenic farms, rustic walking paths and folk culture of Yilan,
-    one of the most breathtaking regions outside Taipei...
-  location: Taiwan
-  price_currency: "$"
-  price: '233'
-- img: http://cache-graphicslib.viator.com/graphicslib/thumbs674x446/6279/SITours/3-day-east-coast-and-hualien-tour-from-taipei-in-taipei-164762.jpg
-  title: 3-Day East Coast and Hualien Tour from Taipei
-  content: Experience the breathtaking beauty of Taiwan’s east coast on a 3-day small-group
-    tour from Taipei...
-  location: Taiwan
-  price_currency: "$"
-  price: '395'
-- img: http://cache-graphicslib.viator.com/graphicslib/thumbs674x446/6279/SITours/3-day-taroko-gorge-adventure-from-taipei-hiking-night-market-and-in-taipei-159737.jpg
-  title: '3-Day Taroko Gorge Adventure from Taipei: Hiking, Night Market and Shrimp
-    Fishing'
-  content: Experience the breathtaking beauty of Taroko Gorge, including guided day
-    hikes along the Shakadang Trail and the steep Jhuilu Old Trail...
-  location: Taiwan
-  price_currency: "$"
-  price: '395'
-- img: http://cache-graphicslib.viator.com/graphicslib/thumbs674x446/7326/SITours/taiwan-5-day-cycling-escapade-tour-in-taipei-201712.jpg
-  title: Taiwan 5-Day Cycling Escapade Tour
-  content: What better way to explore Taiwan than on a stimulating bicycle ride? Join
-    us on this exuberant journey as we guide you along the beautiful terrains of the
-    eastern coastline...
-  location: Taiwan
-  price_currency: "$"
-  price: '2990'

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: lonely_planet_tours
 version: !ruby/object:Gem::Version
-  version: 1.0.3
+  version: 1.1.0
 platform: ruby
 authors:
 - Bayardo Salgado
@@ -11,7 +11,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-10-24 00:00:00.000000000 Z
+date: 2015-11-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: minitest
@@ -108,6 +108,8 @@ files:
 - lib/lonelyplanet_scrap_test.rb
 - lonely_planet_tours.gemspec
 - spec/fixtures/vcr_cassettes/taiwan_tours.yml
+- spec/fixtures/vcr_cassettes/taiwan_tours_full.yml
+- spec/fixtures/vcr_cassettes/taiwan_tours_json.yml
 - spec/lonelyplanet_spec.rb
 - spec/support/vcr_setup.rb
 - spec/tours.yml
@@ -138,6 +140,8 @@ summary: The lonelyplanet web scraper service traverses details of tour packages
   on specified country
 test_files:
 - spec/fixtures/vcr_cassettes/taiwan_tours.yml
+- spec/fixtures/vcr_cassettes/taiwan_tours_full.yml
+- spec/fixtures/vcr_cassettes/taiwan_tours_json.yml
 - spec/lonelyplanet_spec.rb
 - spec/support/vcr_setup.rb
 - spec/tours.yml