lonely_coder 0.1.3 → 0.1.4

data/spec/pagination_spec.rb

@@ -1,20 +1,52 @@
 require 'spec_helper'
 
 describe "pagination" do
-  before(:each) do
-    VCR.use_cassette('paginate_search_results_by_10', :erb => {:username => ENV['OKC_USERNAME'], :password => ENV['OKC_PASSWORD']}) do
-      okc = OKCupid.new(ENV['OKC_USERNAME'], ENV['OKC_PASSWORD'])
-      
-      @search = okc.search({
-        gentation: 'girls who like guys'
-      })
-      @search.results
-      @search.load_next_page
+  describe "success" do
+    before(:each) do
+      VCR.use_cassette('paginate_search_results_by_10', :erb => {:username => ENV['OKC_USERNAME'], :password => ENV['OKC_PASSWORD']}) do
+        okc = OKCupid.new(ENV['OKC_USERNAME'], ENV['OKC_PASSWORD'])
+
+        @search = okc.search({
+          gentation: 'girls who like guys',
+          location: 4356796
+        })
+        @search.results
+        @did_it_work = @search.load_next_page
+      end
+    end
+
+    it "snags 10 more results" do
+      @search.results.size.should == 20
+      @search.results.all? {|p| p.kind_of?(OKCupid::Profile)}.should == true
+    end
+    
+    it "returns true" do
+      @did_it_work.should == true
     end
   end
   
-  it "snags 10 more results" do
-    @search.results.size.should == 20
-    @search.results.all? {|p| p.kind_of?(OKCupid::Profile)}.should == true
+  describe "failure" do
+    before(:each) do
+      VCR.use_cassette('paginate_search_results_by_10_with_failure', :erb => {:username => ENV['OKC_USERNAME'], :password => ENV['OKC_PASSWORD']}) do
+        okc = OKCupid.new(ENV['OKC_USERNAME'], ENV['OKC_PASSWORD'])
+
+        @search = okc.search({
+          gentation: 'guys who like guys',
+          location: 4204350, # "Provo, Utah"
+          min_age: 30,
+          max_age: 30
+        })
+        @count = @search.results.size
+        @did_it_work = @search.load_next_page
+      end
+    end
+
+    it "doesn't snag any more results" do
+      @search.results.size.should == @count
+    end
+    
+    it "returns false" do
+      @did_it_work.should == false
+    end
   end
 end

data/spec/profile_spec.rb

@@ -5,6 +5,16 @@ describe "Profile" do
   it "checks for equality based on username" do
     OKCupid::Profile.new(:username => 'someguy', :age => 22).should == OKCupid::Profile.new(:username => 'someguy', :age => 35)
   end
+  
+  it "checks for object equality based on username" do
+    OKCupid::Profile.new(:username => 'someguy', :age => 22).should eql(OKCupid::Profile.new(:username => 'someguy', :age => 35))
+  end
+  
+  it "hashes itself by username if present, for Set inclusion" do
+    one = OKCupid::Profile.new(:username => 'someguy')
+    two = OKCupid::Profile.new(:username => 'someguy')
+    one.hash.should == two.hash
+  end
 end
 
 describe "Profile from specific find" do
@@ -125,6 +135,7 @@ describe "Profile from specific find" do
 end
 
 describe "Profile from search result" do
+  # N.B. we used to check for specific values. This is maddening. Now we match found values to a regexp or Ruby class.
   before(:each) do
     VCR.use_cassette('load_profile_from_search', :erb => {:username => ENV['OKC_USERNAME'], :password => ENV['OKC_PASSWORD']}) do
       @profile = OKCupid.new(ENV['OKC_USERNAME'], ENV['OKC_PASSWORD']).search({
@@ -134,42 +145,44 @@ describe "Profile from search result" do
   end
   
   it "has a username" do
-    @profile.username.should == 'Misha862'
+    @profile.username.should be_kind_of(String)
   end
   
   it "has an age" do
-    @profile.age.should == '35'
+    @profile.age.should be_kind_of(String)
   end
     
   it "has a match %" do
-    @profile.match.should == 95
+    @profile.match.should be_kind_of(Integer)
   end
   
   it "has a friend %" do
-    @profile.friend.should == 73
+    @profile.friend.should be_kind_of(Integer)
   end
   
   it "has an enemy %" do
-    @profile.enemy.should == 4
+    @profile.enemy.should be_kind_of(Integer)
   end
   
   it "has a location" do
-    @profile.location.should == 'Ann Arbor, Michigan'
+    @profile.location.should match(/[\w]+, [\w]+/)
   end
   
   it "has a small avatar url" do
-    @profile.small_avatar_url.should == 'http://ak2.okccdn.com/php/load_okc_image.php/images/82x82/82x82/14x56/323x365/2/853930758706783150.jpeg'
+    @profile.small_avatar_url.should match(/^http:\/\//)
+    #== 'http://ak2.okccdn.com/php/load_okc_image.php/images/82x82/82x82/14x56/323x365/2/853930758706783150.jpeg'
   end
   
   it "has a sex" do
-    @profile.sex.should == 'F'
+    sexes = ['M', 'F']
+    sexes.should include(@profile.sex)
   end
   
   it "has an orientation" do
-    @profile.orientation.should == 'Straight'
+    @profile.orientation.should be_kind_of(String)
   end
   
   it "has a signle status" do
-    @profile.single.should == 'Single'
+    @profile.single.should be_kind_of(String)
   end
 end

data/spec/search_spec.rb

@@ -46,14 +46,25 @@ describe "Search" do
 end
 
 describe "Results" do
-  it "returns an array of OKCupid::Profile objects" do
+  it "returns an empty collection if nothing is found" do
+    VCR.use_cassette('search_finding_no_results', :erb => {:username => ENV['OKC_USERNAME'], :password => ENV['OKC_PASSWORD']}) do
+      @results = OKCupid.new(ENV['OKC_USERNAME'], ENV['OKC_PASSWORD']).search({
+        gentation: 'guys who like guys',
+        min_age: 25,
+        max_age: 25,
+        location: 4195656
+      }).results
+    end
+    @results.empty?.should == true
+  end
+  
+  it "returns an collection of OKCupid::Profile objects" do
     VCR.use_cassette('search_by_filters', :erb => {:username => ENV['OKC_USERNAME'], :password => ENV['OKC_PASSWORD']}) do
       @results = OKCupid.new(ENV['OKC_USERNAME'], ENV['OKC_PASSWORD']).search({
         gentation: 'girls who like guys'
       }).results
     end
     
-    @results.should be_kind_of(Array)
     @results.size.should == 10
     @results.all? {|p| p.kind_of?(OKCupid::Profile)}.should == true
   end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: lonely_coder
 version: !ruby/object:Gem::Version
-  version: 0.1.3
+  version: 0.1.4
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-03-26 00:00:00.000000000 Z
+date: 2012-03-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: mechanize
@@ -50,6 +50,7 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- CHANGELOG
 - Gemfile
 - README.mdown
 - lib/lonely_coder.rb
@@ -68,8 +69,10 @@ files:
 - spec/cassettes/loading_mailbox.yml
 - spec/cassettes/location_filter_looks_up_location_id.yml
 - spec/cassettes/paginate_search_results_by_10.yml
+- spec/cassettes/paginate_search_results_by_10_with_failure.yml
 - spec/cassettes/search_by_filters.yml
 - spec/cassettes/search_by_username.yml
+- spec/cassettes/search_finding_no_results.yml
 - spec/cassettes/search_that_includes_a_location.yml
 - spec/cassettes/successful_authentication.yml
 - spec/helper_spec.rb
@@ -114,8 +117,10 @@ test_files:
 - spec/cassettes/loading_mailbox.yml
 - spec/cassettes/location_filter_looks_up_location_id.yml
 - spec/cassettes/paginate_search_results_by_10.yml
+- spec/cassettes/paginate_search_results_by_10_with_failure.yml
 - spec/cassettes/search_by_filters.yml
 - spec/cassettes/search_by_username.yml
+- spec/cassettes/search_finding_no_results.yml
 - spec/cassettes/search_that_includes_a_location.yml
 - spec/cassettes/successful_authentication.yml
 - spec/helper_spec.rb