london-bike-hire-cli 1.3.0

data/spec/fixtures/n19ae_geocode.yml

@@ -0,0 +1,114 @@
+---
+http_interactions:
+- request:
+    method: get
+    uri: http://maps.googleapis.com/maps/api/geocode/json?address=n19ae&language=en&sensor=false
+    body:
+      encoding: US-ASCII
+      string: ''
+    headers:
+      Accept-Encoding:
+      - gzip;q=1.0,deflate;q=0.6,identity;q=0.3
+      Accept:
+      - "*/*"
+      User-Agent:
+      - Ruby
+  response:
+    status:
+      code: 200
+      message: OK
+    headers:
+      Content-Type:
+      - application/json; charset=UTF-8
+      Date:
+      - Sat, 23 Aug 2014 07:31:30 GMT
+      Expires:
+      - Sun, 24 Aug 2014 07:31:30 GMT
+      Cache-Control:
+      - public, max-age=86400
+      Access-Control-Allow-Origin:
+      - "*"
+      Server:
+      - mafe
+      X-Xss-Protection:
+      - 1; mode=block
+      X-Frame-Options:
+      - SAMEORIGIN
+      Alternate-Protocol:
+      - 80:quic
+      Transfer-Encoding:
+      - chunked
+    body:
+      encoding: UTF-8
+      string: |
+        {
+           "results" : [
+              {
+                 "address_components" : [
+                    {
+                       "long_name" : "N1 9AE",
+                       "short_name" : "N1 9AE",
+                       "types" : [ "postal_code" ]
+                    },
+                    {
+                       "long_name" : "Kings Cross",
+                       "short_name" : "Kings Cross",
+                       "types" : [ "neighborhood", "political" ]
+                    },
+                    {
+                       "long_name" : "London",
+                       "short_name" : "London",
+                       "types" : [ "locality", "political" ]
+                    },
+                    {
+                       "long_name" : "London",
+                       "short_name" : "London",
+                       "types" : [ "postal_town" ]
+                    },
+                    {
+                       "long_name" : "Greater London",
+                       "short_name" : "Gt Lon",
+                       "types" : [ "administrative_area_level_2", "political" ]
+                    },
+                    {
+                       "long_name" : "United Kingdom",
+                       "short_name" : "GB",
+                       "types" : [ "country", "political" ]
+                    }
+                 ],
+                 "formatted_address" : "Kings Cross, London N1 9AE, UK",
+                 "geometry" : {
+                    "bounds" : {
+                       "northeast" : {
+                          "lat" : 51.5310654,
+                          "lng" : -0.1212172
+                       },
+                       "southwest" : {
+                          "lat" : 51.5308025,
+                          "lng" : -0.1218269
+                       }
+                    },
+                    "location" : {
+                       "lat" : 51.5309584,
+                       "lng" : -0.1215387
+                    },
+                    "location_type" : "APPROXIMATE",
+                    "viewport" : {
+                       "northeast" : {
+                          "lat" : 51.5322829302915,
+                          "lng" : -0.120173069708498
+                       },
+                       "southwest" : {
+                          "lat" : 51.5295849697085,
+                          "lng" : -0.122871030291502
+                       }
+                    }
+                 },
+                 "types" : [ "postal_code" ]
+              }
+           ],
+           "status" : "OK"
+        }
+    http_version: 
+  recorded_at: Sat, 23 Aug 2014 07:31:30 GMT
+recorded_with: VCR 2.9.2

data/spec/fixtures/no_results_geocode.yml

@@ -0,0 +1,50 @@
+---
+http_interactions:
+- request:
+    method: get
+    uri: http://maps.googleapis.com/maps/api/geocode/json?address=====&language=en&sensor=false
+    body:
+      encoding: US-ASCII
+      string: ''
+    headers:
+      Accept-Encoding:
+      - gzip;q=1.0,deflate;q=0.6,identity;q=0.3
+      Accept:
+      - "*/*"
+      User-Agent:
+      - Ruby
+  response:
+    status:
+      code: 200
+      message: OK
+    headers:
+      Content-Type:
+      - application/json; charset=UTF-8
+      Date:
+      - Sat, 23 Aug 2014 10:15:38 GMT
+      Expires:
+      - Sun, 24 Aug 2014 10:15:38 GMT
+      Cache-Control:
+      - public, max-age=86400
+      Access-Control-Allow-Origin:
+      - "*"
+      Server:
+      - mafe
+      X-Xss-Protection:
+      - 1; mode=block
+      X-Frame-Options:
+      - SAMEORIGIN
+      Alternate-Protocol:
+      - 80:quic
+      Transfer-Encoding:
+      - chunked
+    body:
+      encoding: UTF-8
+      string: |
+        {
+           "results" : [],
+           "status" : "ZERO_RESULTS"
+        }
+    http_version: 
+  recorded_at: Sat, 23 Aug 2014 10:15:38 GMT
+recorded_with: VCR 2.9.2

data/spec/geocoding_adapter_spec.rb

@@ -0,0 +1,47 @@
+require 'spec_helper'
+
+RSpec.describe LondonBikeHireCli::GeocodingAdapter do
+  subject { described_class.new }
+
+  describe '#geocode with valid search term', vcr: { cassette_name: 'n19ae_geocode' } do
+    let(:search_term) { 'n19ae' }
+
+    it 'returns hash' do
+      expect(subject.geocode(search_term)).to be_instance_of(Hash)
+    end
+
+    it 'returns 2d point with lat key' do
+      expect(subject.geocode(search_term)).to have_key(:lat)
+    end
+
+    it 'returns 2d point with lat key' do
+      expect(subject.geocode(search_term)).to have_key(:long)
+    end
+
+    it 'returns 2d point with lat value' do
+      point = subject.geocode(search_term)
+      expect(point[:lat]).to eq(51.5309584)
+    end
+
+    it 'returns 2d point with long value' do
+      point = subject.geocode(search_term)
+      expect(point[:long]).to eq(-0.1215387)
+    end
+  end
+
+  describe '#geocode with search term returning no results', vcr: { cassette_name: 'no_results_geocode' } do
+    let(:search_term) { '====' }
+
+    it 'returns non nil' do
+      expect(subject.geocode(search_term)).not_to be_nil
+    end
+
+    it 'returns hash' do
+      expect(subject.geocode(search_term)).to be_instance_of(Hash)
+    end
+
+    it 'returns emtpy hash' do
+      expect(subject.geocode(search_term)).to be_empty
+    end
+  end
+end

data/spec/spatial_search_spec.rb

@@ -0,0 +1,27 @@
+require 'spec_helper'
+
+RSpec.describe LondonBikeHireCli::SpatialSearch do
+  let(:point_1) { [51.53005939, -0.120973687, 1] }
+  let(:point_2) { [51.50810309, -0.12602103, 2] }
+  let(:datasource) { [point_1, point_2] }
+  subject { described_class.new(datasource) }
+
+  describe '#nearest' do
+    context 'with datasource' do
+      let(:request) { { lat: 51.5309, long: -0.1215 } }
+      it 'returns results ordered by distance' do
+        results = subject.nearest(request)
+
+        expect(results).to eq([1, 2])
+      end
+
+      context 'given a limit request' do
+        it 'returns correct number of results' do
+          results = subject.nearest(request, 1)
+
+          expect(results.size).to eq(1)
+        end
+      end
+    end
+  end
+end

data/spec/spec_helper.rb

@@ -0,0 +1,83 @@
+require 'codeclimate-test-reporter'
+require 'coveralls'
+require 'pry-byebug'
+CodeClimate::TestReporter.start
+Coveralls.wear!
+
+require File.join(File.dirname(__FILE__), '..', '/lib/', 'london_bike_hire_cli')
+Dir["#{File.dirname(__FILE__)}/support/**/*.rb"].each { |f| require f }
+
+# This file was generated by the `rspec --init` command. Conventionally, all
+# specs live under a `spec` directory, which RSpec adds to the `$LOAD_PATH`.
+# The generated `.rspec` file contains `--require spec_helper` which will cause this
+# file to always be loaded, without a need to explicitly require it in any files.
+#
+# Given that it is always loaded, you are encouraged to keep this file as
+# light-weight as possible. Requiring heavyweight dependencies from this file
+# will add to the boot time of your test suite on EVERY test run, even for an
+# individual file that may not need all of that loaded. Instead, make a
+# separate helper file that requires this one and then use it only in the specs
+# that actually need it.
+#
+# The `.rspec` file also contains a few flags that are not defaults but that
+# users commonly want.
+#
+# See http://rubydoc.info/gems/rspec-core/RSpec/Core/Configuration
+RSpec.configure do |config|
+  # These two settings work together to allow you to limit a spec run
+  # to individual examples or groups you care about by tagging them with
+  # `:focus` metadata. When nothing is tagged with `:focus`, all examples
+  # get run.
+  config.filter_run :focus
+  config.run_all_when_everything_filtered = true
+
+  # Many RSpec users commonly either run the entire suite or an individual
+  # file, and it's useful to allow more verbose output when running an
+  # individual spec file.
+  if config.files_to_run.one?
+    # Use the documentation formatter for detailed output,
+    # unless a formatter has already been configured
+    # (e.g. via a command-line flag).
+    config.default_formatter = 'doc'
+  end
+
+  # Print the 10 slowest examples and example groups at the
+  # end of the spec run, to help surface which specs are running
+  # particularly slow.
+  config.profile_examples = 10
+
+  # Run specs in random order to surface order dependencies. If you find an
+  # order dependency and want to debug it, you can fix the order by providing
+  # the seed, which is printed after each run.
+  #     --seed 1234
+  config.order = :random
+
+  # Seed global randomization in this process using the `--seed` CLI option.
+  # Setting this allows you to use `--seed` to deterministically reproduce
+  # test failures related to randomization by passing the same `--seed` value
+  # as the one that triggered the failure.
+  Kernel.srand config.seed
+
+  # rspec-expectations config goes here. You can use an alternate
+  # assertion/expectation library such as wrong or the stdlib/minitest
+  # assertions if you prefer.
+  config.expect_with :rspec do |expectations|
+    # Enable only the newer, non-monkey-patching expect syntax.
+    # For more details, see:
+    #   - http://myronmars.to/n/dev-blog/2012/06/rspecs-new-expectation-syntax
+    expectations.syntax = :expect
+  end
+
+  # rspec-mocks config goes here. You can use an alternate test double
+  # library (such as bogus or mocha) by changing the `mock_with` option here.
+  config.mock_with :rspec do |mocks|
+    # Enable only the newer, non-monkey-patching expect syntax.
+    # For more details, see:
+    #   - http://teaisaweso.me/blog/2013/05/27/rspecs-new-message-expectation-syntax/
+    mocks.syntax = :expect
+
+    # Prevents you from mocking or stubbing a method that does not exist on
+    # a real object. This is generally recommended.
+    mocks.verify_partial_doubles = true
+  end
+end

data/spec/station_adapter_spec.rb

@@ -0,0 +1,29 @@
+require 'spec_helper'
+
+RSpec.describe LondonBikeHireCli::StationAdapter do
+  let(:datasource) { TestDatasource.new }
+  let(:test_repository) { LondonBikeHireCli::StationRepository.new(datasource) }
+  subject { described_class.new(test_repository.all) }
+
+  describe '#to_triples' do
+    context 'given datasource' do
+      it 'returns expected number of results' do
+        results = subject.to_triples
+
+        expect(results.size).to eq(2)
+      end
+
+      it 'produces triple of first station' do
+        results = subject.to_triples
+
+        expect(results.first).to eq([51.53005939, -0.120973687, 1])
+      end
+
+      it 'produces triple of second station' do
+        results = subject.to_triples
+
+        expect(results.last).to eq([51.50810309, -0.12602103, 2])
+      end
+    end
+  end
+end

data/spec/station_respository_spec.rb

@@ -0,0 +1,117 @@
+require 'spec_helper'
+
+RSpec.describe LondonBikeHireCli::StationRepository do
+  let(:datasource) { TestDatasource.new }
+  subject { described_class.new(datasource) }
+
+  describe '#all' do
+    context 'given feed_parser returns dataset' do
+      it 'should return expected number of results' do
+        results = subject.all
+
+        expect(results.size).to eq(2)
+      end
+    end
+  end
+
+  describe '#find_by_id' do
+    context 'given feed_parser returns dataset' do
+      it 'should return expected number of results' do
+        results = subject.find_by_id(1)
+
+        expect(results.size).to eq(1)
+      end
+
+      it 'should return expected result' do
+        result = subject.find_by_id(1).first
+
+        expect(result.name).to eq('test-station-1')
+      end
+
+      context 'given a request for an id that does not exist' do
+        it 'should raise error' do
+          expect do
+            subject.find_by_id(99)
+          end.to raise_error
+        end
+      end
+
+      context 'given a request for more than one id' do
+        it 'should return expected number of results' do
+          results = subject.find_by_id(1, 2)
+
+          expect(results.size).to eq(2)
+        end
+      end
+    end
+  end
+
+  describe '#find_by_name' do
+    context 'given feed_parser returns dataset' do
+      it 'should return expected number of results' do
+        results = subject.find_by_name('test-station-1')
+
+        expect(results.size).to eq(1)
+      end
+
+      it 'should return expected result' do
+        result = subject.find_by_name('test-station-1').first
+
+        expect(result.id).to eq(1)
+      end
+
+      context 'given a request for an id that does not exist' do
+        it 'should not raise error' do
+          expect do
+            subject.find_by_name('foo')
+          end.not_to raise_error
+        end
+
+        it 'should return empty array' do
+          expect(subject.find_by_name('foo').size).to eq(0)
+        end
+      end
+    end
+
+    describe 'integration tests', vcr: { cassette_name: 'feed_xml' } do
+      subject { LondonBikeHireCli::StationRepository.new(LondonBikeHireCli::FeedParser.new) }
+
+      describe '#find_by_id' do
+        it 'should return expected number of results' do
+          results = subject.find_by_id(777)
+
+          expect(results.size).to eq(1)
+        end
+
+        it 'should return expected result' do
+          result = subject.find_by_id(777).first
+
+          expect(result.name).to eq('Limburg Road, Clapham Common')
+        end
+      end
+
+      describe '#find_by_name' do
+        it 'should return expected number of results' do
+          results = subject.find_by_name('kings')
+
+          expect(results.size).to eq(3)
+        end
+
+        it 'should return expected result' do
+          results = subject.find_by_name('kings')
+          actual_ids = results.map(&:id)
+
+          expect(actual_ids).to include(283, 439, 594)
+        end
+      end
+
+      describe '#all' do
+        it 'should return expected number of results' do
+          results = subject.all
+
+          expect(results.size).to eq(747)
+        end
+      end
+    end
+  end
+end