lolita-translation 0.6.3 → 0.7.0

data/spec/integrations/active_record_integration_spec.rb

@@ -2,21 +2,21 @@ require 'spec_helper'
 require 'ar_schema'
 ARSchema.connect!
 
-describe "Integration with ActiveRecord" do 
+describe "Integration with ActiveRecord" do
 
-  before(:each) do 
-    ActiveRecord::Base.connection.execute("DELETE FROM categories")
-    ActiveRecord::Base.connection.execute("DELETE FROM products")
-  end
-  context "configuration defination" do 
+  # before(:each) do
+  #   ActiveRecord::Base.connection.execute("DELETE FROM categories")
+  #   ActiveRecord::Base.connection.execute("DELETE FROM products")
+  # end
+  context "configuration defination" do
 
-    before(:each) do 
+    before do
       Object.send(:remove_const, :Product) rescue nil
       klass = Class.new(ActiveRecord::Base)
       Object.const_set(:Product,klass)
     end
 
-    it "should have class method for translation configuration" do 
+    it "should have class method for translation configuration" do
       Product.class_eval do
         include Lolita::Translation
       end
@@ -25,17 +25,17 @@ describe "Integration with ActiveRecord" do
       Product.should.respond_to?(:translate)
     end
 
-    it "should create configuration when class is loaded with field names to translate" do  
-      Product.class_eval do 
+    it "should create configuration when class is loaded with field names to translate" do
+      Product.class_eval do
         include Lolita::Translation
         translate :name, :description
       end
       Product.translations_configuration.should be_kind_of(Lolita::Translation::Configuration)
     end
 
-    it "should accept block and yield configuration" do 
+    it "should accept block and yield configuration" do
       block_called = false
-      Product.class_eval do 
+      Product.class_eval do
         include Lolita::Translation
         translate :name, :description do |conf|
           block_called = true
@@ -45,35 +45,34 @@ describe "Integration with ActiveRecord" do
     end
   end
 
-  context "record" do 
+  context "record" do
     let(:category){Category.create(:name => "category_name", :default_locale => "en")}
 
-    before(:each) do 
+    before do
       I18n.default_locale = :en
       Object.send(:remove_const, :Category) rescue nil
       klass = Class.new(ActiveRecord::Base)
       Object.const_set(:Category,klass)
-      Category.class_eval do 
+      Category.class_eval do
         include Lolita::Translation
         attr_accessible :name, :default_locale
         translate :name
       end
     end
 
-    it "should have default locale" do 
-      category = Category.create(:name => Faker::Name.first_name, :default_locale => "en")
+    it "should have default locale" do
       I18n.default_locale = :lv
       category.original_locale.to_s.should eq("en")
     end
 
-    it "should have translations" do 
+    it "should have translations" do
       category.translations.should be_empty
       category.update_attributes(:name => "updated",:translations_attributes => [{:name => "translation-lv", :locale => "lv"}])
       category.errors.should be_empty
       category.translations.reload.should have(1).item
     end
 
-    it "should return translatable attribute in current locale" do 
+    it "should return translatable attribute in current locale" do
       I18n.default_locale = :lv
       I18n.locale = :lv
       category.name.should eq("category_name")
@@ -82,22 +81,22 @@ describe "Integration with ActiveRecord" do
       category.update_attributes(:name => "updated",:translations_attributes => [{:name => "translation-lv", :locale => "lv"}])
       I18n.locale = :lv
       category.name.should eq("translation-lv")
-      I18n.locale = :ru 
+      I18n.locale = :ru
       category.name.should eq("updated")
     end
 
-    it "should switch attribute to different locale" do 
+    it "should switch attribute to different locale" do
       category.name.should eq("category_name")
       category.update_attributes(:translations_attributes => [{:name => "translation-lv", :locale => "lv"}])
       category.name.in(:lv).should eq("translation-lv")
     end
   end
-  
+
   context "saving" do
     let(:category){Category.create(:name => "category_name", :default_locale => :en)}
     let(:product){ Product.create(:name => "product_name", :description => "product_description") }
 
-    before(:each) do 
+    before(:each) do
       I18n.locale = :en
       I18n.default_locale = :lv
       Object.send(:remove_const, :Category) rescue nil
@@ -106,19 +105,19 @@ describe "Integration with ActiveRecord" do
       Object.const_set(:Category,klass)
       product_klass = Class.new(ActiveRecord::Base)
       Object.const_set(:Product,product_klass)
-      Category.class_eval do 
+      Category.class_eval do
         include Lolita::Translation
         attr_accessible :name, :default_locale
         translate :name
       end
-      Product.class_eval do 
+      Product.class_eval do
         include Lolita::Translation
         attr_accessible :name, :default_locale
         translate :name, :description
       end
     end
- 
-    it "should create translations for object" do 
+
+    it "should create translations for object" do
       new_cat = Category.create({
         :name => "cat_name",
         :original_locale => :en,
@@ -131,7 +130,7 @@ describe "Integration with ActiveRecord" do
       new_cat.translations.should have(2).items
     end
 
-    it "should save translation as nested attributes" do 
+    it "should save translation as nested attributes" do
       category.translations.should be_empty
       category.update_attributes(:translations_attributes => [
         {:name => "translation-lv", :locale => "lv"},
@@ -141,7 +140,7 @@ describe "Integration with ActiveRecord" do
       category.translations.should have(2).items
     end
 
-    it "should save locale for record if it accepts it" do 
+    it "should save locale for record if it accepts it" do
       I18n.locale = :lv
       category.original_locale.should eq(:en)
       product.original_locale.should eq(:lv)
@@ -156,7 +155,7 @@ describe "Integration with ActiveRecord" do
       category.errors.keys.should include(:"translations.locale")
     end
 
-    it "translation record should be associated with original record" do 
+    it "translation record should be associated with original record" do
       transl1 = CategoryTranslation.new(:name => "translation-lv", :locale => "lv")
       transl1.category = category
       transl1.save
@@ -166,21 +165,21 @@ describe "Integration with ActiveRecord" do
       transl2.errors.keys.should include(:"category")
     end
 
-    it "should validate that locale is presented" do 
+    it "should validate that locale is presented" do
       transl1 = CategoryTranslation.new(:name => "translation-lv")
-      transl1.category = category 
+      transl1.category = category
       transl1.save
       transl1.errors.keys.should eq([:"locale"])
     end
 
-    it "should validate that locale is unique for each original record" do 
+    it "should validate that locale is unique for each original record" do
       transl1 = category.translations.create(:name => "translation-lv", :locale => "lv")
       transl2 = category.translations.create(:name => "translation-lv", :locale => "lv")
       transl1.errors.should be_empty
       transl2.errors.keys.should eq([:"locale"])
     end
 
-    it "should use default locale for records without default locale field" do 
+    it "should use default locale for records without default locale field" do
       product.update_attributes(:translations_attributes => [
         { :name => "product_name-ru", :locale => "ru"}
       ])
@@ -192,23 +191,23 @@ describe "Integration with ActiveRecord" do
     end
   end
 
-  context "migrating" do 
-    before(:each) do 
+  context "migrating" do
+    before(:each) do
       Object.send(:remove_const,:Comment) rescue nil
       c_class = Class.new(ActiveRecord::Base)
       Object.const_set(:Comment,c_class)
-      c_class.class_eval do 
+      c_class.class_eval do
         include Lolita::Translation
         translate :body
       end
       ActiveRecord::Base.connection.execute("DROP TABLE comments_translations") rescue nil
     end
 
-    after(:each) do 
+    after(:each) do
       Object.send(:remove_const,:Comment) rescue nil
     end
 
-    it "should sync translation table through migrations" do 
+    it "should sync translation table through migrations" do
       ActiveRecord::Base.connection.tables.should_not include("comments_translations")
       Comment.sync_translation_table!
       ActiveRecord::Base.connection.tables.should include("comments_translations")

data/spec/lolita-translation/builder/abstract_builder_spec.rb

@@ -24,23 +24,15 @@ describe Lolita::Translation::Builder::AbstractBuilder do
   end
 
   it "should return class name like <Scoped::ClassName>Translation for class name 'Scoped::ClassName'" do 
-    begin
-      Object.const_set(:Scoped,Class.new)
-      set_class_name(some_class,"Scoped::ClassName")
-      klass.new(some_class).class_name.should eq("Scoped::ClassNameTranslation")
-    ensure
-      Object.send(:remove_const, :Scoped)
-    end
+    stub_const('Scoped',Class.new)
+    set_class_name(some_class,"Scoped::ClassName")
+    klass.new(some_class).class_name.should eq("Scoped::ClassNameTranslation")
   end
 
   it "should create class with scoped name" do 
-    begin
-      Object.const_set(:Scoped,Class.new)
-      set_class_name(some_class,"Scoped::OtherClassName")
-      klass.new(some_class).klass.name.should eq("Scoped::OtherClassNameTranslation")
-    ensure
-      Object.send(:remove_const, :Scoped)
-    end
+    stub_const('Scoped',Class.new)
+    set_class_name(some_class,"Scoped::OtherClassName")
+    klass.new(some_class).klass.name.should eq("Scoped::OtherClassNameTranslation")
   end
 
   it "should show warning when method that should be implemented in concrete builder is not implemented yet" do 

data/spec/lolita-translation/builder/active_record_builder_spec.rb

@@ -4,27 +4,21 @@ require File.expand_path("lib/lolita-translation/builder/active_record_builder")
 require File.expand_path("lib/lolita-translation/configuration")
 ARSchema.connect!
 
-describe Lolita::Translation::Builder::ActiveRecordBuilder do 
+describe Lolita::Translation::Builder::ActiveRecordBuilder do
   let(:klass) { Lolita::Translation::Builder::ActiveRecordBuilder }
   let(:config){ Lolita::Translation::Configuration.new(Product) }
-  before(:each) do 
-    Object.send(:remove_const, :Product) if Object.const_defined?(:Product)
+  before(:each) do
     a_klass = Class.new(ActiveRecord::Base)
-    Object.const_set(:Product, a_klass)
+    stub_const('Product', a_klass)
   end
 
-  after(:each) do 
-    Object.send(:remove_const, :Product) rescue nil
-  end
-
- 
-  it "should build class with ActiveRecord::Base as superclass" do 
+  it "should build class with ActiveRecord::Base as superclass" do
     obj = klass.new(Product)
     obj.build
     obj.klass.superclass.should eq(ActiveRecord::Base)
   end
 
-  it "should call class methods on klass" do 
+  it "should call class methods on klass" do
     obj = klass.new(Product, config)
     obj.stub(:association_name).and_return(:product)
     obj.build
@@ -36,5 +30,5 @@ describe Lolita::Translation::Builder::ActiveRecordBuilder do
     obj.stub(:translations_association_name).and_return(:translations)
     obj.build
     Product.reflections.keys.should include(:translations)
-  end 
+  end
 end

data/spec/lolita-translation/configuration_spec.rb

@@ -3,10 +3,10 @@ require File.expand_path("lib/lolita-translation/configuration")
 require File.expand_path("lib/lolita-translation/translation_class_builder")
 require File.expand_path("lib/lolita-translation/errors")
 
-describe Lolita::Translation::Configuration do 
+describe Lolita::Translation::Configuration do
   let(:klass){Lolita::Translation::Configuration}
-  let(:some_class) do 
-    Class.new do 
+  let(:some_class) do
+    Class.new do
       class << self
         def table_exists?
           true
@@ -15,54 +15,50 @@ describe Lolita::Translation::Configuration do
     end
   end
 
-  before(:each) do 
+  before(:each) do
     Lolita::Translation::TranslationClassBuilder.any_instance.stub(:build_class).and_return("builder")
     Lolita::Translation::TranslationClassBuilder.any_instance.stub(:override_attributes).and_return("attributes")
   end
 
-  it "should have @klass attribute" do 
+  it "should have @klass attribute" do
     klass.new(some_class).klass.should eq(some_class)
   end
 
-  it "should have @attributes attribute" do 
+  it "should have @attributes attribute" do
     klass.new(some_class, :name, :body).attributes.sort.should eq([:name,:body].sort)
   end
 
-  it "should have @translation_class attribute" do 
-    Object.const_set(:Product,some_class)
+  it "should have @translation_class attribute" do
+    stub_const('Product',some_class)
     klass.new(some_class).translation_class.should eq("builder")
   end
 
-  describe "locales" do 
-    before(:each) do 
-      Object.const_set(:Product,some_class)
+  describe "locales" do
+    before do
+      stub_const('Product',some_class)
+      stub_const('Lolita::Translation::Locales', Class.new) unless defined?(Lolita::Translation::Locales)
     end
 
-    after(:each) do 
-      Lolita::Translation.send(:remove_const,:Locales) rescue nil
-    end
-    it "can be received as option" do 
-      Lolita::Translation.const_set(:Locales, Class.new)
+    it "can be received as option" do
       Lolita::Translation::Locales.should_receive(:new).with([:en,:ru]).and_return([:en,:ru])
       config = klass.new(some_class, :locales => [:en, :ru])
       config.locales.should == [:en,:ru]
     end
 
-    it "should fall back to Lolita::Translation.locales when no locales are passed" do 
+    it "should fall back to Lolita::Translation.locales when no locales are passed" do
       config = klass.new(some_class)
       Lolita::Translation.stub(:locales).and_return([:lv,:ru])
       config.locales.should eq(Lolita::Translation.locales)
     end
 
-    it "can be as anonymous method" do 
-      Lolita::Translation.const_set(:Locales, Class.new)
+    it "can be as anonymous method" do
       Lolita::Translation::Locales.should_receive(:new).and_return([:lv,:ru])
       config = klass.new(some_class, :locales => Proc.new{ [:lv,:ru] })
       config.locales.should eq([:lv,:ru])
     end
   end
 
-  it "should yield block with self when called with block" do 
+  it "should yield block with self when called with block" do
     block_called = nil
     translation_conf = klass.new(some_class) do |conf|
       block_called = conf

data/spec/lolita-translation/locales_spec.rb

@@ -1,20 +1,20 @@
 require 'header'
 require File.expand_path("lib/lolita-translation/locales")
 
-describe Lolita::Translation::Locales do 
-  let(:klass){ Lolita::Translation::Locales }
+describe Lolita::Translation::Locales do
+  let(:klass){ ::Lolita::Translation::Locales }
 
-  it "should create new with given locales names" do 
+  it "should create new with given locales names" do
     obj = klass.new([:lv,:en,:ru])
     obj.locale_names.should eq([:en,:lv,:ru])
   end
 
-  it "should implement Enumerable and each element should be Locale" do 
+  it "should implement Enumerable and each element should be Locale" do
     obj = klass.new([:lv,:en,:ru])
     obj.first.should be_kind_of(Lolita::Translation::Locale)
   end
 
-  it "should return locales in order where first is locale that belongs to record" do 
+  it "should return locales in order where first is locale that belongs to record" do
     obj = klass.new([:lv,:en,:ru])
     resource = double("resource")
     transl_rec = double("transl-rec")
@@ -23,7 +23,7 @@ describe Lolita::Translation::Locales do
     obj.by_resource_locale(resource).map{|r| r.name}.should eq([:ru,:en,:lv])
   end
 
-  it "should return active locale" do 
+  it "should return active locale" do
     obj = klass.new([:lv,:en,:ru])
     I18n.locale = :ru
     obj.active.name.should eq(:ru)

data/spec/lolita-translation/lolita/tab_extension_spec.rb

@@ -32,7 +32,7 @@ describe "Lolita tab extension" do
 
   it "should provide tab with #build_translations_nested_form with resource" do 
     c_class = Class.new(ActiveRecord::Base)
-    Object.const_set(:Product,c_class)
+    stub_const('Product',c_class)
     c_class.class_eval do 
       include Lolita::Configuration
       include Lolita::Translation
@@ -48,7 +48,7 @@ describe "Lolita tab extension" do
 
   it "should add #original_locale field to original tab" do 
     c_class = Class.new(ActiveRecord::Base)
-    Object.const_set(:Product,c_class)
+    stub_const('Product',c_class)
     c_class.class_eval do 
       include Lolita::Configuration
       include Lolita::Translation

data/spec/lolita-translation/migrator_spec.rb

@@ -1,31 +1,26 @@
 require 'spec_helper'
 
-describe Lolita::Translation::Migrator do 
+describe Lolita::Translation::Migrator do
   let(:klass) { Lolita::Translation::Migrator }
-  
-  before(:each) do 
-    Object.send(:remove_const,:Comment) rescue nil
+
+  before(:each) do
     c_class = Class.new(ActiveRecord::Base)
-    Object.const_set(:Comment,c_class)
-    c_class.class_eval do 
+    stub_const('Comment',c_class)
+    c_class.class_eval do
       include Lolita::Translation
       translate :body
     end
   end
 
-  after(:each) do 
-    Object.send(:remove_const,:Comment) rescue nil
-  end
-
-  describe "Instance methods" do 
+  describe "Instance methods" do
 
-    it "should have klass and config attributes" do 
+    it "should have klass and config attributes" do
       migrator = klass.new(Comment)
       migrator.klass.should eq(Comment)
       migrator.config.should eq(Comment.translations_configuration)
     end
 
-    it "should raise error when #migrate called" do 
+    it "should raise error when #migrate called" do
       migrator = klass.new(Comment)
       expect{
         migrator.migrate
@@ -33,10 +28,10 @@ describe Lolita::Translation::Migrator do
     end
   end
 
-  describe "Class methods" do 
-    it "should create concrete migrator for AR" do 
+  describe "Class methods" do
+    it "should create concrete migrator for AR" do
       klass.create(Comment).should be_kind_of(Lolita::Translation::Migrators::ActiveRecordMigrator)
     end
   end
 
-end 
+end