lolcommits-uploldz 0.0.2 → 0.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: ae45eeab78fa99bdbc87098624e7c14c1de47c20
-  data.tar.gz: f2ebff5d427fe370ea6b005ff35fdb5b65897570
+SHA256:
+  metadata.gz: ce77eebc0710354cfe830be0a57a742709bb2cc8ce44e7a0c546f568144750b5
+  data.tar.gz: af4a350514b825c830a355e41a659206a55382c4532513be335fffe2e39bdd32
 SHA512:
-  metadata.gz: b72af5118e0a9c8e3c66d6b89319ad11e5c9c33bf9a529fbf0cf4aa5a343b975b20adc43dfc95c86e161c7e37f279360c1fced40662d1f0ff5d668148600cbd4
-  data.tar.gz: 69b948bf52f86b49cb4f0ff712a672ba210677ac3e3c02aa3fa6e127d76e31309ab18126c4b49035e28216b051348050731b9060c2ad548a923a6828e175d1d2
+  metadata.gz: ba6a26e52cc2bcbd1b84ccc6a0ff67d442b2d300e1dd421103f1229f13948c6634a0c346ff95d162dd870289b88aeed2e22f8cd40f81cae7f9eb8f1c0789a439
+  data.tar.gz: a652739ff472eed65a28704ffaaa019fdd91d48c2b8a0a11a3f45e6151da0e28bff8cd0d7737074a0704fac5e7680be8cd59b0c4493ccffc7f6e7b7019ca49d6

data/.travis.yml

@@ -2,18 +2,19 @@ sudo: false
 language: ruby
 cache: bundler
 rvm:
- - 2.0.0
- - 2.1.10
- - 2.2.8
- - 2.3.5
- - 2.4.2
- - ruby-head
+  - 2.0.0
+  - 2.1.10
+  - 2.2.9
+  - 2.3.6
+  - 2.4.3
+  - 2.5.0
+  - ruby-head
 
 before_install:
- - gem install bundler -v 1.13.7
- - git --version
- - git config --global user.email "lol@commits.org"
- - git config --global user.name "Lolcommits"
+  - gem update --system
+  - git --version
+  - git config --global user.email "lol@commits.org"
+  - git config --global user.name "Lolcommits"
 
 matrix:
   allow_failures:

data/lib/lolcommits/plugin/uploldz.rb

@@ -16,15 +16,6 @@ module Lolcommits
         options.concat(plugin_options)
       end
 
-      ##
-      # Returns the name of the plugin to identify the plugin to lolcommits.
-      #
-      # @return [String] the plugin name
-      #
-      def self.name
-        'uploldz'
-      end
-
       ##
       # Returns position(s) of when this plugin should run during the capture
       # process. Uploading happens when a new capture is ready.
@@ -35,15 +26,6 @@ module Lolcommits
         [:capture_ready]
       end
 
-      ##
-      # Returns true if the plugin has been configured.
-      #
-      # @return [Boolean] true/false indicating if plugin is configured
-      #
-      def configured?
-        !!(!configuration['enabled'].nil? && configuration['endpoint'])
-      end
-
       ##
       # Returns true/false indicating if the plugin has been correctly
       # configured. The `endpoint` option must be set with a URL beginning with
@@ -53,7 +35,7 @@ module Lolcommits
       # configured
       #
       def valid_configuration?
-        !!(configuration['endpoint'] =~ /^http(s)?:\/\//)
+        !!(configuration[:endpoint] =~ /^http(s)?:\/\//)
       end
 
       ##
@@ -73,9 +55,9 @@ module Lolcommits
       # @return [Nil] if any error occurs
       #
       def run_capture_ready
-        debug "Posting capture to #{configuration['endpoint']}"
+        debug "Posting capture to #{configuration[:endpoint]}"
         RestClient.post(
-          configuration['endpoint'],
+          configuration[:endpoint],
           {
             file: File.new(runner.main_image),
             message: runner.message,
@@ -83,7 +65,7 @@ module Lolcommits
             author_name: runner.vcs_info.author_name,
             author_email: runner.vcs_info.author_email,
             sha: runner.sha,
-            key: configuration['optional_key']
+            key: configuration[:optional_key]
           },
           Authorization: authorization_header
         )
@@ -100,12 +82,12 @@ module Lolcommits
       # @return [Array] the option names
       #
       def plugin_options
-        %w(
-          endpoint
-          optional_key
-          optional_http_auth_username
-          optional_http_auth_password
-        )
+        [
+          :endpoint,
+          :optional_key,
+          :optional_http_auth_username,
+          :optional_http_auth_password
+        ]
       end
 
       ##
@@ -116,8 +98,8 @@ module Lolcommits
       # @return [Nil] if no username or password option set
       #
       def authorization_header
-        user     = configuration['optional_http_auth_username']
-        password = configuration['optional_http_auth_password']
+        user     = configuration[:optional_http_auth_username]
+        password = configuration[:optional_http_auth_password]
         return unless user || password
 
         'Basic ' + Base64.encode64("#{user}:#{password}").chomp

data/lib/lolcommits/uploldz/version.rb

@@ -1,5 +1,5 @@
 module Lolcommits
   module Uploldz
-    VERSION = "0.0.2".freeze
+    VERSION = "0.0.3".freeze
   end
 end

data/lolcommits-uploldz.gemspec

@@ -37,7 +37,7 @@ Gem::Specification.new do |spec|
 
   spec.add_runtime_dependency "rest-client"
 
-  spec.add_development_dependency "lolcommits", ">= 0.9.5"
+  spec.add_development_dependency "lolcommits", ">= 0.10.0"
   spec.add_development_dependency "bundler"
   spec.add_development_dependency "webmock"
   spec.add_development_dependency "pry"

data/test/lolcommits/plugin/uploldz_test.rb

@@ -6,14 +6,6 @@ describe Lolcommits::Plugin::Uploldz do
   include Lolcommits::TestHelpers::GitRepo
   include Lolcommits::TestHelpers::FakeIO
 
-  def plugin_name
-    "uploldz"
-  end
-
-  it "should have a name" do
-    ::Lolcommits::Plugin::Uploldz.name.must_equal plugin_name
-  end
-
   it "should run on capture ready" do
     ::Lolcommits::Plugin::Uploldz.runner_order.must_equal [:capture_ready]
   end
@@ -22,11 +14,7 @@ describe Lolcommits::Plugin::Uploldz do
     def runner
       # a simple lolcommits runner with an empty configuration Hash
       @runner ||= Lolcommits::Runner.new(
-        main_image: Tempfile.new('main_image.jpg'),
-        config: OpenStruct.new(
-          read_configuration: {},
-          loldir: File.expand_path("#{__dir__}../../../images")
-        )
+        main_image: Tempfile.new('main_image.jpg')
       )
     end
 
@@ -35,38 +23,34 @@ describe Lolcommits::Plugin::Uploldz do
     end
 
     def valid_enabled_config
-      @config ||= OpenStruct.new(
-        read_configuration: {
-          "uploldz" => {
-            "enabled" => true,
-            "endpoint" => "https://uploldz.com/uplol",
-            'optional_http_auth_username' => 'joe',
-            'optional_http_auth_password' => '1234'
-          }
-        }
-      )
+      {
+        enabled: true,
+        endpoint: "https://uploldz.com/uplol",
+        optional_http_auth_username: 'joe',
+        optional_http_auth_password: '1234'
+      }
     end
 
     describe "initalizing" do
       it "assigns runner and all plugin options" do
         plugin.runner.must_equal runner
-        plugin.options.must_equal %w(
-          enabled
-          endpoint
-          optional_key
-          optional_http_auth_username
-          optional_http_auth_password
-        )
+        plugin.options.must_equal [
+          :enabled,
+          :endpoint,
+          :optional_key,
+          :optional_http_auth_username,
+          :optional_http_auth_password
+        ]
       end
     end
 
     describe "#enabled?" do
       it "is false by default" do
-        plugin.enabled?.must_equal false
+        assert_nil plugin.enabled?
       end
 
       it "is true when configured" do
-        plugin.config = valid_enabled_config
+        plugin.configuration = valid_enabled_config
         plugin.enabled?.must_equal true
       end
     end
@@ -77,7 +61,7 @@ describe Lolcommits::Plugin::Uploldz do
 
       it "syncs lolcommits" do
         in_repo do
-          plugin.config = valid_enabled_config
+          plugin.configuration = valid_enabled_config
 
           stub_request(:post, "https://uploldz.com/uplol").to_return(status: 200)
 
@@ -99,15 +83,6 @@ describe Lolcommits::Plugin::Uploldz do
     end
 
     describe "configuration" do
-      it "returns false when not configured" do
-        plugin.configured?.must_equal false
-      end
-
-      it "returns true when configured" do
-        plugin.config = valid_enabled_config
-        plugin.configured?.must_equal true
-      end
-
       it "allows plugin options to be configured" do
         # enabled, endpoint, key, user, password
         inputs = %w(
@@ -124,24 +99,22 @@ describe Lolcommits::Plugin::Uploldz do
         end
 
         configured_plugin_options.must_equal({
-          "enabled" => true,
-          "endpoint" => "https://my-server.com/uplol",
-          "optional_key" => "key-123",
-          "optional_http_auth_username" => "joe",
-          "optional_http_auth_password" => "1337pass"
+          enabled: true,
+          endpoint: "https://my-server.com/uplol",
+          optional_key: "key-123",
+          optional_http_auth_username: "joe",
+          optional_http_auth_password: "1337pass"
         })
       end
 
       describe "#valid_configuration?" do
         it "returns false for an invalid configuration" do
-          plugin.config = OpenStruct.new(read_configuration: {
-            "lolsrv" => { "endpoint" => "gibberish" }
-          })
+          plugin.configuration = { endpoint: "gibberish" }
           plugin.valid_configuration?.must_equal false
         end
 
         it "returns true with a valid configuration" do
-          plugin.config = valid_enabled_config
+          plugin.configuration = valid_enabled_config
           plugin.valid_configuration?.must_equal true
         end
       end

data/test/test_helper.rb

@@ -1,10 +1,7 @@
 $LOAD_PATH.unshift File.expand_path('../../lib', __FILE__)
 
-# necessary libs from lolcommits (allowing plugin to run)
-require 'git'
-require 'lolcommits/runner'
-require 'lolcommits/vcs_info'
-require 'lolcommits/backends/git_info'
+# lolcommits gem
+require 'lolcommits'
 
 # lolcommit test helpers
 require 'lolcommits/test_helpers/git_repo'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: lolcommits-uploldz
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.0.3
 platform: ruby
 authors:
 - Matthew Hutchinson
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-12-06 00:00:00.000000000 Z
+date: 2018-01-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rest-client
@@ -30,14 +30,14 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.9.5
+        version: 0.10.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.9.5
+        version: 0.10.0
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
@@ -169,7 +169,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.13
+rubygems_version: 2.7.3
 signing_key: 
 specification_version: 4
 summary: Uploads lolcommits to a remote server