lolcommits-slack 0.0.2 → 0.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: c9ad2c07401cb1d094bc9a627af6e6f4566ebe6f
-  data.tar.gz: 3ab347e1fbb18a26fefb360376e875ccea3eeaa1
+SHA256:
+  metadata.gz: f10b4933ce906fbbe9a3e27f9f5ed623da1e768511f4c57f1f15ab30473b0d95
+  data.tar.gz: f995f7b137d0a7d749a0e3eaa395eef8814c2d0f30009b0939ad4344fa7241e6
 SHA512:
-  metadata.gz: 165b0aa1181726475066fc17c32e3cb684da0ece597f23f5c559e7c675d1611f8c51aab668a41603268037330025e7639e0525f0c86887d09efcd37ad5c2651e
-  data.tar.gz: ca94265e28d186d5e7c687618b1943cc5d3de5690e3e657008dc9df8349b9b3ba509739fb48cff035eb3ea157ca2318b941c0faeda68a5c7162b160cc74d4d2d
+  metadata.gz: c087299c9709c53be553ef452973908ebb254b52279bf416c71bd5930711e1ea8582832cbd84d680c9a2f9ef0108a259e5a0b6732372e97ba9e584288e4248bf
+  data.tar.gz: b8e3caf920b124662b5efefbdb8555a1641c8bb621343783a17dc0a26ac8993e0add459a38be1af3127f0a3ea3569b1f42a10f9f29b38d610e083a1aca134cfc

data/.travis.yml

@@ -4,13 +4,14 @@ cache: bundler
 rvm:
  - 2.0.0
  - 2.1.10
- - 2.2.8
- - 2.3.5
- - 2.4.2
+ - 2.2.9
+ - 2.3.6
+ - 2.4.3
+ - 2.5.0
  - ruby-head
 
 before_install:
- - gem install bundler -v 1.13.7
+ - gem update --system
  - git --version
  - git config --global user.email "lol@commits.org"
  - git config --global user.name "Lolcommits"
@@ -18,3 +19,14 @@ before_install:
 matrix:
   allow_failures:
     - rvm: ruby-head
+
+env:
+  global:
+    - CC_TEST_REPORTER_ID=23a400f6c5d8a15d9f1b4c6102ed07115d1a1d3bc979e5bc36cd43e2558edf7c
+    - GIT_COMMITTED_AT=$(if [ "$TRAVIS_PULL_REQUEST" == "false" ]; then git log -1 --pretty=format:%ct; else git log -1 --skip 1 --pretty=format:%ct; fi)
+before_script:
+  - curl -L https://codeclimate.com/downloads/test-reporter/test-reporter-latest-linux-amd64 > ./cc-test-reporter
+  - chmod +x ./cc-test-reporter
+  - ./cc-test-reporter before-build - GIT_COMMITTED_AT=$(if [ "$TRAVIS_PULL_REQUEST" == "false" ]; then git log -1 --pretty=format:%ct; else git log -1 --skip 1 --pretty=format:%ct; fi)
+after_script:
+  - ./cc-test-reporter after-build --exit-code $TRAVIS_TEST_RESULT

data/README.md

@@ -2,8 +2,8 @@
 
 [![Gem Version](https://img.shields.io/gem/v/lolcommits-slack.svg?style=flat)](http://rubygems.org/gems/lolcommits-slack)
 [![Travis Build Status](https://travis-ci.org/lolcommits/lolcommits-slack.svg?branch=master)](https://travis-ci.org/lolcommits/lolcommits-slack)
-[![Coverage Status](https://coveralls.io/repos/github/lolcommits/lolcommits-slack/badge.svg?branch=master)](https://coveralls.io/github/lolcommits/lolcommits-slack)
-[![Code Climate](https://codeclimate.com/github/lolcommits/lolcommits-slack/badges/gpa.svg)](https://codeclimate.com/github/lolcommits/lolcommits-slack)
+[![Maintainability](https://img.shields.io/codeclimate/maintainability/lolcommits/lolcommits-slack.svg)](https://codeclimate.com/github/lolcommits/lolcommits-slack/maintainability)
+[![Test Coverage](https://img.shields.io/codeclimate/c/lolcommits/lolcommits-slack.svg)](https://codeclimate.com/github/lolcommits/lolcommits-slack/test_coverage)
 [![Gem Dependency Status](https://gemnasium.com/badges/github.com/lolcommits/lolcommits-slack.svg)](https://gemnasium.com/github.com/lolcommits/lolcommits-slack)
 
 [lolcommits](https://lolcommits.github.io/) takes a snapshot with your webcam
@@ -110,7 +110,7 @@ The gem is available as open source under the terms of
 ## Links
 
 * [Travis CI](https://travis-ci.org/lolcommits/lolcommits-slack)
-* [Test Coverage](https://coveralls.io/github/lolcommits/lolcommits-slack?branch=master)
+* [Test Coverage](https://codeclimate.com/github/lolcommits/lolcommits-slack/test_coverage)
 * [Code Climate](https://codeclimate.com/github/lolcommits/lolcommits-slack)
 * [RDoc](http://rdoc.info/projects/lolcommits/lolcommits-slack)
 * [Issues](http://github.com/lolcommits/lolcommits-slack/issues)

data/lib/lolcommits/plugin/slack.rb

@@ -10,17 +10,6 @@ module Lolcommits
       # Number of times to retry if RestClient.post fails
       RETRY_COUNT = 2
 
-      ##
-      # Returns the name of the plugin.
-      #
-      # Identifies the plugin to lolcommits.
-      #
-      # @return [String] the plugin name
-      #
-      def self.name
-        'slack'
-      end
-
       ##
       # Returns position(s) of when this plugin should run during the capture
       # process.
@@ -52,11 +41,11 @@ module Lolcommits
           response = RestClient.post(
             ENDPOINT_URL,
             file: File.new(runner.main_image),
-            token: configuration['access_token'],
+            token: configuration[:access_token],
             filetype: 'jpg',
             filename: runner.sha,
             title: runner.message + "[#{runner.vcs_info.repo}]",
-            channels: configuration['channels']
+            channels: configuration[:channels]
           )
 
           debug response
@@ -86,7 +75,7 @@ module Lolcommits
       def configure_options!
         options = super
 
-        if options['enabled']
+        if options[:enabled]
           print "open the url below and issue a token for your user:\n"
           print "https://api.slack.com/custom-integrations/legacy-tokens\n"
           print "enter the generated token below, then press enter: (e.g. xxxx-xxxxxxxxx-xxxx) \n"
@@ -97,24 +86,13 @@ module Lolcommits
           channels = parse_user_input(gets.strip)
 
           options.merge!(
-            'access_token' => code,
-            'channels'     => channels
+            access_token: code,
+            channels: channels
           )
         end
 
         options
       end
-
-      ##
-      # Returns true/false indicating if the plugin has been configured.
-      #
-      # Checks the `access_token` ond `channels` options have been set.
-      #
-      # @return [Boolean] true/false
-      #
-      def configured?
-        !configuration['access_token'].nil? && !configuration['channels'].nil?
-      end
     end
   end
 end

data/lib/lolcommits/slack/version.rb

@@ -1,5 +1,5 @@
 module Lolcommits
   module Slack
-    VERSION = "0.0.2".freeze
+    VERSION = "0.0.3".freeze
   end
 end

data/lolcommits-slack.gemspec

@@ -34,11 +34,10 @@ Gem::Specification.new do |spec|
 
   spec.add_runtime_dependency "rest-client"
 
-  spec.add_development_dependency "lolcommits", "~> 0.9.6"
+  spec.add_development_dependency "lolcommits", ">= 0.10.0"
   spec.add_development_dependency "webmock"
   spec.add_development_dependency "bundler"
   spec.add_development_dependency "rake"
   spec.add_development_dependency "minitest"
   spec.add_development_dependency "simplecov"
-  spec.add_development_dependency "coveralls"
 end

data/test/lolcommits/plugin/slack_test.rb

@@ -5,14 +5,6 @@ describe Lolcommits::Plugin::Slack do
   include Lolcommits::TestHelpers::GitRepo
   include Lolcommits::TestHelpers::FakeIO
 
-  def plugin_name
-    'slack'
-  end
-
-  it 'should have a name' do
-    ::Lolcommits::Plugin::Slack.name.must_equal plugin_name
-  end
-
   it 'should run on pre_capture and capture_ready' do
     ::Lolcommits::Plugin::Slack.runner_order.must_equal [:capture_ready]
   end
@@ -20,9 +12,8 @@ describe Lolcommits::Plugin::Slack do
   describe 'with a runner' do
 
     def runner
-      # a simple lolcommits runner with an empty configuration Hash
+      # a simple lolcommits runner
       @_runner ||= Lolcommits::Runner.new(
-        config: OpenStruct.new(read_configuration: {}),
         main_image: Tempfile.new('test_image')
       )
     end
@@ -32,22 +23,11 @@ describe Lolcommits::Plugin::Slack do
     end
 
     def valid_enabled_config
-      @_config ||= OpenStruct.new(
-        read_configuration: {
-          plugin.class.name => {
-            'enabled'      => true,
-            'access_token' => 'acbd-1234-wxyz-5678',
-            'channels'     => 'c123,c456'
-          }
-        }
-      )
-    end
-
-    describe 'initalizing' do
-      it 'should assign runner and an enabled option' do
-        plugin.runner.must_equal runner
-        plugin.options.must_equal ['enabled']
-      end
+      {
+        enabled: true,
+        access_token: 'acbd-1234-wxyz-5678',
+        channels: 'c123,c456'
+      }
     end
 
     describe '#run_capture_ready' do
@@ -58,7 +38,7 @@ describe Lolcommits::Plugin::Slack do
       it 'should post the message to slack' do
         stub_request(:any, plugin.class::ENDPOINT_URL)
         in_repo do
-          plugin.config = valid_enabled_config
+          plugin.configuration = valid_enabled_config
           output = fake_io_capture { plugin.run_capture_ready }
           assert_equal output, "Posting to Slack ... done!\n"
 
@@ -71,10 +51,10 @@ describe Lolcommits::Plugin::Slack do
       it 'should retry (and explain) if there is a failure (req timeout)' do
         in_repo do
           stub_request(:any, plugin.class::ENDPOINT_URL).to_timeout
-          plugin.config = valid_enabled_config
+          plugin.configuration = valid_enabled_config
 
           Proc.new { plugin.run_capture_ready }.
-            must_output("Posting to Slack ... failed! Request Timeout - retrying ...\nPosting to Slack ... failed! Request Timeout - giving up ...\nTry running config again:\n\tlolcommits --config -p slack\n")
+            must_output("Posting to Slack ... failed! Timed out connecting to server - retrying ...\nPosting to Slack ... failed! Timed out connecting to server - giving up ...\nTry running config again:\n\tlolcommits --config -p slack\n")
 
           assert_requested :post, plugin.class::ENDPOINT_URL,
             headers: { 'Content-Type' => /multipart\/form-data;/ },
@@ -87,46 +67,37 @@ describe Lolcommits::Plugin::Slack do
 
     describe '#enabled?' do
       it 'should be false by default' do
-        plugin.enabled?.must_equal false
+        assert_nil plugin.enabled?
       end
 
       it 'should true when configured' do
-        plugin.config = valid_enabled_config
+        plugin.configuration = valid_enabled_config
         plugin.enabled?.must_equal true
       end
     end
 
     describe 'configuration' do
-      it 'should not be configured by default' do
-        plugin.configured?.must_equal false
-      end
-
       it 'should allow plugin options to be configured' do
         configured_plugin_options = {}
 
-        output = fake_io_capture(inputs: %w(true abc-def c1,c3,c4)) do
+        fake_io_capture(inputs: %w(true abc-def c1,c3,c4)) do
           configured_plugin_options = plugin.configure_options!
         end
 
-        configured_plugin_options.must_equal( {
-          "enabled"      => true,
-          "access_token" => 'abc-def',
-          "channels"     => 'c1,c3,c4'
+        configured_plugin_options.must_equal({
+          enabled: true,
+          access_token: 'abc-def',
+          channels: 'c1,c3,c4'
         })
       end
 
-      it 'should indicate when configured' do
-        plugin.config = valid_enabled_config
-        plugin.configured?.must_equal true
-      end
-
       describe '#valid_configuration?' do
         it 'should be false without config set' do
           plugin.valid_configuration?.must_equal(false)
         end
 
         it 'should be true for a valid configuration' do
-          plugin.config = valid_enabled_config
+          plugin.configuration = valid_enabled_config
           plugin.valid_configuration?.must_equal true
         end
       end

data/test/test_helper.rb

@@ -1,26 +1,18 @@
 $LOAD_PATH.unshift File.expand_path('../../lib', __FILE__)
 
-# necessary libs from lolcommits (allowing plugin to run)
-require 'git'
-require 'lolcommits/runner'
-require 'lolcommits/vcs_info'
-require 'lolcommits/backends/git_info'
+# lolcommits gem
+require 'lolcommits'
 
-# lolcommit test helpers
-require 'webmock/minitest'
+# lolcommits test helpers
 require 'lolcommits/test_helpers/git_repo'
 require 'lolcommits/test_helpers/fake_io'
 
 if ENV['COVERAGE']
-  if ENV['TRAVIS']
-    require 'coveralls'
-    Coveralls.wear!
-  else
-    require 'simplecov'
-  end
+  require 'simplecov'
 end
 
 # plugin gem test libs
+require 'webmock/minitest'
 require 'lolcommits/plugin/slack'
 require 'minitest/autorun'
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: lolcommits-slack
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.0.3
 platform: ruby
 authors:
 - Matthew Hutchinson
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-12-05 00:00:00.000000000 Z
+date: 2018-01-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rest-client
@@ -28,16 +28,16 @@ dependencies:
   name: lolcommits
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 0.9.6
+        version: 0.10.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 0.9.6
+        version: 0.10.0
 - !ruby/object:Gem::Dependency
   name: webmock
   requirement: !ruby/object:Gem::Requirement
@@ -108,20 +108,6 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-- !ruby/object:Gem::Dependency
-  name: coveralls
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
 description: Automatically post your lolcommits to Slack
 email:
 - matt@hiddenloop.com
@@ -167,7 +153,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.13
+rubygems_version: 2.7.3
 signing_key: 
 specification_version: 4
 summary: Sends lolcommits to one (or more) Slack channels