lolcommits-dotcom 0.0.2 → 0.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: c26d62730fa7ca1e96b79c5366637f0a9f7fbdf3
-  data.tar.gz: ec06eb2d245009ec5049918d7bf82a912d78c969
+SHA256:
+  metadata.gz: 6673616dd32c9642387841696bd8b826b45bbf2751c9f06a9ce979955a0315a8
+  data.tar.gz: 3e0fa1a3023631bf50b2f7eafea55a7525e98800c96d22d804f5e5780358fcc6
 SHA512:
-  metadata.gz: f1f18f121c4d2811d5814e200b2d69beb44ddd575ea7d7056a650ead253a0ce2576ac7da64d7cb442d2ba7ef6526a9a35097bbba2ce08e494d576d6825d9cdac
-  data.tar.gz: 0fc7245554214d9ae74e69e35b6e3f5cb4988e49448ce6df71a3420435591f1d0e615ebac5158c42c96624817938007adce31e494f71d20eb7303b7faf5ced7c
+  metadata.gz: a2dd6c722ec9ff0de484f3558fd605d2eb23ec8fb0abca12a1b6d3a2431b1112eb44e132a9647d7747f675c413d0cb37a0f3778491b2f811d7081d668068b34f
+  data.tar.gz: 5b34e9d8d9a2e61c5cfce1e1b18f06d5e4b34e9bd8c6c1276628efe8eab298c02fd202849a5a5d4598f713ae5f665bd0029732d8922ec56538dcf34957ce043c

data/.travis.yml

@@ -2,18 +2,19 @@ sudo: false
 language: ruby
 cache: bundler
 rvm:
- - 2.0.0
- - 2.1.10
- - 2.2.8
- - 2.3.5
- - 2.4.2
- - ruby-head
+  - 2.0.0
+  - 2.1.10
+  - 2.2.9
+  - 2.3.6
+  - 2.4.3
+  - 2.5.0
+  - ruby-head
 
 before_install:
- - gem install bundler -v 1.13.7
- - git --version
- - git config --global user.email "lol@commits.org"
- - git config --global user.name "Lolcommits"
+  - gem update --system
+  - git --version
+  - git config --global user.email "lol@commits.org"
+  - git config --global user.name "Lolcommits"
 
 matrix:
   allow_failures:

data/lib/lolcommits/dotcom/version.rb

@@ -1,5 +1,5 @@
 module Lolcommits
   module Dotcom
-    VERSION = "0.0.2".freeze
+    VERSION = "0.0.3".freeze
   end
 end

data/lib/lolcommits/plugin/dotcom.rb

@@ -15,15 +15,6 @@ module Lolcommits
         options.concat(plugin_options)
       end
 
-      ##
-      # Returns the name of the plugin to identify the plugin to lolcommits.
-      #
-      # @return [String] the plugin name
-      #
-      def self.name
-        'dotcom'
-      end
-
       ##
       # Returns position(s) of when this plugin should run during the capture
       # process. Uploading happens when a new capture is ready.
@@ -34,16 +25,6 @@ module Lolcommits
         [:capture_ready]
       end
 
-      ##
-      # Returns true if the plugin has been configured.
-      #
-      # @return [Boolean] true/false indicating if plugin is configured
-      #
-      def configured?
-        !configuration.values.empty? &&
-          configuration.values.all? { |value| !value.nil? }
-      end
-
       ##
       # Returns true/false indicating if the plugin has been correctly
       # configured. All options must be set with 32 character alphanumeric keys.
@@ -84,13 +65,13 @@ module Lolcommits
           {
             git_commit: {
               sha: runner.sha,
-              repo_external_id: configuration['repo_id'],
+              repo_external_id: configuration[:repo_id],
               image: File.open(runner.main_image),
               raw: File.open(runner.snapshot_loc)
             },
-            key: configuration['api_key'],
+            key: configuration[:api_key],
             t: t,
-            token: Digest::SHA1.hexdigest(configuration['api_secret'] + t)
+            token: Digest::SHA1.hexdigest(configuration[:api_secret] + t)
           }
         )
       rescue => e
@@ -107,7 +88,7 @@ module Lolcommits
       # @return [Array] the option names
       #
       def plugin_options
-        %w(api_key api_secret repo_id)
+        [:api_key, :api_secret, :repo_id]
       end
     end
   end

data/lolcommits-dotcom.gemspec

@@ -37,7 +37,7 @@ Gem::Specification.new do |spec|
 
   spec.add_runtime_dependency "rest-client"
 
-  spec.add_development_dependency "lolcommits", ">= 0.9.5"
+  spec.add_development_dependency "lolcommits", ">= 0.10.0"
   spec.add_development_dependency "bundler"
   spec.add_development_dependency "webmock"
   spec.add_development_dependency "pry"

data/test/lolcommits/plugin/dotcom_test.rb

@@ -6,14 +6,6 @@ describe Lolcommits::Plugin::Dotcom do
   include Lolcommits::TestHelpers::GitRepo
   include Lolcommits::TestHelpers::FakeIO
 
-  def plugin_name
-    "dotcom"
-  end
-
-  it "should have a name" do
-    ::Lolcommits::Plugin::Dotcom.name.must_equal plugin_name
-  end
-
   it "should run on capture ready" do
     ::Lolcommits::Plugin::Dotcom.runner_order.must_equal [:capture_ready]
   end
@@ -24,10 +16,6 @@ describe Lolcommits::Plugin::Dotcom do
       @runner ||= Lolcommits::Runner.new(
         main_image: Tempfile.new('main_image.jpg'),
         snapshot_loc: Tempfile.new('snapshot_loc.jpg'),
-        config: OpenStruct.new(
-          read_configuration: {},
-          loldir: File.expand_path("#{__dir__}../../../images")
-        )
       )
     end
 
@@ -36,37 +24,28 @@ describe Lolcommits::Plugin::Dotcom do
     end
 
     def valid_enabled_config
-      @config ||= OpenStruct.new(
-        read_configuration: {
-          "dotcom" => {
-            "enabled" => true,
-            "api_key"    => 'aaa8e2404ef6013556db5a9828apikey',
-            'api_secret' => 'aaa8e2404ef6013556db5a9apisecret',
-            "repo_id"    => "aaa8e2404ef6013556db5a9828repoid"
-          }
-        }
-      )
+      {
+        enabled: true,
+        api_key: 'aaa8e2404ef6013556db5a9828apikey',
+        api_secret: 'aaa8e2404ef6013556db5a9apisecret',
+        repo_id: "aaa8e2404ef6013556db5a9828repoid"
+      }
     end
 
     describe "initalizing" do
       it "assigns runner and all plugin options" do
         plugin.runner.must_equal runner
-        plugin.options.must_equal %w(
-          enabled
-          api_key
-          api_secret
-          repo_id
-        )
+        plugin.options.must_equal [:enabled, :api_key, :api_secret, :repo_id]
       end
     end
 
     describe "#enabled?" do
       it "is false by default" do
-        plugin.enabled?.must_equal false
+        assert_nil plugin.enabled?
       end
 
       it "is true when configured" do
-        plugin.config = valid_enabled_config
+        plugin.configuration = valid_enabled_config
         plugin.enabled?.must_equal true
       end
     end
@@ -77,7 +56,7 @@ describe Lolcommits::Plugin::Dotcom do
 
       it "uploads lolcommits to dot com server endpoint" do
         in_repo do
-          plugin.config = valid_enabled_config
+          plugin.configuration = valid_enabled_config
           stub_request(:post, /^http\:\/\/lolcommits-dot-com.herokuapp.com/).to_return(status: 200)
 
           plugin.run_capture_ready
@@ -101,15 +80,6 @@ describe Lolcommits::Plugin::Dotcom do
     end
 
     describe "configuration" do
-      it "returns false when not configured" do
-        plugin.configured?.must_equal false
-      end
-
-      it "returns true when configured" do
-        plugin.config = valid_enabled_config
-        plugin.configured?.must_equal true
-      end
-
       it "allows plugin options to be configured" do
         # enabled, api_key, api_secret repo_id
         inputs = %w(
@@ -125,23 +95,21 @@ describe Lolcommits::Plugin::Dotcom do
         end
 
         configured_plugin_options.must_equal({
-          "enabled" => true,
-          "api_key" => "aaa8e2404ef6013556db5a9828apikey",
-          "api_secret" => "aaa8e2404ef6013556db5a9apisecret",
-          "repo_id" => "aaa8e2404ef6013556db5a9828repoid"
+          enabled: true,
+          api_key: "aaa8e2404ef6013556db5a9828apikey",
+          api_secret: "aaa8e2404ef6013556db5a9apisecret",
+          repo_id: "aaa8e2404ef6013556db5a9828repoid"
         })
       end
 
       describe "#valid_configuration?" do
         it "returns false for an invalid configuration" do
-          plugin.config = OpenStruct.new(read_configuration: {
-            "dotcom" => { "repo_id" => "gibberish" }
-          })
+          plugin.configuration = { repo_id: "gibberish" }
           plugin.valid_configuration?.must_equal false
         end
 
         it "returns true with a valid configuration" do
-          plugin.config = valid_enabled_config
+          plugin.configuration = valid_enabled_config
           plugin.valid_configuration?.must_equal true
         end
       end

data/test/test_helper.rb

@@ -1,10 +1,7 @@
 $LOAD_PATH.unshift File.expand_path('../../lib', __FILE__)
 
-# necessary libs from lolcommits (allowing plugin to run)
-require 'git'
-require 'lolcommits/runner'
-require 'lolcommits/vcs_info'
-require 'lolcommits/backends/git_info'
+# lolcommits gem
+require 'lolcommits'
 
 # lolcommit test helpers
 require 'lolcommits/test_helpers/git_repo'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: lolcommits-dotcom
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.0.3
 platform: ruby
 authors:
 - Matthew Hutchinson
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-12-06 00:00:00.000000000 Z
+date: 2018-01-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rest-client
@@ -30,14 +30,14 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.9.5
+        version: 0.10.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.9.5
+        version: 0.10.0
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
@@ -169,7 +169,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.13
+rubygems_version: 2.7.3
 signing_key: 
 specification_version: 4
 summary: Uploads lolcommits to a remote server