lol_static 0.0.7 → 0.0.8

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: debfeb6efa88cc7fd0ce0959fb5be914ab7a595b
-  data.tar.gz: d861a73c7f8ed565e22f5b6c278266f0fad1aa03
+  metadata.gz: e2590a57c64958ce913e12f182f8800f6d822ceb
+  data.tar.gz: 4e730334954c16b91bbd401f4da4eab77bb3ddad
 SHA512:
-  metadata.gz: 54e4c9229cab511274227938f5702f3b3e42e9121a657ae4a1b4eed311b63b1875428acd93ba947754df70c59aadca8c7fab7c0f6dd58b38b229290499b0cf3c
-  data.tar.gz: e5c9cae4bbfab3ea5d5d03d2f099853ab9b5a33e42d1c2e789524749f3b72518eb3d6f0392aaeaa2a3b06174dea36e25cbd4a892a76f18d0f88c4e770a69ae44
+  metadata.gz: f5ba1d608a978d4bf2608e4641b3703b1ef064315960960747ee6d6b4dd9b254ca344ec1591c2a9052094e6250882c0f3e34be23a3db35c28f2d6ce19f3f4fed
+  data.tar.gz: 6102a639057a0a3fb0cc6d5e17ea1088dcd57795f4172246812a1a610095e423c02f1cc57c20ff7444830b8362a6a3489406369cc626a4ed78bb810e294b2df5

data/lib/lol_static.rb

@@ -1,24 +1,6 @@
 require 'lol_static/version'
-require 'lol_static/item'
-require 'lol_static/spell'
-require 'lol_static/realm'
-require 'lol_static/champion'
-
+require 'lol_static/client'
 
 module LolStatic
-  class << self
-
-    def item(id)
-      Item.new(id)
-    end
-
-    def spell(id)
-      Spell.new(id)
-    end
-
-    def champion(id)
-      Champion.new(id)
-    end
 
-  end
 end

data/lib/lol_static/client.rb

@@ -0,0 +1,26 @@
+require 'lol_static/realm'
+require 'lol_static/item'
+require 'lol_static/spell'
+require 'lol_static/champion'
+
+module LolStatic
+  class Client
+
+    def initialize
+      @realm = Realm.new
+    end
+
+    def item(id)
+      Item.new(id, @realm)
+    end
+
+    def spell(id)
+      Spell.new(id, @realm)
+    end
+
+    def champion(id)
+      Champion.new(id, @realm)
+    end
+
+  end
+end

data/lib/lol_static/endpoint.rb

@@ -1,26 +1,20 @@
 require 'open-uri'
-require 'lol_static/config'
 
 module LolStatic
   class Endpoint
 
-    def self.api_version
-      LolStatic::Config.api_version(key)
-    end
-
-    def initialize(id)
+    def initialize(id, realm)
       @id = id
+      @realm = realm
     end
 
     def image_url
-      "#{LolStatic::Config.base_uri}/#{self.class.api_version}/img/#{self.class.key}/#{@id}.png"
+      "#{@realm.base_uri}/#{api_version}/img/#{self.class.key}/#{@id}.png"
     end
 
     def download(path)
-      open(image_url) do |image|
-        File.open(path, 'wb') do |f|
-          f.write(image.read)
-        end
+      File.open(path, 'wb') do |f|
+        f.write(read)
       end
     rescue OpenURI::HTTPError
       false
@@ -28,5 +22,15 @@ module LolStatic
       true
     end
 
+    def read
+      open(image_url) do |image|
+        image.read
+      end
+    end
+
+    def api_version
+      @realm.api_version(self.class.key)
+    end
+
   end
 end

data/lib/lol_static/realm.rb

@@ -3,6 +3,10 @@ require 'httparty'
 module LolStatic
   class Realm
 
+    def initialize
+      @mutex = Mutex.new
+    end
+
     def base_uri
       realm_data['cdn']
     end
@@ -14,7 +18,9 @@ module LolStatic
   private
 
     def realm_data
-      @realm_data ||= HTTParty.get('http://ddragon.leagueoflegends.com/realms/euw.json').parsed_response
+      @mutex.synchronize do
+        @realm_data ||= HTTParty.get('http://ddragon.leagueoflegends.com/realms/euw.json').parsed_response
+      end
     end
 
   end

data/lib/lol_static/version.rb

@@ -1,3 +1,3 @@
 module LolStatic
-  VERSION = '0.0.7'
+  VERSION = '0.0.8'
 end

data/spec/integration/client_spec.rb

@@ -0,0 +1,14 @@
+require 'spec_helper'
+
+require 'lol_static/client'
+
+describe LolStatic::Client, vcr: { cassette_name: 'realm' } do
+
+  let(:client) { LolStatic::Client.new }
+
+  describe '#item' do
+    it 'does not raise error' do
+      expect { client.item(1) }.to_not raise_error
+    end
+  end
+end

data/spec/spec_helper.rb

@@ -2,11 +2,8 @@ require 'vcr'
 
 ROOT_DIR = File.dirname(File.dirname(__FILE__))
 
-RSpec.configure do |c|
-  c.extend VCR::RSpec::Macros
-end
-
 VCR.configure do |c|
   c.cassette_library_dir = File.join(ROOT_DIR, 'spec', 'fixtures')
   c.hook_into :webmock # or :fakeweb
+  c.configure_rspec_metadata!
 end

data/spec/unit/champion_spec.rb

@@ -0,0 +1,13 @@
+require 'spec_helper'
+
+require 'lol_static/champion'
+
+describe LolStatic::Champion do
+
+  describe '.key' do
+    it 'returns champion' do
+      expect(LolStatic::Champion.key).to eq('champion')
+    end
+  end
+
+end

data/spec/unit/endpoint_spec.rb

@@ -0,0 +1,31 @@
+require 'spec_helper'
+
+require 'lol_static/endpoint'
+
+class ConcreteEndpoint < LolStatic::Endpoint
+
+  def self.key
+    'key'
+  end
+
+end
+
+describe LolStatic::Endpoint do
+
+  let(:id) { 1 }
+  let(:realm) { double('realm', api_version: '4.4.3', base_uri: 'http://ddragon.leagueoflegends.com/cdn') }
+
+  let(:endpoint) { ConcreteEndpoint.new(id, realm) }
+
+  describe '#api_version' do
+    it 'returns api version' do
+      expect(endpoint.api_version).to eq('4.4.3')
+    end
+  end
+
+  describe '#image_url' do
+    it 'returns image url' do
+      expect(endpoint.image_url).to eq("http://ddragon.leagueoflegends.com/cdn/4.4.3/img/key/#{id}.png")
+    end
+  end
+end

data/spec/unit/item_spec.rb

@@ -0,0 +1,13 @@
+require 'spec_helper'
+
+require 'lol_static/item'
+
+describe LolStatic::Item do
+
+  describe '.key' do
+    it 'returns item' do
+      expect(LolStatic::Item.key).to eq('item')
+    end
+  end
+
+end

data/spec/unit/realm_spec.rb

@@ -0,0 +1,20 @@
+require 'spec_helper'
+
+require 'lol_static/realm'
+
+describe LolStatic::Realm, vcr: { cassette_name: 'realm' } do
+
+  describe '#base_uri' do
+    it 'returns correct uri' do
+      realm = LolStatic::Realm.new
+      expect(realm.base_uri).to eq('http://ddragon.leagueoflegends.com/cdn')
+    end
+  end
+
+  describe '#api_version' do
+    it 'returns correct version for item' do
+      realm = LolStatic::Realm.new
+      expect(realm.api_version('item')).to eq('4.4.3')
+    end
+  end
+end

data/spec/unit/spell_spec.rb

@@ -0,0 +1,12 @@
+require 'spec_helper'
+
+require 'lol_static/spell'
+
+describe LolStatic::Spell do
+
+  describe '.key' do
+    it 'returns spell' do
+      expect(LolStatic::Spell.key).to eq('spell')
+    end
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: lol_static
 version: !ruby/object:Gem::Version
-  version: 0.0.7
+  version: 0.0.8
 platform: ruby
 authors:
 - Cameron Martin
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-03-22 00:00:00.000000000 Z
+date: 2014-03-31 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -108,7 +108,7 @@ files:
 - Rakefile
 - lib/lol_static.rb
 - lib/lol_static/champion.rb
-- lib/lol_static/config.rb
+- lib/lol_static/client.rb
 - lib/lol_static/endpoint.rb
 - lib/lol_static/item.rb
 - lib/lol_static/realm.rb
@@ -116,11 +116,13 @@ files:
 - lib/lol_static/version.rb
 - lol_static.gemspec
 - spec/fixtures/realm.yml
-- spec/lol_static/champion_spec.rb
-- spec/lol_static/item_spec.rb
-- spec/lol_static/realm_spec.rb
-- spec/lol_static/spell_spec.rb
+- spec/integration/client_spec.rb
 - spec/spec_helper.rb
+- spec/unit/champion_spec.rb
+- spec/unit/endpoint_spec.rb
+- spec/unit/item_spec.rb
+- spec/unit/realm_spec.rb
+- spec/unit/spell_spec.rb
 homepage: ''
 licenses:
 - MIT
@@ -147,9 +149,11 @@ specification_version: 4
 summary: Fetches static content from the league of legends CDN
 test_files:
 - spec/fixtures/realm.yml
-- spec/lol_static/champion_spec.rb
-- spec/lol_static/item_spec.rb
-- spec/lol_static/realm_spec.rb
-- spec/lol_static/spell_spec.rb
+- spec/integration/client_spec.rb
 - spec/spec_helper.rb
+- spec/unit/champion_spec.rb
+- spec/unit/endpoint_spec.rb
+- spec/unit/item_spec.rb
+- spec/unit/realm_spec.rb
+- spec/unit/spell_spec.rb
 has_rdoc: 

data/lib/lol_static/config.rb

@@ -1,21 +0,0 @@
-module LolStatic
-  Config = Object.new.tap do |object|
-    class << object
-
-      def api_version(*args)
-        realm.api_version(*args)
-      end
-
-      def base_uri
-        realm.base_uri
-      end
-
-    private
-
-      def realm
-        @realm ||= Realm.new
-      end
-
-    end
-  end
-end

data/spec/lol_static/champion_spec.rb

@@ -1,24 +0,0 @@
-require 'spec_helper'
-
-require 'lol_static/champion'
-
-describe LolStatic::Champion do
-
-  use_vcr_cassette 'realm'
-
-  let(:id) { 'Champion' }
-
-  let(:spell) { LolStatic::Champion.new(id) }
-
-  describe '.api_version' do
-    it 'returns api version' do
-      expect(LolStatic::Champion.api_version).to eq('4.4.3')
-    end
-  end
-
-  describe '#image_url' do
-    it 'returns image url' do
-      expect(spell.image_url).to eq("http://ddragon.leagueoflegends.com/cdn/4.4.3/img/champion/#{id}.png")
-    end
-  end
-end

data/spec/lol_static/item_spec.rb

@@ -1,24 +0,0 @@
-require 'spec_helper'
-
-require 'lol_static/item'
-
-describe LolStatic::Item do
-
-  use_vcr_cassette 'realm'
-
-  let(:id) { 1 }
-  let(:item) { LolStatic::Item.new(id) }
-
-  describe '.api_version' do
-    it 'returns api version' do
-      expect(LolStatic::Item.api_version).to eq('4.4.3')
-    end
-  end
-
-  describe '#image_url' do
-    it 'returns image url' do
-      item = LolStatic::Item.new(1)
-      expect(item.image_url).to eq("http://ddragon.leagueoflegends.com/cdn/4.4.3/img/item/#{id}.png")
-    end
-  end
-end

data/spec/lol_static/realm_spec.rb

@@ -1,23 +0,0 @@
-require 'spec_helper'
-
-require 'lol_static/realm'
-
-describe LolStatic::Realm do
-  describe '#base_uri' do
-    it 'returns correct uri' do
-      VCR.use_cassette('realm') do
-        realm = LolStatic::Realm.new
-        expect(realm.base_uri).to eq('http://ddragon.leagueoflegends.com/cdn')
-      end
-    end
-  end
-
-  describe '#api_version' do
-    it 'returns correct version for item' do
-      VCR.use_cassette('realm') do
-        realm = LolStatic::Realm.new
-        expect(realm.api_version('item')).to eq('4.4.3')
-      end
-    end
-  end
-end

data/spec/lol_static/spell_spec.rb

@@ -1,24 +0,0 @@
-require 'spec_helper'
-
-require 'lol_static/spell'
-
-describe LolStatic::Spell do
-
-  use_vcr_cassette 'realm'
-
-  let(:id) { 'Spell' }
-
-  let(:spell) { LolStatic::Spell.new(id) }
-
-  describe '.api_version' do
-    it 'returns api version' do
-      expect(LolStatic::Spell.api_version).to eq('4.4.3')
-    end
-  end
-
-  describe '#image_url' do
-    it 'returns image url' do
-      expect(spell.image_url).to eq("http://ddragon.leagueoflegends.com/cdn/4.4.3/img/spell/#{id}.png")
-    end
-  end
-end