lol_static 0.0.6 → 0.0.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: cd63390f5fd29ace9c415bad9e93121836151c1d
-  data.tar.gz: a4db75b631e2a40137f14a634dfc8bcae4845dfc
+  metadata.gz: debfeb6efa88cc7fd0ce0959fb5be914ab7a595b
+  data.tar.gz: d861a73c7f8ed565e22f5b6c278266f0fad1aa03
 SHA512:
-  metadata.gz: 54e99065a57b04948128a1aa4a1a42fde219dacdaf8c4bc2f95c0239543bdc05437325730396957acbd83fda382b6f38e6a6463400afa4ea7ab3904347eaa6dd
-  data.tar.gz: f7916750278a3f435d8621d5184c7f09de9b68f6eebe349bb919cff86cef03ca01c6bfe19222d317af081f14f0bc5a7dd314e5ba65d6089e1a4b57f2ff068ff0
+  metadata.gz: 54e4c9229cab511274227938f5702f3b3e42e9121a657ae4a1b4eed311b63b1875428acd93ba947754df70c59aadca8c7fab7c0f6dd58b38b229290499b0cf3c
+  data.tar.gz: e5c9cae4bbfab3ea5d5d03d2f099853ab9b5a33e42d1c2e789524749f3b72518eb3d6f0392aaeaa2a3b06174dea36e25cbd4a892a76f18d0f88c4e770a69ae44

data/lib/lol_static/champion.rb

@@ -0,0 +1,11 @@
+require 'lol_static/endpoint'
+
+module LolStatic
+  class Champion < Endpoint
+
+    def self.key
+      'champion'
+    end
+
+  end
+end

data/lib/lol_static/config.rb

@@ -0,0 +1,21 @@
+module LolStatic
+  Config = Object.new.tap do |object|
+    class << object
+
+      def api_version(*args)
+        realm.api_version(*args)
+      end
+
+      def base_uri
+        realm.base_uri
+      end
+
+    private
+
+      def realm
+        @realm ||= Realm.new
+      end
+
+    end
+  end
+end

data/lib/lol_static/endpoint.rb

@@ -1,18 +1,19 @@
 require 'open-uri'
+require 'lol_static/config'
 
 module LolStatic
   class Endpoint
 
     def self.api_version
-      LolStatic.api_version
+      LolStatic::Config.api_version(key)
     end
 
     def initialize(id)
       @id = id
     end
 
-    def api_version
-      self.class.api_version
+    def image_url
+      "#{LolStatic::Config.base_uri}/#{self.class.api_version}/img/#{self.class.key}/#{@id}.png"
     end
 
     def download(path)

data/lib/lol_static/item.rb

@@ -1,15 +1,10 @@
-require 'lol_static'
 require 'lol_static/endpoint'
 
 module LolStatic
   class Item < Endpoint
 
-    def self.api_version
-      LolStatic.api_version('item')
-    end
-
-    def image_url
-      "#{LolStatic.base_uri}/#{api_version}/img/item/#{@id}.png"
+    def self.key
+      'item'
     end
 
   end

data/lib/lol_static/realm.rb

@@ -8,7 +8,7 @@ module LolStatic
     end
 
     def api_version(name=nil)
-      name ? realm_data['n'][name.to_s] : realm_data['v']
+      realm_data['n'].has_key?(name.to_s) ? realm_data['n'][name.to_s] : realm_data['v']
     end
 
   private

data/lib/lol_static/spell.rb

@@ -1,11 +1,10 @@
-require 'lol_static'
 require 'lol_static/endpoint'
 
 module LolStatic
   class Spell < Endpoint
 
-    def image_url
-      "#{LolStatic.base_uri}/#{api_version}/img/spell/#{@id}.png"
+    def self.key
+      'spell'
     end
 
   end

data/lib/lol_static/version.rb

@@ -1,3 +1,3 @@
 module LolStatic
-  VERSION = '0.0.6'
+  VERSION = '0.0.7'
 end

data/lib/lol_static.rb

@@ -2,17 +2,11 @@ require 'lol_static/version'
 require 'lol_static/item'
 require 'lol_static/spell'
 require 'lol_static/realm'
+require 'lol_static/champion'
 
 
 module LolStatic
   class << self
-    def api_version(*args)
-      realm.api_version(*args)
-    end
-
-    def base_uri
-      realm.base_uri
-    end
 
     def item(id)
       Item.new(id)
@@ -22,10 +16,8 @@ module LolStatic
       Spell.new(id)
     end
 
-  private
-
-    def realm
-      @realm ||= Realm.new
+    def champion(id)
+      Champion.new(id)
     end
 
   end

data/spec/lol_static/champion_spec.rb

@@ -0,0 +1,24 @@
+require 'spec_helper'
+
+require 'lol_static/champion'
+
+describe LolStatic::Champion do
+
+  use_vcr_cassette 'realm'
+
+  let(:id) { 'Champion' }
+
+  let(:spell) { LolStatic::Champion.new(id) }
+
+  describe '.api_version' do
+    it 'returns api version' do
+      expect(LolStatic::Champion.api_version).to eq('4.4.3')
+    end
+  end
+
+  describe '#image_url' do
+    it 'returns image url' do
+      expect(spell.image_url).to eq("http://ddragon.leagueoflegends.com/cdn/4.4.3/img/champion/#{id}.png")
+    end
+  end
+end

data/spec/lol_static/spell_spec.rb

@@ -6,9 +6,9 @@ describe LolStatic::Spell do
 
   use_vcr_cassette 'realm'
 
-  let(:id) {  }
+  let(:id) { 'Spell' }
 
-  let(:spell) { LolStatic::Spell.new('Spell') }
+  let(:spell) { LolStatic::Spell.new(id) }
 
   describe '.api_version' do
     it 'returns api version' do
@@ -18,7 +18,7 @@ describe LolStatic::Spell do
 
   describe '#image_url' do
     it 'returns image url' do
-      expect(spell.image_url).to eq('http://ddragon.leagueoflegends.com/cdn/4.4.3/img/spell/Spell.png')
+      expect(spell.image_url).to eq("http://ddragon.leagueoflegends.com/cdn/4.4.3/img/spell/#{id}.png")
     end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: lol_static
 version: !ruby/object:Gem::Version
-  version: 0.0.6
+  version: 0.0.7
 platform: ruby
 authors:
 - Cameron Martin
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-03-21 00:00:00.000000000 Z
+date: 2014-03-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -107,6 +107,8 @@ files:
 - README.md
 - Rakefile
 - lib/lol_static.rb
+- lib/lol_static/champion.rb
+- lib/lol_static/config.rb
 - lib/lol_static/endpoint.rb
 - lib/lol_static/item.rb
 - lib/lol_static/realm.rb
@@ -114,6 +116,7 @@ files:
 - lib/lol_static/version.rb
 - lol_static.gemspec
 - spec/fixtures/realm.yml
+- spec/lol_static/champion_spec.rb
 - spec/lol_static/item_spec.rb
 - spec/lol_static/realm_spec.rb
 - spec/lol_static/spell_spec.rb
@@ -144,6 +147,7 @@ specification_version: 4
 summary: Fetches static content from the league of legends CDN
 test_files:
 - spec/fixtures/realm.yml
+- spec/lol_static/champion_spec.rb
 - spec/lol_static/item_spec.rb
 - spec/lol_static/realm_spec.rb
 - spec/lol_static/spell_spec.rb