lol_dba 2.1.5 → 2.1.6

metadata

@@ -1,26 +1,25 @@
 --- !ruby/object:Gem::Specification
 name: lol_dba
 version: !ruby/object:Gem::Version
-  version: 2.1.5
+  version: 2.1.6
 platform: ruby
 authors:
 - Diego Plentz
-- Elad Meidar
-- Eric Davis
-- Muness Alrubaie
-- Vladimir Sharshov
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-03-04 00:00:00.000000000 Z
+date: 2019-04-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
-  name: activerecord
+  name: actionpack
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
         version: '3.0'
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '6.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -28,13 +27,19 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '3.0'
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '6.0'
 - !ruby/object:Gem::Dependency
-  name: actionpack
+  name: activerecord
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
         version: '3.0'
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '6.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -42,6 +47,9 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '3.0'
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '6.0'
 - !ruby/object:Gem::Dependency
   name: railties
   requirement: !ruby/object:Gem::Requirement
@@ -49,6 +57,9 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '3.0'
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '6.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -56,8 +67,53 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '3.0'
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '6.0'
 - !ruby/object:Gem::Dependency
   name: appraisal
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '2.2'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '2.2'
+- !ruby/object:Gem::Dependency
+  name: simplecov
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.1'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.1'
+- !ruby/object:Gem::Dependency
+  name: sqlite3
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 1.3.5
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 1.3.5
+- !ruby/object:Gem::Dependency
+  name: rspec-rails
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -74,16 +130,16 @@ description: lol_dba is a small package of rake tasks that scan your application
   and displays a list of columns that probably should be indexed. Also, it can generate
   .sql migration scripts.
 email:
-- diego@plentz.org
-- elad@eizesus.com
-- ''
-- vsharshov@gmail.com
+- diego@plentz.io
 executables:
 - lol_dba
 extensions: []
 extra_rdoc_files: []
 files:
+- ".codeclimate.yml"
 - ".gitignore"
+- ".rspec"
+- ".rubocop.yml"
 - ".travis.yml"
 - Appraisals
 - Gemfile
@@ -103,17 +159,28 @@ files:
 - gemfiles/rails_5_0.gemfile.lock
 - gemfiles/rails_5_1.gemfile
 - gemfiles/rails_5_1.gemfile.lock
+- gemfiles/rails_5_2.gemfile
+- gemfiles/rails_5_2.gemfile.lock
 - lib/lol_dba.rb
 - lib/lol_dba/cli.rb
-- lib/lol_dba/migration.rb
+- lib/lol_dba/index_finding/belongs_to.rb
+- lib/lol_dba/index_finding/error_logging.rb
+- lib/lol_dba/index_finding/has_and_belongs_to_many.rb
+- lib/lol_dba/index_finding/has_many.rb
+- lib/lol_dba/index_finding/index_finder.rb
+- lib/lol_dba/index_finding/migration_formatter.rb
+- lib/lol_dba/index_finding/relation_inspector.rb
+- lib/lol_dba/index_finding/relation_inspector_factory.rb
+- lib/lol_dba/rails_compatibility.rb
 - lib/lol_dba/railtie.rb
-- lib/lol_dba/sql_generator.rb
+- lib/lol_dba/sql_migrations/migration.rb
+- lib/lol_dba/sql_migrations/migration_mocker.rb
+- lib/lol_dba/sql_migrations/sql_generator.rb
+- lib/lol_dba/sql_migrations/writer.rb
 - lib/lol_dba/version.rb
-- lib/lol_dba/writer.rb
 - lib/tasks/lol_dba.rake
 - lol_dba.gemspec
 - spec/associations_index_spec.rb
-- spec/common_function_spec.rb
 - spec/fixtures/app/models/address.rb
 - spec/fixtures/app/models/billable_week.rb
 - spec/fixtures/app/models/company.rb
@@ -134,7 +201,9 @@ files:
 - spec/fixtures/app/models/worker_user.rb
 - spec/fixtures/app/models/wrong.rb
 - spec/fixtures/schema.rb
+- spec/migration_formatter_spec.rb
 - spec/spec_helper.rb
+- spec/sql_generator_spec.rb
 homepage: https://github.com/plentz/lol_dba
 licenses:
 - MIT
@@ -155,15 +224,13 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.7.6
+rubygems_version: 3.0.2
 signing_key: 
 specification_version: 4
 summary: A small package of rake tasks to track down missing database indexes and
   generate sql migration scripts
 test_files:
 - spec/associations_index_spec.rb
-- spec/common_function_spec.rb
 - spec/fixtures/app/models/address.rb
 - spec/fixtures/app/models/billable_week.rb
 - spec/fixtures/app/models/company.rb
@@ -184,4 +251,6 @@ test_files:
 - spec/fixtures/app/models/worker_user.rb
 - spec/fixtures/app/models/wrong.rb
 - spec/fixtures/schema.rb
+- spec/migration_formatter_spec.rb
 - spec/spec_helper.rb
+- spec/sql_generator_spec.rb

data/lib/lol_dba/migration.rb

@@ -1,40 +0,0 @@
-module LolDba
-  class Migration
-    attr_accessor :full_name
-
-    def initialize(migration_file)
-      self.full_name = File.basename(migration_file, ".rb")
-      require Rails.root.join(migration_file)
-    end
-
-    def number
-      /^(\d+)_(.*)$/.match(full_name)[1]
-    end
-
-    def name
-      /^(\d+)_(.*)$/.match(full_name)[2]
-    end
-
-    def to_s
-      full_name
-    end
-
-    def migration_class
-      name.camelize.split(".")[0].constantize
-    end
-
-    def up
-      migration_class.migrate(:up)
-      connection.execute("INSERT INTO schema_migrations (version) VALUES (#{number})")
-    end
-
-    def down
-      migration_class.migrate(:down)
-      connection.execute("DELETE FROM schema_migrations WHERE version = #{number}")
-    end
-
-    def connection
-      ActiveRecord::Base.connection
-    end
-  end
-end

data/lib/lol_dba/sql_generator.rb

@@ -1,96 +0,0 @@
-module LolDba
-  class SqlGenerator
-    class << self
-
-      def connection
-        ActiveRecord::Base.connection
-      end
-
-      def methods_to_modify
-        [:execute, :do_execute, :rename_column, :change_column, :column_for, :tables, :indexes, :select_all] & connection.methods
-      end
-
-      def redefine_execute_methods
-        save_original_methods
-        connection.class.send(:define_method, :execute) { |*args|
-          if args.first =~ /SELECT "schema_migrations"."version"/ || args.first =~ /^SHOW/
-            self.orig_execute(*args)
-          else
-            Writer.write(to_sql(args.first, args.last))
-          end
-        }
-        connection.class.send(:define_method, :do_execute) { |*args|
-          if args.first =~ /SELECT "schema_migrations"."version"/ || args.first =~ /^SHOW/
-             self.orig_do_execute(*args)
-          else
-            Writer.write(to_sql(args.first, args.last))
-          end
-        }
-        connection.class.send(:define_method, :column_for) { |*args| args.last }
-        connection.class.send(:define_method, :change_column) { |*args| [] }
-        connection.class.send(:define_method, :rename_column) { |*args| [] }
-        connection.class.send(:define_method, :tables) { |*args| [] }
-        connection.class.send(:define_method, :select_all) { |*args| [] }
-        connection.class.send(:define_method, :indexes) { |*args| [] }
-        connection.class.send(:define_method, :index_name_exists?) { |*args| args[2] } #returns always the default(args[2])
-      end
-
-      def save_original_methods
-        methods_to_modify.each do |method_name|
-          connection.class.send(:alias_method, "orig_#{method_name}".to_sym, method_name)
-        end
-      end
-
-      def reset_methods
-        methods_to_modify.each do |method_name|
-          connection.class.send(:alias_method, method_name, "orig_#{method_name}".to_sym) rescue nil
-        end
-      end
-
-      def generate_instead_of_executing(&block)
-        LolDba::Writer.reset
-        redefine_execute_methods
-        yield
-        reset_methods
-      end
-
-      def migrations(which)
-        migrator = nil
-        if ::ActiveRecord::VERSION::MAJOR == 4
-          migrator = ActiveRecord::Migrator.new(:up, ActiveRecord::Migrator.migrations(ActiveRecord::Migrator.migrations_path))
-        else
-          migrator = ActiveRecord::Migrator.new(:up, ActiveRecord::Migrator.migrations_path)
-        end
-        if which == "all"
-          migrator.migrations.collect { |m| m.filename }
-        elsif which == "pending"
-          pending = migrator.pending_migrations
-          if pending.empty?
-            puts "No pending migrations."
-            exit
-          end
-          migrator.pending_migrations.collect { |m| m.filename }
-        else
-          if migration = migrator.migrations.find {|m| m.version == which.to_i}
-            [migration.filename]
-          else
-            puts "There are no migrations for version #{which}."
-            exit
-          end
-        end
-      end
-
-      def generate(which)
-        generate_instead_of_executing { migrations(which).each { |file| up_and_down(file) } }
-      end
-
-      def up_and_down(file)
-        migration = LolDba::Migration.new(file)
-        LolDba::Writer.file_name = "#{migration}.sql"
-        migration.up
-        #MigrationSqlGenerator::Writer.file_name = "#{migration}_down.sql"
-        #migration.down
-      end
-    end
-  end
-end

data/lib/lol_dba/writer.rb

@@ -1,25 +0,0 @@
-module LolDba
-  class Writer
-    class << self
-      attr_accessor :file_name
-    
-      def reset
-        FileUtils.rm_rf output_dir
-        Dir.mkdir output_dir
-      end
-  
-      def output_dir
-        File.join(Rails.root, "db", "migrate_sql")
-      end
-  
-      def path
-        File.join(output_dir, file_name)
-      end
-  
-      def write(string)
-        return if file_name.nil?
-        File.open(path, 'a') { |file| file << string; file << ";\n" }
-      end
-    end
-  end
-end

data/spec/common_function_spec.rb

@@ -1,96 +0,0 @@
-require 'spec_helper'
-
-RSpec.describe "Function form_migration_content:" do
-
-  before do
-    @add = ["add_index :report, :_id_test_plan"]
-  end
-
-  it "print migration skeleton with set name" do
-    migration = LolDba.form_migration_content("TestMigration", @add)
-    expect(migration).to match(/class TestMigration/i)
-  end
-
-  it "print migration with add_keys params" do
-    migration = LolDba.form_migration_content("TestMigration", @add)
-    expect(migration).to match(/add_index :report, :_id_test_plan/i)
-  end
-end
-
-RSpec.describe "Function form_data_for_migration:" do
-
-  it "return data for migrations for non-indexed single key in table" do
-    relationship_indexes = {:users => [:user_id]}
-    allow(LolDba).to receive(:key_exists?).with(:users, :user_id).and_return(false)
-
-    add_indexes = LolDba.form_data_for_migration(relationship_indexes)
-
-    expect(add_indexes.first).to eq("add_index :users, :user_id")
-  end
-
-  it "return data for migrations for non-indexed composite key in table" do
-    relationship_indexes = {:friends => [[:user_id, :friend_id]]}
-    allow(LolDba).to receive(:key_exists?).with(:friends, [:user_id, :friend_id]).and_return(false)
-
-    add_indexes = LolDba.form_data_for_migration(relationship_indexes)
-
-    expect(add_indexes.first).to eq("add_index :friends, [:user_id, :friend_id]")
-  end
-
-  it "ignore empty or nil keys for table" do
-    relationship_indexes = {:table => [""], :table2 => [nil]}
-    add_indexes = LolDba.form_data_for_migration(relationship_indexes)
-
-    expect(add_indexes).to be_empty
-  end
-
-end
-
-RSpec.describe "Function key_exists?:" do
-
-  it "return true if key is already indexed" do
-    expect(LolDba.key_exists?("companies", "country_id")).to be_truthy
-  end
-
-  it "return false if key is not indexed yet" do
-    expect(LolDba.key_exists?("addresses", "country_id")).to be_falsey
-  end
-
-  it "return true if key is primary key(default)" do
-    expect(LolDba.key_exists?("addresses", "id")).to be_truthy
-  end
-
-  it "return true if key is custom primary key" do
-    expect(LolDba.key_exists?("gifts", "custom_primary_key")).to be_truthy
-  end
-
-end
-
-RSpec.describe "Function puts_migration_content:" do
-
-  before do
-    @relationship_indexes, warning_messages = LolDba.check_for_indexes
-  end
-
-  it "print migration code" do
-    expect($stdout).to receive(:puts).with("")
-    expect($stdout).to receive(:puts).with(/TIP/)
-    expect($stdout).to receive(:puts).with(/TestMigration/i)
-    LolDba.puts_migration_content("TestMigration", @relationship_indexes, "")
-  end
-
-  it "print warning messages if they exist" do
-    warning = "warning text here"
-    expect($stdout).to receive(:puts).at_least(:once).with(warning)
-    expect($stdout).to receive(:puts)
-
-    LolDba.puts_migration_content("TestMigration", {}, warning)
-  end
-
-  it "print nothing if no indexes and warning messages exist" do
-    expect($stdout).to receive(:puts).with("")
-    expect($stdout).to receive(:puts).with("Yey, no missing indexes found!")
-    LolDba.puts_migration_content("TestMigration",{}, "")
-  end
-
-end