lol_dba 1.2.0 → 1.2.1

data/README.md

@@ -1,4 +1,4 @@
-#Lol DBA
+#lol_dba
 
 lol_dba is a small package of rake tasks that scan your application models and displays a list of columns that probably should be indexed. Also, it can generate .sql migration scripts. Most of the code come from rails_indexes and migration_sql_generator.
 
@@ -20,17 +20,11 @@ Display a migration for adding/removing all necessary indexes based on associati
 
     rake db:find_indexes
 
-Display a migration for adding/removing all necessary indexes based on AR::Base#find calls (including: `find`, `find_by`, `find_all_by`, `find_by_x_and_y`, `find_all_by_x_and_y`):
-
-    rake db:find_query_indexes
-
 Generate .sql files for all your migrations inside db/migrate_sql folder:
 
     rake db:migrate_sql
 
-*Notice:* At now moment it does not support Arel(the new Rails 3 Active Record Query Interface) calls (including: where, joins, includes, from, select...), but still usefull for indexes based on association.
-
-Note that add index in big database may take a long time.
+Note that create an index in a big database may take a long time.
 
 Compatibility
 -------------

data/lib/lol_dba.rb

@@ -179,95 +179,6 @@ EOM
 
   end
 
-  def self.scan_finds
-
-    # Collect all files that can contain queries, in app/ directories (includes plugins and such)
-    # TODO: add lib too ?
-    file_names = []
-
-    Dir.chdir(Rails.root) do
-      file_names = Dir["**/app/**/*.rb"].uniq.reject {|file_with_path| file_with_path.include?('test')}
-    end
-
-    @indexes_required = Hash.new([])
-
-    # Scan each file
-    file_names.each do |file_name|
-      current_file = File.open(File.join(Rails.root, file_name), 'r')
-      begin
-        current_model_name = File.basename(file_name).sub(/\.rb$/,'').camelize
-      rescue
-        # No-op
-      end
-
-      # by default, try to add index on primary key, based on file name
-      # this will fail if the file is not a model file
-
-      klass = current_model_name.split('::').inject(Object){ |klass,part| klass.const_get(part) } rescue next
-      next if !klass.present? || klass < ActiveRecord::Base && klass.abstract_class?
-
-      # Scan each line
-      current_file.each { |line| check_line_for_find_indexes(file_name, line) }
-    end
-
-    missing_indexes, warning_messages = validate_and_sort_indexes(@indexes_required)
-
-  end
-
-  # Check line for find* methods (include find_all, find_by and just find)
-  def self.check_line_for_find_indexes(file_name, line)
-    # TODO: Assumes that you have a called on #find. you can actually call #find without a caller in a model code. ex:
-    # def something
-    #   find(self.id)
-    # end
-    #
-    # find_regexp = Regexp.new(/([A-Z]{1}[A-Za-z]+|self).(find){1}((_all){0,1}(_by_){0,1}([A-Za-z_]+))?\(([0-9A-Za-z"\':=>. \[\]{},]*)\)/)
-
-    find_regexp = Regexp.new(/(([A-Z]{1}[A-Za-z]+|self).)?(find){1}((_all){0,1}(_by_){0,1}([A-Za-z_]+))?\(([0-9A-Za-z"\':=>. \[\]{},]*)\)/)
-
-    # If line matched a finder
-    if matches = find_regexp.match(line)
-
-      model_name, column_names, options = matches[2], matches[7], matches[8]
-
-      # if the finder class is "self" or empty (can be a simple "find()" in a model)
-      if model_name == "self" || model_name.blank?
-        model_name = File.basename(file_name).sub(/\.rb$/,'').camelize
-        table_name = model_name.constantize.table_name
-      else
-        if model_name.respond_to?(:constantize)
-          if model_name.constantize.respond_to?(:table_name)
-            table_name = model_name.constantize.table_name
-          end
-        end
-      end
-
-      # Check that all prerequisites are met
-      if model_name.present? && table_name.present? && model_name.constantize.ancestors.include?(ActiveRecord::Base)
-        primary_key = model_name.constantize.primary_key
-        @indexes_required[table_name] += [primary_key] unless @indexes_required[table_name].include?(primary_key)
-
-        if column_names.present?
-          column_names = column_names.split('_and_')
-
-          # remove find_by_sql references.
-          column_names.delete("sql")
-
-          column_names = model_name.constantize.column_names & column_names
-
-          # Check if there were more than 1 column
-          if column_names.size == 1
-            column_name = column_names.first
-            @indexes_required[table_name] += [column_name] unless @indexes_required[table_name].include?(column_name)
-          else
-            @indexes_required[table_name] += [column_names] unless @indexes_required[table_name].include?(column_names)
-            @indexes_required[table_name] += [column_names.reverse] unless @indexes_required[table_name].include?(column_names.reverse)
-          end
-        end
-      end
-    end
-  end
-
   def self.key_exists?(table,key_columns)
     result = (Array(key_columns) - ActiveRecord::Base.connection.indexes(table).map { |i| i.columns }.flatten)
     #FIXME: Primary key always indexes, but ActiveRecord::Base.connection.indexes not show it!
@@ -290,11 +201,4 @@ EOM
 
     puts_migration_content("AddMissingIndexes", missing_indexes, warning_messages)
   end
-
-  def self.ar_find_indexes(migration_mode=true)
-    find_indexes, warning_messages = self.scan_finds
-    return find_indexes, warning_messages unless migration_mode
-
-    puts_migration_content("AddFindsMissingIndexes", find_indexes, warning_messages)
-  end
 end

data/lib/lol_dba/version.rb

@@ -1,3 +1,3 @@
 module LolDba
-  VERSION = "1.2.0" unless defined? LolDba::VERSION
+  VERSION = "1.2.1" unless defined? LolDba::VERSION
 end

data/lib/tasks/lol_dba.rake

@@ -6,10 +6,6 @@ namespace :db do
   task :find_indexes => :environment do
     LolDba.simple_migration
   end
-  desc "Display a migration for adding/removing all necessary indexes based on AR::Base#find calls"
-  task :find_query_indexes => :environment do
-    LolDba.ar_find_indexes
-  end
   desc "Generate .sql files for all your migrations inside db/migrate_sql folder"
   task :migrate_sql => :environment do
     LolDba::SqlGenerator.generate

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: lol_dba
 version: !ruby/object:Gem::Version
-  version: 1.2.0
+  version: 1.2.1
   prerelease: 
 platform: ruby
 authors:
@@ -17,7 +17,7 @@ date: 2012-03-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
-  requirement: &70236560955460 !ruby/object:Gem::Requirement
+  requirement: &70321919228860 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -25,10 +25,10 @@ dependencies:
         version: '3.0'
   type: :runtime
   prerelease: false
-  version_requirements: *70236560955460
+  version_requirements: *70321919228860
 - !ruby/object:Gem::Dependency
   name: actionpack
-  requirement: &70236560954840 !ruby/object:Gem::Requirement
+  requirement: &70321919228120 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -36,10 +36,10 @@ dependencies:
         version: '3.0'
   type: :runtime
   prerelease: false
-  version_requirements: *70236560954840
+  version_requirements: *70321919228120
 - !ruby/object:Gem::Dependency
   name: railties
-  requirement: &70236560954140 !ruby/object:Gem::Requirement
+  requirement: &70321919227360 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -47,10 +47,10 @@ dependencies:
         version: '3.0'
   type: :runtime
   prerelease: false
-  version_requirements: *70236560954140
+  version_requirements: *70321919227360
 - !ruby/object:Gem::Dependency
   name: sqlite3
-  requirement: &70236560953260 !ruby/object:Gem::Requirement
+  requirement: &70321919226900 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -58,10 +58,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70236560953260
+  version_requirements: *70321919226900
 - !ruby/object:Gem::Dependency
   name: rspec
-  requirement: &70236560952340 !ruby/object:Gem::Requirement
+  requirement: &70321919226000 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -69,7 +69,7 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70236560952340
+  version_requirements: *70321919226000
 description: lol_dba is a small package of rake tasks that scan your application models
   and displays a list of columns that probably should be indexed. Also, it can generate
   .sql migration scripts.