lokalise_rails 1.4.0 → 4.0.0

data/spec/lib/tasks/import_task_spec.rb

@@ -1,121 +1,56 @@
 # frozen_string_literal: true
 
-require 'fileutils'
-
-RSpec.describe LokaliseRails do
-  let(:loc_path) { described_class.locales_path }
-  let(:local_trans) { "#{Rails.root}/public/trans.zip" }
-  let(:remote_trans) { 'https://github.com/bodrovis/lokalise_rails/blob/master/spec/dummy/public/trans.zip?raw=true' }
+RSpec.describe 'Import Rake task' do
+  let(:global_config) { LokaliseRails::GlobalConfig }
+  let(:loc_path) { global_config.locales_path }
 
   it 'halts when the API key is not set' do
-    allow(described_class).to receive(:api_token).and_return(nil)
+    allow(global_config).to receive(:api_token).and_return(nil)
 
     expect(import_executor).to raise_error(SystemExit, /API token is not set/i)
-    expect(described_class).to have_received(:api_token)
+    expect(global_config).to have_received(:api_token)
   end
 
   it 'halts when the project ID is not set' do
-    allow_project_id nil do
-      expect(import_executor).to raise_error(SystemExit, /ID is not set/i)
-    end
-  end
+    allow(global_config).to receive(:project_id).and_return(nil)
 
-  context 'when directory is empty' do
-    before do
-      mkdir_locales
-      rm_translation_files
-    end
+    expect(import_executor).to raise_error(SystemExit, /ID is not set/i)
 
-    after :all do
-      rm_translation_files
-    end
-
-    it 'import rake task is callable' do
-      allow(LokaliseRails::TaskDefinition::Importer).to receive(
-        :download_files
-      ).and_return(
-        {
-          'project_id' => '123.abc',
-          'bundle_url' => local_trans
-        }
-      )
-
-      expect(import_executor).to output(/complete!/).to_stdout
-
-      expect(count_translations).to eq(4)
-      expect(LokaliseRails::TaskDefinition::Importer).to have_received(:download_files)
-      expect_file_exist loc_path, 'en/nested/main_en.yml'
-      expect_file_exist loc_path, 'en/nested/deep/secondary_en.yml'
-      expect_file_exist loc_path, 'ru/main_ru.yml'
-    end
-
-    it 'import rake task downloads ZIP archive properly' do
-      allow(LokaliseRails::TaskDefinition::Importer).to receive(
-        :download_files
-      ).and_return(
-        {
-          'project_id' => '123.abc',
-          'bundle_url' => remote_trans
-        }
-      )
-
-      expect(import_executor).to output(/complete!/).to_stdout
-
-      expect(LokaliseRails::TaskDefinition::Importer).to have_received(:download_files)
-      expect(count_translations).to eq(4)
-      expect_file_exist loc_path, 'en/nested/main_en.yml'
-      expect_file_exist loc_path, 'en/nested/deep/secondary_en.yml'
-      expect_file_exist loc_path, 'ru/main_ru.yml'
-    end
+    expect(global_config).to have_received(:project_id)
   end
 
-  context 'when directory is not empty and safe mode enabled' do
-    before :all do
-      mkdir_locales
-      described_class.import_safe_mode = true
-    end
-
+  context 'when directory is empty' do
     before do
+      mkdir_locales
       rm_translation_files
-      add_translation_files!
     end
 
     after :all do
       rm_translation_files
-      described_class.import_safe_mode = false
     end
 
-    it 'import proceeds when the user agrees' do
-      allow(LokaliseRails::TaskDefinition::Importer).to receive(
-        :download_files
-      ).and_return(
-        {
-          'project_id' => '123.abc',
-          'bundle_url' => local_trans
-        }
-      )
-
-      allow($stdin).to receive(:gets).and_return('Y')
-      expect(import_executor).to output(/is not empty/).to_stdout
-
-      expect(count_translations).to eq(5)
-      expect($stdin).to have_received(:gets)
-      expect(LokaliseRails::TaskDefinition::Importer).to have_received(:download_files)
-      expect_file_exist loc_path, 'en/nested/main_en.yml'
-      expect_file_exist loc_path, 'en/nested/deep/secondary_en.yml'
-      expect_file_exist loc_path, 'ru/main_ru.yml'
-    end
-
-    it 'import halts when a user chooses not to proceed' do
-      allow(LokaliseRails::TaskDefinition::Importer).to receive(
-        :download_files
-      ).at_most(0).times
-      allow($stdin).to receive(:gets).and_return('N')
-      expect(import_executor).to output(/is not empty/).to_stdout
-
-      expect(LokaliseRails::TaskDefinition::Importer).not_to have_received(:download_files)
-      expect($stdin).to have_received(:gets)
-      expect(count_translations).to eq(1)
+    describe 'import' do
+      it 'is callable' do
+        allow_project_id global_config, ENV['LOKALISE_PROJECT_ID'] do
+          VCR.use_cassette('download_files') do
+            expect(import_executor).to output(/complete!/).to_stdout
+          end
+
+          expect(count_translations).to eq(4)
+
+          expect_file_exist loc_path, 'en.yml'
+          expect_file_exist loc_path, 'ru.yml'
+          expect_file_exist loc_path, 'yo.yml'
+        end
+      end
+
+      it 're-raises export errors' do
+        allow_project_id global_config, 'fake' do
+          VCR.use_cassette('download_files_error') do
+            expect(import_executor).to raise_error(SystemExit, /Invalid `project_id` parameter/)
+          end
+        end
+      end
     end
   end
 end

data/spec/lib/utils_spec.rb

@@ -0,0 +1,16 @@
+# frozen_string_literal: true
+
+describe LokaliseRails::Utils do
+  describe '.rails_root' do
+    it 'returns RAILS_ROOT if defined' do
+      allow(::Rails).to receive(:root).and_return(nil)
+      stub_const('RAILS_ROOT', '/stub')
+      expect(described_class.rails_root).to eq('/stub')
+    end
+
+    it 'fallbacks if neither roots are present' do
+      allow(::Rails).to receive(:root).and_return(nil)
+      expect(described_class.rails_root).to be_nil
+    end
+  end
+end

data/spec/spec_helper.rb

@@ -7,7 +7,6 @@ SimpleCov.start 'rails' do
   add_filter 'spec/'
   add_filter '.github/'
   add_filter 'lib/generators/templates/'
-  add_filter 'lib/lokalise_rails/version'
 end
 
 if ENV['CI'] == 'true'

data/spec/support/file_manager.rb

@@ -3,13 +3,8 @@
 require 'fileutils'
 
 module FileManager
-  def expect_file_exist(path, file)
-    file_path = File.join path, file
-    expect(File.file?(file_path)).to be true
-  end
-
   def mkdir_locales
-    FileUtils.mkdir_p(LokaliseRails.locales_path) unless File.directory?(LokaliseRails.locales_path)
+    FileUtils.mkdir_p(LokaliseRails::GlobalConfig.locales_path) unless File.directory?(LokaliseRails::GlobalConfig.locales_path)
   end
 
   def rm_translation_files
@@ -17,38 +12,46 @@ module FileManager
   end
 
   def locales_dir
-    Dir["#{LokaliseRails.locales_path}/**/*"]
+    Dir["#{LokaliseRails::GlobalConfig.locales_path}/**/*"]
   end
 
   def count_translations
     locales_dir.count { |file| File.file?(file) }
   end
 
-  def add_translation_files!(with_ru: false)
+  def add_translation_files!(with_ru: false, additional: nil)
     FileUtils.mkdir_p "#{Rails.root}/config/locales/nested"
-    File.open("#{Rails.root}/config/locales/nested/en.yml", 'w+:UTF-8') do |f|
-      f.write en_data
-    end
+    open_and_write('config/locales/nested/en.yml') { |f| f.write en_data }
 
     return unless with_ru
 
-    File.open("#{Rails.root}/config/locales/ru.yml", 'w+:UTF-8') do |f|
-      f.write ru_data
+    open_and_write('config/locales/ru.yml') { |f| f.write ru_data }
+
+    return unless additional
+
+    additional.times do |i|
+      data = {'en' => {"key_#{i}" => "value #{i}"}}
+
+      open_and_write("config/locales/en_#{i}.yml") { |f| f.write data.to_yaml }
     end
   end
 
-  def add_config!
+  def add_config!(custom_text = '')
     data = <<~DATA
-      require 'lokalise_rails'
-      LokaliseRails.config do |c|
+      LokaliseRails::GlobalConfig.config do |c|
         c.api_token = ENV['LOKALISE_API_TOKEN']
         c.project_id = ENV['LOKALISE_PROJECT_ID']
-      end
     DATA
 
-    File.open("#{Rails.root}/config/lokalise_rails.rb", 'w+:UTF-8') do |f|
-      f.write data
-    end
+    data += custom_text
+    data += "\nend"
+    open_and_write('config/lokalise_rails.rb') { |f| f.write data }
+  end
+
+  def open_and_write(rel_path, &block)
+    return unless block
+
+    File.open("#{Rails.root}/#{rel_path}", 'w+:UTF-8', &block)
   end
 
   def remove_config

data/spec/support/spec_addons.rb

@@ -1,11 +1,16 @@
 # frozen_string_literal: true
 
 module SpecAddons
-  def allow_project_id(value = ENV['LOKALISE_PROJECT_ID'])
-    allow(LokaliseRails).to receive(:project_id).and_return(value)
+  def expect_file_exist(path, file)
+    file_path = File.join path, file
+    expect(File.file?(file_path)).to be true
+  end
+
+  def allow_project_id(obj, value)
+    allow(obj).to receive(:project_id).and_return(value)
     return unless block_given?
 
     yield
-    expect(LokaliseRails).to have_received(:project_id)
+    expect(obj).to have_received(:project_id)
   end
 end

metadata

@@ -1,183 +1,29 @@
 --- !ruby/object:Gem::Specification
 name: lokalise_rails
 version: !ruby/object:Gem::Version
-  version: 1.4.0
+  version: 4.0.0
 platform: ruby
 authors:
 - Ilya Bodrov
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2021-07-29 00:00:00.000000000 Z
+date: 2022-01-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
-  name: ruby-lokalise-api
+  name: lokalise_manager
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '4.0'
+        version: '2.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '4.0'
-- !ruby/object:Gem::Dependency
-  name: rubyzip
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '2.3'
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '2.3'
-- !ruby/object:Gem::Dependency
-  name: codecov
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '0.2'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '0.2'
-- !ruby/object:Gem::Dependency
-  name: dotenv
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '2.5'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '2.5'
-- !ruby/object:Gem::Dependency
-  name: rails
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 6.1.0
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 6.1.0
-- !ruby/object:Gem::Dependency
-  name: rake
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '13.0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '13.0'
-- !ruby/object:Gem::Dependency
-  name: rspec
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '3.6'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '3.6'
-- !ruby/object:Gem::Dependency
-  name: rubocop
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.0'
-- !ruby/object:Gem::Dependency
-  name: rubocop-performance
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.5'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.5'
-- !ruby/object:Gem::Dependency
-  name: rubocop-rspec
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 2.4.0
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 2.4.0
-- !ruby/object:Gem::Dependency
-  name: simplecov
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '0.16'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '0.16'
-- !ruby/object:Gem::Dependency
-  name: vcr
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '6.0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '6.0'
+        version: '2.0'
 description: This gem allows to exchange translation files between your Rails app
   and Lokalise TMS.
 email:
@@ -198,11 +44,9 @@ files:
 - lib/generators/lokalise_rails/install_generator.rb
 - lib/generators/templates/lokalise_rails_config.rb
 - lib/lokalise_rails.rb
-- lib/lokalise_rails/error.rb
+- lib/lokalise_rails/global_config.rb
 - lib/lokalise_rails/railtie.rb
-- lib/lokalise_rails/task_definition/base.rb
-- lib/lokalise_rails/task_definition/exporter.rb
-- lib/lokalise_rails/task_definition/importer.rb
+- lib/lokalise_rails/utils.rb
 - lib/lokalise_rails/version.rb
 - lib/tasks/lokalise_rails_tasks.rake
 - lokalise_rails.gemspec
@@ -215,26 +59,19 @@ files:
 - spec/dummy/config/environments/development.rb
 - spec/dummy/config/environments/production.rb
 - spec/dummy/config/environments/test.rb
-- spec/dummy/config/initializers/application_controller_renderer.rb
 - spec/dummy/config/initializers/assets.rb
-- spec/dummy/config/initializers/backtrace_silencers.rb
-- spec/dummy/config/initializers/content_security_policy.rb
 - spec/dummy/config/initializers/cookies_serializer.rb
 - spec/dummy/config/initializers/filter_parameter_logging.rb
-- spec/dummy/config/initializers/inflections.rb
-- spec/dummy/config/initializers/mime_types.rb
-- spec/dummy/config/initializers/wrap_parameters.rb
 - spec/dummy/config/lokalise_rails.rb
 - spec/dummy/config/puma.rb
 - spec/dummy/config/routes.rb
 - spec/dummy/db/seeds.rb
 - spec/lib/generators/lokalise_rails/install_generator_spec.rb
-- spec/lib/lokalise_rails/task_definition/base_spec.rb
-- spec/lib/lokalise_rails/task_definition/exporter_spec.rb
-- spec/lib/lokalise_rails/task_definition/importer_spec.rb
-- spec/lib/lokalise_rails_spec.rb
+- spec/lib/lokalise_rails/global_config_spec.rb
+- spec/lib/lokalise_rails/version_spec.rb
 - spec/lib/tasks/export_task_spec.rb
 - spec/lib/tasks/import_task_spec.rb
+- spec/lib/utils_spec.rb
 - spec/spec_helper.rb
 - spec/support/file_manager.rb
 - spec/support/rake_utils.rb
@@ -243,7 +80,8 @@ files:
 homepage: https://github.com/bodrovis/lokalise_rails
 licenses:
 - MIT
-metadata: {}
+metadata:
+  rubygems_mfa_required: 'true'
 post_install_message:
 rdoc_options: []
 require_paths:
@@ -259,7 +97,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.2.24
+rubygems_version: 3.3.5
 signing_key:
 specification_version: 4
 summary: Lokalise integration for Ruby on Rails
@@ -273,26 +111,19 @@ test_files:
 - spec/dummy/config/environments/development.rb
 - spec/dummy/config/environments/production.rb
 - spec/dummy/config/environments/test.rb
-- spec/dummy/config/initializers/application_controller_renderer.rb
 - spec/dummy/config/initializers/assets.rb
-- spec/dummy/config/initializers/backtrace_silencers.rb
-- spec/dummy/config/initializers/content_security_policy.rb
 - spec/dummy/config/initializers/cookies_serializer.rb
 - spec/dummy/config/initializers/filter_parameter_logging.rb
-- spec/dummy/config/initializers/inflections.rb
-- spec/dummy/config/initializers/mime_types.rb
-- spec/dummy/config/initializers/wrap_parameters.rb
 - spec/dummy/config/lokalise_rails.rb
 - spec/dummy/config/puma.rb
 - spec/dummy/config/routes.rb
 - spec/dummy/db/seeds.rb
 - spec/lib/generators/lokalise_rails/install_generator_spec.rb
-- spec/lib/lokalise_rails/task_definition/base_spec.rb
-- spec/lib/lokalise_rails/task_definition/exporter_spec.rb
-- spec/lib/lokalise_rails/task_definition/importer_spec.rb
-- spec/lib/lokalise_rails_spec.rb
+- spec/lib/lokalise_rails/global_config_spec.rb
+- spec/lib/lokalise_rails/version_spec.rb
 - spec/lib/tasks/export_task_spec.rb
 - spec/lib/tasks/import_task_spec.rb
+- spec/lib/utils_spec.rb
 - spec/spec_helper.rb
 - spec/support/file_manager.rb
 - spec/support/rake_utils.rb

data/lib/lokalise_rails/error.rb

@@ -1,10 +0,0 @@
-# frozen_string_literal: true
-
-module LokaliseRails
-  class Error < StandardError
-    # Initializes a new Error object
-    def initialize(message = '')
-      super(message)
-    end
-  end
-end

data/lib/lokalise_rails/task_definition/base.rb

@@ -1,64 +0,0 @@
-# frozen_string_literal: true
-
-require 'ruby-lokalise-api'
-require 'pathname'
-
-module LokaliseRails
-  module TaskDefinition
-    class Base
-      class << self
-        attr_writer :api_client
-
-        # Creates a Lokalise API client
-        #
-        # @return [Lokalise::Client]
-        def api_client
-          @api_client ||= ::Lokalise.client LokaliseRails.api_token, LokaliseRails.timeouts
-        end
-
-        # Resets API client
-        def reset_api_client!
-          Lokalise.reset_client!
-          @api_client = nil
-        end
-
-        # Checks task options
-        #
-        # @return Array
-        def check_options_errors!
-          errors = []
-          errors << 'Project ID is not set!' if LokaliseRails.project_id.nil? || LokaliseRails.project_id.empty?
-          errors << 'Lokalise API token is not set!' if LokaliseRails.api_token.nil? || LokaliseRails.api_token.empty?
-
-          raise(LokaliseRails::Error, errors.join(' ')) if errors.any?
-        end
-
-        private
-
-        # Checks whether the provided file has a proper extension as dictated by the `file_ext_regexp` option
-        #
-        # @return Boolean
-        # @param raw_path [String, Pathname]
-        def proper_ext?(raw_path)
-          path = raw_path.is_a?(Pathname) ? raw_path : Pathname.new(raw_path)
-          LokaliseRails.file_ext_regexp.match? path.extname
-        end
-
-        # Returns directory and filename for the given entry
-        #
-        # @return Array
-        # @param entry [String]
-        def subdir_and_filename_for(entry)
-          Pathname.new(entry).split
-        end
-
-        # Returns Lokalise project ID and branch, semicolumn separated
-        #
-        # @return [String]
-        def project_id_with_branch
-          "#{LokaliseRails.project_id}:#{LokaliseRails.branch}"
-        end
-      end
-    end
-  end
-end