logtail 0.1.20 → 0.1.21

data/spec/logtail/log_devices/http_spec.rb

@@ -1,4 +1,7 @@
 require "spec_helper"
+require "bigdecimal"
+require "date"
+require "set"
 
 # Note: these tests access instance variables and private methods as a means of
 # not muddying the public API. This object should expose a simple buffer like
@@ -22,7 +25,7 @@ describe Logtail::LogDevices::HTTP do
 
     it "should buffer the messages" do
       http.write("test log message")
-      expect(msg_queue.flush).to eq(["test log message"])
+      expect(msg_queue.flush.map(&:message)).to eq(["test log message"])
       http.close
     end
 
@@ -68,6 +71,49 @@ describe Logtail::LogDevices::HTTP do
       expect(http).to receive(:flush).exactly(1).times
       http.close
     end
+
+    it "does nothing when called again, e.g. by the device's at_exit hook" do
+      http.close
+      expect(http).not_to receive(:flush)
+      http.close
+    end
+
+    it "doesn't let a line written after it raise when delivering it fails, whatever the error" do
+      http.close
+
+      # WebMock refuses to connect with an error that isn't a StandardError
+      expect { http.write(Logtail::LogEntry.new("INFO", Time.now, nil, "test log message", nil, nil)) }.not_to raise_error
+    end
+
+    it "stops waiting for the outlet thread once it has died" do
+      stub_request(:post, "https://in.logs.betterstack.com/")
+      http.write(Logtail::LogEntry.new("INFO", Time.now, nil, "test log message", nil, nil))
+      http.instance_variable_get(:@request_outlet_thread).kill.join
+
+      closing = Process.clock_gettime(Process::CLOCK_MONOTONIC)
+      http.close
+      expect(Process.clock_gettime(Process::CLOCK_MONOTONIC) - closing).to be < 1
+    end
+
+    it "drops the lines written after it once Better Stack answered one of them with 429 or 5xx" do
+      stub = stub_request(:post, "https://in.logs.betterstack.com/").to_return({status: 503}, {status: 202})
+      http.close
+
+      2.times { http.write(Logtail::LogEntry.new("INFO", Time.now, nil, "test log message", nil, nil)) }
+
+      expect(stub).to have_been_requested.once
+    end
+
+    it "reports a line written after it that Better Stack rejects" do
+      # A status is reported once per process, so none has been reported yet.
+      stub_const("Logtail::LogDevices::HTTP::REPORTED_REJECTIONS", [])
+      stub_request(:post, "https://in.logs.betterstack.com/").to_return(status: [403, "Forbidden"])
+      http.close
+      expect(http).to receive(:warn).once.with("Logtail: Better Stack rejected 1 log line with HTTP 403 " \
+        "Forbidden - check your source token. Further rejections with this status won't be reported.")
+
+      http.write(Logtail::LogEntry.new("INFO", Time.now, nil, "test log message", nil, nil))
+    end
   end
 
   # Testing a private method because it helps break down our tests
@@ -84,6 +130,128 @@ describe Logtail::LogDevices::HTTP do
       http.send(:flush)
       http.close
     end
+
+    it "delivers in the calling thread when no outlet thread runs" do
+      messages = []
+      stub = stub_request(:post, "https://in.logs.betterstack.com/").to_return do |request|
+        messages.concat(MessagePack.unpack(Zlib::Inflate.inflate(request.body)).map { |line| line["message"] })
+        { status: 202 }
+      end
+      http = described_class.new("MYKEY", flush_continuously: false)
+      http.write(Logtail::LogEntry.new("INFO", time, nil, "test log message 1", nil, nil))
+      http.write(Logtail::LogEntry.new("INFO", time, nil, "test log message 2", nil, nil))
+
+      http.flush
+
+      expect(stub).to have_been_requested.once
+      expect(messages).to eq(["test log message 1", "test log message 2"])
+      http.close
+    end
+
+    it "doesn't raise when delivering in the calling thread fails, whatever the error" do
+      http = described_class.new("MYKEY", flush_continuously: false)
+      http.write(Logtail::LogEntry.new("INFO", time, nil, "test log message", nil, nil))
+
+      # WebMock refuses to connect with an error that isn't a StandardError
+      expect { http.flush }.not_to raise_error
+      http.close
+    end
+
+    it "doesn't warn about @last_resp when it can't connect while Ruby shuts down, with warnings on" do
+      # Ruby 2.7 and older warn about an instance variable that is read before it's set
+      result = run_ruby(<<-RUBY)
+        $VERBOSE = true
+        require "logtail"
+        # Like Net::HTTP before Ruby 4.0 while Ruby shuts down: it can't start the thread that
+        # times out connecting
+        Net::HTTP.prepend(Module.new { def start(*); raise ThreadError, "can't alloc thread"; end })
+        http = Logtail::LogDevices::HTTP.new("token", flush_continuously: false, ingesting_host: "127.0.0.1", ingesting_port: 1, ingesting_scheme: "http")
+        logger = Logtail::Logger.new(http)
+        logger.info("line")
+        logger.flush
+      RUBY
+
+      expect(result.status).to be_success, result.stderr
+      expect(result.stderr).not_to include("@last_resp not initialized")
+    end
+
+    it "waits about 5 seconds at most for the outlet thread to deliver" do
+      allow_any_instance_of(Net::HTTP).to receive(:request) { sleep } # Better Stack never answers
+      http = described_class.new("MYKEY")
+      http.write(Logtail::LogEntry.new("INFO", time, nil, "test log message", nil, nil))
+
+      flushing = Process.clock_gettime(Process::CLOCK_MONOTONIC)
+      http.flush
+      expect(Process.clock_gettime(Process::CLOCK_MONOTONIC) - flushing).to be_between(4, 7)
+
+      http.instance_variable_get(:@flush_thread).kill.join
+      http.instance_variable_get(:@request_outlet_thread).kill.join
+    end
+
+    context "when Better Stack answers the delivery in the calling thread with an error status" do
+      let(:http) { described_class.new("MYKEY", flush_continuously: false) }
+
+      # A status is reported once per process, so none has been reported yet in each example.
+      before { stub_const("Logtail::LogDevices::HTTP::REPORTED_REJECTIONS", []) }
+
+      it "drops batches rejected with 401 and warns only once" do
+        stub = stub_request(:post, "https://in.logs.betterstack.com/").to_return(status: [401, "Unauthorized"])
+        expect(http).to receive(:warn).once.with("Logtail: Better Stack rejected 2 log lines with HTTP 401 " \
+          "Unauthorized - check your source token. Further rejections with this status won't be reported.")
+
+        2.times do
+          2.times { |i| http.write(Logtail::LogEntry.new("INFO", time, nil, "line #{i}", nil, nil)) }
+          http.flush
+        end
+
+        expect(stub).to have_been_requested.twice
+        http.close
+      end
+
+      it "neither retries nor reports a batch answered with 408, 429 or 5xx" do
+        stub = stub_request(:post, "https://in.logs.betterstack.com/").
+          to_return({status: 503}, {status: 429}, {status: [408, "Request Time-out"]})
+        expect(http).not_to receive(:warn)
+
+        3.times do
+          http.write(Logtail::LogEntry.new("INFO", time, nil, "test log message", nil, nil))
+          http.flush
+        end
+
+        expect(stub).to have_been_requested.times(3)
+        http.close
+      end
+    end
+
+    it "waits up to 5 seconds for a slow host when it delivers in the calling thread" do
+      # Takes 3 seconds to answer each request
+      slow_ingest = Class.new(LocalIngestServer) do
+        private
+
+        def serve(socket)
+          def socket.write(*)
+            sleep 3
+            super
+          end
+          super
+        end
+      end.new
+      result = run_ruby(<<-RUBY)
+        require "logtail"
+        # A request per line, which flush delivers as no outlet thread runs
+        http = Logtail::LogDevices::HTTP.new("token", flush_continuously: false, batch_size: 1, #{slow_ingest.device_options})
+        logger = Logtail::Logger.new(http)
+        logger.info("first line")
+        logger.info("second line")
+        logger.flush
+      RUBY
+
+      # A request that times out would drop the one after it
+      expect(result.status).to be_success, result.stderr
+      expect(slow_ingest.messages).to contain_exactly("first line", "second line")
+    ensure
+      slow_ingest.stop if slow_ingest
+    end
   end
 
   # Testing a private method because it helps break down our tests
@@ -108,6 +276,139 @@ describe Logtail::LogDevices::HTTP do
     end
   end
 
+  # Testing a private method because it helps break down our tests
+  describe "#build_request" do
+    let(:http) { described_class.new("MYKEY", flush_continuously: false) }
+    let(:logger) { Logtail::Logger.new(http) }
+
+    # Flushes the buffer and decodes the request body, the way the API reads it.
+    def delivered_entries
+      http.send(:flush_async)
+      request = http.instance_variable_get(:@request_queue).deq.request
+      MessagePack.unpack(Zlib::Inflate.inflate(request.body))
+    end
+
+    a_proc = proc {}
+    an_object = Object.new
+    a_cyclic_hash = { name: "parent" }
+    a_cyclic_hash[:self] = a_cyclic_hash
+    a_cyclic_array = ["parent"]
+    a_cyclic_array << a_cyclic_array
+    # Like a Rack::Session::SessionId, whose public id is the cookie of a server-side session
+    a_session_id = Object.new
+    def a_session_id.private_id
+      "2::hashed-session-id"
+    end
+    def a_session_id.to_s
+      "session-cookie"
+    end
+
+    {
+      "a Time" => [Time.utc(2026, 10, 1, 12, 0, 0, 123456), "2026-10-01T12:00:00.123456Z"],
+      "a Time with a UTC offset" => [Time.new(2026, 10, 1, 14, 0, 0, "+02:00"), "2026-10-01T12:00:00.000000Z"],
+      "a DateTime" => [DateTime.new(2026, 10, 1, 14, 0, 0, "+02:00"), "2026-10-01T12:00:00.000000Z"],
+      "a Date" => [Date.new(2026, 10, 1), "2026-10-01"],
+      "a BigDecimal" => [BigDecimal("19.99"), "19.99"],
+      "a Rational" => [Rational(1, 3), "1/3"],
+      "an Integer above the 64-bit range" => [2**64, "18446744073709551616"],
+      "an Integer below the 64-bit range" => [-2**63 - 1, "-9223372036854775809"],
+      "a Set" => [Set[1, 2], [1, 2]],
+      "a Struct" => [Struct.new(:id, :name).new(1, "Ann"), { "id" => 1, "name" => "Ann" }],
+      "an Exception" => [ArgumentError.new("boom"), { "class" => "ArgumentError", "message" => "boom" }],
+      "a Range" => [1..2, "1..2"],
+      "a Class" => [String, "String"],
+      "a Proc" => [a_proc, a_proc.to_s],
+      "an arbitrary object" => [an_object, an_object.to_s],
+      "an object with a private id" => [a_session_id, "2::hashed-session-id"],
+      "a Hash that contains itself" => [a_cyclic_hash, { "name" => "parent", "self" => "[circular]" }],
+      "an Array that contains itself" => [a_cyclic_array, ["parent", "[circular]"]],
+    }.each do |description, (value, expected)|
+      it "delivers the whole batch when a log line holds #{description}" do
+        logger.info("line before")
+        logger.info("line with the value", value: value)
+        logger.info("line after")
+
+        entries = delivered_entries
+        expect(entries.map { |entry| entry["message"] }).to eq(["line before", "line with the value", "line after"])
+        expect(entries[1]["value"]).to eq(expected)
+      end
+    end
+
+    it "replaces a log line it still can't encode with one that says why, and delivers the rest" do
+      unencodable = Object.new
+      def unencodable.to_s
+        raise "to_s failed"
+      end
+
+      logger.info("line before")
+      logger.warn("line with the value", value: unencodable)
+      logger.info("line after")
+
+      entries = delivered_entries
+      expect(entries.map { |entry| entry["message"] }).to eq([
+        "line before",
+        "Logtail could not encode this log line (RuntimeError: to_s failed): line with the value",
+        "line after",
+      ])
+      expect(entries[1].keys).to contain_exactly("level", "dt", "message")
+      expect(entries[1]["level"]).to eq("warn")
+      expect(entries[1]["dt"]).to match(/\A\d{4}-\d\d-\d\dT\d\d:\d\d:\d\d\.\d{6}Z\z/)
+    end
+
+    it "sends a log line that msgpack can encode as it is, without copying it" do
+      hash = { message: "caf\u00E9", count: 1, ratio: 0.5, flag: true, none: nil, level: :info, nested: { list: [1, "two"] } }
+
+      expect(http.send(:encodable_value, hash)).to be(hash)
+    end
+
+    it "passes strings that aren't valid UTF-8 to force_utf8_encoding, also in arrays and keys" do
+      in_array = "in an array \xFF".b
+      key = "key \xFF".b
+      allow(http).to receive(:force_utf8_encoding).and_call_original
+
+      logger.info("line", items: [in_array], counts: { key => 1 })
+      delivered_entries
+
+      expect(http).to have_received(:force_utf8_encoding).with(in_array).at_least(:once)
+      expect(http).to have_received(:force_utf8_encoding).with(key).at_least(:once)
+    end
+
+    it "keeps the order of the keys of a hash when it converts some of them" do
+      logger.info("line", value: { "a" => 1, Time.utc(2026, 10, 1) => 2, "c" => Date.new(2026, 10, 1) })
+
+      expect(delivered_entries[0]["value"].to_a).to eq([["a", 1], ["2026-10-01T00:00:00.000000Z", 2], ["c", "2026-10-01"]])
+    end
+
+    it "leaves the logged values as they are" do
+      value = { at: Time.utc(2026, 10, 1), nested: { on: Date.new(2026, 10, 1), list: [Set[1], "\xFF".b] } }
+      original = Marshal.load(Marshal.dump(value))
+
+      logger.info("line", value: value)
+      delivered_entries
+
+      expect(value).to eq(original)
+    end
+
+    it "delivers hashes and arrays nested 110 levels deep" do
+      value = "leaf"
+      110.times { |level| value = level.even? ? { "level #{level}" => value } : [value] }
+
+      logger.info("line", value: value)
+
+      expect(delivered_entries[0]["value"]).to eq(value)
+    end
+
+    it "delivers strings written to the device as info lines" do
+      http.write("written to the device\n")
+      ::Logger.new(http).warn("logged by a plain Ruby logger")
+
+      entries = delivered_entries
+      expect(entries.map { |entry| entry["level"] }).to eq(["info", "info"])
+      expect(entries[0]["message"]).to eq("written to the device")
+      expect(entries[1]["message"]).to end_with("WARN -- : logged by a plain Ruby logger")
+    end
+  end
+
   # Testing a private method because it helps break down our tests
   describe "#intervaled_flush" do
     it "should start a intervaled flush thread and flush on an interval" do
@@ -119,6 +420,74 @@ describe Logtail::LogDevices::HTTP do
     end
   end
 
+  # Testing a private method because it helps break down our tests
+  describe "#force_utf8_encoding" do
+    let(:http) { described_class.new("MYKEY", flush_continuously: false) }
+    let(:logger) { Logtail::Logger.new(http) }
+
+    # Flushes the buffer and decodes the single entry in the request, the way the API reads it.
+    def delivered_entry
+      http.send(:flush_async)
+      request = http.instance_variable_get(:@request_queue).deq.request
+      MessagePack.unpack(Zlib::Inflate.inflate(request.body)).first
+    end
+
+    it "replaces invalid bytes in the message with U+FFFD" do
+      logger.info("invalid \xFF\xFE bytes")
+      expect(delivered_entry["message"]).to eq("invalid �� bytes")
+    end
+
+    it "treats a binary message as UTF-8" do
+      logger.info("caf\xC3\xA9 \xFF".b)
+      expect(delivered_entry["message"]).to eq("café �")
+    end
+
+    it "replaces invalid bytes in a nested field" do
+      logger.info("nested", user: { name: "An\xFFn" })
+      expect(delivered_entry["user"]).to eq("name" => "An�n")
+    end
+
+    it "replaces invalid bytes in array elements" do
+      logger.info("array", items: ["valid", "\xFF\xFE".b, ["in\xFFner"]])
+      expect(delivered_entry["items"]).to eq(["valid", "��", ["in�ner"]])
+    end
+
+    it "replaces invalid bytes in hash keys" do
+      logger.info("keys", counts: { "k\xFFy".b => 1 })
+      expect(delivered_entry["counts"]).to eq("k�y" => 1)
+    end
+
+    it "replaces invalid bytes in the context" do
+      Logtail.with_context(request: { path: "/caf\xE9".b }) { logger.info("context") }
+      expect(delivered_entry["context"]["request"]).to eq("path" => "/caf�")
+    end
+
+    it "converts strings in other encodings to UTF-8" do
+      logger.info("latin-1", city: "Montr\xE9al".dup.force_encoding("ISO-8859-1"))
+      expect(delivered_entry["city"]).to eq("Montréal")
+    end
+
+    it "sends valid UTF-8 for a string in an encoding Ruby can't convert" do
+      logger.info("windows-1258", word: "caf\xE9".dup.force_encoding("Windows-1258"))
+      word = delivered_entry["word"]
+      expect(word).to start_with("caf")
+      expect(word).to be_valid_encoding
+    end
+
+    it "sends a string that is valid UTF-8 already as it is, without a copy" do
+      utf8 = "café"
+      ascii = "ascii".encode("US-ASCII")
+
+      expect(http.send(:force_utf8_encoding, utf8)).to be(utf8)
+      expect(http.send(:force_utf8_encoding, ascii)).to be(ascii)
+    end
+
+    it "treats a US-ASCII string with bytes above 127 as UTF-8" do
+      logger.info("us-ascii", word: "caf\xC3\xA9 \xFF".dup.force_encoding("US-ASCII"))
+      expect(delivered_entry["word"]).to eq("café �")
+    end
+  end
+
   # Outlet
   describe "#request_outlet" do
     let(:time) { Time.utc(2016, 9, 1, 12, 0, 0) }
@@ -208,6 +577,106 @@ describe Logtail::LogDevices::HTTP do
       end
     end
 
+    context "when Better Stack answers with an error status" do
+      # Raised to leave the outlet's endless loop, see above.
+      let(:stop_outlet) { Class.new(Exception) }
+      let(:http_device) { described_class.new("MYKEY", flush_continuously: false, requests_per_conn: 1) }
+      let(:request_queue) { http_device.instance_variable_get(:@request_queue) }
+      let(:waits) { [] }
+
+      before do
+        allow(http_device).to receive(:sleep) { |seconds| waits << seconds }
+        # Leave the loop once there is nothing left to deliver.
+        allow(request_queue).to receive(:deq).and_wrap_original { |deq| deq.call || raise(stop_outlet) }
+        # A status is reported once per process, so none has been reported yet in each example.
+        stub_const("Logtail::LogDevices::HTTP::REPORTED_REJECTIONS", [])
+      end
+
+      def queue_batch(size)
+        size.times { |i| http_device.write(Logtail::LogEntry.new("INFO", Time.now, nil, "line #{i}", nil, nil)) }
+        http_device.send(:flush_async)
+      end
+
+      it "retries a batch answered with 500 and delivers it once" do
+        stub = stub_request(:post, "https://in.logs.betterstack.com/").to_return({status: 500}, {status: 202})
+        queue_batch(1)
+
+        expect { http_device.send(:request_outlet) }.to raise_error(stop_outlet)
+        expect(stub).to have_been_requested.twice
+        expect(waits).to eq([1])
+      end
+
+      it "retries a batch answered with 408 without a warning, and delivers it once" do
+        # Better Stack answers 408 when a new connection stays unused for more than about 10 seconds
+        stub = stub_request(:post, "https://in.logs.betterstack.com/").
+          to_return({status: [408, "Request Time-out"], headers: {"Connection" => "close"}}, {status: 202})
+        queue_batch(1)
+        expect(http_device).not_to receive(:warn)
+
+        expect { http_device.send(:request_outlet) }.to raise_error(stop_outlet)
+        expect(stub).to have_been_requested.twice
+        expect(waits).to eq([1])
+      end
+
+      it "waits before retrying a batch answered with 429 at least as long as Retry-After says" do
+        stub = stub_request(:post, "https://in.logs.betterstack.com/").
+          to_return({status: 429, headers: {"Retry-After" => "3"}}, {status: 202})
+        queue_batch(1)
+
+        expect { http_device.send(:request_outlet) }.to raise_error(stop_outlet)
+        expect(stub).to have_been_requested.twice
+        expect(waits).to eq([3])
+      end
+
+      it "reads Retry-After as a date too, and waits 60 seconds at most" do
+        Timecop.freeze(Time.utc(2026, 10, 1, 12, 0, 0)) do
+          stub = stub_request(:post, "https://in.logs.betterstack.com/").to_return(
+            {status: 503, headers: {"Retry-After" => (Time.now + 5).httpdate}},
+            {status: 503, headers: {"Retry-After" => "3600"}},
+            {status: 202}
+          )
+          queue_batch(1)
+
+          expect { http_device.send(:request_outlet) }.to raise_error(stop_outlet)
+          expect(stub).to have_been_requested.times(3)
+          expect(waits).to eq([5, 60])
+        end
+      end
+
+      it "drops a batch answered with 503 three times, backing off in between" do
+        stub = stub_request(:post, "https://in.logs.betterstack.com/").to_return(status: 503)
+        queue_batch(1)
+        expect(http_device).not_to receive(:warn)
+
+        expect { http_device.send(:request_outlet) }.to raise_error(stop_outlet)
+        expect(stub).to have_been_requested.times(3)
+        expect(waits).to eq([1, 2, 4])
+      end
+
+      it "drops batches answered with 401 and warns only once" do
+        stub = stub_request(:post, "https://in.logs.betterstack.com/").to_return(status: [401, "Unauthorized"])
+        queue_batch(2)
+        queue_batch(2)
+        expect(http_device).to receive(:warn).once.with("Logtail: Better Stack rejected 2 log lines with HTTP 401 " \
+          "Unauthorized - check your source token. Further rejections with this status won't be reported.")
+
+        expect { http_device.send(:request_outlet) }.to raise_error(stop_outlet)
+        expect(stub).to have_been_requested.twice
+        expect(waits).to eq([])
+      end
+
+      it "drops a batch answered with 413 and warns" do
+        stub = stub_request(:post, "https://in.logs.betterstack.com/").to_return(status: [413, "Payload Too Large"])
+        queue_batch(1)
+
+        expect do
+          expect { http_device.send(:request_outlet) }.to raise_error(stop_outlet)
+        end.to output(/^Logtail: Better Stack rejected 1 log line with HTTP 413 Payload Too Large\. Further rejections with this status won't be reported\.$/).to_stderr
+        expect(stub).to have_been_requested.once
+        expect(waits).to eq([])
+      end
+    end
+
     it "lets close stop the outlet while it waits to reconnect" do
       connection_attempts = 0
       allow_any_instance_of(Net::HTTP).to receive(:start) do

data/spec/logtail/log_entry_spec.rb

@@ -32,5 +32,78 @@ describe Logtail::LogEntry do
       expect(hash[:context][:runtime][:frame_label]).to_not be_nil
       expect(hash[:context][:runtime][:frame_label].encoding.to_s).to eq('UTF-8')
     end
+
+    context "with a context logged by the user" do
+      let(:context_snapshot) { {system: {hostname: "computer-name", pid: 123}, runtime: {thread_id: 456}} }
+
+      it "should keep the user's context next to the system and runtime context" do
+        log_entry = described_class.new("INFO", time, nil, "log message", context_snapshot, {context: {tenant: 1}})
+
+        context = log_entry.to_hash[:context]
+        expect(context[:tenant]).to eq(1)
+        expect(context[:system]).to eq(hostname: "computer-name", pid: 123)
+        expect(context[:runtime]).to eq(thread_id: 456)
+      end
+
+      it "should merge nested hashes, keeping the gem's own values on conflict" do
+        user_context = {system: {hostname: "spoofed", region: "eu-west"}, runtime: {worker: "w1"}, job: {id: 7}}
+        log_entry = described_class.new("INFO", time, nil, "log message", context_snapshot, {context: user_context})
+
+        context = log_entry.to_hash[:context]
+        expect(context[:system]).to eq(hostname: "computer-name", pid: 123, region: "eu-west")
+        expect(context[:runtime]).to eq(thread_id: 456, worker: "w1")
+        expect(context[:job]).to eq(id: 7)
+      end
+
+      it "should not modify the user's context or the current context" do
+        user_context = {runtime: {worker: "w1"}}
+        Logtail::CurrentContext.with(runtime: {thread_id: 456}) do
+          log_entry = Logtail::Logger::PassThroughFormatter.new.call("INFO", time, "", {message: "log message", context: user_context})
+
+          runtime_context = log_entry.to_hash[:context][:runtime]
+          expect(runtime_context).to include(thread_id: 456, worker: "w1")
+          expect(runtime_context[:file]).to end_with('/spec/logtail/log_entry_spec.rb')
+          expect(user_context).to eq(runtime: {worker: "w1"})
+          expect(Logtail::CurrentContext.instance.snapshot[:runtime]).to eq(thread_id: 456)
+        end
+      end
+
+      it "should ignore a context that isn't a Hash" do
+        log_entry = described_class.new("INFO", time, nil, "log message", context_snapshot, {context: "checkout"})
+        expect(log_entry.to_hash[:context]).to eq(context_snapshot)
+
+        log_entry = described_class.new("INFO", time, nil, "log message", nil, {context: "checkout"})
+        expect(log_entry.to_hash[:context]).to eq(runtime: {})
+      end
+
+      # logtail-rails logs Rails.event events this way, with the context set by Rails.event.set_context
+      it "should deliver the context of an event" do
+        http_device = Logtail::LogDevices::HTTP.new("MYKEY", flush_continuously: false)
+        logger = Logtail::Logger.new(http_device)
+        Logtail::CurrentContext.with(system: {hostname: "computer-name.domain.com", pid: 123}) do
+          logger.info("[order.placed] id=1", event_name: "order.placed", payload: {id: 1},
+                      context: {request_id: "abc-123", shop_id: 42}, tags: [], source_location: {})
+        end
+
+        http_device.send(:flush_async)
+        request = http_device.instance_variable_get(:@request_queue).deq.request
+        delivered = MessagePack.unpack(Zlib::Inflate.inflate(request.body)).first
+        expect(delivered["event_name"]).to eq("order.placed")
+        expect(delivered["context"]).to include("request_id" => "abc-123", "shop_id" => 42)
+        expect(delivered["context"]["system"]).to eq("hostname" => "computer-name.domain.com", "pid" => 123)
+        expect(delivered["context"]["runtime"]).to include("file", "line")
+      end
+    end
+  end
+
+  describe "#message" do
+    it "cuts a long message on a character boundary" do
+      # The 4-byte emoji takes bytes 8,191 to 8,194, across the 8,192-byte limit.
+      message = "a" * 8190 + "\u{1F600} and more"
+      log_entry = described_class.new("INFO", time, nil, message, nil, nil)
+
+      expect(log_entry.message.bytesize).to eq(8190)
+      expect(log_entry.message.valid_encoding?).to be(true)
+    end
   end
 end

data/spec/logtail/logger_flush_all_spec.rb

@@ -0,0 +1,82 @@
+require "spec_helper"
+
+# Rails flushes Rails.logger after every request (Rails::Rack::Logger calls
+# ActiveSupport::LogSubscriber.flush_all!), and Logger#flush returns right away for that call
+# instead of waiting for delivery. These run ActiveSupport's real flush_all! in another process, so
+# an ActiveSupport that calls flush differently fails here. The ingesting host holds its answers
+# until the direct flush, so a flush_all! that waited for delivery would take 5 seconds.
+describe Logtail::Logger, "#flush called by ActiveSupport::LogSubscriber.flush_all!" do
+  {
+    "a Logtail::Logger" => "logger",
+    "a Logtail::Logger in ActiveSupport::TaggedLogging" => "ActiveSupport::TaggedLogging.new(logger)",
+    "a Logtail::Logger in an ActiveSupport::BroadcastLogger, as Rails 7.1 and later wrap it" =>
+      "ActiveSupport::BroadcastLogger.new(logger)",
+    "a Logtail::Logger in ActiveSupport::TaggedLogging in an ActiveSupport::BroadcastLogger" =>
+      "ActiveSupport::BroadcastLogger.new(ActiveSupport::TaggedLogging.new(logger))"
+  }.each do |description, rails_logger|
+    it "returns right away for #{description}, and flushing it directly delivers" do
+      if rails_logger.include?("BroadcastLogger") && Gem.loaded_specs["activesupport"].version < Gem::Version.new("7.1")
+        skip "ActiveSupport::BroadcastLogger was added in ActiveSupport 7.1"
+      end
+
+      result = run_ruby(<<-RUBY)
+        require "logger" # ActiveSupport 6.1 needs it loaded first since concurrent-ruby 1.3.5
+        require "active_support"
+        require "active_support/log_subscriber"
+        require "active_support/tagged_logging"
+        require "json"
+        require "logtail"
+
+        # The ingesting host keeps the lines of every request, but answers only once `answering` is set
+        delivered = []
+        answering = false
+        server = TCPServer.new("127.0.0.1", 0)
+        Thread.new do
+          loop do
+            Thread.new(server.accept) do |socket|
+              while socket.gets
+                length = 0
+                while (header = socket.gets) != "\\r\\n"
+                  length = header.split(":")[1].to_i if header.downcase.start_with?("content-length:")
+                end
+                delivered.concat(MessagePack.unpack(Zlib::Inflate.inflate(socket.read(length))).map { |line| line["message"] })
+                sleep 0.01 until answering
+                socket.write("HTTP/1.1 202 Accepted\\r\\nContent-Length: 0\\r\\n\\r\\n")
+              end
+            end
+          end
+        end
+
+        # Logs a line for every request, like Rails' ActionController::LogSubscriber
+        class RequestLogSubscriber < ActiveSupport::LogSubscriber
+          def request(event)
+            info(event.payload[:message])
+          end
+        end
+        RequestLogSubscriber.attach_to(:app)
+
+        logger = Logtail::Logger.new(Logtail::LogDevices::HTTP.new("token", flush_interval: 60,
+          ingesting_host: "127.0.0.1", ingesting_port: server.addr[1], ingesting_scheme: "http"))
+        ActiveSupport::LogSubscriber.logger = #{rails_logger}
+        ActiveSupport::Notifications.instrument("request.app", message: "Completed 200 OK")
+
+        flushing = Process.clock_gettime(Process::CLOCK_MONOTONIC)
+        ActiveSupport::LogSubscriber.flush_all!
+        flush_all_seconds = Process.clock_gettime(Process::CLOCK_MONOTONIC) - flushing
+        delivered_by_flush_all = delivered.dup
+
+        answering = true
+        ActiveSupport::LogSubscriber.logger.flush
+        puts JSON.generate("flush_all_seconds" => flush_all_seconds, "delivered_by_flush_all" => delivered_by_flush_all,
+          "delivered_by_flush" => delivered.drop(delivered_by_flush_all.size))
+      RUBY
+
+      expect(result.status).to be_success, result.stderr
+      expect(JSON.parse(result.stdout)).to match(
+        "flush_all_seconds" => a_value < 1,
+        "delivered_by_flush_all" => [],
+        "delivered_by_flush" => ["Completed 200 OK"]
+      )
+    end
+  end
+end