logstruct 0.2.0 → 0.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 30339bbe0c17b5baf55abe19e911758af000864097ec3777d133572da938c9b4
-  data.tar.gz: 2963dd6d8680361a664fdea12e6137176a065e18a5bb2b7332556b648a09ef4d
+  metadata.gz: 23182266ea1c9f53e0b824a8b806207b92255ed6a6d2755cf67c8f3d35680d19
+  data.tar.gz: 4d684c903461a10aa875314f6dac3fca9978ac190ce0616c3f6d34076c3b8ba7
 SHA512:
-  metadata.gz: 3a6bb597673b7fffc1dac97c78b184b2277ec363ab14f061bf00e1d58931259a41ec82c67cafa32c101389201f3c58a0aee079087513ae02b430f5158ea11316
-  data.tar.gz: 14dc4bb646c20a8a9e917e451e4e6a43cddd49cc419ee120d9e7182e735be595cd50f7a397c98f59abef04469d1629496b37f72cb84701d34fb30df4cd60a9c1
+  metadata.gz: 4a3dc3b56efac2d68703b77210006852059188425e612f537be307e7740da79781600dc4147d955c52c0e65a39978d476fefd0a796b07b7fe5ee170d2ce5b07a
+  data.tar.gz: bb328f655eda7dbcfb2ace155586966bfc47a4a60df88dcb7aa2e355b5213f0e76623d52e83906063a5aaff63039c8937c59bdd373c783faa7013a7c860acfac

data/CHANGELOG.md

@@ -5,6 +5,12 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [0.2.1] - 2026-10-18
+
+### Fixed
+
+- **Lograge**: With `config.exceptions_app = routes`, a request whose action raises has one request line, the action's: the error page's controller no longer logs a second line as `GET /500`. When the error comes before any action (a routing error) or after it (in a middleware), the error page's line has the request's own method and path instead of `GET /404` (#28)
+
 ## [0.2.0] - 2026-10-18
 
 ### Changed

data/lib/log_struct/integrations/lograge.rb

@@ -36,6 +36,20 @@ module LogStruct
         T::Array[Symbol]
       )
 
+      # With config.exceptions_app = routes, Rails renders an error page by sending the request through the app again
+      # as GET /<status>, and keeps the request's own method and path in these headers
+      ORIGINAL_METHOD_HEADER = "action_dispatch.original_request_method"
+      ORIGINAL_PATH_HEADER = "action_dispatch.original_path"
+      # Set when the request's action logged a line with its error, so the error page for it logs none
+      ACTION_ERROR_LOGGED_HEADER = "logstruct.action_error_logged"
+
+      # A Proc, not a Method: sorbet-runtime replaces a method with sig checks on its first call, so a Method taken
+      # before then isn't equal to one taken after, and setup couldn't tell it had added the test already
+      IGNORE_REPEATED_ERROR_PAGE = T.let(
+        ->(event) { Lograge.repeated_error_page?(event) },
+        T.proc.params(event: ActiveSupport::Notifications::Event).returns(T::Boolean)
+      )
+
       class << self
         extend T::Sig
 
@@ -77,6 +91,9 @@ module LogStruct
               Integrations::Lograge.unsubscribe_rails_request_lines unless app.config.lograge.keep_original_rails_log
             end
           end
+
+          # Lograge.setup adds the app's own ignore tests to the same list
+          ::Lograge.ignore(IGNORE_REPEATED_ERROR_PAGE) unless ::Lograge.ignore_tests.include?(IGNORE_REPEATED_ERROR_PAGE)
         end
 
         # Rails' "Processing by", "Completed 200 OK" and "Rendered" lines, which the request line replaces
@@ -98,6 +115,7 @@ module LogStruct
             :source_ip
           ).compact
           add_request_address(event.payload[:request], options)
+          add_error_page_request(event, options)
 
           if event.payload[:params].present?
             options[:params] = event.payload[:params].except("controller", "action")
@@ -127,6 +145,29 @@ module LogStruct
           end
         end
 
+        # An error page's line has the method and path of the request it's for, not GET /500
+        sig { params(event: ActiveSupport::Notifications::Event, options: T::Hash[Symbol, T.untyped]).void }
+        def add_error_page_request(event, options)
+          request = event.payload[:request]
+          return unless request.is_a?(::ActionDispatch::Request)
+
+          if request.has_header?(ORIGINAL_PATH_HEADER)
+            options[:method] = request.get_header(ORIGINAL_METHOD_HEADER)
+            options[:path] = "#{request.script_name}#{request.get_header(ORIGINAL_PATH_HEADER)}"
+          elsif event.payload[:exception]
+            request.set_header(ACTION_ERROR_LOGGED_HEADER, true)
+          end
+        end
+
+        # The error page for an error its action's line logged would log the request a second time. A request whose
+        # error came before any action (a routing error) or after it (in a middleware) keeps its error page's line.
+        sig { params(event: ActiveSupport::Notifications::Event).returns(T::Boolean) }
+        def repeated_error_page?(event)
+          request = event.payload[:request]
+          request.is_a?(::ActionDispatch::Request) && request.has_header?(ORIGINAL_PATH_HEADER) &&
+            request.get_header(ACTION_ERROR_LOGGED_HEADER) == true
+        end
+
         # Process headers from the event payload
         sig { params(event: ActiveSupport::Notifications::Event, options: T::Hash[Symbol, T.untyped]).void }
         def process_headers(event, options)

data/lib/log_struct/version.rb

@@ -2,5 +2,5 @@
 # frozen_string_literal: true
 
 module LogStruct
-  VERSION = "0.2.0"
+  VERSION = "0.2.1"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: logstruct
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.2.1
 platform: ruby
 authors:
 - DocSpring