logster 2.11.2 → 2.11.4

data/client-app/package.json

@@ -27,7 +27,7 @@
     "@glimmer/component": "^1.0.0",
     "babel-eslint": "^10.1.0",
     "broccoli-asset-rev": "^3.0.0",
-    "ember-auto-import": "^1.5.3",
+    "ember-auto-import": "^1.12.2",
     "ember-cli": "^3.15.0",
     "ember-cli-app-version": "^3.2.0",
     "ember-cli-babel": "^7.19.0",
@@ -58,6 +58,9 @@
     "edition": "octane"
   },
   "dependencies": {
-    "moment": "~2.29.2"
+    "moment": "~2.29.4"
+  },
+  "overrides": {
+    "testem": "^3.9.0"
   }
 }

data/client-app/tests/unit/controllers/index-test.js

@@ -25,6 +25,6 @@ module('Unit | Controller | index', function (hooks) {
 
     assert.equal(controller.searchTerm, "tomtom", 'search sets search term');
     assert.equal(ajaxStub.firstCall.args[0], "/messages.json", "get messages");
-    assert.deepEqual(ajaxStub.firstCall.args[1], {"data": {"filter": "5", "search": "tomtom"}}, "with correct terms");
+    assert.deepEqual(ajaxStub.firstCall.args[1], {"data": {"filter": "5", "search": "tomtom"}, "method": "POST"}, "with correct terms");
   });
 });

data/lib/logster/message.rb

@@ -81,8 +81,11 @@ module Logster
 
     def self.hostname
       @hostname ||= begin
-        command = (Logster.config.use_full_hostname ? `hostname -f` : `hostname`) rescue "<unknown>"
+        command = Logster.config.use_full_hostname ? `hostname -f` : `hostname`
         command.strip!
+        command
+      rescue
+        "<unknown>"
       end
     end
 

data/lib/logster/middleware/viewer.rb

@@ -18,7 +18,7 @@ module Logster
         (@store = Logster.store) || raise(ArgumentError.new("store"))
 
         @assets_path = File.expand_path("../../../../assets", __FILE__)
-        @fileserver = Rack::File.new(@assets_path)
+        @fileserver = Rack::Files.new(@assets_path)
       end
 
       def call(env)
@@ -33,7 +33,7 @@ module Logster
           if resource =~ /\.ico$|\.js$|\.png|\.handlebars$|\.css$|\.woff$|\.ttf$|\.woff2$|\.svg$|\.otf$|\.eot$/
             serve_file(env, resource)
 
-          elsif resource.start_with?("/messages.json")
+          elsif resource.start_with?("/messages.json") && env[REQUEST_METHOD] == "POST"
             serve_messages(Rack::Request.new(env))
 
           elsif resource =~ /\/message\/([0-9a-f]+)$/
@@ -102,10 +102,10 @@ module Logster
             end
 
             if json
-              [200, { "Content-Type" => "application/json; charset=utf-8" }, [message.to_json]]
+              [200, { "content-type" => "application/json; charset=utf-8" }, [message.to_json]]
             else
               preload = { "/show/#{key}" => message }
-              [200, { "Content-Type" => "text/html; charset=utf-8" }, [body(preload)]]
+              [200, { "content-type" => "text/html; charset=utf-8" }, [body(preload)]]
             end
 
           elsif resource =~ /\/settings(\.json)?$/
@@ -128,9 +128,9 @@ module Logster
               grouping = Logster::GroupingPattern.find_all(raw: true).map do |pattern|
                 { value: pattern }
               end
-              [200, { "Content-Type" => "application/json; charset=utf-8" }, [JSON.generate(suppression: suppression, grouping: grouping)]]
+              [200, { "content-type" => "application/json; charset=utf-8" }, [JSON.generate(suppression: suppression, grouping: grouping)]]
             else
-              [200, { "Content-Type" => "text/html; charset=utf-8" }, [body]]
+              [200, { "content-type" => "text/html; charset=utf-8" }, [body]]
             end
           elsif resource =~ /\/patterns\/([a-zA-Z0-9_]+)\.json$/
             unless Logster.config.enable_custom_patterns_via_ui
@@ -161,12 +161,12 @@ module Logster
             Logster.store.remove_ignore_count(pattern)
             [200, {}, ["OK"]]
           elsif resource == "/"
-            [200, { "Content-Type" => "text/html; charset=utf-8" }, [body]]
+            [200, { "content-type" => "text/html; charset=utf-8" }, [body]]
           elsif resource =~ /\/fetch-env\/([0-9a-f]+)\.json$/
             key = $1
             env = Logster.store.get_env(key)
             if env
-              [200, { "Content-Type" => "application/json; charset=utf-8" }, [JSON.generate(env)]]
+              [200, { "content-type" => "application/json; charset=utf-8" }, [JSON.generate(env)]]
             else
               not_found
             end
@@ -181,7 +181,7 @@ module Logster
             group.messages_keys.each { |k| Logster.store.solve(k) }
             [200, {}, []]
           elsif resource == '/development-preload.json' && ENV["LOGSTER_ENV"] == "development"
-            [200, { "Content-Type" => "application/json; charset=utf-8" }, [JSON.generate(preloaded_data)]]
+            [200, { "content-type" => "application/json; charset=utf-8" }, [JSON.generate(preloaded_data)]]
           else
             not_found
           end
@@ -230,7 +230,7 @@ module Logster
         }
 
         json = JSON.generate(payload)
-        [200, { "Content-Type" => "application/json" }, [json]]
+        [200, { "content-type" => "application/json" }, [json]]
       end
 
       def update_patterns(set_name, req)
@@ -258,7 +258,7 @@ module Logster
           return method_not_allowed(%w[POST PUT DELETE])
         end
 
-        [200, { "Content-Type" => "application/json" }, [JSON.generate(pattern: record.to_s)]]
+        [200, { "content-type" => "application/json" }, [JSON.generate(pattern: record.to_s)]]
       rescue => err
         error_message = err.message
 
@@ -293,7 +293,7 @@ module Logster
         if Array === allowed_methods
           allowed_methods = allowed_methods.join(", ")
         end
-        [405, { "Allow" => allowed_methods }, []]
+        [405, { "allow" => allowed_methods }, []]
       end
 
       def parse_regex(string)

data/lib/logster/redis_store.rb

@@ -318,11 +318,11 @@ module Logster
     end
 
     def insert_pattern(set_name, pattern)
-      @redis.sadd(set_name, pattern)
+      @redis.sadd(set_name, [pattern])
     end
 
     def remove_pattern(set_name, pattern)
-      @redis.srem(set_name, pattern)
+      @redis.srem(set_name, [pattern])
     end
 
     def get_patterns(set_name)
@@ -434,9 +434,9 @@ module Logster
       redis.hset(hash_key, message.key, message.to_json(exclude_env: true))
       push_env(message.key, message.env, redis: redis) if save_env
       if message.protected
-        redis.sadd(protected_key, message.key)
+        redis.sadd(protected_key, [message.key])
       else
-        redis.srem(protected_key, message.key)
+        redis.srem(protected_key, [message.key])
       end
     end
 

data/lib/logster/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Logster
-  VERSION = "2.11.2"
+  VERSION = "2.11.4"
 end

data/test/logster/middleware/test_viewer.rb

@@ -43,23 +43,29 @@ class TestViewer < Minitest::Test
   end
 
   def test_search_raceguard_s
-    response = request.get('/logsie/messages.json?search=searchkey')
+    response = request.post('/logsie/messages.json?search=searchkey')
     result = JSON.parse(response.body)
     assert_equal('searchkey', result['search'])
   end
 
   def test_search_raceguard_sr
-    response = request.get('/logsie/messages.json?search=/regex/&regex_search=true')
+    response = request.post('/logsie/messages.json?search=/regex/&regex_search=true')
     result = JSON.parse(response.body)
     assert_equal('/regex/', result['search'])
   end
 
   def test_search_raceguard_f
-    response = request.get("/logsie/messages.json?filter=0_1_2_3_4")
+    response = request.post("/logsie/messages.json?filter=0_1_2_3_4")
     result = JSON.parse(response.body)
     assert_equal([0, 1, 2, 3, 4], result['filter'])
   end
 
+  def test_search_does_not_respond_to_get_requests
+    response = request.get("/logsie/messages.json?filter=0_1_2_3_4")
+    assert_equal(404, response.status)
+    assert_equal("Not found", response.body)
+  end
+
   def test_regex_parse
     assert_equal(/hello/i, viewer.send(:parse_regex, '/hello/i'))
   end
@@ -304,7 +310,7 @@ class TestViewer < Minitest::Test
     ).each do |path|
       response = request.get(path)
       assert_equal(200, response.status)
-      assert_equal('application/javascript', response.headers['Content-Type'])
+      assert_equal('application/javascript', response.headers['content-type'])
     end
   end
 
@@ -315,7 +321,7 @@ class TestViewer < Minitest::Test
     ).each do |path|
       response = request.get(path)
       assert_equal(200, response.status)
-      assert_equal('text/css', response.headers['Content-Type'])
+      assert_equal('text/css', response.headers['content-type'])
     end
   end
 
@@ -335,7 +341,7 @@ class TestViewer < Minitest::Test
     Logster.store.clear_all
     env = { "b" => 1, "c" => 2 }
     msg = Logster.store.report(Logger::INFO, "test", "something hello", env: env)
-    response = request.get("/logsie/messages.json")
+    response = request.post("/logsie/messages.json")
     assert_equal(200, response.status)
     messages = JSON.parse(response.body)["messages"]
     assert_equal(1, messages.size)
@@ -348,7 +354,7 @@ class TestViewer < Minitest::Test
     Logster.store.clear_all
     env = { "b" => 1, "c" => 2 }
     msg = Logster.store.report(Logger::INFO, "test", "something hello", env: env)
-    response = request.get("/logsie/messages.json?search=something")
+    response = request.post("/logsie/messages.json?search=something")
     assert_equal(200, response.status)
     messages = JSON.parse(response.body)["messages"]
     assert_equal(1, messages.size)
@@ -387,7 +393,7 @@ class TestViewer < Minitest::Test
     %i[get head options].each do |m|
       response = request.public_send(m, "/logsie/solve-group", params: { regex: "/gotta be post/" })
       assert_equal(405, response.status)
-      assert_equal("POST", response.headers["Allow"])
+      assert_equal("POST", response.headers["allow"])
     end
     latest = Logster.store.latest
     assert_equal(1, latest.size)

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: logster
 version: !ruby/object:Gem::Version
-  version: 2.11.2
+  version: 2.11.4
 platform: ruby
 authors:
 - Sam Saffron
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2022-04-28 00:00:00.000000000 Z
+date: 2023-01-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler