logster 1.2.11 → 1.3.pre

data/lib/logster/version.rb

@@ -1,3 +1,3 @@
-module Logster
-  VERSION = "1.2.11"
-end
+module Logster
+  VERSION = "1.3.pre"
+end

data/lib/logster/web.rb

@@ -1,14 +1,14 @@
-require 'logster/middleware/viewer'
-
-class Logster::Web
-  class FourOhFour
-    def call(env)
-      [404, {}, ["not found"]]
-    end
-  end
-
-  def self.call(env)
-    @middleware ||= Logster::Middleware::Viewer.new(FourOhFour.new)
-    @middleware.call(env)
-  end
-end
+require 'logster/middleware/viewer'
+
+class Logster::Web
+  class FourOhFour
+    def call(env)
+      [404, {}, ["not found"]]
+    end
+  end
+
+  def self.call(env)
+    @middleware ||= Logster::Middleware::Viewer.new(FourOhFour.new)
+    @middleware.call(env)
+  end
+end

data/logster.gemspec

@@ -1,33 +1,34 @@
-# coding: utf-8
-lib = File.expand_path('../lib', __FILE__)
-$LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
-require 'logster/version'
-
-Gem::Specification.new do |spec|
-  spec.name          = "logster"
-  spec.version       = Logster::VERSION
-  spec.authors       = ["UI for viewing logs in Rack"]
-  spec.email         = ["sam.saffron@gmail.com"]
-  spec.summary       = %q{UI for viewing logs in Rack}
-  spec.description   = %q{UI for viewing logs in Rack}
-  spec.homepage      = "https://github.com/discourse/logster"
-  spec.license       = "MIT"
-
-  spec.files         = `git ls-files -z`.split("\x0").reject do |f|
-    f.start_with?("bower_components") || f.start_with?("website") || f.start_with?("bin")
-  end
-  spec.executables   = spec.files.grep(%r{^bin/}) { |f| File.basename(f) }
-  spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
-  spec.require_paths = ["lib"]
-
-  # NOTE dependency on rack is not explicit, this enables us to use
-  # logster outside of rack (for reporting)
-
-  spec.add_development_dependency "bundler", "~> 1.6"
-  spec.add_development_dependency "rake"
-  spec.add_development_dependency "rack"
-  spec.add_development_dependency "redis"
-  spec.add_development_dependency "guard"
-  spec.add_development_dependency "guard-minitest"
-  spec.add_development_dependency "timecop"
-end
+# coding: utf-8
+lib = File.expand_path('../lib', __FILE__)
+$LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
+require 'logster/version'
+
+Gem::Specification.new do |spec|
+  spec.name          = "logster"
+  spec.version       = Logster::VERSION
+  spec.authors       = ["UI for viewing logs in Rack"]
+  spec.email         = ["sam.saffron@gmail.com"]
+  spec.summary       = %q{UI for viewing logs in Rack}
+  spec.description   = %q{UI for viewing logs in Rack}
+  spec.homepage      = "https://github.com/discourse/logster"
+  spec.license       = "MIT"
+
+  spec.files         = `git ls-files -z`.split("\x0").reject do |f|
+    f.start_with?("bower_components") || f.start_with?("website") || f.start_with?("bin")
+  end
+  spec.executables   = spec.files.grep(%r{^bin/}) { |f| File.basename(f) }
+  spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
+  spec.require_paths = ["lib"]
+
+  # NOTE dependency on rack is not explicit, this enables us to use
+  # logster outside of rack (for reporting)
+
+  spec.add_development_dependency "bundler", "~> 1.6"
+  spec.add_development_dependency "rake"
+  spec.add_development_dependency "rack"
+  spec.add_development_dependency "redis"
+  spec.add_development_dependency "guard"
+  spec.add_development_dependency "guard-minitest"
+  spec.add_development_dependency "timecop"
+  spec.add_development_dependency "byebug"
+end

data/test/examples/test_sidekiq_reporter_example.rb

@@ -1,46 +1,46 @@
-require_relative '../test_helper'
-require 'logster/logger'
-require 'logster/redis_store'
-require 'logger'
-require 'examples/sidekiq_logster_reporter'
-
-class TestSidekiqReporter < MiniTest::Test
-
-  def setup
-    Logster.store = @store = Logster::RedisStore.new(Redis.new)
-    Logster.logger = @logger = Logster::Logger.new(Logster.store)
-    @store.clear_all
-  end
-
-  def teardown
-    @store.clear_all
-  end
-
-  def test_sidekiq_handler_example
-    handler = SidekiqLogsterReporter.new
-    error = nil
-    begin
-      raise TypeError.new
-    rescue => e
-      error = e
-    end
-    trace = error.backtrace
-
-    handler.call(error, code: "Test", something_important: "Foo", params: { article_id: 20 })
-
-    report = @store.latest[0]
-
-    # Message is right format
-    assert_equal("Job exception: TypeError\n", report.message)
-
-    # A backtrace is joined()
-    assert_equal(trace.join("\n"), report.backtrace)
-    # The backtrace is deleted from the env
-    assert_nil(report.env['backtrace'])
-    assert_nil(report.env[:backtrace])
-
-    # The env is in the report
-    assert_equal("Test", report.env['code'])
-    assert_equal(20, report.env['params']['article_id'])
-  end
-end
+require_relative '../test_helper'
+require 'logster/logger'
+require 'logster/redis_store'
+require 'logger'
+require 'examples/sidekiq_logster_reporter'
+
+class TestSidekiqReporter < MiniTest::Test
+
+  def setup
+    Logster.store = @store = Logster::RedisStore.new(Redis.new)
+    Logster.logger = @logger = Logster::Logger.new(Logster.store)
+    @store.clear_all
+  end
+
+  def teardown
+    @store.clear_all
+  end
+
+  def test_sidekiq_handler_example
+    handler = SidekiqLogsterReporter.new
+    error = nil
+    begin
+      raise TypeError.new
+    rescue => e
+      error = e
+    end
+    trace = error.backtrace
+
+    handler.call(error, code: "Test", something_important: "Foo", params: { article_id: 20 })
+
+    report = @store.latest[0]
+
+    # Message is right format
+    assert_equal("Job exception: TypeError\n", report.message)
+
+    # A backtrace is joined()
+    assert_equal(trace.join("\n"), report.backtrace)
+    # The backtrace is deleted from the env
+    assert_nil(report.env['backtrace'])
+    assert_nil(report.env[:backtrace])
+
+    # The env is in the report
+    assert_equal("Test", report.env['code'])
+    assert_equal(20, report.env['params']['article_id'])
+  end
+end

data/test/fake_data/Gemfile

@@ -1,4 +1,4 @@
-source 'https://rubygems.org'
-
-gem 'redis'
-gem 'logster', path: '../../'
+source 'https://rubygems.org'
+
+gem 'redis'
+gem 'logster', path: '../../'

data/test/fake_data/generate.rb

@@ -1,10 +1,10 @@
-require 'redis'
-require 'logster'
-
-Logster.config.allow_grouping = true
-Logster.config.application_version = "ABC123"
-Logster.store = Logster::RedisStore.new
-
-10.times do
-  Logster.store.report(Logger::WARN, "application", "test warning", backtrace: "method1\nmethod2", env: {something: ["hello world", "hello places"], another: {thing: "something else"}})
-end
+require 'redis'
+require 'logster'
+
+Logster.config.allow_grouping = true
+Logster.config.application_version = "ABC123"
+Logster.store = Logster::RedisStore.new
+
+10.times do
+  Logster.store.report(Logger::WARN, "application", "test warning", backtrace: "method1\nmethod2", env: {something: ["hello world", "hello places"], another: {thing: "something else"}})
+end

data/test/logster/middleware/test_reporter.rb

@@ -1,21 +1,21 @@
-require_relative '../../test_helper'
-require 'rack'
-require 'logster/redis_store'
-require 'logster/middleware/reporter'
-
-
-class TestReporter < Minitest::Test
-
-  def test_logs_errors
-    Logster.store = Logster::TestStore.new
-
-    reporter = Logster::Middleware::Reporter.new(nil)
-    env = Rack::MockRequest.env_for("/logs/report_js_error?message=hello")
-    status, = reporter.call(env)
-
-    assert_equal(200, status)
-    assert_equal(1, Logster.store.count)
-  end
-
-end
-
+require_relative '../../test_helper'
+require 'rack'
+require 'logster/redis_store'
+require 'logster/middleware/reporter'
+
+
+class TestReporter < Minitest::Test
+
+  def test_logs_errors
+    Logster.store = Logster::TestStore.new
+
+    reporter = Logster::Middleware::Reporter.new(nil)
+    env = Rack::MockRequest.env_for("/logs/report_js_error?message=hello")
+    status, = reporter.call(env)
+
+    assert_equal(200, status)
+    assert_equal(1, Logster.store.count)
+  end
+
+end
+

data/test/logster/middleware/test_viewer.rb

@@ -1,70 +1,96 @@
-require_relative '../../test_helper'
-require 'rack'
-require 'logster/redis_store'
-require 'logster/middleware/viewer'
-
-class TestViewer < Minitest::Test
-
-  class BrokenApp
-    def call(env)
-      [500, {}, ["broken"]]
-    end
-  end
-
-  def setup
-    Logster.store = Logster::RedisStore.new
-  end
-
-  def teardown
-    Logster.config.subdirectory = nil
-    Logster.store = nil
-  end
-
-  def viewer
-    @viewer ||= begin
-                  Logster.config.subdirectory = "/logsie"
-                  Logster::Middleware::Viewer.new(nil)
-                end
-  end
-
-  def test_path_resolution
-    assert_nil(viewer.send(:resolve_path, "/logs"))
-    assert_nil(viewer.send(:resolve_path, "/admin/logsie"))
-    assert_nil(viewer.send(:resolve_path, "/admin/logsie/bla"))
-    assert_equal("/",viewer.send(:resolve_path, "/logsie"))
-    assert_equal("/",viewer.send(:resolve_path, "/logsie/"))
-    assert_equal("/hello/world",viewer.send(:resolve_path, "/logsie/hello/world"))
-  end
-
-  def test_search_raceguard_s
-    _,_,result_j = viewer.call(Rack::MockRequest.env_for("/logsie/messages.json?search=searchkey"))
-    result = JSON.parse(result_j.first)
-    assert_equal('searchkey', result['search'])
-  end
-
-  def test_search_raceguard_sr
-    _,_,result_j = viewer.call(Rack::MockRequest.env_for("/logsie/messages.json?search=/regex/&regex_search=true"))
-    result = JSON.parse(result_j.first)
-    assert_equal('/regex/', result['search'])
-  end
-
-  def test_search_raceguard_f
-    _,_,result_j = viewer.call(Rack::MockRequest.env_for("/logsie/messages.json?filter=0_1_2_3_4"))
-    result = JSON.parse(result_j.first)
-    assert_equal([0,1,2,3,4], result['filter'])
-  end
-
-  def test_assets
-    env = {}
-    env["PATH_INFO"] = "/logsie/javascript/external/jquery.min.js"
-    env["REQUEST_METHOD"] = "GET"
-
-    result,  = viewer.call(env)
-    assert_equal(200, result)
-  end
-
-  def test_regex_parse
-    assert_equal(/hello/i, viewer.send(:parse_regex, '/hello/i'))
-  end
-
-end
+require_relative '../../test_helper'
+require 'rack'
+require 'logster/redis_store'
+require 'logster/middleware/viewer'
+
+class TestViewer < Minitest::Test
+
+  class BrokenApp
+    def call(env)
+      [500, {}, ["broken"]]
+    end
+  end
+
+  def setup
+    Logster.config.subdirectory = "/logsie"
+    Logster.store = Logster::RedisStore.new
+  end
+
+  def teardown
+    Logster.config.subdirectory = nil
+    Logster.store = nil
+  end
+
+  def viewer
+    @viewer ||= Logster::Middleware::Viewer.new(nil)
+  end
+
+  def request
+    @request ||= Rack::MockRequest.new(Rack::Lint.new(viewer))
+  end
+
+  def test_path_resolution
+    assert_nil(viewer.send(:resolve_path, "/logs"))
+    assert_nil(viewer.send(:resolve_path, "/admin/logsie"))
+    assert_nil(viewer.send(:resolve_path, "/admin/logsie/bla"))
+    assert_equal("/",viewer.send(:resolve_path, "/logsie"))
+    assert_equal("/",viewer.send(:resolve_path, "/logsie/"))
+    assert_equal("/hello/world",viewer.send(:resolve_path, "/logsie/hello/world"))
+  end
+
+  def test_search_raceguard_s
+    response = request.get('/logsie/messages.json?search=searchkey')
+    result = JSON.parse(response.body)
+    assert_equal('searchkey', result['search'])
+  end
+
+  def test_search_raceguard_sr
+    response = request.get('/logsie/messages.json?search=/regex/&regex_search=true')
+    result = JSON.parse(response.body)
+    assert_equal('/regex/', result['search'])
+  end
+
+  def test_search_raceguard_f
+    response = request.get("/logsie/messages.json?filter=0_1_2_3_4")
+    result = JSON.parse(response.body)
+    assert_equal([0,1,2,3,4], result['filter'])
+  end
+
+  def test_regex_parse
+    assert_equal(/hello/i, viewer.send(:parse_regex, '/hello/i'))
+  end
+
+  def test_linking_to_a_valid_js_files
+    %w(
+      /logsie/javascript/client-app.js
+      /logsie/javascript/vendor.js
+    ).each do |path|
+      response = request.get(path)
+      assert_equal(200, response.status)
+      assert_equal('application/javascript', response.headers['Content-Type'])
+    end
+  end
+
+  def test_linking_to_a_valid_css_files
+    %w(
+      /logsie/stylesheets/client-app.css
+      /logsie/stylesheets/vendor.css
+    ).each do |path|
+      response = request.get(path)
+      assert_equal(200, response.status)
+      assert_equal('text/css', response.headers['Content-Type'])
+    end
+  end
+
+  def test_linking_to_an_invalid_ember_component_or_template
+    %w(
+      /logsie/javascript/templates/application.hbs
+      /logsie/javascript/templates/does_not_exist.js
+      /logsie/javascript/components/does_not_exist.js
+      /logsie/javascript/templates/../../app.js
+    ).each do |path|
+      response = request.get(path)
+      assert_equal(404, response.status, "#{path} should have 404'ed")
+    end
+  end
+end

data/test/logster/test_base_store.rb

@@ -1,147 +1,147 @@
-require_relative '../test_helper'
-require 'logster/base_store'
-require 'logster/ignore_pattern'
-
-class TestBaseStore < Minitest::Test
-
-  def setup
-    @store = Logster::TestStore.new
-    @store.clear_all
-  end
-
-  def teardown
-    @store.clear_all
-  end
-
-  def test_report_skip_empty
-    @store.skip_empty = true
-    @store.report(Logger::WARN, "test", nil)
-    @store.report(Logger::WARN, "test", '')
-    @store.report(Logger::WARN, "test", "foo") #
-    @store.skip_empty = false
-    @store.report(Logger::WARN, "test", nil) #
-
-    assert_equal(2, @store.count)
-  end
-
-  def test_report_skip_level
-    @store.level = nil
-    @store.report(Logger::DEBUG, "test", "A") #
-    @store.level = Logger::WARN
-    @store.report(Logger::DEBUG, "test", "A")
-    @store.report(Logger::INFO, "test", "B")
-    @store.report(Logger::WARN, "test", "C") #
-    @store.report(Logger::ERROR, "test", "D") #
-    assert_equal(3, @store.count)
-  end
-
-  def test_report_skip_ignore
-    @store.report(Logger::WARN, "test", "Can't verify CSRF token authenticity")
-    @store.report(Logger::FATAL, "test", "ActiveRecord::RecordNotFound (Couldn't find Upload with 'id'=9947)")
-    @store.report(Logger::WARN, "test", "B")
-    @store.ignore = [
-        /^ActiveRecord::RecordNotFound \(Couldn't find Upload/,
-        /^Can't verify CSRF token authenticity/
-    ]
-    @store.report(Logger::WARN, "test", "Can't verify CSRF token authenticity")
-    @store.report(Logger::FATAL, "test", "ActiveRecord::RecordNotFound (Couldn't find Upload with 'id'=9947)")
-    @store.report(Logger::FATAL, "test", "ActiveRecord::RecordNotFound (Couldn't find Upload with 'id'=9489+78946947)")
-    @store.report(Logger::WARN, "test", "B")
-
-    assert_equal(4, @store.count)
-  end
-
-  def test_ignore_pattern_basic
-    @store.ignore = [
-        Logster::IgnorePattern.new(nil, {username: 'CausingErrors'})
-    ]
-    @store.report(Logger::WARN, "test", "Foobar") #
-    @store.report(Logger::WARN, "test", "Foobar", { env: { username: 'CausingErrors' }})
-    @store.report(Logger::WARN, "test", "Foobar", env: nil)
-    @store.report(Logger::WARN, "test", "Something Else", { env: { username: 'CausingErrors' }})
-    @store.report(Logger::WARN, "test", "Something Else", { env: { 'username' => 'CausingErrors' }})
-    @store.report(Logger::WARN, "test", "Something Else", { env: { username: 'GoodPerson' }}) #
-    @store.report(Logger::WARN, "test", "Can't verify CSRF token authenticity") #
-
-    assert_equal(4, @store.count)
-  end
-
-  def test_ignore_pattern_real
-    @store.ignore = [
-        /^ActionController::RoutingError \(No route matches/,
-        Logster::IgnorePattern.new("Can't verify CSRF token authenticity", { REQUEST_URI: /\/trackback\/$/ })
-    ]
-    # blocked
-    @store.report(Logger::WARN, "whatever", "Can't verify CSRF token authenticity", {
-        env: {
-            HTTP_HOST: 'meta.discourse.org',
-            REQUEST_URI: '/t/use-more-standard-smiley-codes-instead-of-smile/1822/trackback/',
-            REQUEST_METHOD: 'POST',
-            HTTP_USER_AGENT: 'Mozilla/4.0 (compatible; MSIE 6.0; Windows NT 5.1; SV1)',
-            params: {
-                title: 'Something Spammy',
-                url: 'http://spam.example.net/whatever/spam.html',
-                excerpt: 'http://spam.example.com/pdf/blahblah.html free viagra',
-                blog_name: 'get free spam for cheap'
-            }
-        }
-    })
-    # logged
-    @store.report(Logger::WARN, "whatever", "Can't verify CSRF token authenticity", {
-        env: {
-            HTTP_HOST: 'meta.discourse.org',
-            REQUEST_URI: '/session',
-            REQUEST_METHOD: 'POST',
-            HTTP_USER_AGENT: 'Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/35.0.1916.153 Safari/537.36',
-            params: {
-                username: 'user',
-                password: 'password',
-                form_authenticity_token: 'incorrect'
-            }
-        }
-    })
-    assert_equal(1, @store.count)
-  end
-
-  def test_timestamp
-    time = Time.now - 24*60*60
-    message = @store.report(Logger::WARN, "test", "B", timestamp: time)
-
-    assert_equal(time, message.timestamp)
-  end
-
-  def test_backtrace
-    # Create an error with a backtrace
-    error = TypeError.new
-    begin
-      raise error
-    rescue => e
-      error = e
-    end
-
-    # Backtrace can be passed via backtrace param or env
-    message = @store.report(Logger::WARN, "test", "A", backtrace: error.backtrace)
-    assert_equal(error.backtrace.join("\n"), message.backtrace)
-    message = @store.report(Logger::WARN, "test", "B", env: {backtrace: error.backtrace})
-    assert_equal(error.backtrace.join("\n"), message.backtrace)
-
-    # Via env takes priority
-    message = @store.report(Logger::WARN, "test", "C", backtrace: "Garbage", env: {backtrace: error.backtrace})
-    assert_equal(error.backtrace.join("\n"), message.backtrace)
-
-    # Backtrace is always a string
-    # Cannot do an equal assert here, because it uses `caller` when not provided
-    message = @store.report(Logger::WARN, "test", "D", backtrace: nil)
-    assert_kind_of(String, message.backtrace)
-    message = @store.report(Logger::WARN, "test", "E", env: {backtrace: nil})
-    assert_kind_of(String, message.backtrace)
-    message = @store.report(Logger::WARN, "test", "F", backtrace: nil, env: {backtrace: nil})
-    assert_kind_of(String, message.backtrace)
-    message = @store.report(Logger::WARN, "test", "G")
-    assert_kind_of(String, message.backtrace)
-
-    # Arrays are turned into strings via join \n
-    message = @store.report(Logger::WARN, "test", "H", backtrace: ["Foo", "Bar"])
-    assert_equal("Foo\nBar", message.backtrace)
-  end
-end
+require_relative '../test_helper'
+require 'logster/base_store'
+require 'logster/ignore_pattern'
+
+class TestBaseStore < Minitest::Test
+
+  def setup
+    @store = Logster::TestStore.new
+    @store.clear_all
+  end
+
+  def teardown
+    @store.clear_all
+  end
+
+  def test_report_skip_empty
+    @store.skip_empty = true
+    @store.report(Logger::WARN, "test", nil)
+    @store.report(Logger::WARN, "test", '')
+    @store.report(Logger::WARN, "test", "foo") #
+    @store.skip_empty = false
+    @store.report(Logger::WARN, "test", nil) #
+
+    assert_equal(2, @store.count)
+  end
+
+  def test_report_skip_level
+    @store.level = nil
+    @store.report(Logger::DEBUG, "test", "A") #
+    @store.level = Logger::WARN
+    @store.report(Logger::DEBUG, "test", "A")
+    @store.report(Logger::INFO, "test", "B")
+    @store.report(Logger::WARN, "test", "C") #
+    @store.report(Logger::ERROR, "test", "D") #
+    assert_equal(3, @store.count)
+  end
+
+  def test_report_skip_ignore
+    @store.report(Logger::WARN, "test", "Can't verify CSRF token authenticity")
+    @store.report(Logger::FATAL, "test", "ActiveRecord::RecordNotFound (Couldn't find Upload with 'id'=9947)")
+    @store.report(Logger::WARN, "test", "B")
+    @store.ignore = [
+        /^ActiveRecord::RecordNotFound \(Couldn't find Upload/,
+        /^Can't verify CSRF token authenticity/
+    ]
+    @store.report(Logger::WARN, "test", "Can't verify CSRF token authenticity")
+    @store.report(Logger::FATAL, "test", "ActiveRecord::RecordNotFound (Couldn't find Upload with 'id'=9947)")
+    @store.report(Logger::FATAL, "test", "ActiveRecord::RecordNotFound (Couldn't find Upload with 'id'=9489+78946947)")
+    @store.report(Logger::WARN, "test", "B")
+
+    assert_equal(4, @store.count)
+  end
+
+  def test_ignore_pattern_basic
+    @store.ignore = [
+        Logster::IgnorePattern.new(nil, {username: 'CausingErrors'})
+    ]
+    @store.report(Logger::WARN, "test", "Foobar") #
+    @store.report(Logger::WARN, "test", "Foobar", { env: { username: 'CausingErrors' }})
+    @store.report(Logger::WARN, "test", "Foobar", env: nil)
+    @store.report(Logger::WARN, "test", "Something Else", { env: { username: 'CausingErrors' }})
+    @store.report(Logger::WARN, "test", "Something Else", { env: { 'username' => 'CausingErrors' }})
+    @store.report(Logger::WARN, "test", "Something Else", { env: { username: 'GoodPerson' }}) #
+    @store.report(Logger::WARN, "test", "Can't verify CSRF token authenticity") #
+
+    assert_equal(4, @store.count)
+  end
+
+  def test_ignore_pattern_real
+    @store.ignore = [
+        /^ActionController::RoutingError \(No route matches/,
+        Logster::IgnorePattern.new("Can't verify CSRF token authenticity", { REQUEST_URI: /\/trackback\/$/ })
+    ]
+    # blocked
+    @store.report(Logger::WARN, "whatever", "Can't verify CSRF token authenticity", {
+        env: {
+            HTTP_HOST: 'meta.discourse.org',
+            REQUEST_URI: '/t/use-more-standard-smiley-codes-instead-of-smile/1822/trackback/',
+            REQUEST_METHOD: 'POST',
+            HTTP_USER_AGENT: 'Mozilla/4.0 (compatible; MSIE 6.0; Windows NT 5.1; SV1)',
+            params: {
+                title: 'Something Spammy',
+                url: 'http://spam.example.net/whatever/spam.html',
+                excerpt: 'http://spam.example.com/pdf/blahblah.html free viagra',
+                blog_name: 'get free spam for cheap'
+            }
+        }
+    })
+    # logged
+    @store.report(Logger::WARN, "whatever", "Can't verify CSRF token authenticity", {
+        env: {
+            HTTP_HOST: 'meta.discourse.org',
+            REQUEST_URI: '/session',
+            REQUEST_METHOD: 'POST',
+            HTTP_USER_AGENT: 'Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/35.0.1916.153 Safari/537.36',
+            params: {
+                username: 'user',
+                password: 'password',
+                form_authenticity_token: 'incorrect'
+            }
+        }
+    })
+    assert_equal(1, @store.count)
+  end
+
+  def test_timestamp
+    time = Time.now - 24*60*60
+    message = @store.report(Logger::WARN, "test", "B", timestamp: time)
+
+    assert_equal(time, message.timestamp)
+  end
+
+  def test_backtrace
+    # Create an error with a backtrace
+    error = TypeError.new
+    begin
+      raise error
+    rescue => e
+      error = e
+    end
+
+    # Backtrace can be passed via backtrace param or env
+    message = @store.report(Logger::WARN, "test", "A", backtrace: error.backtrace)
+    assert_equal(error.backtrace.join("\n"), message.backtrace)
+    message = @store.report(Logger::WARN, "test", "B", env: {backtrace: error.backtrace})
+    assert_equal(error.backtrace.join("\n"), message.backtrace)
+
+    # Via env takes priority
+    message = @store.report(Logger::WARN, "test", "C", backtrace: "Garbage", env: {backtrace: error.backtrace})
+    assert_equal(error.backtrace.join("\n"), message.backtrace)
+
+    # Backtrace is always a string
+    # Cannot do an equal assert here, because it uses `caller` when not provided
+    message = @store.report(Logger::WARN, "test", "D", backtrace: nil)
+    assert_kind_of(String, message.backtrace)
+    message = @store.report(Logger::WARN, "test", "E", env: {backtrace: nil})
+    assert_kind_of(String, message.backtrace)
+    message = @store.report(Logger::WARN, "test", "F", backtrace: nil, env: {backtrace: nil})
+    assert_kind_of(String, message.backtrace)
+    message = @store.report(Logger::WARN, "test", "G")
+    assert_kind_of(String, message.backtrace)
+
+    # Arrays are turned into strings via join \n
+    message = @store.report(Logger::WARN, "test", "H", backtrace: ["Foo", "Bar"])
+    assert_equal("Foo\nBar", message.backtrace)
+  end
+end