logster 0.1.5 → 0.1.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 78822a7188bcfb1a31a9aad3f8affdb955f93a1b
-  data.tar.gz: 7bd13d687d0a8aa395b6ccb0a65bc4ac6fc16c02
+  metadata.gz: d995b434dc8396a1b599aec866dad4d0ac4063da
+  data.tar.gz: 39e45321820da7c8c5ddc1dc3c4c89eac3dc4621
 SHA512:
-  metadata.gz: 960feebb6fff37749e84721061b3222126cfc283096339aea4d0edbd940a82863aed17386c7759e63e5d4620ae417344e70dc0a9096d839641de9903e1b94842
-  data.tar.gz: 09ea17c801477205634516c5e038becb197f1092120ea39b53176f9c7f7d91ba6e60495256ff248741e210237a85be9ca7664ca9c085cc67fb84c202180fed6a
+  metadata.gz: 30772ee8c258f97d6bb16c04f3439bab6073a30d66da862245e248c04c6ac07067d77075a425dc9e104a7b0e0a1c841f475b890679f9c556c08563f7897752ee
+  data.tar.gz: 552c9f5737eb998e0bf235cb378451a6b5e829f7d768ebbebeebce867e079b02d823bc705a1b9f79a5f2dd56060b7ab21fdf199ea821ee74b4cfac25306feca4

data/README.md

@@ -17,18 +17,16 @@ And then execute:
 
     $ bundle
 
-Make Logster available in your development environment by adding the following to your routes.rb:
+Make logster web available add the following to your `routes.rb`:
 
 ```
-if Rails.env == "development"
-  mount Logster::Web => "/logs"
-end
+mount Logster::Web => "/logs", lambda { |req| req.session["admin"] }
 ```
 
-Logster will be available in your Rails app in **development** mode only. To wire up in production you will need to set
+Out of the box, logster will use the default redis connection, to customise, in `config/application.rb`
 
 ```
-Logster.config.authorize_callback = lambda{|env| your_own_can_see_logs? }
+Logster.store = Logster.RedisStore.new(redis_connection)
 ```
 
 ## Usage
@@ -84,3 +82,8 @@ Logster UI is built using [Ember.js](http://emberjs.com/)
   - Automatically include ignore filter
 - 2014-08-08: Version 0.1.4
   - Fix crash in ignore filter
+- 2014-08-10: Version 0.1.5
+  - Fix crash in Rails 3
+- 2014-08-13: Version 0.1.6
+  - Simplify install process
+  - Fix crash on 404 in /logs dir

data/lib/logster.rb

@@ -4,6 +4,13 @@ require 'logster/configuration'
 require 'logster/web'
 require 'logster/ignore_pattern'
 
+if defined? Redis
+  require 'logster/redis_store'
+else
+  STDERR.puts "ERROR: Redis is not loaded, ensure redis gem is required before logster"
+  exit
+end
+
 module Logster
   def self.logger=(logger)
     @logger = logger
@@ -36,7 +43,6 @@ module Logster
 end
 
 Logster.config.current_context = lambda{ |env, &block| block.call }
-Logster.config.authorize_callback = lambda{ |env| true }
 
 if defined?(::Rails) && ::Rails::VERSION::MAJOR.to_i >= 3
   require 'logster/rails/railtie'

data/lib/logster/configuration.rb

@@ -1,5 +1,5 @@
 module Logster
   class Configuration
-    attr_accessor :authorize_callback, :subdirectory, :current_context
+    attr_accessor :subdirectory, :current_context
   end
 end

data/lib/logster/middleware/viewer.rb

@@ -29,11 +29,6 @@ module Logster
 
         if resource = resolve_path(path)
 
-          # easier to debug, call per line
-          unless Logster.config.authorize_callback.call(env)
-            return @app.call(env)
-          end
-
           if resource =~ /\.js$|\.handlebars$|\.css$/
             env[PATH_INFO] = resource
             # accl redirect is going to be trouble, ensure its bypassed

data/lib/logster/rails/railtie.rb

@@ -7,22 +7,17 @@ module Logster::Rails
   def self.set_logger(config)
     return unless Rails.env.development? || Rails.env.production?
 
-    if defined?(Redis)
-      require 'logster/middleware/debug_exceptions'
-      require 'logster/middleware/reporter'
-      require 'logster/redis_store'
+    require 'logster/middleware/debug_exceptions'
+    require 'logster/middleware/reporter'
 
-      store = Logster.store ||= Logster::RedisStore.new
-      store.level = Logger::Severity::WARN if Rails.env.production?
+    store = Logster.store ||= Logster::RedisStore.new
+    store.level = Logger::Severity::WARN if Rails.env.production?
 
-      logger = Logster::Logger.new(store)
-      logger.chain(::Rails.logger)
-      logger.level = ::Rails.logger.level
+    logger = Logster::Logger.new(store)
+    logger.chain(::Rails.logger)
+    logger.level = ::Rails.logger.level
 
-      Logster.logger = ::Rails.logger = config.logger = logger
-    else
-      Rails.logger.warn "Not loading logster, Redis missing"
-    end
+    Logster.logger = ::Rails.logger = config.logger = logger
   end
 
 
@@ -46,9 +41,6 @@ module Logster::Rails
   class Railtie < ::Rails::Railtie
 
     config.before_initialize do
-      Logster.config.authorize_callback = lambda {|env|
-        Rails.env == "development"
-      }
       Logster::Rails.set_logger(config)
     end
 

data/lib/logster/version.rb

@@ -1,3 +1,3 @@
 module Logster
-  VERSION = "0.1.5"
+  VERSION = "0.1.6"
 end

data/lib/logster/web.rb

@@ -1,8 +1,14 @@
 require 'logster/middleware/viewer'
 
 class Logster::Web
+  class FourOhFour
+    def call(env)
+      [404, {}, ["not found"]]
+    end
+  end
+
   def self.call(env)
-    @middleware ||= Logster::Middleware::Viewer.new(nil)
+    @middleware ||= Logster::Middleware::Viewer.new(FourOhFour.new)
     @middleware.call(env)
   end
 end

data/test/logster/middleware/test_viewer.rb

@@ -17,7 +17,6 @@ class TestViewer < Minitest::Test
 
   def teardown
     Logster.config.subdirectory = nil
-    Logster.config.authorize_callback = nil
     Logster.store = nil
   end
 
@@ -28,19 +27,6 @@ class TestViewer < Minitest::Test
                 end
   end
 
-  def test_authorize_callback
-    Logster.config.authorize_callback = lambda{ |env|
-      env["authorized"]
-    }
-
-    viewer = Logster::Middleware::Viewer.new(BrokenApp.new)
-    status, _  = viewer.call({"PATH_INFO" => "/logs"})
-    assert_equal(500, status)
-
-    status, _  = viewer.call({"PATH_INFO" => "/logs", "authorized" => true})
-    assert_equal(200, status)
-  end
-
   def test_path_resolution
     assert_nil(viewer.send(:resolve_path, "/logs"))
     assert_nil(viewer.send(:resolve_path, "/admin/logsie"))
@@ -51,10 +37,6 @@ class TestViewer < Minitest::Test
   end
 
   def test_assets
-    Logster.config.authorize_callback = lambda{ |env|
-      true
-    }
-
     env = {}
     env["PATH_INFO"] = "/logsie/javascript/external/jquery.min.js"
     env["REQUEST_METHOD"] = "GET"

data/test/test_helper.rb

@@ -2,8 +2,8 @@ require 'minitest'
 require 'minitest/unit'
 require 'minitest/autorun'
 require 'minitest/pride'
-require 'logster'
 require 'redis'
+require 'logster'
 require 'logster/base_store'
 
 class Logster::TestStore < Logster::BaseStore

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: logster
 version: !ruby/object:Gem::Version
-  version: 0.1.5
+  version: 0.1.6
 platform: ruby
 authors:
 - UI for viewing logs in Rack
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-08-12 00:00:00.000000000 Z
+date: 2014-08-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler