logster 0.1.3 → 0.1.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: d087f190e0b8ea9d96fb43ade1d4f9b074622e96
-  data.tar.gz: 0d244873038cb9ae045e8254523f07a3bdade1d3
+  metadata.gz: 5d142d05e56687317b126da8d5c270cac6b6fbad
+  data.tar.gz: e622c3a2464971d04001f186431eca6f11a62573
 SHA512:
-  metadata.gz: 8bbf7687d1b79033a4cf79504244340c6c566af2e7689cb437def65fdff9cafdedaea7a46d84aa6c10dbd087a898db764746f5e33ccfc052ede2051ec4af060a
-  data.tar.gz: 32ebb0388d1079019d83176e3f3ccd72139dc9ba45ff8cc769db95f089ec804ac1c8d12235f0775f15bc3f98b3a58e8ff4bb25f7d7a5e0908af7020459d4724a
+  metadata.gz: d06cc3bd37e67a26e3d39386c4a6f408c8f34c298559e03d6ede9f27595ff1fe6fdeb0ec1493471d97e58e2b136a5153ddb9f30cbf0a4fc0c8bae0d9bd499722
+  data.tar.gz: c59388ac7cc26a6ad02cdde54c5d370f0758d67b1faf2c1dc728f81b7ef4537aea91fcc1ad81df2485231abf285a626c034f7fa9f4f3caba1f0f54530e3ec4b7

data/README.md

@@ -82,3 +82,5 @@ Logster UI is built using [Ember.js](http://emberjs.com/)
   - Render hashes provided via Logster.add_to_env
 - 2014-08-05: Version 0.1.3
   - Automatically include ignore filter
+- 2014-08-08: Version 0.1.4
+  - Fix crash in ignore filter

data/lib/logster/ignore_pattern.rb

@@ -29,17 +29,21 @@ module Logster
     private
 
     def compare(message, pattern)
+      return false unless message && pattern
+
       case pattern
         when Regexp
-          message =~ pattern
+          message.to_s =~ pattern
         when String
-          message.downcase =~ Regexp.new(pattern.downcase, Regexp::IGNORECASE)
+          message.to_s.downcase =~ Regexp.new(pattern.downcase, Regexp::IGNORECASE)
         when Hash
-          compare_hash(message, pattern)
-        when NilClass
-          true
+          if Hash === message
+            compare_hash(message, pattern)
+          else
+            false
+          end
         else
-          true
+          false
       end
     end
 
@@ -54,7 +58,7 @@ module Logster
     def get_indifferent(hash, key)
       return hash[key] if hash[key]
       return hash[key.to_s] if hash[key.to_s]
-      return hash[key.to_sym] if hash[key.to_sym]
+      # no key.to_sym please, memory leak in Ruby < 2.2
       nil
     end
   end

data/lib/logster/version.rb

@@ -1,3 +1,3 @@
 module Logster
-  VERSION = "0.1.3"
+  VERSION = "0.1.4"
 end

data/test/logster/test_base_store.rb

@@ -57,12 +57,13 @@ class TestBaseStore < Minitest::Test
     ]
     @store.report(Logger::WARN, "test", "Foobar") #
     @store.report(Logger::WARN, "test", "Foobar", { env: { username: 'CausingErrors' }})
+    @store.report(Logger::WARN, "test", "Foobar", env: nil)
     @store.report(Logger::WARN, "test", "Something Else", { env: { username: 'CausingErrors' }})
     @store.report(Logger::WARN, "test", "Something Else", { env: { 'username' => 'CausingErrors' }})
     @store.report(Logger::WARN, "test", "Something Else", { env: { username: 'GoodPerson' }}) #
     @store.report(Logger::WARN, "test", "Can't verify CSRF token authenticity") #
 
-    assert_equal(3, @store.count)
+    assert_equal(4, @store.count)
   end
 
   def test_ignore_pattern_real

data/test/logster/test_ignore_pattern.rb

@@ -0,0 +1,41 @@
+require_relative '../test_helper'
+require 'logster/ignore_pattern'
+
+class TestIgnorePattern < Minitest::Test
+
+  def test_string_message_pattern
+    msg = Logster::Message.new(Logger::WARN, "test", "my error")
+    msg_frog = Logster::Message.new(Logger::WARN, "test", "a frog")
+    msg_nil = Logster::Message.new(Logger::WARN, "test", nil)
+
+    pattern = Logster::IgnorePattern.new("ERROR")
+
+    assert pattern.matches? msg
+    assert !pattern.matches?(msg_frog)
+    assert !pattern.matches?(msg_nil)
+  end
+
+  def test_env_pattern
+    msg = Logster::Message.new(Logger::WARN, "test", "my error")
+    msg.env = {"frogs" => "are big"}
+
+    pattern = Logster::IgnorePattern.new(nil, {frogs: "big"})
+
+    assert pattern.matches? msg
+
+    msg.env = {legs: nil}
+    assert !(pattern.matches? msg)
+
+    msg.env = {legs: 3}
+    assert !(pattern.matches? msg)
+
+    msg.env = {frogs: "small"}
+    assert !pattern.matches?(msg)
+
+    pattern = Logster::IgnorePattern.new(nil, "small")
+    assert pattern.matches? msg
+
+    msg.env = {frogs: "big"}
+    assert !(pattern.matches? msg)
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: logster
 version: !ruby/object:Gem::Version
-  version: 0.1.3
+  version: 0.1.4
 platform: ruby
 authors:
 - UI for viewing logs in Rack
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-08-05 00:00:00.000000000 Z
+date: 2014-08-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -143,6 +143,7 @@ files:
 - test/logster/middleware/test_reporter.rb
 - test/logster/middleware/test_viewer.rb
 - test/logster/test_base_store.rb
+- test/logster/test_ignore_pattern.rb
 - test/logster/test_logger.rb
 - test/logster/test_redis_store.rb
 - test/test_helper.rb
@@ -176,6 +177,7 @@ test_files:
 - test/logster/middleware/test_reporter.rb
 - test/logster/middleware/test_viewer.rb
 - test/logster/test_base_store.rb
+- test/logster/test_ignore_pattern.rb
 - test/logster/test_logger.rb
 - test/logster/test_redis_store.rb
 - test/test_helper.rb