logstash_rails 0.0.9 → 0.0.10

data/Gemfile

@@ -7,6 +7,7 @@ group :development do
   gem 'pry'
   gem 'yard'
   gem 'rake'
+  gem 'redcarpet'
 end
 
 group :test do

data/README.md

@@ -32,7 +32,7 @@ and provide an initializer for configuration.
 
 * __transport__
   
-  redis is the only available transport atm
+  redis, logstash-udp and logstash-tcp are available atm
 
 * __logger__
   
@@ -64,7 +64,7 @@ A more complete example looks like:
 ```ruby
 if Rails.env.production?
   LogstashRails.config(
-    transport: redis,
+    transport: :redis,
     host: '1.2.3.4', 
     port: 12345,
     redis_key: 'my_key',

data/Rakefile

@@ -1,5 +1,5 @@
 require 'bundler/gem_tasks'
-require 'yard/rake/yardoc_task'
+require 'yard'
 require 'rspec/core/rake_task'
 
 RSpec::Core::RakeTask.new(:test)

data/lib/logstash_rails/configuration_base.rb

@@ -1,6 +1,14 @@
 module LogstashRails
+
+  # base class for all transports
+  #
   class ConfigurationBase
 
+    # @param options [Hash]
+    #
+    # @option options [Array]  :events The list of events to subscribe
+    # @option options [Logger] :logger The logger for exceptions
+    #
     def initialize(options)
       @events = options[:events] || [/.*/]
       @logger = options[:logger]
@@ -12,6 +20,10 @@ module LogstashRails
       subscribe
     end
 
+    # destroy
+    #
+    # unsubscribe from ActiveSupport::Notifications
+    #
     def destroy
       return unless @subscriptions
 
@@ -24,21 +36,23 @@ module LogstashRails
 
     def subscribe
       @subscriptions = @events.map do |event|
-        ActiveSupport::Notifications.subscribe(event) do |*args|
-          json_event = Formatter.format(*args)
-
-          begin
-            push(json_event)
-          rescue
-            log($!)
-          end
-        end
+        ActiveSupport::Notifications.subscribe(event, method(:event_handler))
+      end
+    end
+
+    def event_handler(*args)
+      json_event = Formatter.format(*args)
+
+      begin
+        push(json_event)
+      rescue
+        log($!)
       end
     end
 
     def log(exception)
-      msg = exception.message + "\n " + exception.backtrace.join("\n ")
-      @logger.error(msg) if @logger
+      return unless @logger
+      @logger.error(exception.message + "\n " + exception.backtrace.join("\n "))
     end
 
   end

data/lib/logstash_rails/version.rb

@@ -1,3 +1,3 @@
 module LogstashRails
-  VERSION = "0.0.9"
+  VERSION = "0.0.10"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: logstash_rails
 version: !ruby/object:Gem::Version
-  version: 0.0.9
+  version: 0.0.10
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-06-12 00:00:00.000000000 Z
+date: 2013-06-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: logstash-event
@@ -103,7 +103,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: 1855130879453576509
+      hash: -1863269077052874356
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
@@ -112,10 +112,10 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: 1855130879453576509
+      hash: -1863269077052874356
 requirements: []
 rubyforge_project: 
-rubygems_version: 1.8.25
+rubygems_version: 1.8.24
 signing_key: 
 specification_version: 3
 summary: Send events from Rails to Logstash without logger foo.