logstash-output-redis 3.0.5 → 4.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 6009b56027763c8362c42d50710fab2e85ece956
-  data.tar.gz: 8f329922d6678eed6237cc6c8238bac0bb0295ac
+  metadata.gz: 90bf407558132b84780ba559b7f3ff82571ca80e
+  data.tar.gz: e50d4dc796ba4475033b71d415a03bde5edae3af
 SHA512:
-  metadata.gz: 84c07bae86a0cc3997c5ac3c9154e67de015c0a2ca09b26fe9b858cd5af59bce71bb58862f1d15e0388a4fc1657fd518d7a41204fef288070ed9997c062a692f
-  data.tar.gz: 3d5c997286c42e226cbcda84723a203f584fcae806be57533dc0f0020d4532a36e6bfaa9d676b2f3609b7427ec95b8e1a1c905d83181e6103be797e0ea970306
+  metadata.gz: f7be387bf6b017efac53dcb654cdcfb33f56a0b93d720b942ca982cd22bf414f288863060e89ecb962bd9b5b0beed4981e891579888ae79288295bca8170963b
+  data.tar.gz: be7c7a0f750e79d8fa53ae1c04fb3ab8b63906f4b09fc2a90cd805f41329f5ff450e862fa4829ee3bbcc3b444677bdc6d79d3ae81fc2708c83bc37b1f62bbb88

data/CHANGELOG.md

@@ -1,5 +1,5 @@
-## 3.0.5
-  - Docs fixes
+## 4.0.0
+  - Mark deprecated `name` and `queue` configuration parameters as obsolete
 
 ## 3.0.3
   - Fix logging method signature for #debug

data/docs/index.asciidoc

@@ -119,8 +119,8 @@ Only supported for `list` Redis `data_type`.
   * Value can be any of: `list`, `channel`
   * There is no default value for this setting.
 
-Either list or channel.  If `redis_type` is list, then we will set
-RPUSH to key. If `redis_type` is channel, then we will PUBLISH to `key`.
+Either list or channel.  If `data_type` is list, then we will set
+RPUSH to key. If `data_type` is channel, then we will PUBLISH to `key`.
 
 [id="plugins-{type}s-{plugin}-db"]
 ===== `db` 
@@ -156,15 +156,6 @@ For example:
 The name of a Redis list or channel. Dynamic names are
 valid here, for example `logstash-%{type}`.
 
-[id="plugins-{type}s-{plugin}-name"]
-===== `name`  (DEPRECATED)
-
-  * DEPRECATED WARNING: This configuration item is deprecated and may not be available in future versions.
-  * Value type is <<string,string>>
-  * Default value is `"default"`
-
-Name is used for logging in case there are multiple instances.
-
 [id="plugins-{type}s-{plugin}-password"]
 ===== `password` 
 
@@ -181,16 +172,6 @@ Password to authenticate with.  There is no authentication by default.
 
 The default port to connect on. Can be overridden on any hostname.
 
-[id="plugins-{type}s-{plugin}-queue"]
-===== `queue`  (DEPRECATED)
-
-  * DEPRECATED WARNING: This configuration item is deprecated and may not be available in future versions.
-  * Value type is <<string,string>>
-  * There is no default value for this setting.
-
-The name of the Redis queue (we'll use RPUSH on this). Dynamic names are
-valid here, for example `logstash-%{type}`
-
 [id="plugins-{type}s-{plugin}-reconnect_interval"]
 ===== `reconnect_interval` 
 

data/lib/logstash/outputs/redis.rb

@@ -21,8 +21,7 @@ class LogStash::Outputs::Redis < LogStash::Outputs::Base
   default :codec, "json"
 
   # Name is used for logging in case there are multiple instances.
-  config :name, :validate => :string, :default => 'default',
-    :deprecated => true
+  config :name, :validate => :string, :obsolete => "This option is obsolete"
 
   # The hostname(s) of your Redis server(s). Ports may be specified on any
   # hostname, which will override the global port config.
@@ -51,17 +50,15 @@ class LogStash::Outputs::Redis < LogStash::Outputs::Base
   # Password to authenticate with.  There is no authentication by default.
   config :password, :validate => :password
 
-  # The name of the Redis queue (we'll use RPUSH on this). Dynamic names are
-  # valid here, for example `logstash-%{type}`
-  config :queue, :validate => :string, :deprecated => true
+  config :queue, :validate => :string, :obsolete => "This option is obsolete. Use `key` and `data_type`."
 
   # The name of a Redis list or channel. Dynamic names are
   # valid here, for example `logstash-%{type}`.
-  config :key, :validate => :string, :required => false
+  config :key, :validate => :string, :required => true
 
   # Either list or channel.  If `redis_type` is list, then we will set
   # RPUSH to key. If `redis_type` is channel, then we will PUBLISH to `key`.
-  config :data_type, :validate => [ "list", "channel" ], :required => false
+  config :data_type, :validate => [ "list", "channel" ], :required => true
 
   # Set to true if you want Redis to batch up values and send 1 RPUSH command
   # instead of one command per value to push on the list.  Note that this only
@@ -98,25 +95,6 @@ class LogStash::Outputs::Redis < LogStash::Outputs::Base
   def register
     require 'redis'
 
-    # TODO remove after setting key and data_type to true
-    if @queue
-      if @key or @data_type
-        raise RuntimeError.new(
-          "Cannot specify queue parameter and key or data_type"
-        )
-      end
-      @key = @queue
-      @data_type = 'list'
-    end
-
-    if not @key or not @data_type
-      raise RuntimeError.new(
-        "Must define queue, or key and data_type parameters"
-      )
-    end
-    # end TODO
-
-
     if @batch
       if @data_type != "list"
         raise RuntimeError.new(
@@ -224,7 +202,7 @@ class LogStash::Outputs::Redis < LogStash::Outputs::Base
 
   # A string used to identify a Redis instance in log messages
   def identity
-    @name || "redis://#{@password}@#{@current_host}:#{@current_port}/#{@db} #{@data_type}:#{@key}"
+    "redis://#{@password}@#{@current_host}:#{@current_port}/#{@db} #{@data_type}:#{@key}"
   end
 
   def send_to_redis(event, payload)

data/logstash-output-redis.gemspec

@@ -1,7 +1,7 @@
 Gem::Specification.new do |s|
 
   s.name            = 'logstash-output-redis'
-  s.version         = '3.0.5'
+  s.version         = '4.0.0'
   s.licenses        = ['Apache License (2.0)']
   s.summary         = "This output will send events to a Redis queue using RPUSH"
   s.description     = "This gem is a Logstash plugin required to be installed on top of the Logstash core pipeline using $LS_HOME/bin/logstash-plugin install gemname. This gem is not a stand-alone program"

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: logstash-output-redis
 version: !ruby/object:Gem::Version
-  version: 3.0.5
+  version: 4.0.0
 platform: ruby
 authors:
 - Elastic
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2017-08-18 00:00:00.000000000 Z
+date: 2017-07-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   requirement: !ruby/object:Gem::Requirement