logstash-output-mqtt 1.1.0 → 1.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: c13e7a4156045d08c121c0de23f4eaa1a4bce1995b2d079abb4dd15ac7d5c1d9
-  data.tar.gz: 610ddd709836340d87c55ce1ecc2ef145ca6c6e447d8a9688e55d4f775639457
+  metadata.gz: 6466f5b821ccadda609280f2b3fa5f8db9db834a67a09b3687504058233c391a
+  data.tar.gz: eadd6cde4e746c043b2ca6fc400ff98f08181cbdf1c930dc2580cc594cb3c99d
 SHA512:
-  metadata.gz: f98f37cd1a440228baf58e576765eef0c573d349e857ded201c680fd9c5f87085a11cb63f21262eb95f27b05e00d4eccf8197676b903502f8f7d94adfa666441
-  data.tar.gz: 27a270fd71d5deba222d85113231be86f43b747e538d11dcc404f459dd88e96a7d1dc26801a8af3ccf6a98a3ff906c55451d664fb964f56f05417730401aba63
+  metadata.gz: 3fdd61209f6761f2c06459d2099632472b68880a836224315634b5789fb2334c1955df195c461d2f1285b60d3990b7813a607abc1b7100143ee76d6a37bfeee4
+  data.tar.gz: 7ad0be8ab0e16a818673cc4622778fb4b9e88481f5a0e949092fdb4d7428c52b805a00806b892c4f35304c5555edecd02b3c5e6576278989b1e4610d3db4152c

data/lib/logstash/outputs/mqtt.rb

@@ -102,7 +102,6 @@ class LogStash::Outputs::MQTT < LogStash::Outputs::Base
   # Time in seconds to wait before retrying a connection
   config :connect_retry_interval, :validate => :number, :default => 10
 
-  public
   def register
     @options = {
       :host => @host
@@ -138,50 +137,41 @@ class LogStash::Outputs::MQTT < LogStash::Outputs::Base
     @codec.on_event do |event, encoded_event|
       @event_buffer.push([event, encoded_event])
     end
-
   end # def register
 
-  public
   def receive(event)
-
     @codec.encode(event)
     handle_events
   end # def receive
 
-  public
   def multi_receive(events)
-    events.each do |event|
-      @codec.encode(event)
-    end
-
+    events.each { |event| @codec.encode(event) }
     # Handle all events at once to prevent taking a new connection for each event
     handle_events
   end
 
-  public
   def close
-
     @closing = true
   end # def close
 
   private
-  def handle_events
-    # Simple design: connect separately for each event / bunch of events in the buffer
-    # This way it is easy to cope with network failures, ie. if connection fails just try it again
+
+  def mqtt_client
     @logger.debug("Connecting MQTT with options #{@options}")
-    MQTT::Client.connect(@options) do |client|
-      while event = @event_buffer.first do
-        @logger.debug("Publishing MQTT event #{event[1]} with topic #{@topic}, retain #{@retain}, qos #{@qos}")
-        client.publish(event[0].sprintf(@topic), event[1], @retain, @qos)
-        @event_buffer.shift
-      end
-    end
+    @mqtt_client ||= MQTT::Client.connect(@options)
+  end
 
+  def handle_events
+    # It is easy to cope with network failures, ie. if connection fails just try it again
+    while event = @event_buffer.first do
+      @logger.debug("Publishing MQTT event #{event[1]} with topic #{@topic}, retain #{@retain}, qos #{@qos}")
+      mqtt_client.publish(event[0].sprintf(@topic), event[1], @retain, @qos)
+      @event_buffer.shift
+    end
   rescue StandardError => e
     @logger.error("Error #{e.message} while publishing to MQTT server. Will retry in #{@connect_retry_interval} seconds.")
-
+    @mqtt_client = nil
     Stud.stoppable_sleep(@connect_retry_interval, 1) { @closing }
     retry
   end # def handle_event
-
 end # class LogStash::Outputs::MQTT

data/logstash-output-mqtt.gemspec

@@ -1,7 +1,7 @@
 Gem::Specification.new do |s|
   s.name = 'logstash-output-mqtt'
-  s.version         = "1.1.0"
-  s.licenses = ["Apache License (2.0)"]
+  s.version         = "1.2.0"
+  s.licenses = ["Apache-2.0"]
   s.summary = "This is Logstash output plugin for the http://mqtt.org/[MQTT] protocol"
   s.description = "This gem is a logstash plugin required to be installed on top of the Logstash core pipeline using $LS_HOME/bin/plugin install gemname. This gem is not a stand-alone program"
   s.authors = ["Tommi Palomäki"]
@@ -22,5 +22,7 @@ Gem::Specification.new do |s|
   s.add_runtime_dependency "logstash-core-plugin-api", "~> 2.0"
   s.add_runtime_dependency "logstash-codec-json"
   s.add_runtime_dependency "mqtt"
-  s.add_development_dependency "logstash-devutils", "< 1.3.5"
+
+  # 1.3.5 version has some problems, stick to 1.3.4 by now
+  s.add_development_dependency "logstash-devutils", "< 1.3.6"
 end

data/spec/outputs/mqtt_spec.rb

@@ -4,6 +4,7 @@ require "logstash/outputs/mqtt"
 require "logstash/codecs/json"
 require "logstash/event"
 require "time"
+require "json"
 
 describe LogStash::Outputs::MQTT do
   # Define a sample event and its JSON encoded form
@@ -11,48 +12,37 @@ describe LogStash::Outputs::MQTT do
   tstamp = Time.parse(datestring)
   tstamp_utc = tstamp.utc.iso8601(3)
   let(:sample_event) { LogStash::Event.new("message" => "test message", "@timestamp" => datestring) }
-  encoded_event = "{\"@timestamp\":\"" + tstamp_utc + "\",\"@version\":\"1\",\"message\":\"test message\"}"
+  encoded_event = "{\"message\":\"test message\",\"@version\":\"1\",\"@timestamp\":\"" + tstamp_utc + "\"}"
 
   settings = {
     "host" => "test.mosquitto.org",
     "topic" => "hello"
   }
   let(:output) { LogStash::Outputs::MQTT.new(settings) }
-  let(:stub_client) { Object.new }
+  let(:stub_client) { instance_double(MQTT::Client) }
 
   before do
     output.register
   end
 
   describe "receive message" do
-
     it "connects and publishes with correct arguments" do
-
       expect(MQTT::Client).to receive(:connect).with(
         :host => "test.mosquitto.org",
         :port => 8883
-      ) do |*args, &block|
-        block.call(stub_client)
-      end
-
+      ).and_return(stub_client)
       expect(stub_client).to receive(:publish).with("hello", encoded_event, false, 0)
-
       output.receive(sample_event)
     end
   end
 
   describe "multi_receive" do
     it "connects once and publishes all messages" do
-
       expect(MQTT::Client).to receive(:connect).once.with(
         :host => "test.mosquitto.org",
         :port => 8883
-      ) do |*args, &block|
-        block.call(stub_client)
-      end
-
+      ).and_return(stub_client)
       expect(stub_client).to receive(:publish).exactly(3).times.with("hello", encoded_event, false, 0)
-
       three_events = [sample_event, sample_event, sample_event]
       output.multi_receive(three_events)
     end
@@ -65,14 +55,14 @@ describe "Test subtopic:" do
   tstamp = Time.parse(datestring)
   tstamp_utc = tstamp.utc.iso8601(3)
   let(:sample_event) { LogStash::Event.new("message" => "test message", "@timestamp" => datestring, "subtopic" => "mysubtopic") }
-  encoded_event = "{\"@timestamp\":\"" + tstamp_utc + "\",\"@version\":\"1\",\"message\":\"test message\",\"subtopic\":\"mysubtopic\"}"
+  encoded_event = "{\"@version\":\"1\",\"@timestamp\":\"" + tstamp_utc + "\",\"message\":\"test message\",\"subtopic\":\"mysubtopic\"}"
 
   settings = {
     "host" => "test.mosquitto.org",
     "topic" => "hello/%{subtopic}"
   }
   let(:output) { LogStash::Outputs::MQTT.new(settings) }
-  let(:stub_client) { Object.new }
+  let(:stub_client) { instance_double(MQTT::Client) }
 
   before do
     output.register
@@ -80,16 +70,11 @@ describe "Test subtopic:" do
 
   describe "receive message on a subtopic based on a field of an event" do
     it "connects and publishes" do
-
       expect(MQTT::Client).to receive(:connect).with(
         :host => "test.mosquitto.org",
         :port => 8883
-      ) do |*args, &block|
-        block.call(stub_client)
-      end
-
+      ).and_return(stub_client)
       expect(stub_client).to receive(:publish).with("hello/mysubtopic", encoded_event, false, 0)
-
       output.receive(sample_event)
     end
   end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: logstash-output-mqtt
 version: !ruby/object:Gem::Version
-  version: 1.1.0
+  version: 1.2.0
 platform: ruby
 authors:
 - Tommi Palomäki
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2017-10-24 00:00:00.000000000 Z
+date: 2018-11-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   requirement: !ruby/object:Gem::Requirement
@@ -57,7 +57,7 @@ dependencies:
     requirements:
     - - "<"
       - !ruby/object:Gem::Version
-        version: 1.3.5
+        version: 1.3.6
   name: logstash-devutils
   prerelease: false
   type: :development
@@ -65,7 +65,7 @@ dependencies:
     requirements:
     - - "<"
       - !ruby/object:Gem::Version
-        version: 1.3.5
+        version: 1.3.6
 description: This gem is a logstash plugin required to be installed on top of the
   Logstash core pipeline using $LS_HOME/bin/plugin install gemname. This gem is not
   a stand-alone program
@@ -85,7 +85,7 @@ files:
 - spec/outputs/mqtt_spec.rb
 homepage: https://github.com/kompa3/logstash-output-mqtt
 licenses:
-- Apache License (2.0)
+- Apache-2.0
 metadata:
   logstash_plugin: 'true'
   logstash_group: output
@@ -105,7 +105,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project:
-rubygems_version: 2.6.13
+rubygems_version: 2.7.6
 signing_key:
 specification_version: 4
 summary: This is Logstash output plugin for the http://mqtt.org/[MQTT] protocol