logstash-output-jms 3.0.4 → 3.0.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e8c6884ef9fed2c5e1f52d37d32f01bcb1521381cfb1b8355a80483d6004e39a
-  data.tar.gz: 83dcf48a5d1851be6c39b55992f98c72140dab4fd55046b037a328d5a952b25b
+  metadata.gz: f3d27d534c83d98949910785e963e44bf475d3ae0954b07c9944ba506e146615
+  data.tar.gz: 1d9e8d144efc3741ace3239ef5c343db69a87ef2664ed85396785213af2b867a
 SHA512:
-  metadata.gz: b0b8b4672024ffa12932af9562dfc7e365b818624887893317642a0bf40eceb8cb881787168e00e715adcd6908b035f4278d571b9028773bdde769b0dfc86fcf
-  data.tar.gz: 296bf31b7e15bf1ca755060b94f62f59ede467132ed363d22fcb736d5a2aeee8d03f82735b27b8dab810307b027fc9fa406e7688d8ff2a0962644beaa5b5fd79
+  metadata.gz: 1a16d6ab310543e0c983414c961e0057b5badd71b4b186edda338df6efc7be56f56c045ee0243bf2cb818fec9c970d357e6209f987c84ad3baade684775c1386
+  data.tar.gz: 04bcda04efd670503ca16d42c48b8dd7556bd29d28ca6bec7e2be6d2ad9e7124bbb29ca212b5e57b045c5b2bf2c97bcd9ed5fa2e43d058425bd19f7988902193

data/CHANGELOG.md

@@ -1,3 +1,6 @@
+## 3.0.5
+  - Change `password` config type to `password` to prevent leaking in the debug logs [#15](https://github.com/logstash-plugins/logstash-output-jms/pull/15) 
+
 ## 3.0.4
   - Fixes an issue where `delivery_mode` directive was silently ignored.
 

data/README.md

@@ -1,6 +1,6 @@
 # Logstash Plugin
 
-[![Travis Build Status](https://travis-ci.org/logstash-plugins/logstash-output-jms.svg)](https://travis-ci.org/logstash-plugins/logstash-output-jms)
+[![Travis Build Status](https://travis-ci.com/logstash-plugins/logstash-output-jms.svg)](https://travis-ci.com/logstash-plugins/logstash-output-jms)
 
 This is a plugin for [Logstash](https://github.com/elastic/logstash).
 

data/docs/index.asciidoc

@@ -52,7 +52,7 @@ This plugin supports the following configuration options plus the <<plugins-{typ
 | <<plugins-{type}s-{plugin}-factory>> |<<string,string>>|No
 | <<plugins-{type}s-{plugin}-jndi_context>> |<<hash,hash>>|No
 | <<plugins-{type}s-{plugin}-jndi_name>> |<<string,string>>|No
-| <<plugins-{type}s-{plugin}-password>> |<<string,string>>|No
+| <<plugins-{type}s-{plugin}-password>> |<<password,password>>|No
 | <<plugins-{type}s-{plugin}-pub_sub>> |<<boolean,boolean>>|No
 | <<plugins-{type}s-{plugin}-require_jars>> |<<array,array>>|No
 | <<plugins-{type}s-{plugin}-username>> |<<string,string>>|No
@@ -119,7 +119,7 @@ Name of JNDI entry at which the Factory can be found
 [id="plugins-{type}s-{plugin}-password"]
 ===== `password` 
 
-  * Value type is <<string,string>>
+  * Value type is <<password,password>>
   * There is no default value for this setting.
 
 Password to use when connecting to the JMS provider

data/lib/logstash/outputs/jms.rb

@@ -51,7 +51,7 @@ config :factory, :validate => :string
 # Username to connect to JMS provider with
 config :username, :validate => :string
 # Password to use when connecting to the JMS provider
-config :password, :validate => :string
+config :password, :validate => :password
 # Url to use when connecting to the JMS provider
 config :broker_url, :validate => :string
 
@@ -88,7 +88,7 @@ config :jndi_context, :validate => :hash
         :require_jars => @require_jars,
         :factory => @factory,
         :username => @username,
-        :password => @password,
+        :password => @password.nil? ? nil : @password.value,
         :broker_url => @broker_url,
         :url => @broker_url # "broker_url" is named "url" with Oracle AQ
         }

data/logstash-output-jms.gemspec

@@ -1,7 +1,7 @@
 Gem::Specification.new do |s|
 
 	s.name            = 'logstash-output-jms'
-	s.version         = '3.0.4'
+	s.version         = '3.0.5'
 	s.licenses        = ['Apache License (2.0)']
 	s.summary         = "Push events to a JMS topic or queue."
 	s.description     = "This gem is a Logstash plugin required to be installed on top of the Logstash core pipeline using $LS_HOME/bin/logstash-plugin install gemname. This gem is not a stand-alone program"

data/spec/outputs/jms_spec.rb

@@ -34,4 +34,14 @@ describe "outputs/jms" do
       # Add code to check the message is correct on the queue.
     end
   end
+
+  describe "debugging `password`" do
+    let(:config) { jms_config.merge("password" => "$ecre&-key") }
+    it "should not show origin value" do
+
+      output = LogStash::Plugin.lookup("output", "jms").new(config)
+      expect(output.logger).to receive(:debug).with('<password>')
+      output.logger.send(:debug, output.password.to_s)
+    end
+  end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: logstash-output-jms
 version: !ruby/object:Gem::Version
-  version: 3.0.4
+  version: 3.0.5
 platform: ruby
 authors:
 - Elasticsearch
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2018-09-04 00:00:00.000000000 Z
+date: 2023-05-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   requirement: !ruby/object:Gem::Requirement
@@ -124,8 +124,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project:
-rubygems_version: 2.6.13
+rubygems_version: 3.2.33
 signing_key:
 specification_version: 4
 summary: Push events to a JMS topic or queue.