logstash-output-dynatrace 0.7.1 → 0.8.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 81b4a8c2170a81fb234ff285214b21e531d8b33a304ccbe25b643a10d05a7c28
-  data.tar.gz: 70e9196d107abd6655ea8394fac223713bd8120c5305c5f22075d402f897d65d
+  metadata.gz: d6854ef3745f76258a310201110f0ad2c4eb584f5eaeb1a947b90bdaddcefd28
+  data.tar.gz: 8a9e2c1477a26137756bc7a1a2e0356d3ddc85f070553a7543db10c74f960dc1
 SHA512:
-  metadata.gz: 6c67bc08595859467e6c32da87b60e0da67e99f3df4eb8b59d1ecedd8b96676429fe908b4e0678ea4f74736445fab3880a25461d439ef8fef3ce6100b9bc7ada
-  data.tar.gz: c0c78831f7436a02ae3faafab913a725af81d9bf8a14111b7de5d4e46bac3b473f22b325ef27280f5bb4262279a86dadf6ec2b19250b89819e90b7e7f5b8c32b
+  metadata.gz: fb86589466be40fe1483c96bf4ec626272cfa1fbe11b7a6105d8a347af3a821ede7800f0c56d300272223d0ec862d60fb090ef5310c9fde29a0c908d9e73bc0d
+  data.tar.gz: d40f8eb38fc24a574af1c876be615f36e81bfdf3e249a27b1d294504ce4e4717a44ae48106f1ef0c5ae2cd19d5e828aa2627dc88a7a26044e6edbb5ff5f781bf

data/CHANGELOG.md

@@ -1,3 +1,7 @@
+## 0.7.2
+
+- Log response bodies when the response is `200` indicating the request was only partially accepted
+ 
 ## 0.7.1
 
 - Fix an error where max payload size was calculated using character count instead of bytes

data/README.md

@@ -109,6 +109,15 @@ This option may be required if you are using a self-signed certificate, an expir
 > NOTE: Starting in plugin version `0.5.0`, this option has no effect in versions of Logstash older than `8.1.0`.
 > If this functionality is required, it is recommended to update Logstash or stay at plugin version `0.4.x` or older.
 
+### `max_payload_size`
+
+* Value type is [number](https://www.elastic.co/docs/reference/logstash/configuration-file-structure#number)
+* Optional
+* Default value is `9_500_000`
+
+It is recommended **not** to set this optional configuration unless you have a specific reason to do so.
+If you, for example, are using a proxy with a payload size limit, this configuration can be used to reduce the maximum size batch that is sent to the server.
+
 ### `proxy`
 
 * Value type is [string](https://www.elastic.co/guide/en/logstash/current/configuration-file-structure.html#string) or [hash](https://www.elastic.co/guide/en/logstash/current/configuration-file-structure.html#hash)

data/lib/logstash/outputs/dynatrace.rb

@@ -76,7 +76,7 @@ module LogStash
       config :debug_include_body, validate: :boolean, default: false
 
       # Maximum size payload to send to the Dynatrace API in Bytes. Batches of events which would be larger than max_payload_size when serialized will be split into smaller batches of events.
-      config :max_payload_size, validate: :number, default: 4_500_000
+      config :max_payload_size, validate: :number, default: 9_500_000
 
       # Disable cookie support. Overridden default value from LogStash::PluginMixins::HttpClient
       config :cookies, :validate => :boolean, :default => false
@@ -160,6 +160,10 @@ module LogStash
         end
       end
 
+      def log_partial_success_response(response)
+        @logger.warn("Encountered partial success response", code: response.code, body: response.body)
+      end
+
       def log_error_response(response, ingest_endpoint_url, event)
         log_failure(
           "Encountered non-2xx HTTP code #{response.code}",
@@ -267,6 +271,8 @@ module LogStash
         response = client.post(ingest_endpoint_url, body: event, headers: headers)
 
         if response_success?(response)
+          # some events were not accepted but we don't know which ones or why
+          log_partial_success_response(response) if response_partial_success?(response)
           [:success, event, attempt]
         elsif retryable_response?(response)
           log_retryable_response(response)
@@ -315,6 +321,10 @@ module LogStash
         response.code >= 200 && response.code <= 299
       end
 
+      def response_partial_success?(response)
+        response.code == 200
+      end
+
       def retryable_response?(response)
         RETRYABLE_CODES.include?(response.code)
       end

data/spec/outputs/dynatrace_spec.rb

@@ -168,6 +168,19 @@ describe LogStash::Outputs::Dynatrace do
       end
     end
 
+    context 'with partial success responses' do
+      let(:ingest_endpoint_url) { "http://localhost:#{port}/partial" }
+
+      before do
+        allow(subject).to receive(:log_partial_success_response)
+      end
+
+      it 'should warn on partial success' do
+        subject.multi_receive([event])
+        expect(subject).to have_received(:log_partial_success_response)
+      end
+    end
+
     context 'with retryable failing requests' do
       let(:ingest_endpoint_url) { "http://localhost:#{port}/retry" }
       let(:api_key) { 'placeholder-key' }
@@ -188,17 +201,6 @@ describe LogStash::Outputs::Dynatrace do
       end
     end
 
-    context 'with more than 4.5MB of events' do
-      before do
-        allow(subject).to receive(:send_event) { |e, att| [:success, e, att] }
-        subject.multi_receive([1, 2].map { |n| LogStash::Event.new({ 'n' => n.to_s * 2_500_001 }) })
-      end
-
-      it 'should split the chunk into multiple requests' do
-        expect(subject).to have_received(:send_event).exactly(2).times
-      end
-    end
-
     shared_examples('send small and drop large') do
       it 'should only send the small event' do
         expect(subject).to have_received(:send_event).exactly(1).times
@@ -210,26 +212,6 @@ describe LogStash::Outputs::Dynatrace do
           .exactly(:once)
       end
     end
-
-    context 'with one small event and one too large event' do
-      before do
-        allow(subject).to receive(:send_event) { |e, att| [:success, e, att] }
-        subject.multi_receive([LogStash::Event.new({ 'event' => 'small' }),
-                               LogStash::Event.new({ 'event' => 'n' * 4_500_001 })])
-      end
-
-      include_examples('send small and drop large')
-    end
-
-    context 'with one too large event and one small event' do
-      before do
-        allow(subject).to receive(:send_event) { |e, att| [:success, e, att] }
-        subject.multi_receive([LogStash::Event.new({ 'event' => 'n' * 4_500_001 }),
-                               LogStash::Event.new({ 'event' => 'small' })])
-      end
-
-      include_examples('send small and drop large')
-    end
   end
 
   context 'max_payload_size 500' do

data/spec/spec_helper.rb

@@ -98,7 +98,12 @@ class TestApp < Sinatra::Base
 
   multiroute(%w[get post put patch delete], '/good') do
     self.class.last_request = request
-    [200, 'YUP']
+    [204, 'YUP']
+  end
+
+  multiroute(%w[get post put patch delete], '/partial') do
+    self.class.last_request = request
+    [200, 'partial success']
   end
 
   multiroute(%w[get post put patch delete], '/bad') do

data/version.yaml

@@ -1 +1 @@
-logstash-output-dynatrace: '0.7.1'
+logstash-output-dynatrace: '0.8.0'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: logstash-output-dynatrace
 version: !ruby/object:Gem::Version
-  version: 0.7.1
+  version: 0.8.0
 platform: ruby
 authors:
 - Dynatrace Open Source Engineering
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2025-04-23 00:00:00.000000000 Z
+date: 2025-05-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: logstash-codec-json