logstash-output-dynatrace 0.7.0 → 0.7.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 4db961537a03cb5b21240ab63ea56877ceebcf0a075c5db85feb736b787d05df
-  data.tar.gz: 185005382c4ac576fde60eeffa8d3f1a5e037445b3dd92b2126be22f0a3481dc
+  metadata.gz: 81b4a8c2170a81fb234ff285214b21e531d8b33a304ccbe25b643a10d05a7c28
+  data.tar.gz: 70e9196d107abd6655ea8394fac223713bd8120c5305c5f22075d402f897d65d
 SHA512:
-  metadata.gz: 0b14e9eba2edf866eff03c2fa7333ec23733bb6622dd841fcc3da9ddf5cfe5e5b1104238a2857cadc7474bc49444773ee0b5ae7cabcbbaddbefd28e4da403bb8
-  data.tar.gz: 334f37197001b662b86c451c1dcb1faa059f94d1d4045ad43e66590f08663e7a90ea5979bbe247d3d2d7774a0f0e386d6f97c33663e6bef70c0dc6b909557ce3
+  metadata.gz: 6c67bc08595859467e6c32da87b60e0da67e99f3df4eb8b59d1ecedd8b96676429fe908b4e0678ea4f74736445fab3880a25461d439ef8fef3ce6100b9bc7ada
+  data.tar.gz: c0c78831f7436a02ae3faafab913a725af81d9bf8a14111b7de5d4e46bac3b473f22b325ef27280f5bb4262279a86dadf6ec2b19250b89819e90b7e7f5b8c32b

data/CHANGELOG.md

@@ -1,3 +1,7 @@
+## 0.7.1
+
+- Fix an error where max payload size was calculated using character count instead of bytes
+
 ## 0.7.0
 
 - Add new development dependency `rackup` for logstash 8.x compatibility

data/lib/logstash/outputs/dynatrace.rb

@@ -122,11 +122,11 @@ module LogStash
 
         def offer(serialized_event)
           # 2 square brackets, the length of all previously serialized strings, commas, and the current event size
-          batch_size_bytes = 2 + @batch_events_size + @serialized_events.length + serialized_event.length
+          batch_size_bytes = 2 + @batch_events_size + @serialized_events.length + serialized_event.bytesize
           return false if batch_size_bytes > @max_batch_size
 
           @serialized_events.push(serialized_event)
-          @batch_events_size += serialized_event.length
+          @batch_events_size += serialized_event.bytesize
           true
         end
 
@@ -178,8 +178,8 @@ module LogStash
 
         events.each do |event|
           serialized_event = LogStash::Json.dump(event.to_hash)
-          if serialized_event.length > @max_payload_size
-            log_params = { size: serialized_event.length }
+          if serialized_event.bytesize > @max_payload_size
+            log_params = { size: serialized_event.bytesize }
             log_params[:body] = serialized_event if @debug_include_body
             log_warning('Event larger than max_payload_size dropped', log_params)
             next

data/spec/outputs/dynatrace_spec.rb

@@ -232,17 +232,38 @@ describe LogStash::Outputs::Dynatrace do
     end
   end
 
-  context 'max_payload_size 2MB' do
-    let(:config) { { 'ingest_endpoint_url' => ingest_endpoint_url, 'api_key' => api_key, 'max_payload_size' => 2_000_000 } }
+  context 'max_payload_size 500' do
+    let(:max_payload_size) { 500 }
+    let(:config) { { 'ingest_endpoint_url' => ingest_endpoint_url, 'api_key' => api_key, 'max_payload_size' => max_payload_size } }
     subject { LogStash::Outputs::Dynatrace.new(config) }
 
     before do
       allow(subject).to receive(:send_event) { |e, att| [:success, e, att] }
-      subject.multi_receive([1, 2].map { |n| LogStash::Event.new({ 'n' => n.to_s * 1_250_000 }) })
     end
 
-    it 'should split the chunk into multiple requests' do
-      expect(subject).to have_received(:send_event).exactly(2).times
+    it 'should send 2 400B messages in multiple requests' do
+      subject.multi_receive([1, 2].map { |n| LogStash::Event.new({ 'n' => n.to_s * 400 }) })
+      expect(subject).to have_received(:send_event).exactly(2).times do |s|
+        expect(s.bytesize).to be <= max_payload_size
+      end
+    end
+
+    it 'should send 2 100B messages in a single request' do
+      subject.multi_receive([1, 2].map { |n| LogStash::Event.new({ 'n' => n.to_s * 100 }) })
+      expect(subject).to have_received(:send_event).exactly(1).times do |s|
+        expect(s.bytesize).to be <= max_payload_size
+      end
+    end
+
+    it 'should drop messages larger than max_payload_size' do
+      subject.multi_receive([
+        LogStash::Event.new({ 'event' => '🤣' * 400 }),
+        LogStash::Event.new({ 'event' => 'n' * 600 }),
+        LogStash::Event.new({ 'event' => 'n' * 400 }),
+      ])
+      expect(subject).to have_received(:send_event).exactly(1).times do |s|
+        expect(s.bytesize).to be <= max_payload_size
+      end
     end
   end
 

data/version.yaml

@@ -1 +1 @@
-logstash-output-dynatrace: '0.7.0'
+logstash-output-dynatrace: '0.7.1'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: logstash-output-dynatrace
 version: !ruby/object:Gem::Version
-  version: 0.7.0
+  version: 0.7.1
 platform: ruby
 authors:
 - Dynatrace Open Source Engineering
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2025-01-08 00:00:00.000000000 Z
+date: 2025-04-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: logstash-codec-json