logstash-output-dynatrace 0.3.0 → 0.3.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: aefa283dfb7437921963fafa7f068d82363dd421506ebab8b146026f5ca7e30c
-  data.tar.gz: d8843b75b161044bbc20cd6ee4b6f28777ff98bd2cab487e669240d662ce3e4a
+  metadata.gz: 60e4c5d23c89b5a19d03a7af2545a407256fbdde27bd08ea95d63dc47749d8c5
+  data.tar.gz: 3bd9657eb9dfeadbbb3aa4b057c18ff0bc37c57f8e9b78258b499acd2f806ccf
 SHA512:
-  metadata.gz: 4ef069a726a4765d9d4395156ab4bfa13ddaf5aa83fe6934ffd8e610af6330f6ecca44a16de538d85551b7c416b8fd97340907a5b6ad6cdf1c8a0abf0b5fb2a2
-  data.tar.gz: 244956ca7a924de908e05987eb5d13392c007c864f4462b51914ff766db8784aefc7e1b24eb52ff68a747e530f22f5233bb1af155a4ca461f8adce61dee605e9
+  metadata.gz: 1d7efaac8bd9920d794187ec71a8d8294ff8ed76c50344cad4a231157cdda6cea6ef97b86664793fb97c024e81aad7dcfb03cd396cd206c675177d343f7baba0
+  data.tar.gz: 57573b36604af385d257edbe5a9af18a07eb68c6d31605003896787ba28e8afb72d7519202c92dd82f2d7854f60d43168dea86476dee1e0da1f4be4b30580e6c

data/CHANGELOG.md

@@ -1,8 +1,20 @@
+## 0.3.2
+
+- Add Net::OpenTimeout to the list of retried exceptions
+
+## 0.3.1
+
+- Log and re-raise unknown errors
+- Use [password](https://www.elastic.co/guide/en/logstash/current/configuration-file-structure.html#password) type for `api_key` configuration
+
 ## 0.3.0
- - Log response bodies on client errors
+
+- Log response bodies on client errors
 
 ## 0.2.0
- - Add retries with exponential backoff (#8)
+
+- Add retries with exponential backoff (#8)
 
 ## 0.1.0
- - Initial release
+
+- Initial release

data/lib/logstash/outputs/dynatrace.rb

@@ -19,7 +19,7 @@ require 'logstash/outputs/base'
 require 'logstash/json'
 
 MAX_RETRIES = 5
-PLUGIN_VERSION = '0.3.0'
+PLUGIN_VERSION = '0.3.2'
 
 module LogStash
   module Outputs
@@ -36,7 +36,7 @@ module LogStash
       config :ingest_endpoint_url, validate: :uri, required: true
 
       # The API token to use to authenticate requests to the log ingestion endpoint. Must have `logs.ingest` (Ingest Logs) scope.
-      config :api_key, validate: :string, required: true
+      config :api_key, validate: :password, required: true
 
       # Disable SSL validation by setting :verify_mode OpenSSL::SSL::VERIFY_NONE
       config :ssl_verify_none, validate: :boolean, default: false
@@ -63,7 +63,7 @@ module LogStash
         {
           'User-Agent' => "logstash-output-dynatrace/#{PLUGIN_VERSION}",
           'Content-Type' => 'application/json; charset=utf-8',
-          'Authorization' => "Api-Token #{@api_key}"
+          'Authorization' => "Api-Token #{@api_key.value}"
         }
       end
 
@@ -93,8 +93,9 @@ module LogStash
 
           raise RetryableError.new "code #{response.code}" if retryable(response)
 
-        rescue Net::HTTPBadResponse, RetryableError => e
-          # indicates a protocol error
+        rescue Net::OpenTimeout, Net::HTTPBadResponse, RetryableError => e
+          # Net::OpenTimeout indicates a connection could not be established within the timeout period
+          # Net::HTTPBadResponse indicates a protocol error
           if retries < MAX_RETRIES
             sleep_seconds = 2 ** retries
             @logger.warn("Failed to contact dynatrace: #{e.message}. Trying again after #{sleep_seconds} seconds.")
@@ -105,6 +106,9 @@ module LogStash
             @logger.error("Failed to export logs to Dynatrace.")
             return
           end
+        rescue StandardError => e
+          @logger.error("Unknown error raised", :error => e.inspect)
+          raise e
         end
       end
 

data/spec/outputs/dynatrace_spec.rb

@@ -135,4 +135,17 @@ describe LogStash::Outputs::Dynatrace do
       subject.multi_receive(events)
     end
   end
+
+  context 'when an unknown error occurs' do
+    it 'logs and re-raises the error' do
+      class BadEvents
+        def length
+          1
+        end
+      end
+
+      expect(subject.logger).to receive(:error)
+      expect { subject.multi_receive(BadEvents.new) }.to raise_error(StandardError)
+    end
+  end
 end

data/version.rb

@@ -16,5 +16,5 @@
 
 module DynatraceConstants
   # Also required to change the version in lib/logstash/outputs/dynatrace.rb
-  VERSION = '0.3.0'
+  VERSION = '0.3.2'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: logstash-output-dynatrace
 version: !ruby/object:Gem::Version
-  version: 0.3.0
+  version: 0.3.2
 platform: ruby
 authors:
 - Dynatrace Open Source Engineering
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2022-10-06 00:00:00.000000000 Z
+date: 2022-10-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: logstash-codec-json