logstash-mixin-http_client 4.0.3 → 5.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 997861fb27c7f41617d640e9526db40c9750fc27
-  data.tar.gz: becffe860628916c9829ac650fff941067a35009
+  metadata.gz: 3407598b8fe0c863cdf83991df712acadb5156d2
+  data.tar.gz: 597f3f3b3dfd3da2db551b4071c429c44fc1b4a0
 SHA512:
-  metadata.gz: 51baa92d069a19d4885fd97755da05aa3e2b409536ce4d8d68fb32e33777d1dd9d7e4729e6bb41f1c458e6615d098162fb8c4fc82dfb68c98abf9932cefd045f
-  data.tar.gz: 2415d592ecaa660f4fbc1f0e5f0706881377ad52909f58f66d1b8c9efe7ebf24b03ef6a641ce11d7b964f078ab8c83db3bc8d79fa3646fc3d3d1af134b6b97e6
+  metadata.gz: c6d5cafaeb158d80ec39b621127676eeee1dfbb2494835ec59e7e98f4c7f3735023d7b8ba0086fc9376279b996195f5452fac13c03eb9c33d94c1450e917df0a
+  data.tar.gz: 1d511a3e32b178592bb27772f4de3edae4638911f2a61cf0e9da995f5bec5ded738ad728c599062ce6201d7dcf7155a3fd1c0799ad88d42843aa1ff96077ae24

data/CHANGELOG.md

@@ -1,3 +1,6 @@
+## 5.0.0
+  - Obsolete ssl_certificate_verify option that didn't actually work
+
 ## 4.0.3
   - Raise configuration error when user supplies a trust/keystore without a password
 

data/lib/logstash/plugin_mixins/http_client.rb

@@ -52,9 +52,7 @@ module LogStash::PluginMixins::HttpClient
     # See https://hc.apache.org/httpcomponents-client-ga/httpclient/apidocs/org/apache/http/impl/conn/PoolingHttpClientConnectionManager.html#setValidateAfterInactivity(int)[these docs for more info]
     config :validate_after_inactivity, :validate => :number, :default => 200
 
-    # Set this to false to disable SSL/TLS certificate validation
-    # Note: setting this to false is generally considered insecure!
-    config :ssl_certificate_validation, :validate => :boolean, :default => true
+    config :ssl_certificate_validation, :obsolete => "This option did not work in a meaningful way and has been removed! Please use the correct truststore"
 
     # If you need to use a custom X.509 CA (.pem certs) specify the path to that here
     config :cacert, :validate => :path
@@ -119,7 +117,7 @@ module LogStash::PluginMixins::HttpClient
         @proxy
     end
 
-    c[:ssl] = {verify: @ssl_certificate_validation}
+    c[:ssl] = {}
     if @cacert
       c[:ssl][:ca_file] = @cacert
     end

data/logstash-mixin-http_client.gemspec

@@ -1,6 +1,6 @@
 Gem::Specification.new do |s|
   s.name            = 'logstash-mixin-http_client'
-  s.version         = '4.0.3'
+  s.version         = '5.0.0'
   s.licenses        = ['Apache License (2.0)']
   s.summary         = "AWS mixins to provide a unified interface for Amazon Webservice"
   s.description     = "This gem is a Logstash plugin required to be installed on top of the Logstash core pipeline using $LS_HOME/bin/logstash-plugin install gemname. This gem is not a stand-alone program"

data/spec/plugin_mixin/http_client_spec.rb

@@ -148,26 +148,5 @@ describe LogStash::PluginMixins::HttpClient do
 
       include_examples("raising a configuration error")
     end
-
-    describe "ssl certificate validation" do
-      subject { Dummy.new(conf).send(:client_config) }
-
-      context "when set to true" do
-        let(:conf) { basic_config.merge("ssl_certificate_validation" => true)}
-
-        it "should set [:ssl][:verify] to true" do
-          expect(subject[:ssl][:verify]).to eql(true)
-        end
-      end
-
-      context "when set to false" do
-        let(:conf) { basic_config.merge("ssl_certificate_validation" => false)}
-
-        it "should set [:ssl][:verify] to true" do
-          expect(subject[:ssl][:verify]).to eql(false)
-        end
-      end
-    end
-
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: logstash-mixin-http_client
 version: !ruby/object:Gem::Version
-  version: 4.0.3
+  version: 5.0.0
 platform: ruby
 authors:
 - Elastic
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2016-07-21 00:00:00.000000000 Z
+date: 2016-08-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   requirement: !ruby/object:Gem::Requirement